> -----Original Message----- > From: Yongseok Koh [mailto:ys...@mellanox.com] > Sent: Friday, January 19, 2018 7:10 AM > To: Ananyev, Konstantin <konstantin.anan...@intel.com> > Cc: Lu, Wenzhuo <wenzhuo...@intel.com>; Wu, Jingjing <jingjing...@intel.com>; > dev@dpdk.org; Jerin Jacob > <jerin.ja...@caviumnetworks.com> > Subject: Re: [dpdk-dev] [PATCH v2] app/testpmd: make txonly mode generate > multiple flows > > > > On Jan 18, 2018, at 4:21 AM, Ananyev, Konstantin > > <konstantin.anan...@intel.com> wrote: > > > > Hi, > > > >> -----Original Message----- > >> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Yongseok Koh > >> Sent: Wednesday, January 17, 2018 6:19 PM > >> To: Lu, Wenzhuo <wenzhuo...@intel.com>; Wu, Jingjing > >> <jingjing...@intel.com> > >> Cc: dev@dpdk.org; Yongseok Koh <ys...@mellanox.com> > >> Subject: [dpdk-dev] [PATCH v2] app/testpmd: make txonly mode generate > >> multiple flows > >> > >> Testpmd can generate multiple flows without taking much cost and this could > >> be a simple traffic generator for developer's quick tests. IP destination > >> address is varied. > > > > Correct me if I am wrong - but that the change of existing behavior. > > Without any announcement and without ability to the user to keep > > current one (command-line option, new CLI command, etc.). > > What if there are people who rely on existing behavior > > (some test scripts or so)? > > Konstantin > > Good point. But I think it is unlikely. Currently, it generates single fat > flow > and if someone uses it for testing, then Rx side likely uses single core. Even > if it gets to generate multiple flows, it would be same to such a case. > > However, it is my speculation. If you disagree anyway, I'll stash it for 18.05 > and add a new knob to enable it. I'm okay with that because it is just for > convenience, not an urgent issue. >
Yes, I think some sort of announcement would be good. Another alternative - add for user an ability to choose - new CLI command or so. Konstantin
