> -----Original Message----- > From: Tomasz Duszynski [mailto:t...@semihalf.com] > Sent: Thursday, December 14, 2017 9:28 AM > To: De Lara Guarch, Pablo <pablo.de.lara.gua...@intel.com> > Cc: Doherty, Declan <declan.dohe...@intel.com>; > jerin.ja...@caviumnetworks.com; j...@semihalf.com; t...@semihalf.com; > d...@marvell.com; nsams...@marvell.com; jianbo....@arm.org; > dev@dpdk.org > Subject: Re: [PATCH] cryptodev: remove duplicated device name length > > On Wed, Dec 13, 2017 at 03:54:08PM +0000, Pablo de Lara wrote: > > Two macros were defined in cryptodev, to serve the same > > purpose: RTE_CRYPTODEV_NAME_LEN (in the config file) and > > RTE_CRYPTODEV_NAME_MAX_LEN (in the rte_cryptodev.h file). > > Since the second one is part of the external API, the first one has > > been removed, avoiding duplications. > > > > Signed-off-by: Pablo de Lara <pablo.de.lara.gua...@intel.com>
... > As for mrvl crypto pmd: > Acked-by: Tomasz Duszynski <t...@semihalf.com> I am aware that this patch is removing a configuration option, that was used in an internal app (so it could potentially be used in other apps). This shouldn't be the case, plus this macro is duplicated, so apps and PMDs should use the macro in the cryptodev header file. Applied to dpdk-next-crypto. Pablo
