> -----Original Message----- > From: Matan Azrad [mailto:ma...@mellanox.com] > Sent: Friday, January 19, 2018 12:52 PM > To: Ananyev, Konstantin <konstantin.anan...@intel.com>; Thomas Monjalon > <tho...@monjalon.net>; Gaetan Rivet > <gaetan.ri...@6wind.com>; Wu, Jingjing <jingjing...@intel.com> > Cc: dev@dpdk.org; Neil Horman <nhor...@tuxdriver.com>; Richardson, Bruce > <bruce.richard...@intel.com> > Subject: RE: [PATCH v3 7/7] app/testpmd: adjust ethdev port ownership > > Hi Konstantin > > From: Ananyev, Konstantin, Friday, January 19, 2018 2:38 PM > > To: Matan Azrad <ma...@mellanox.com>; Thomas Monjalon > > <tho...@monjalon.net>; Gaetan Rivet <gaetan.ri...@6wind.com>; Wu, > > Jingjing <jingjing...@intel.com> > > Cc: dev@dpdk.org; Neil Horman <nhor...@tuxdriver.com>; Richardson, > > Bruce <bruce.richard...@intel.com> > > Subject: RE: [PATCH v3 7/7] app/testpmd: adjust ethdev port ownership > > > > Hi Matan, > > > > > -----Original Message----- > > > From: Matan Azrad [mailto:ma...@mellanox.com] > > > Sent: Thursday, January 18, 2018 4:35 PM > > > To: Thomas Monjalon <tho...@monjalon.net>; Gaetan Rivet > > > <gaetan.ri...@6wind.com>; Wu, Jingjing <jingjing...@intel.com> > > > Cc: dev@dpdk.org; Neil Horman <nhor...@tuxdriver.com>; Richardson, > > > Bruce <bruce.richard...@intel.com>; Ananyev, Konstantin > > > <konstantin.anan...@intel.com> > > > Subject: [PATCH v3 7/7] app/testpmd: adjust ethdev port ownership > > > > > > Testpmd should not use ethdev ports which are managed by other DPDK > > > entities. > > > > > > Set Testpmd ownership to each port which is not used by other entity > > > and prevent any usage of ethdev ports which are not owned by Testpmd. > > > > > > Signed-off-by: Matan Azrad <ma...@mellanox.com> > > > --- > > > app/test-pmd/cmdline.c | 89 +++++++++++++++++++--------------------- > > ----- > > > app/test-pmd/cmdline_flow.c | 2 +- > > > app/test-pmd/config.c | 37 ++++++++++--------- > > > app/test-pmd/parameters.c | 4 +- > > > app/test-pmd/testpmd.c | 63 ++++++++++++++++++++------------ > > > app/test-pmd/testpmd.h | 3 ++ > > > 6 files changed, 103 insertions(+), 95 deletions(-) > > > > > > diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c index > > > 31919ba..6199c64 100644 > > > --- a/app/test-pmd/cmdline.c > > > +++ b/app/test-pmd/cmdline.c > > > @@ -1394,7 +1394,7 @@ struct cmd_config_speed_all { > > > &link_speed) < 0) > > > return; > > > > > > - RTE_ETH_FOREACH_DEV(pid) { > > > + RTE_ETH_FOREACH_DEV_OWNED_BY(pid, my_owner.id) { > > > > Why do we need all these changes? > > As I understand you changed definition of RTE_ETH_FOREACH_DEV(), so no > > testpmd should work ok default (no_owner case). > > Am I missing something here? > > Now, After Gaetan suggestion RTE_ETH_FOREACH_DEV(pid) will iterate over all > valid and ownerless ports.
Yes. > Here Testpmd wants to iterate over its owned ports. Why? Why it can't just iterate over all valid and ownerless ports? As I understand it would be enough to fix current problems and would allow us to avoid any changes in testmpd (which I think is a good thing). Konstantin > > I added to Testpmd ability to take an ownership of ports as the new ownership > and synchronization rules suggested, > Since Tespmd is a DPDK entity which wants that no one will touch its owned > ports, > It must allocate an unique ID, set owner for its ports (see in main function) > and recognizes them by its owner ID. > > > Konstantin > >
