Re: [dpdk-dev] [PATCH 01/39] eventdev: update PMD dequeue timeout conversion callback

2017-03-15 Thread Van Haaren, Harry
> From: Jerin Jacob [mailto:jerin.ja...@caviumnetworks.com] > Sent: Friday, March 3, 2017 5:28 PM > To: dev@dpdk.org > Subject: [dpdk-dev] [PATCH 01/39] eventdev: update PMD dequeue timeout > conversion > callback > > eventdev driver may return error on dequeue timeout tick conversion. > Change t

Re: [dpdk-dev] [PATCH 02/39] app/test: fix eventdev reconfigure test

2017-03-15 Thread Van Haaren, Harry
> From: Jerin Jacob [mailto:jerin.ja...@caviumnetworks.com] > Sent: Friday, March 3, 2017 5:28 PM > To: dev@dpdk.org > Subject: [dpdk-dev] [PATCH 02/39] app/test: fix eventdev reconfigure test > > Minimum value of nb_event_ports and/or nb_event_queues > should be one before reconfiguring the event

Re: [dpdk-dev] [PATCH v2 1/2] librte_net: add crc init and compute APIs

2017-03-15 Thread Thomas Monjalon
2017-03-08 11:08, De Lara Guarch, Pablo: > From: Thomas Monjalon [mailto:thomas.monja...@6wind.com] > > 2017-03-02 13:03, Singh, Jasvinder: > > > From: Thomas Monjalon [mailto:thomas.monja...@6wind.com] > > > > 2017-02-28 12:08, Jasvinder Singh: > > > > > lib/librte_net/rte_net_crc.c | 664

Re: [dpdk-dev] [PATCH v3] lpm: extend IPv6 next hop field

2017-03-15 Thread Thomas Monjalon
2017-03-14 19:17, Vladyslav Buslov: > This patch extend next_hop field from 8-bits to 21-bits in LPM library > for IPv6. > > Added versioning symbols to functions and updated > library and applications that have a dependency on LPM library. > > Signed-off-by: Vladyslav Buslov > Acked-by: Bruce R

Re: [dpdk-dev] [PATCH] net/vmxnet3: fix queue size changes

2017-03-15 Thread Yong Wang
> -Original Message- > From: Charles (Chas) Williams [mailto:ciwil...@brocade.com] > Sent: Wednesday, March 15, 2017 5:35 AM > To: dev@dpdk.org > Cc: Yong Wang ; Charles (Chas) Williams > > Subject: [PATCH] net/vmxnet3: fix queue size changes > > If the user reconfigures the queue size, t

[dpdk-dev] [PATCH v7 0/3] new API to free consumed buffers in Tx ring

2017-03-15 Thread Billy McFall
See request from 11/21/2016: http://dpdk.org/ml/archives/dev/2016-November/050585.html Add a new API to free consumed buffers on TX ring. This addresses two scenarios: 1) Flooding a packet and want to reuse existing mbuf to avoid a packet copy. Increment the reference count of the packet and pol

[dpdk-dev] [PATCH v7 1/3] ethdev: new API to free consumed buffers in Tx ring

2017-03-15 Thread Billy McFall
Add a new API to force free consumed buffers on Tx ring. API will return the number of packets freed (0-n) or error code if feature not supported (-ENOTSUP) or input invalid (-ENODEV). Signed-off-by: Billy McFall --- doc/guides/conf.py | 7 +-- doc/guides/nics/features/

[dpdk-dev] [PATCH v7 2/3] net/e1000: e1000 igb support to free consumed buffers

2017-03-15 Thread Billy McFall
Add support to the e1000 igb driver for the new API to force free consumed buffers on Tx ring. This API is independent of the tx_rs_thresh setting. With this API, buffers should be free even if tx_rs_thresh is not met. e1000 igb driver does not implement a tx_rs_thresh to free mbufs, it frees a sl

[dpdk-dev] [PATCH v7 3/3] net/vhost: vHost support to free consumed buffers

2017-03-15 Thread Billy McFall
Add support to the vHostdriver for the new API to force free consumed buffers on Tx ring. vHost does not cache the mbufs so there is no work to do. Signed-off-by: Billy McFall Acked-by: Maxime Coquelin --- doc/guides/nics/features/vhost.ini | 1 + drivers/net/vhost/rte_eth_vhost.c | 11 ++

Re: [dpdk-dev] [PATCH v4 00/17] Wind River Systems AVP PMD vs virtio?

2017-03-15 Thread Ferruh Yigit
On 3/15/2017 2:08 PM, Vincent JARDIN wrote: > Le 15/03/2017 à 12:29, Ferruh Yigit a écrit : >> The scope of the patch is limited to PMD. >> As long as it is maintained, it is good to have alternative approaches. > > From your logic, then, how many PMDs can be accepted? > > See my previous email:

Re: [dpdk-dev] [PATCH] net/vmxnet3: fix queue size changes

2017-03-15 Thread Jan Blunck
On Wed, Mar 15, 2017 at 1:35 PM, Charles (Chas) Williams wrote: > If the user reconfigures the queue size, then the previously allocated > memzone may potentially be too small. Release the memzone when a queue > is released and allocate a new one each time a queue is setup. > > While here convert

Re: [dpdk-dev] [PATCH] net/vmxnet3: fix queue size changes

2017-03-15 Thread Shrikrishna Khare
On Wed, 15 Mar 2017, Yong Wang wrote: > > -Original Message- > > From: Charles (Chas) Williams [mailto:ciwil...@brocade.com] > > Sent: Wednesday, March 15, 2017 5:35 AM > > To: dev@dpdk.org > > Cc: Yong Wang ; Charles (Chas) Williams > > > > Subject: [PATCH] net/vmxnet3: fix queue size

Re: [dpdk-dev] [PATCH v2 1/2] librte_net: add crc init and compute APIs

2017-03-15 Thread Dumitrescu, Cristian
... > > > > > I think it should be in librte_hash. > > > > > > > > > > Please check lib/librte_hash/rte_hash_crc.h > > > > > > > > Is it good to include payload crc calculation in hash library as I see > > > > all > hash > > > related functionality there? > > > > > > I think yes. Pablo? > > > >

Re: [dpdk-dev] [PATCH v2 1/2] librte_net: add crc init and compute APIs

2017-03-15 Thread Dumitrescu, Cristian
> -Original Message- > From: Dumitrescu, Cristian > Sent: Wednesday, March 15, 2017 7:04 PM > To: 'Thomas Monjalon' ; De Lara Guarch, > Pablo > Cc: Singh, Jasvinder ; dev@dpdk.org; Doherty, > Declan > Subject: RE: [dpdk-dev] [PATCH v2 1/2] librte_net: add crc init and compute > APIs >

[dpdk-dev] [PATCH] vhost: fix virtio_net cache sharing of broadcast_rarp

2017-03-15 Thread Kevin Traynor
The virtio_net structure is used in both enqueue and dequeue datapaths. broadcast_rarp is checked with cmpset in the dequeue datapath regardless of whether descriptors are available or not. It is observed in some cases where dequeue and enqueue are performed by different cores and no packets are a

Re: [dpdk-dev] [PATCH v2 1/2] librte_net: add crc init and compute APIs

2017-03-15 Thread Thomas Monjalon
2017-03-15 19:03, Dumitrescu, Cristian: > ... > > > > > > > I think it should be in librte_hash. > > > > > > > > > > > > Please check lib/librte_hash/rte_hash_crc.h > > > > > > > > > > Is it good to include payload crc calculation in hash library as I > > > > > see all > > hash > > > > related f

Re: [dpdk-dev] [PATCH v4 00/17] Wind River Systems AVP PMD vs virtio?

2017-03-15 Thread Wiles, Keith
> On Mar 15, 2017, at 10:02 PM, Vincent JARDIN wrote: > > Le 15/03/2017 à 05:10, O'Driscoll, Tim a écrit : >>> so, still an nack because: >>> - no performance data of avp vs virtio, >> I don't think it should be a requirement for Allain to provide performance >> data in order to justify getti

Re: [dpdk-dev] [PATCH v7 0/3] new API to free consumed buffers in Tx ring

2017-03-15 Thread Wiles, Keith
> On Mar 16, 2017, at 2:02 AM, Billy McFall wrote: > > See request from 11/21/2016: > http://dpdk.org/ml/archives/dev/2016-November/050585.html > > Add a new API to free consumed buffers on TX ring. This addresses two > scenarios: > 1) Flooding a packet and want to reuse existing mbuf to avoid

Re: [dpdk-dev] [PATCH v2 1/2] librte_net: add crc init and compute APIs

2017-03-15 Thread Dumitrescu, Cristian
> -Original Message- > From: Thomas Monjalon [mailto:thomas.monja...@6wind.com] > Sent: Wednesday, March 15, 2017 8:16 PM > To: Dumitrescu, Cristian > Cc: De Lara Guarch, Pablo ; Singh, > Jasvinder ; dev@dpdk.org; Doherty, Declan > > Subject: Re: [dpdk-dev] [PATCH v2 1/2] librte_net: ad

Re: [dpdk-dev] [PATCH v5 1/8] net/tap: remove wrong IFF_NOARP flags

2017-03-15 Thread Wiles, Keith
> On Mar 15, 2017, at 10:48 PM, Pascal Mazon wrote: > > There is no reason not to support ARP on a tap netdevice. > Focus on IFF_UP when a link status change is required. > > Fixes: f457b472b1f2 ("net/tap: add link up and down operations") > Signed-off-by: Pascal Mazon > Reviewed-by: Ferruh Yi

Re: [dpdk-dev] [PATCH v5 0/8] net/tap: add additional management ops

2017-03-15 Thread Wiles, Keith
Please let me know if I have missed and Ack for the TAP PMD. I believe I have reviewed and agree with all of the changes to TAP at this time. > On Mar 16, 2017, at 12:46 AM, Yigit, Ferruh wrote: > > On 3/15/2017 2:48 PM, Pascal Mazon wrote: >> v2 change: >> - use snprintf in tap_mtu set >> >>

Re: [dpdk-dev] [PATCH] net/tap: support segmented mbufs

2017-03-15 Thread Wiles, Keith
> On Mar 15, 2017, at 11:09 PM, Pascal Mazon wrote: > > Support for segmented packets (scatter/gather) is mandatory for most > purposes, regardless of the MTU size. Tx packets are often the result of > mbuf concatenation, and an mbuf is not necessarily large enough for Rx > packets to fit in a s

Re: [dpdk-dev] [PATCH] net/tap: do not send packets larger than MTU

2017-03-15 Thread Wiles, Keith
> On Mar 15, 2017, at 11:09 PM, Pascal Mazon wrote: > > Signed-off-by: Pascal Mazon Acked-by: Keith Wiles > --- > drivers/net/tap/rte_eth_tap.c | 6 ++ > drivers/net/tap/rte_eth_tap.h | 1 + > 2 files changed, 7 insertions(+) Regards, Keith

[dpdk-dev] [PATCH v3 0/2] net/mlx5: add enhanced multi-packet send for ConnectX-5

2017-03-15 Thread Yongseok Koh
This patchset is to add the Enhanced Multi-Packet Send feature which is newly introduced for ConnectX-5 families of adaptors. v3: * Fix indentation * Fix typo in comment * Change name of variables and functions v2: * Resolves conflicts with other patches in review. * Improved performance by reloc

[dpdk-dev] [PATCH v3 2/2] doc: update PMD options for mlx5

2017-03-15 Thread Yongseok Koh
Enhanced multi-packet send mode is newly introduced for ConnectX-5 families of adaptors. Signed-off-by: Yongseok Koh --- doc/guides/nics/mlx5.rst | 31 +++ 1 file changed, 27 insertions(+), 4 deletions(-) diff --git a/doc/guides/nics/mlx5.rst b/doc/guides/nics/mlx5.r

[dpdk-dev] [PATCH v3 1/2] net/mlx5: add enhanced multi-packet send for ConnectX-5

2017-03-15 Thread Yongseok Koh
ConnectX-5 supports enhanced version of multi-packet send (MPS). An MPS Tx descriptor can carry multiple packets either by including pointers of packets or by inlining packets. Inlining packet data can be helpful to better utilize PCIe bandwidth. In addition, Enhanced MPS supports hybrid mode - mix

Re: [dpdk-dev] [PATCH v3 0/2] net/mlx5: add enhanced multi-packet send for ConnectX-5

2017-03-15 Thread Yongseok Koh
Hi, > On Mar 15, 2017, at 4:55 PM, Yongseok Koh wrote: > > This patchset is to add the Enhanced Multi-Packet Send feature which is > newly introduced for ConnectX-5 families of adaptors. > > v3: > * Fix indentation > * Fix typo in comment > * Change name of variables and functions I forgot to

[dpdk-dev] [PATCH] net/i40e: fix broadcast promiscuous mode setting

2017-03-15 Thread Wenzhuo Lu
When setting up the VSIs, MAC filter is used for receiving MAC broadcast packets. We should follow it to implement the broadcast promiscuous mode setting. Fixes: 61fff9b4c68b (net/i40e: set VF broadcast mode from PF) Signed-off-by: Wenzhuo Lu --- drivers/net/i40e/i40e_ethdev.c | 16

Re: [dpdk-dev] [PATCH v4 00/17] Wind River Systems AVP PMD vs virtio?

2017-03-15 Thread O'Driscoll, Tim
> From: Vincent JARDIN [mailto:vincent.jar...@6wind.com] > > Le 15/03/2017 à 11:55, Thomas Monjalon a écrit : > >> I'd suggest that this is a good topic for the next Tech Board > meeting. > > I agree Tim. > > CC'ing techboard to add this item to the agenda of the next meeting. > > Frankly, I disa

Re: [dpdk-dev] [PATCH] vhost: fix virtio_net cache sharing of broadcast_rarp

2017-03-15 Thread Yuanhan Liu
On Wed, Mar 15, 2017 at 07:10:49PM +, Kevin Traynor wrote: > The virtio_net structure is used in both enqueue and dequeue datapaths. > broadcast_rarp is checked with cmpset in the dequeue datapath regardless > of whether descriptors are available or not. > > It is observed in some cases where

Re: [dpdk-dev] [PATCH v2 1/2] net/mlx5: add enhanced multi-packet send for ConnectX-5

2017-03-15 Thread Shahaf Shuler
Saturday, March 11, 2017 1:14 AM, Yongseok Koh: > Subject: [dpdk-dev] [PATCH v2 1/2] net/mlx5: add enhanced multi-packet > send for ConnectX-5 > > ConnectX-5 supports enhanced version of multi-packet send (MPS). An MPS > Tx descriptor can carry multiple packets either by including pointers of > p

Re: [dpdk-dev] [PATCH v2 2/2] doc: update PMD options for mlx5

2017-03-15 Thread Shahaf Shuler
Saturday, March 11, 2017 1:14 AM, Yongseok Koh: > Enhanced multi-packet send mode is newly introduced for ConnectX-5 > families of adaptors. > > Signed-off-by: Yongseok Koh > --- > doc/guides/nics/mlx5.rst | 31 +++ > 1 file changed, 27 insertions(+), 4 deletions(-) >

[dpdk-dev] FW: [dpdk-test-report] | ERROR | daily Intel builds (37/43)

2017-03-15 Thread Wei, FangfangX
Hi all, There's one build error which was brought by commit "0fe9830b53452a6747cae9ff1a6bfc737b839a9d". commit 0fe9830b53452a6747cae9ff1a6bfc737b839a9d Author: Gowrishankar Muthukrishnan Date: Mon Mar 6 20:34:15 2017 +0530 eal/ppc: support sPAPR IOMMU for vfio-pci Below changes adds

Re: [dpdk-dev] [PATCH v2] net/virtio-user: fix overflow

2017-03-15 Thread Yuanhan Liu
On Tue, Mar 14, 2017 at 10:09:56AM +, Wenfeng Liu wrote: > virtio-user limits the qeueue number to 8 but provides no limit > check against the queue number input from user. If a bigger queue > number (> 8) is given, there is an overflow issue. Doing a sanity > check could avoid it. > > Fixes:

Re: [dpdk-dev] [PATCH] net/vmxnet3: fix queue size changes

2017-03-15 Thread Jan Blunck
On Tue, Mar 14, 2017 at 5:38 PM, Charles (Chas) Williams wrote: > > > On 03/14/2017 12:11 PM, Jan Blunck wrote: >> >> On Mon, Mar 13, 2017 at 11:41 PM, Charles (Chas) Williams >> wrote: >>> >>> If the user reconfigures the queues size, then the previosly allocated >>> memzone may potentially be t

Re: [dpdk-dev] [PATCH 3/3] eal: remove references to execinfo.h for musl

2017-03-15 Thread Jan Blunck
On Mon, Mar 13, 2017 at 9:10 AM, Dai, Wei wrote: >> -Original Message- >> From: jblu...@gmail.com [mailto:jblu...@gmail.com] On Behalf Of Jan Blunck >> Sent: Friday, March 10, 2017 10:50 PM >> To: Thomas Monjalon >> Cc: Dai, Wei ; dev ; Mcnamara, John >> ; david.march...@intel.com >> Subj

Re: [dpdk-dev] [PATCH v2 1/3] examples/performance-thread: remove reference to execinfo.h

2017-03-15 Thread Jan Blunck
On Mon, Mar 13, 2017 at 9:59 AM, Wei Dai wrote: > There is no function to refer any part of execinfo.h, so remove the > reference to it. And there is no this file in musl. So need to > remove it to support musl. > > The musl is an alternative LIBC to GLIBC and provides the > standard C/POSIX libra

Re: [dpdk-dev] FW: [dpdk-test-report] | ERROR | daily Intel builds (37/43)

2017-03-15 Thread Burakov, Anatoly
> Hi all, > There's one build error which was brought by commit > "0fe9830b53452a6747cae9ff1a6bfc737b839a9d". > > commit 0fe9830b53452a6747cae9ff1a6bfc737b839a9d > Author: Gowrishankar Muthukrishnan > Hi Gowrishankar, It seems we missed a vfio_iommu_spapr_tce_info structure in our conditional

Re: [dpdk-dev] [PATCH] net/vmxnet3: fix queue size changes

2017-03-15 Thread Charles (Chas) Williams
On 03/15/2017 04:18 AM, Jan Blunck wrote: On Tue, Mar 14, 2017 at 5:38 PM, Charles (Chas) Williams wrote: On 03/14/2017 12:11 PM, Jan Blunck wrote: On Mon, Mar 13, 2017 at 11:41 PM, Charles (Chas) Williams wrote: If the user reconfigures the queues size, then the previosly allocated me

Re: [dpdk-dev] [PATCH] net/vmxnet3: fix queue size changes

2017-03-15 Thread Jan Blunck
On Wed, Mar 15, 2017 at 10:45 AM, Charles (Chas) Williams wrote: > > > On 03/15/2017 04:18 AM, Jan Blunck wrote: >> >> On Tue, Mar 14, 2017 at 5:38 PM, Charles (Chas) Williams >> wrote: >>> >>> >>> >>> On 03/14/2017 12:11 PM, Jan Blunck wrote: On Mon, Mar 13, 2017 at 11:41 PM, Char

Re: [dpdk-dev] [PATCH] net/vmxnet3: fix queue size changes

2017-03-15 Thread Charles (Chas) Williams
On 03/15/2017 06:05 AM, Jan Blunck wrote: On Wed, Mar 15, 2017 at 10:45 AM, Charles (Chas) Williams wrote: On 03/15/2017 04:18 AM, Jan Blunck wrote: On Tue, Mar 14, 2017 at 5:38 PM, Charles (Chas) Williams wrote: On 03/14/2017 12:11 PM, Jan Blunck wrote: On Mon, Mar 13, 2017 at 11

Re: [dpdk-dev] [PATCH 1/2] net/mlx5: add enhanced multi-packet send for ConnectX-5

2017-03-15 Thread Nélio Laranjeiro
Hi Yongseok, Please see the comments below, On Tue, Feb 28, 2017 at 09:02:24PM -0800, Yongseok Koh wrote: > ConnectX-5 supports enhanced version of multi-packet send (MPS). An MPS Tx > descriptor can carry multiple packets either by including pointers of > packets or by inlining packets. Inlining

[dpdk-dev] PMD features matrix

2017-03-15 Thread Thomas Monjalon
Hi, Reminder: We have a tool to monitor the PMD features implementations: http://dpdk.org/doc/guides/nics/overview.html#id1 It may be used for various important needs, and must be updated when the code change. There are still some drivers not filled in this matrix (null, af_packet, xenvir

Re: [dpdk-dev] [PATCH v6 3/3] net/vhost: vHost support to free consumed buffers

2017-03-15 Thread Thomas Monjalon
2017-03-09 15:51, Billy McFall: > Add support to the vHostdriver for the new API to force free consumed > buffers on Tx ring. vHost does not cache the mbufs so there is no work > to do. > > Signed-off-by: Billy McFall Your forgot a acked-by from Maxime here.

Re: [dpdk-dev] [PATCH v6 1/3] ethdev: new API to free consumed buffers in Tx ring

2017-03-15 Thread Olivier Matz
Hi Billy, On Thu, 9 Mar 2017 15:51:17 -0500, Billy McFall wrote: > Add a new API to force free consumed buffers on Tx ring. API will return > the number of packets freed (0-n) or error code if feature not supported > (-ENOTSUP) or input invalid (-ENODEV). > > Please double check my python codin

Re: [dpdk-dev] [PATCH v6 1/3] ethdev: new API to free consumed buffers in Tx ring

2017-03-15 Thread Thomas Monjalon
2017-03-09 15:51, Billy McFall: > @@ -3097,6 +3101,33 @@ rte_eth_tx_buffer(uint8_t port_id, uint16_t queue_id, > } > > /** > + * Request the driver to free mbufs currently cached by the driver. The > + * driver will only free the mbuf if it is no longer in use. It is the > + * application's res

Re: [dpdk-dev] [PATCH v2 1/2] net/mlx5: add enhanced multi-packet send for ConnectX-5

2017-03-15 Thread Nélio Laranjeiro
Hi Yongseok, I did not see this v2, in the future please use the "in-reply-to" in addition of the --thread option. Please see the comments below, On Fri, Mar 10, 2017 at 03:13:33PM -0800, Yongseok Koh wrote: > ConnectX-5 supports enhanced version of multi-packet send (MPS). An MPS Tx > descripto

Re: [dpdk-dev] [PATCH v2 1/2] net/mlx5: add enhanced multi-packet send for ConnectX-5

2017-03-15 Thread Nélio Laranjeiro
On Wed, Mar 15, 2017 at 11:39:07AM +0100, Nélio Laranjeiro wrote: > Hi Yongseok, > > I did not see this v2, in the future please use the "in-reply-to" in > addition of the --thread option. > > Please see the comments below, > >[...] > > > > @@ -292,7 +298,11 @@ mlx5_args_check(const char *key,

Re: [dpdk-dev] [PATCH] remove unmaintained TILE-Gx architecture

2017-03-15 Thread Thomas Monjalon
2017-02-11 21:36, Thomas Monjalon: > The TILE-Gx architecture and its driver mpipe are not maintained. > The code is removed to avoid confusion. > > Signed-off-by: Thomas Monjalon Applied with text additions: A last update has been done in 17.05 before removal. It can be built with the updated

Re: [dpdk-dev] FW: Issues with ixgbe and rte_flow

2017-03-15 Thread Adrien Mazarguil
Hi Wenzhuo, On Mon, Mar 13, 2017 at 02:33:52AM +, Lu, Wenzhuo wrote: [...] > > > It's a good suggestion. I remember we have some discussion about how > > > to feedback the error to the APP. I think the reason why we don't make > > > it too complex because it's the first step of generic API.

Re: [dpdk-dev] [PATCH v4 00/17] Wind River Systems AVP PMD vs virtio?

2017-03-15 Thread Thomas Monjalon
2017-03-15 04:10, O'Driscoll, Tim: > I've included a couple of specific comments inline below, and a general > comment here. > > We have somebody proposing to add a new driver to DPDK. It's standalone and > doesn't affect any of the core libraries. They're willing to maintain the > driver and h

Re: [dpdk-dev] [PATCH v2 0/6] Support running Solarflare PMD over PCI VFs

2017-03-15 Thread Ferruh Yigit
On 3/9/2017 5:22 PM, Andrew Rybchenko wrote: > Running Solarflare PMD over PCI virtual functions requires few fixes: > - periodic MAC stats DMA is not supported for VFs > - promiscious and all-multicast modes may be denied by FW/PF > - MCDI proxy authorization made by FW should be properly handl

Re: [dpdk-dev] [PATCH v2 5/6] net/sfc: add support for MCDI proxy

2017-03-15 Thread Ferruh Yigit
On 3/9/2017 5:23 PM, Andrew Rybchenko wrote: > From: Ivan Malov > > The patch is to add support for MCDI proxy which comes in > useful, particularly, while running over VF: few commands > will normally fail with EPERM, but in some cases the host > driver (i.e. running over the corresponding PF, t

Re: [dpdk-dev] [PATCH v2 00/13] introduce fail-safe PMD

2017-03-15 Thread Thomas Monjalon
2017-03-15 03:28, Bruce Richardson: > On Tue, Mar 14, 2017 at 03:49:47PM +0100, Gaëtan Rivet wrote: > > > > 2. Bonding and link availability > > > > > > > > The hot-plug functionality is not a core function of the bonding PMD. > > > > It is only interested in knowing if the link is active or not.

Re: [dpdk-dev] [PATCH v4 00/17] Wind River Systems AVP PMD vs virtio?

2017-03-15 Thread Ferruh Yigit
On 3/15/2017 4:10 AM, O'Driscoll, Tim wrote: > I've included a couple of specific comments inline below, and a general > comment here. > > We have somebody proposing to add a new driver to DPDK. It's standalone and > doesn't affect any of the core libraries. > They're willing to maintain the dri

Re: [dpdk-dev] [PATCH v2] examples/ip_fragmentation: fix check of packet type

2017-03-15 Thread Ananyev, Konstantin
> -Original Message- > From: Dai, Wei > Sent: Tuesday, March 14, 2017 2:48 PM > To: dev@dpdk.org > Cc: Ananyev, Konstantin ; Dai, Wei > ; sta...@dpdk.org > Subject: [PATCH v2] examples/ip_fragmentation: fix check of packet type > > The packet_type in mbuf is not correctly filled by ixgb

[dpdk-dev] [PATCH] net/mlx5: limit flow API rules to one tunnel

2017-03-15 Thread Nelio Laranjeiro
Signed-off-by: Nelio Laranjeiro Acked-by: Adrien Mazarguil --- drivers/net/mlx5/mlx5_flow.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c index e789c4c..5468642 100644 --- a/drivers/net/mlx5/mlx5_flow.c +++ b/drivers/n

Re: [dpdk-dev] [PATCH] net/vmxnet3: fix queue size changes

2017-03-15 Thread Charles (Chas) Williams
On 03/15/2017 06:05 AM, Jan Blunck wrote: On Wed, Mar 15, 2017 at 10:45 AM, Charles (Chas) Williams wrote: On 03/15/2017 04:18 AM, Jan Blunck wrote: On Tue, Mar 14, 2017 at 5:38 PM, Charles (Chas) Williams wrote: On 03/14/2017 12:11 PM, Jan Blunck wrote: On Mon, Mar 13, 2017 at 11

[dpdk-dev] [PATCH] net/vmxnet3: fix queue size changes

2017-03-15 Thread Charles (Chas) Williams
If the user reconfigures the queue size, then the previously allocated memzone may potentially be too small. Release the memzone when a queue is released and allocate a new one each time a queue is setup. While here convert to rte_eth_dma_zone_reserve() which does basically the same things as the

Re: [dpdk-dev] [PATCH v3 2/2] ethdev: add hierarchical scheduler API

2017-03-15 Thread Thomas Monjalon
2017-03-10 18:37, Dumitrescu, Cristian: > From: O'Driscoll, Tim > > > > OK I better understand now. > > > > You should add this level of explanation in your patch. > > > > > > > > However I am reluctant to add an API if there is no user. > > > > I think we should wait to have at least one existing

Re: [dpdk-dev] [PATCH v4] mbuf: use pktmbuf helper to create the pool

2017-03-15 Thread Thomas Monjalon
2017-03-14 10:14, Olivier Matz: > From: Hemant Agrawal > > When possible, replace the uses of rte_mempool_create() with > the helper provided in librte_mbuf: rte_pktmbuf_pool_create(). > > This is the preferred way to create a mbuf pool. > > This also updates the documentation. > > Signed-off-

Re: [dpdk-dev] [PATCH] igb_uio: support devices with at least 1 bar defined

2017-03-15 Thread Thomas Monjalon
2017-03-14 16:59, Ferruh Yigit: > On 3/14/2017 4:33 PM, Allain Legacy wrote: > > From: Matt Peters > > > > Allow the BAR setup to succeed if a device has at least 1 BAR region > > defined. Previously, the device probe would only succeed if at least one > > memory BAR existed, but there are devic

[dpdk-dev] [PATCH v10 0/18] distributor library performance enhancements

2017-03-15 Thread David Hunt
This patch aims to improve the throughput of the distributor library. It uses a similar handshake mechanism to the previous version of the library, in that bits are used to indicate when packets are ready to be sent to a worker and ready to be returned from a worker. One main difference is that in

[dpdk-dev] [PATCH v10 02/18] lib: create private header file

2017-03-15 Thread David Hunt
We'll be adding internal implementation definitions in here that are common to both burst and legacy APIs. Signed-off-by: David Hunt Acked-by: Bruce Richardson --- lib/librte_distributor/rte_distributor_private.h | 136 +++ lib/librte_distributor/rte_distributor_v20.c |

[dpdk-dev] [PATCH v10 01/18] lib: rename legacy distributor lib files

2017-03-15 Thread David Hunt
Move files out of the way so that we can replace with new versions of the distributor libtrary. Files are named in such a way as to match the symbol versioning that we will apply for backward ABI compatibility. Signed-off-by: David Hunt Acked-by: Bruce Richardson --- lib/librte_distributor/Make

[dpdk-dev] [PATCH v10 03/18] lib: add new distributor code

2017-03-15 Thread David Hunt
This patch includes the code for new burst-capable distributor library. It also includes the rte_distributor_next.h file which will be used as the public header once we add in the symbol versioning for v20 and v1705 APIs, at which stage we will rename it to rte_distributor.h. The new distributor

[dpdk-dev] [PATCH v10 04/18] lib: add SIMD flow matching to distributor

2017-03-15 Thread David Hunt
Add an optimised version of the in-flight flow matching algorithm using SIMD instructions. This should give up to 1.5x over the scalar versions performance. Falls back to scalar version if SSE4.2 not available Signed-off-by: David Hunt Acked-by: Bruce Richardson --- lib/librte_distributor/Make

[dpdk-dev] [PATCH v10 05/18] test/distributor: extra params for autotests

2017-03-15 Thread David Hunt
In the next few patches, we'll want to test old and new API, so here we're allowing different parameters to be passed to the tests, instead of just a distributor struct. Signed-off-by: David Hunt Acked-by: Bruce Richardson --- test/test/test_distributor.c | 64 +-

[dpdk-dev] [PATCH v10 06/18] lib: switch distributor over to new API

2017-03-15 Thread David Hunt
This is the main switch over between the legacy API and the new burst API. We rename all the functions in rte_distributor.c to remove the _v1705, and we add in _v20 in the rte_distributor_v20.c We also rename the rte_distributor_next.h as rte_distributor.h, as this is now the public header. At th

[dpdk-dev] [PATCH v10 07/18] lib: make v20 header file private

2017-03-15 Thread David Hunt
Signed-off-by: David Hunt Acked-by: Bruce Richardson --- lib/librte_distributor/Makefile | 1 - 1 file changed, 1 deletion(-) diff --git a/lib/librte_distributor/Makefile b/lib/librte_distributor/Makefile index a812fe4..2b28eff 100644 --- a/lib/librte_distributor/Makefile +++ b/lib/librte_distr

[dpdk-dev] [PATCH v10 08/18] lib: add symbol versioning to distributor

2017-03-15 Thread David Hunt
Also bumped up the ABI version number in the Makefile Signed-off-by: David Hunt Acked-by: Bruce Richardson --- lib/librte_distributor/Makefile| 2 +- lib/librte_distributor/rte_distributor.c | 57 +++--- lib/librte_distributor/rte_distributor_v1705.h |

[dpdk-dev] [PATCH v10 09/18] test: test single and burst distributor API

2017-03-15 Thread David Hunt
Signed-off-by: David Hunt Acked-by: Bruce Richardson --- test/test/test_distributor.c | 116 ++- 1 file changed, 82 insertions(+), 34 deletions(-) diff --git a/test/test/test_distributor.c b/test/test/test_distributor.c index 7a30513..890a852 100644 --- a

[dpdk-dev] [PATCH v10 10/18] test: add perf test for distributor burst mode

2017-03-15 Thread David Hunt
Signed-off-by: David Hunt Acked-by: Bruce Richardson --- test/test/test_distributor_perf.c | 75 ++- 1 file changed, 51 insertions(+), 24 deletions(-) diff --git a/test/test/test_distributor_perf.c b/test/test/test_distributor_perf.c index 1dd326b..732d86d 1

[dpdk-dev] [PATCH v10 11/18] examples/distributor: allow for extra stats

2017-03-15 Thread David Hunt
This will allow us to see what's going on at various stages throughout the sample app, with per-second visibility Signed-off-by: David Hunt Acked-by: Bruce Richardson --- examples/distributor/main.c | 140 +++- 1 file changed, 124 insertions(+), 16 deleti

[dpdk-dev] [PATCH v10 16/18] doc: distributor library changes for new burst API

2017-03-15 Thread David Hunt
Signed-off-by: David Hunt Acked-by: John McNamara Acked-by: Bruce Richardson --- doc/guides/prog_guide/packet_distrib_lib.rst | 3 +++ 1 file changed, 3 insertions(+) diff --git a/doc/guides/prog_guide/packet_distrib_lib.rst b/doc/guides/prog_guide/packet_distrib_lib.rst index b5bdabb..e0adca

[dpdk-dev] [PATCH v10 12/18] examples/distributor: wait for ports to come up

2017-03-15 Thread David Hunt
On some machines, ports take several seconds to come up. This patch causes the app to wait. Signed-off-by: David Hunt Acked-by: Bruce Richardson --- examples/distributor/main.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/examples/distributor/main.c b/examples/dist

[dpdk-dev] [PATCH v10 15/18] examples/distributor: give Rx thread a core

2017-03-15 Thread David Hunt
Now that we're printing out a page of stats every second to the console, we should give the stats it's own core so that we don't interfere with the performance of the Rx core. Signed-off-by: David Hunt Acked-by: Bruce Richardson --- examples/distributor/main.c | 24 1 f

[dpdk-dev] [PATCH v10 13/18] examples/distributor: add dedicated core for dist

2017-03-15 Thread David Hunt
Give the distribution functionality it's own core for performance, otherwise it's limited by the Rx core. Signed-off-by: David Hunt Acked-by: Bruce Richardson --- examples/distributor/main.c | 181 ++-- 1 file changed, 123 insertions(+), 58 deletions(-)

[dpdk-dev] [PATCH v10 14/18] examples/distributor: tweaks for performance

2017-03-15 Thread David Hunt
Approximately 10% performance increase due to these changes. Signed-off-by: David Hunt Acked-by: Bruce Richardson --- examples/distributor/main.c | 36 +++- 1 file changed, 23 insertions(+), 13 deletions(-) diff --git a/examples/distributor/main.c b/examples/dis

[dpdk-dev] [PATCH v10 17/18] doc: distributor app changes for new burst API

2017-03-15 Thread David Hunt
Changes in the thread layout described, with an updated diagram. Signed-off-by: David Hunt --- doc/guides/sample_app_ug/dist_app.rst | 49 +++--- doc/guides/sample_app_ug/img/dist_app.svg | 276 +- 2 files changed, 179 insertions(+), 146 deletions(-) diff --git

[dpdk-dev] [PATCH v10 18/18] maintainers: add to distributor lib maintainers

2017-03-15 Thread David Hunt
Signed-off-by: David Hunt Acked-by: Bruce Richardson --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 39bc78e..0545911 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -494,6 +494,7 @@ F: doc/guides/sample_app_ug/ip_reassembly.rst Distributor M

Re: [dpdk-dev] [PATCH v4 7/8] net/tap: add packet type management

2017-03-15 Thread Ferruh Yigit
On 3/14/2017 8:22 AM, Pascal Mazon wrote: > Advertize packet types supported by the librte_net. > > Signed-off-by: Pascal Mazon <...> > > #include > #include > @@ -228,6 +229,8 @@ pmd_rx_burst(void *queue, struct rte_mbuf **bufs, > uint16_t nb_pkts) > mbuf->data_len = len;

Re: [dpdk-dev] [PATCH v4 7/8] net/tap: add packet type management

2017-03-15 Thread Ferruh Yigit
On 3/14/2017 8:22 AM, Pascal Mazon wrote: > Advertize packet types supported by the librte_net. > > Signed-off-by: Pascal Mazon <...> > > +static const uint32_t* > +tap_dev_supported_ptypes_get(struct rte_eth_dev *dev __rte_unused) > +{ > + static const uint32_t ptypes[] = { > +

Re: [dpdk-dev] [PATCH v4 0/8] net/tap: add additional management ops

2017-03-15 Thread Ferruh Yigit
On 3/14/2017 8:22 AM, Pascal Mazon wrote: > Add a few eth_dev ops to the tap PMD for completeness. > We want it to behave as much as possible as a standard PMD. > > v2 change: > - use snprintf in tap_mtu set > > v3 change: > - call tap_mac_set() only once in tap_setup_queue() > > v4 changes:

Re: [dpdk-dev] [PATCH v4 7/8] net/tap: add packet type management

2017-03-15 Thread Pascal Mazon
On Wed, 15 Mar 2017 13:35:44 + Ferruh Yigit wrote: > On 3/14/2017 8:22 AM, Pascal Mazon wrote: > > Advertize packet types supported by the librte_net. > > > > Signed-off-by: Pascal Mazon > > <...> > > > > > #include > > #include > > @@ -228,6 +229,8 @@ pmd_rx_burst(void *queue, stru

Re: [dpdk-dev] [PATCH v2 02/14] ring: create common structure for prod and cons metadata

2017-03-15 Thread Thomas Monjalon
clang error below: 2017-03-07 11:32, Bruce Richardson: > + union { > + uint32_t sp_enqueue; /**< True, if single producer. */ > + uint32_t sc_dequeue; /**< True, if single consumer. */ > + }; error: anonymous unions are a C11 extension

Re: [dpdk-dev] [PATCH v4 00/17] Wind River Systems AVP PMD vs virtio?

2017-03-15 Thread Vincent JARDIN
Le 15/03/2017 à 05:10, O'Driscoll, Tim a écrit : so, still an nack because: - no performance data of avp vs virtio, I don't think it should be a requirement for Allain to provide performance data in order to justify getting this accepted into DPDK. Keith pointed out in a previous comment on

Re: [dpdk-dev] [PATCH v4 00/17] Wind River Systems AVP PMD vs virtio?

2017-03-15 Thread Vincent JARDIN
Le 15/03/2017 à 05:10, O'Driscoll, Tim a écrit : so, still an nack because: - no performance data of avp vs virtio, I don't think it should be a requirement for Allain to provide performance data in order to justify getting this accepted into DPDK. Keith pointed out in a previous comment on

Re: [dpdk-dev] [PATCH v4 00/17] Wind River Systems AVP PMD vs virtio?

2017-03-15 Thread Vincent JARDIN
Le 15/03/2017 à 12:29, Ferruh Yigit a écrit : The scope of the patch is limited to PMD. As long as it is maintained, it is good to have alternative approaches. From your logic, then, how many PMDs can be accepted? See my previous email: techboard should not bypass discussion of the dev@ maili

Re: [dpdk-dev] [PATCH v4 00/17] Wind River Systems AVP PMD vs virtio?

2017-03-15 Thread Vincent JARDIN
Le 15/03/2017 à 11:55, Thomas Monjalon a écrit : I'd suggest that this is a good topic for the next Tech Board meeting. I agree Tim. CC'ing techboard to add this item to the agenda of the next meeting. Frankly, I disagree, it is missing some discussions on the list.

Re: [dpdk-dev] [PATCH v2 00/13] introduce fail-safe PMD

2017-03-15 Thread Gaëtan Rivet
On Wed, Mar 15, 2017 at 12:15:56PM +0100, Thomas Monjalon wrote: 2017-03-15 03:28, Bruce Richardson: On Tue, Mar 14, 2017 at 03:49:47PM +0100, Gaëtan Rivet wrote: > - In the bonding, the init and configuration steps are still the > responsibility of the application and no one else. The bonding

Re: [dpdk-dev] [PATCH v2 1/2] net/mlx5: add enhanced multi-packet send for ConnectX-5

2017-03-15 Thread Ferruh Yigit
On 3/10/2017 11:13 PM, Yongseok Koh wrote: > ConnectX-5 supports enhanced version of multi-packet send (MPS). An MPS Tx > descriptor can carry multiple packets either by including pointers of > packets or by inlining packets. Inlining packet data can be helpful to > better utilize PCIe bandwidth. I

Re: [dpdk-dev] FW: Issues with ixgbe and rte_flow

2017-03-15 Thread Le Scouarnec Nicolas
Hi Adrien, > > > > And about the tpid, ethertype. I have a thought that why we need it as > > > > it's > > > duplicate with the item type. I think the initial design is just > > > following the IEEE > > > spec to define the structures so we will not miss anything. But why not > > > do some > >

Re: [dpdk-dev] [PATCH v4 7/8] net/tap: add packet type management

2017-03-15 Thread Ferruh Yigit
On 3/15/2017 1:44 PM, Pascal Mazon wrote: > On Wed, 15 Mar 2017 13:35:44 + > Ferruh Yigit wrote: > >> On 3/14/2017 8:22 AM, Pascal Mazon wrote: >>> Advertize packet types supported by the librte_net. >>> >>> Signed-off-by: Pascal Mazon >> >> <...> >> >>> >>> #include >>> #include >>> @

[dpdk-dev] [PATCH v5 0/8] net/tap: add additional management ops

2017-03-15 Thread Pascal Mazon
v2 change: - use snprintf in tap_mtu set v3 change: - call tap_mac_set() only once in tap_setup_queue() v4 changes: - use new tap_ioctl function for shared behavior between ops - update supported packet types - remove IFF_NOARP flag from link status change - sync desired MTU to both r

[dpdk-dev] [PATCH v5 2/8] net/tap: refactor ioctl calls

2017-03-15 Thread Pascal Mazon
Create a socket for ioctl at tap device creation instead of opening it and closing it every call to tap_link_set_flags(). Use a common tap_ioctl() function that can be extended for various uses (such as MTU change, MAC address change, ...). Signed-off-by: Pascal Mazon Reviewed-by: Ferruh Yigit

[dpdk-dev] [PATCH v5 1/8] net/tap: remove wrong IFF_NOARP flags

2017-03-15 Thread Pascal Mazon
There is no reason not to support ARP on a tap netdevice. Focus on IFF_UP when a link status change is required. Fixes: f457b472b1f2 ("net/tap: add link up and down operations") Signed-off-by: Pascal Mazon Reviewed-by: Ferruh Yigit --- drivers/net/tap/rte_eth_tap.c | 4 ++-- 1 file changed, 2 i

[dpdk-dev] [PATCH v5 4/8] net/tap: add MTU management

2017-03-15 Thread Pascal Mazon
The MTU is assigned to the tap netdevice according to the argument, but packet transmission and reception just write/read on an fd with the default limit being the socket buffer size. As a new rte_eth_dev_data is allocated during tap device init, ensure it is set again dev->data->mtu. Once the act

[dpdk-dev] [PATCH v5 3/8] net/tap: add MAC address management

2017-03-15 Thread Pascal Mazon
As soon as the netdevice is created, update pmd->mac_addr with its actual MAC address. Signed-off-by: Pascal Mazon Reviewed-by: Ferruh Yigit --- doc/guides/nics/features/tap.ini | 1 + drivers/net/tap/rte_eth_tap.c| 39 +-- 2 files changed, 34 insertions

[dpdk-dev] [PATCH v5 8/8] net/tap: add flow control management

2017-03-15 Thread Pascal Mazon
A tap netdevice does not support flow control; ensure nothing but RTE_FC_NONE mode can be set. Signed-off-by: Pascal Mazon Reviewed-by: Ferruh Yigit --- doc/guides/nics/features/tap.ini | 1 + drivers/net/tap/rte_eth_tap.c| 19 +++ 2 files changed, 20 insertions(+) diff --

  1   2   >