> On Mar 15, 2017, at 10:48 PM, Pascal Mazon <pascal.ma...@6wind.com> wrote:
>
> There is no reason not to support ARP on a tap netdevice.
> Focus on IFF_UP when a link status change is required.
>
> Fixes: f457b472b1f2 ("net/tap: add link up and down operations")
> Signed-off-by: Pascal Mazon <pascal.ma...@6wind.com>
> Reviewed-by: Ferruh Yigit <ferruh.yi...@intel.com>
Acked-by: keith.wi...@intel.com for the series.
> ---
> drivers/net/tap/rte_eth_tap.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/tap/rte_eth_tap.c b/drivers/net/tap/rte_eth_tap.c
> index a5cbb23e4cd2..fcf4a1dc3da1 100644
> --- a/drivers/net/tap/rte_eth_tap.c
> +++ b/drivers/net/tap/rte_eth_tap.c
> @@ -375,7 +375,7 @@ tap_link_set_down(struct rte_eth_dev *dev)
> struct pmd_internals *pmd = dev->data->dev_private;
>
> dev->data->dev_link.link_status = ETH_LINK_DOWN;
> - return tap_link_set_flags(pmd, IFF_UP | IFF_NOARP, 0);
> + return tap_link_set_flags(pmd, IFF_UP, 0);
> }
>
> static int
> @@ -384,7 +384,7 @@ tap_link_set_up(struct rte_eth_dev *dev)
> struct pmd_internals *pmd = dev->data->dev_private;
>
> dev->data->dev_link.link_status = ETH_LINK_UP;
> - return tap_link_set_flags(pmd, IFF_UP | IFF_NOARP, 1);
> + return tap_link_set_flags(pmd, IFF_UP, 1);
> }
>
> static int
> --
> 2.8.0.rc0
>
Regards,
Keith
