On Tue, Jan 31, 2017 at 04:14:18PM +, Harry van Haaren wrote:
> The following patchset adds software eventdev implementation
> to the next-eventdev tree.
>
> This implementation is based on the previous software eventdev
> v1 patchset, now with comments addressed:
> 1) xstats api return values
On Tue, Jan 31, 2017 at 04:14:19PM +, Harry van Haaren wrote:
> From: Bruce Richardson
>
> Since eventdev uses event structures rather than working directly on
> mbufs, there is no actual dependencies on the mbuf library. The
> inclusion of an mbuf pointer element inside the event itself does
On Tue, Jan 31, 2017 at 04:14:20PM +, Harry van Haaren wrote:
> From: Bruce Richardson
>
> Add in APIs for extended stats so that eventdev implementations can report
> out information on their internal state. The APIs are based on, but not
> identical to, the equivalent ethdev functions.
The
On Tue, Jan 31, 2017 at 04:14:21PM +, Harry van Haaren wrote:
> From: Bruce Richardson
>
> This adds the minimal changes to allow a SW eventdev implementation to
> be compiled, linked and created at run time. The eventdev does nothing,
> but can be created via vdev on commandline, e.g.
>
>
On Tue, Jan 31, 2017 at 04:14:22PM +, Harry van Haaren wrote:
> From: Bruce Richardson
>
> Add in the info_get function to return details on the queues, flow,
> prioritization capabilities, etc. that this device has.
>
> Signed-off-by: Bruce Richardson
> Signed-off-by: Harry van Haaren
> -
Creating IPv4 flow and IPv6 flow will cause confilct error.
Root cause is there's no IP info included in tunnel filter
input.
Fixes: 425c3325f0b0 ("net/i40e: store tunnel filter")
Fixes: d416530e6358 ("net/i40e: parse tunnel filter")
Signed-off-by: Beilei Xing
---
drivers/net/i40e/i40e_ethdev.c
> -Original Message-
> From: Ananyev, Konstantin
> Sent: Sunday, February 5, 2017 8:11 PM
> To: Ananyev, Konstantin ; Wu, Jingjing
> ; dev@dpdk.org
> Subject: RE: [dpdk-dev] [PATCH v2 3/5] net/ixgbe: fix bitmask of supported
> Tx flags
>
>
>
> > -Original Message-
> > From: dev
Hi, Jan,
On 2/1/2017 7:41 PM, Jan Blunck wrote:
On Fri, Jan 20, 2017 at 4:21 AM, Chen Jing D(Mark)
wrote:
This is the documentation to describe what prgdev is, how to use
prgdev API and accomplish an image download.
Signed-off-by: Chen Jing D(Mark)
---
doc/guides/prog_guide/prgdev_lib.rst
On Tue, Jan 31, 2017 at 04:14:25PM +, Harry van Haaren wrote:
> From: Bruce Richardson
>
> Add in the data structures for the event queues, and the eventdev
> functions to create and destroy those queues.
>
> Signed-off-by: Bruce Richardson
> Signed-off-by: Harry van Haaren
> ---
> driver
That also leave the question of how to HASH only on the IP tuple for TCP and
UDP packets? The use case is that I want all packets from the same IP src/dst
pair to be hashed to the same queue. This cannot be enforced with a complete
hash on TCP/UDP fields.
Tom
On Tue, Jan 31, 2017 at 04:14:27PM +, Harry van Haaren wrote:
> From: Bruce Richardson
>
> Signed-off-by: Bruce Richardson
> Signed-off-by: Harry van Haaren
> ---
> drivers/event/sw/sw_evdev.c | 68
> +
> 1 file changed, 68 insertions(+)
>
> di
> -Original Message-
> From: Jerin Jacob [mailto:jerin.ja...@caviumnetworks.com]
> Sent: Monday, February 6, 2017 8:07 AM
> To: Van Haaren, Harry
> Cc: dev@dpdk.org
> Subject: Re: [PATCH v2 00/15] next-eventdev: event/sw software eventdev
>
> On Tue, Jan 31, 2017 at 04:14:18PM +, Harr
Hi Jianfeng,
On 02/06/2017 07:39 AM, Tan, Jianfeng wrote:
Hi Maxime,
Have seen that you submit a feature in QEMU, commit c5f048d8fb69
(“vhost-user: Add MTU protocol feature and op”).
Appreciate your insights on:
(1) Do you have plan to enable it in DPDK vhost user?
Yes, I plan to propose
> -Original Message-
> From: Jerin Jacob [mailto:jerin.ja...@caviumnetworks.com]
> Sent: Monday, February 6, 2017 9:25 AM
> To: Van Haaren, Harry
> Cc: dev@dpdk.org; Richardson, Bruce
> Subject: Re: [PATCH v2 07/15] event/sw: add support for event queues
>
> On Tue, Jan 31, 2017 at 04:14
Hi Jingjing,
On Sat, 4 Feb 2017 11:36:12 +0800, Jingjing Wu
wrote:
> Some Tx offload flags are missed in bitmask of all supported packet
> Tx flags by i40e.
> This patch fixes it.
Could you detail which flag was missing?
Is it PKT_TX_TUNNEL_MASK?
If yes, shouldn't we have a "Fixes:" line?
I th
On Mon, 6 Feb 2017 03:02:12 +, "Wu, Jingjing"
wrote:
> >
> > Functionally will be same, but what do you think about following,
> > to make easy to see what define adds:
> >
> > +#define I40E_TX_OFFLOAD_MASK ( \
> > + PKT_TX_IP_CKSUM |\
> > + PKT_TX_IP
> -Original Message-
> From: Jerin Jacob [mailto:jerin.ja...@caviumnetworks.com]
> Sent: Monday, February 6, 2017 8:23 AM
> To: Van Haaren, Harry
> Cc: dev@dpdk.org; Richardson, Bruce
> Subject: Re: [PATCH v2 02/15] eventdev: add APIs for extended stats
>
> On Tue, Jan 31, 2017 at 04:14:
> As 1.x is for linux/freebsd, but 2.0 is for solaris, 2.0 doesn't
> leverage the messages from 1.x. For example, 0x0a has different
> meaning in 1.x and 2.0. So better letting it be.
>
Ok, thanks for your reply.
The hardware may reject adding host_info in case support for
host_info is missing in the list of supported features. On the
other hand the list of supported featues may contain support
for the host_info - typical bootstrap problem.
This patch solves it by removing check against support for
host_inf
The hardware may reject adding host_info in case support for
host_info is missing in the list of supported features. On the
other hand the list of supported featues may contain support
for the host_info - typical bootstrap problem.
This patch solves it by removing check against support for
host_inf
> -Original Message-
> From: Wu, Jingjing
> Sent: Monday, February 6, 2017 8:54 AM
> To: Ananyev, Konstantin ; dev@dpdk.org
> Subject: RE: [dpdk-dev] [PATCH v2 3/5] net/ixgbe: fix bitmask of supported Tx
> flags
>
>
>
> > -Original Message-
> > From: Ananyev, Konstantin
> > Se
Hi Tom,
>
> That also leave the question of how to HASH only on the IP tuple for TCP and
> UDP packets? The use case is that I want all packets from the
> same IP src/dst pair to be hashed to the same queue. This cannot be enforced
> with a complete hash on TCP/UDP fields.
>
That's for IPv4 o
Dereferencing a pointer that might be null key_token when calling strstr.
Check if the pointer is null before.
Coverity issue: 141071
Fixes: f8be1786b1b8 ("app/crypto-perf: introduce performance test application")
Signed-off-by: Slawomir Mrozowicz
---
app/test-crypto-perf/cperf_test_vector_pars
Added a pointer to the rte_eventdev type in the event port
link and unlink callbacks. This device shall be used by some
of the event drivers to fetch queue related information.
Also, update the skeleton eventdev driver with corresponding changes.
Signed-off-by: Nipun Gupta
---
drivers/event/ske
Hi guys
we are upgrading our application from dpdk 16.11 to 17.02-rc2 and we are
facing a strange behavior with i40e driver and LSC
If we call rte_eth_dev_configure() with port_conf.intr_conf.lsc = 1, the
call always failed with error
Configuring Port 0 (socket 1)
rte_eth_dev_configure: driver net
Document the issue with Tso on shared packets.
Signed-off-by: Olivier Matz
---
doc/guides/rel_notes/known_issues.rst | 31 +++
1 file changed, 31 insertions(+)
diff --git a/doc/guides/rel_notes/known_issues.rst
b/doc/guides/rel_notes/known_issues.rst
index 018e999..
Hi Daniel,
> -Original Message-
> From: Mrzyglod, DanielX T
> Sent: Friday, February 03, 2017 12:10 PM
> To: De Lara Guarch, Pablo; Thomas Monjalon; Mrozowicz, SlawomirX
> Cc: dev@dpdk.org
> Subject: RE: [dpdk-dev] [PATCH v2] app/test-crypto-perf: fix gcc compilation
> under FreeBSD
>
>
The objective of this RFC patchset is to introduce a framework to
support dynamic log types in EAL. It also provides one example of use
(in i40e).
Features:
- log types are identified by a string
- at registration, a uniq identifier is associated to a log type
- each log type can have its level ch
Introduce 2 new functions to support dynamic log types:
- rte_log_register(): register a log name, and return a log type id
- rte_log_set_level(): set the log level of a given log type
Signed-off-by: Olivier Matz
---
app/test/test_logs.c| 6 +-
doc/guides/contribut
Introduce a function to dump the global level and the registered log
types.
Signed-off-by: Olivier Matz
---
lib/librte_eal/bsdapp/eal/rte_eal_version.map | 1 +
lib/librte_eal/common/eal_common_log.c | 34 +
lib/librte_eal/common/include/rte_log.h | 10
Introduce a function to set the log level of several log types that
match a regular expression.
Signed-off-by: Olivier Matz
---
lib/librte_eal/bsdapp/eal/rte_eal_version.map | 1 +
lib/librte_eal/common/eal_common_log.c | 21 +
lib/librte_eal/common/include/rte_lo
Deprecate the following functions:
- rte_set_log_level(), replaced by rte_log_set_global_level()
- rte_get_log_level(), replaced by rte_log_get_global_level()
- rte_set_log_type(), rte_log_set_level()
- rte_get_log_type(), rte_log_get_level()
The new functions provide a better control of the per-t
Signed-off-by: Olivier Matz
---
app/test-pmd/cmdline.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c
index 43fc636..849d807 100644
--- a/app/test-pmd/cmdline.c
+++ b/app/test-pmd/cmdline.c
@@ -7673,6 +7673,8 @@ static void
Signed-off-by: Olivier Matz
---
app/test/commands.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/app/test/commands.c b/app/test/commands.c
index 2df46b0..488dc41 100644
--- a/app/test/commands.c
+++ b/app/test/commands.c
@@ -158,13 +158,15 @@ static void cmd_dump_parsed(
Example of use:
./app/test-pmd --log-level='pmd\.i40e.*,8'
This enables debug logs for all dynamic logs whose type starts with
'pmd.i40e'.
Signed-off-by: Olivier Matz
---
lib/librte_eal/bsdapp/eal/eal.c| 4 +--
lib/librte_eal/common/eal_common_options.c | 48 +
This is an example of how a dynamic log type can be used in a
PMD.
Signed-off-by: Olivier Matz
---
drivers/net/i40e/i40e_ethdev.c | 18 --
drivers/net/i40e/i40e_fdir.c | 4
drivers/net/i40e/i40e_logs.h | 17 ++---
3 files changed, 22 insertions(+), 17 deleti
Hi,
I have some issues w.r.t the mapping sessions and queue pairs.
As per my understanding:
- Number of sessions may be large – they are independent of number of
queue pairs
- Queue pairs are L-core specific
- Depending on the implementation, one queue pair can be mapped to many
sessions. Or,
On Mon, Feb 06, 2017 at 02:29:08PM +0100, Olivier Matz wrote:
> The objective of this RFC patchset is to introduce a framework to
> support dynamic log types in EAL. It also provides one example of use
> (in i40e).
>
> Features:
> - log types are identified by a string
> - at registration, a uniq
Hi,
On Wed, 11 Jan 2017 17:52:04 +0100, Olivier Matz
wrote:
> From: Guo Fengtian
>
> When PF triggers a reset, VF port must acknowledge it by calling
> ixgbe_reset_hw().
>
> Before this patch, the port link status, speed and duplex are invalid
> (all set to 0).
>
> The patch move the call to
Hi,
On Wed, 11 Jan 2017 18:04:14 +0100, Olivier Matz
wrote:
> From: Guo Fengtian
>
> When PF is set down, in VF, the value of stats register is zero.
> So only increase stats when it's non zero.
>
> Fixes: af75078fece3 ("first public release")
>
> CC: sta...@dpdk.org
> Signed-off-by: Guo Feng
Hi Bruce,
On Mon, 6 Feb 2017 13:49:03 +, Bruce Richardson
wrote:
> On Mon, Feb 06, 2017 at 02:29:08PM +0100, Olivier Matz wrote:
> > The objective of this RFC patchset is to introduce a framework to
> > support dynamic log types in EAL. It also provides one example of
> > use (in i40e).
> >
> On Feb 6, 2017, at 8:10 AM, Olivier Matz wrote:
>
> Hi Bruce,
>
> On Mon, 6 Feb 2017 13:49:03 +, Bruce Richardson
> wrote:
>> On Mon, Feb 06, 2017 at 02:29:08PM +0100, Olivier Matz wrote:
>>> The objective of this RFC patchset is to introduce a framework to
>>> support dynamic log types
Given that the packet distributor library improvements (1) will
not be in 17.02, I plan on doing some consolidation of the
API for burst operation for 17.05, merging the two api's into
one, with options for single or burst operation.
(1) http://dpdk.org/dev/patchwork/patch/19911/
Signed-off-by: D
Hi Konstantin,
It seems a little overkill to play with the key... The XL710 seems to be able
to hash on IP fields only. It seems only a configuration issue, I'm adding i40e
maintainers in CC so they can confirm? I think the i40e driver should configure
XL710 to hash on IP fields for TCP and UDP
On Mon, 6 Feb 2017 15:01:30 +, "Wiles, Keith"
wrote:
> > On Feb 6, 2017, at 8:10 AM, Olivier Matz
> > wrote:
> >
> > Hi Bruce,
> >
> > On Mon, 6 Feb 2017 13:49:03 +, Bruce Richardson
> > wrote:
> >> On Mon, Feb 06, 2017 at 02:29:08PM +0100, Olivier Matz wrote:
> >>> The objective o
On Sun, Feb 05, 2017 at 03:44:52PM +0100, Thomas Monjalon wrote:
> Hi Jan,
>
> 2016-03-22 10:55, Jan Blunck:
> > v3 changes:
> > - removed fake PCI interface
> > - removed struct virt_eth_driver
> > - check for UIO name and version
> > - added basic documentation
> >
> > Jan Blunck (3):
> > xen
On Sun, 5 Feb 2017 10:05:07 -0600
Keith Wiles wrote:
> At the same time remove the code which created the first device queue
> at probe time. Now all queues are created during queue setup calls.
>
> Signed-off-by: Keith Wiles
> ---
> drivers/net/tap/rte_eth_tap.c | 104
> ++---
> On Feb 6, 2017, at 9:27 AM, Olivier Matz wrote:
>
> On Mon, 6 Feb 2017 15:01:30 +, "Wiles, Keith"
> wrote:
>>> On Feb 6, 2017, at 8:10 AM, Olivier Matz
>>> wrote:
>>>
>>> Hi Bruce,
>>>
>>> On Mon, 6 Feb 2017 13:49:03 +, Bruce Richardson
>>> wrote:
On Mon, Feb 06, 2017 at 02
On Sun, 5 Feb 2017 10:05:09 -0600
Keith Wiles wrote:
> Signed-off-by: Keith Wiles
> ---
> drivers/net/tap/rte_eth_tap.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/tap/rte_eth_tap.c b/drivers/net/tap/rte_eth_tap.c
> index 65e4bab..966e91a 100644
> --
> On Feb 6, 2017, at 9:45 AM, Pascal Mazon wrote:
>
> On Sun, 5 Feb 2017 10:05:07 -0600
> Keith Wiles wrote:
>
>> At the same time remove the code which created the first device queue
>> at probe time. Now all queues are created during queue setup calls.
>>
>> Signed-off-by: Keith Wiles
>>
> On Feb 6, 2017, at 9:57 AM, Pascal Mazon wrote:
>
> Fixes: ee418a25b0d3 ("net/tap: implement link up and down callbacks”)
As I need to add these changes I will produce a v3 patch
Regards,
Keith
On Mon, 6 Feb 2017 15:55:20 +, "Wiles, Keith"
wrote:
> > On Feb 6, 2017, at 9:27 AM, Olivier Matz
> > wrote:
> >
> > On Mon, 6 Feb 2017 15:01:30 +, "Wiles, Keith"
> > wrote:
> >>> On Feb 6, 2017, at 8:10 AM, Olivier Matz
> >>> wrote:
> >>>
> >>> Hi Bruce,
> >>>
> >>> On Mon, 6 Feb
On Tue, 31 Jan 2017 20:02:26 +0530, Santosh Shukla
wrote:
> Hi Olivier,
>
> Reply inline.
>
> On Tue, Jan 31, 2017 at 11:31:51AM +0100, Olivier Matz wrote:
> > Hi Santosh,
> >
> > I guess this patch is targeted for 17.05, right?
> >
>
> Yes.
>
> > Please see some other comments below.
> >
From: Alan Dewar
Prevent a segmentation fault in rte_sched_port_free by only accessing
the port structure after the NULL pointer check has been made.
Fixes: 7b3c4f35 ("sched: fix releasing enqueued packets")
Signed-off-by: Alan Dewar
Signed-off-by: Jan Blunck
---
lib/librte_sched/rte_sched.c
> On Feb 6, 2017, at 10:18 AM, Olivier Matz wrote:
>
> On Mon, 6 Feb 2017 15:55:20 +, "Wiles, Keith"
> wrote:
>>> On Feb 6, 2017, at 9:27 AM, Olivier Matz
>>> wrote:
>>>
>>> On Mon, 6 Feb 2017 15:01:30 +, "Wiles, Keith"
>>> wrote:
> On Feb 6, 2017, at 8:10 AM, Olivier Matz
>>>
Hi Olivier,
Looks good in general, some comments from me below.
Thanks
Konstantin
>
> The main changes are:
> - reorder structure to increase vector performance on some non-ia
> platforms.
> - add a 64bits timestamp field in the 1st cache line
Wonder why it deserves to be in first cache line?
> -Original Message-
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Jan Blunck
> Sent: Monday, February 6, 2017 5:33 PM
> To: dev@dpdk.org
> Cc: h.mikit...@gmail.com; Alan Dewar
> Subject: [dpdk-dev] [PATCH] sched: fix segmentation fault when freeing port
>
> From: Alan Dewar
>
Signed-off-by: Keith Wiles
---
doc/guides/nics/tap.rst | 16
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/doc/guides/nics/tap.rst b/doc/guides/nics/tap.rst
index 622b9e7..c4f207b 100644
--- a/doc/guides/nics/tap.rst
+++ b/doc/guides/nics/tap.rst
@@ -45,18 +45,18
Signed-off-by: Keith Wiles
---
drivers/net/tap/rte_eth_tap.c | 12
1 file changed, 4 insertions(+), 8 deletions(-)
diff --git a/drivers/net/tap/rte_eth_tap.c b/drivers/net/tap/rte_eth_tap.c
index c7b04bb..6d93eb7 100644
--- a/drivers/net/tap/rte_eth_tap.c
+++ b/drivers/net/tap/rte_e
Signed-off-by: Keith Wiles
---
drivers/net/tap/rte_eth_tap.c | 10 +++---
1 file changed, 3 insertions(+), 7 deletions(-)
diff --git a/drivers/net/tap/rte_eth_tap.c b/drivers/net/tap/rte_eth_tap.c
index 6d93eb7..61659bc 100644
--- a/drivers/net/tap/rte_eth_tap.c
+++ b/drivers/net/tap/rte_eth
At the same time remove the code which created the first device queue
at probe time. Now all queues are created during queue setup calls.
Signed-off-by: Keith Wiles
---
drivers/net/tap/rte_eth_tap.c | 104 ++
1 file changed, 34 insertions(+), 70 deletions(
Signed-off-by: Keith Wiles
---
drivers/net/tap/rte_eth_tap.c | 54 ++-
1 file changed, 28 insertions(+), 26 deletions(-)
diff --git a/drivers/net/tap/rte_eth_tap.c b/drivers/net/tap/rte_eth_tap.c
index 7c923a2..65e4bab 100644
--- a/drivers/net/tap/rte_eth_
Fixes: ee418a25b0d3 ("net/tap: implement link up and down callbacks")
Signed-off-by: Keith Wiles
---
drivers/net/tap/rte_eth_tap.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/net/tap/rte_eth_tap.c b/drivers/net/tap/rte_eth_tap.c
index 65e4bab..966e91a 100644
---
At the same time remove closing fds code from pmd stop routine.
Signed-off-by: Keith Wiles
---
drivers/net/tap/rte_eth_tap.c | 18 +++---
1 file changed, 11 insertions(+), 7 deletions(-)
diff --git a/drivers/net/tap/rte_eth_tap.c b/drivers/net/tap/rte_eth_tap.c
index 966e91a..0a7f4a
Hi
With dpdk 17.02-rc2 i40e driver doesn't load at all when memory
allocation is restricted on numa node 1 (on system with more than 1
node, obviously)
[root@micro ~]# /tmp/testpmd -d /home/micro/lib/librte_pmd_i40e.so -c
0xFFFC000 -w :81:00.0 -w :81:00.1 -n 4 --socket-mem=0,8192 --
-i -
Thanks for the suggestions!
I'll try them and I will report back the results in the next days.
Regards
Ivan
On 6 February 2017 at 02:04, Zhang, Qi Z wrote:
> Hi Ivan:
>
> I'm looking at this issue, but I can't repeat it on my environment
> both with X710x4 and XL710x1
> Not sure
On Mon, 6 Feb 2017 14:16:53 +0100
Olivier Matz wrote:
> +**Implication**:
> + In this situation, the shared data will be modified by the driver,
> + potentially causing race conditions with the other users of the mbuf
> + data.
This is a driver bug! The driver must check for refcount and
>
>This PMD driver doesn't seem to work with VFIO. I haven't had time
>to look into it very closely, so I was going to ask here first just
>in case someone had any ideas why this might be the case. Thanks
>for any pointers here!
>
Hi Chas,
Yes its a known issue - we haven’t looked at it yet, but
Hi Ivan:
This is a bug and is fixed with below patch
http://dpdk.org/dev/patchwork/patch/20163/
Regards
Qi
> -Original Message-
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Ivan Nardi
> Sent: Monday, February 6, 2017 9:13 PM
> To: dev@dpdk.org
> Subject: [dpdk-dev
> -Original Message-
> From: Ivan Nardi [mailto:nardi.i...@gmail.com]
> Sent: Tuesday, February 7, 2017 5:04 AM
> To: dev@dpdk.org
> Cc: Zhang, Helin; Wu, Jingjing
> Subject: i40e and memory allocations restricted on node 1
>
> Hi
> With dpdk 17.02-rc2 i40e driver doesn't load at all whe
Hi Tom
Sorry, by default, i40e HW is a bit different from ixgbe HW. It will not treat
UDP as an IP packet, when setting hash enable flags.
But, a feature of configuring 'input set' can help to change the default HW
behavior. Please refer to testpmd input set part to understand how to use that.
> -Original Message-
> From: Ananyev, Konstantin
> Sent: Monday, February 6, 2017 8:11 PM
> To: Wu, Jingjing ; dev@dpdk.org
> Subject: RE: [dpdk-dev] [PATCH v2 3/5] net/ixgbe: fix bitmask of supported
> Tx flags
>
>
>
> > -Original Message-
> > From: Wu, Jingjing
> > Sent: Mond
> -Original Message-
> From: Olivier Matz [mailto:olivier.m...@6wind.com]
> Sent: Monday, February 6, 2017 6:29 PM
> To: Wu, Jingjing
> Cc: Yigit, Ferruh ; dev@dpdk.org; Zhang, Helin
>
> Subject: Re: [dpdk-dev] [PATCH v2 2/5] net/i40e: fix bitmask of supported Tx
> flags
>
> On Mon, 6
> -Original Message-
> From: Olivier Matz [mailto:olivier.m...@6wind.com]
> Sent: Monday, February 6, 2017 6:27 PM
> To: Wu, Jingjing
> Cc: dev@dpdk.org; Zhang, Helin ; Ananyev,
> Konstantin ; Yigit, Ferruh
>
> Subject: Re: [dpdk-dev] [PATCH v2 2/5] net/i40e: fix bitmask of supported Tx
Uninitialized scalar variable. Using uninitialized value
cfg->sections[curr_section]->num_entries when calling rte_cfgfile_close.
And memory in variables cfg->sections[curr_section], sect->entries[curr_entry]
maybe not equal NULL. We must decrement counters curr_section, curr_entry when
failed t
Some Tx offload flags are missed in bitmask of all supported packet
Tx flags, it will cause rte_eth_tx_prepare fails when Tx burst packets.
v3 changes:
- add PKT_TX_MACSEC to PKT_TX_OFFLOAD_MASK
- refine code of drivers' TX_OFFLOAD_MASK definition
v2 changes:
- redefine the PKT_TX_OFFLOAD_MASK
Add missed PKT_TX_IEEE1588_TMST to bitmask of all supported
packet Tx flags.
Fixes: 7829b8d52be0 ("net/ixgbe: add Tx preparation")
Signed-off-by: Jingjing Wu
---
drivers/net/ixgbe/ixgbe_rxtx.c | 8 +++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/drivers/net/ixgbe/ixgbe_rxtx
PKT_TX_TUNNEL_MASK and PKT_TX_IEEE1588_TMST are missed in bitmask
of all supported packet Tx flags by i40e. It will cause packet preparing
fail when sending tunnel packets with Tx offload.
This patch fixes it.
Fixes: 3f33e643e5c6 ("net/i40e: add Tx preparation")
Signed-off-by: Jingjing Wu
---
dr
Add missed PKT_TX_IEEE1588_TMST to bitmask of all supported
packet Tx flags.
Fixes: 2b76648872c9 ("net/e1000: add Tx preparation")
Signed-off-by: Jingjing Wu
---
drivers/net/e1000/igb_rxtx.c | 8 +++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/drivers/net/e1000/igb_rxtx.c b
Add missed PKT_TX_MACSEC flag to bitmask of all supported packet Tx
offload features flags.
Fixes: 4fb7e803eb1a ("ethdev: add Tx preparation")
Signed-off-by: Jingjing Wu
---
lib/librte_mbuf/rte_mbuf.h | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/lib/librte_mbuf/rte_mbuf.
The GL_SWR_PRI_JOIN_MAP registers are affecting filters hit, modify
the register default value will result the ethertype filter function
fail. The GL_SWR_PRI_JOIN_MAP value is difference between different
NICs, should keep up the register value with default NVM value in X722.
Fixes: 973273c7a4b7 (
Hi Olivier,
On Mon, Feb 06, 2017 at 06:01:15PM +0100, Olivier Matz wrote:
> On Tue, 31 Jan 2017 20:02:26 +0530, Santosh Shukla
> wrote:
> > Hi Olivier,
> >
> > Reply inline.
> >
> > On Tue, Jan 31, 2017 at 11:31:51AM +0100, Olivier Matz wrote:
> > > Hi Santosh,
> > >
> > > I guess this patch i
On Fri, Feb 03, 2017 at 04:28:15PM +0530, Hemant Agrawal wrote:
> On 2/3/2017 12:08 PM, Nipun Gupta wrote:
> > > > > -Original Message-
> > > > > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Jerin Jacob
> > > > > Sent: Wednesday, December 21, 2016 14:55
> > > > > To: dev@dpdk.org
>
On Wed, Jan 25, 2017 at 05:51:50PM +0800, Ananyev, Konstantin wrote:
>
>
> > -Original Message-
> > From: Wiles, Keith
> > Sent: Wednesday, January 25, 2017 3:40 AM
> > To: Stephen Hemminger
> > Cc: Ananyev, Konstantin ; Hu, Jiayu
> > ; dev@dpdk.org; Kinsella, Ray
> > ; Gilmore, Walter
Signed-off-by: Wenzhuo Lu
---
doc/guides/nics/ixgbe.rst | 16 ++--
1 file changed, 14 insertions(+), 2 deletions(-)
diff --git a/doc/guides/nics/ixgbe.rst b/doc/guides/nics/ixgbe.rst
index 3b6851b..1f7d6b3 100644
--- a/doc/guides/nics/ixgbe.rst
+++ b/doc/guides/nics/ixgbe.rst
@@ -185
On Mon, Feb 06, 2017 at 10:37:31AM +, Van Haaren, Harry wrote:
> > -Original Message-
> > From: Jerin Jacob [mailto:jerin.ja...@caviumnetworks.com]
> > Sent: Monday, February 6, 2017 8:23 AM
> > To: Van Haaren, Harry
> > Cc: dev@dpdk.org; Richardson, Bruce
> > Subject: Re: [PATCH v2 0
It's not appropriate to call rte_eth_dev_info_get in PMD,
as rte_eth_dev_info_get need to get info from PMD.
Remove rte_eth_dev_info_get from PMD code and get the
info directly.
Signed-off-by: Wenzhuo Lu
---
v2:
- change is_ixgbe_pmd to is_device_supported to make it more generic.
v3:
- minor cha
On Mon, Feb 06, 2017 at 10:25:18AM +, Van Haaren, Harry wrote:
> > -Original Message-
> > From: Jerin Jacob [mailto:jerin.ja...@caviumnetworks.com]
> > Sent: Monday, February 6, 2017 9:25 AM
> > To: Van Haaren, Harry
> > Cc: dev@dpdk.org; Richardson, Bruce
> > Subject: Re: [PATCH v2 0
Hi, Adrien:
Sorry for the late reply due to Chinese new year.
> -Original Message-
> From: Adrien Mazarguil [mailto:adrien.mazarg...@6wind.com]
> Sent: Tuesday, January 24, 2017 12:36 AM
> To: Richardson, Bruce
> Cc: Ananyev, Konstantin ; Andrew
> Rybchenko ; Yang, Zhiyong
> ; d
89 matches
Mail list logo
