> -----Original Message----- > From: Olivier Matz [mailto:olivier.m...@6wind.com] > Sent: Monday, February 6, 2017 6:27 PM > To: Wu, Jingjing <jingjing...@intel.com> > Cc: dev@dpdk.org; Zhang, Helin <helin.zh...@intel.com>; Ananyev, > Konstantin <konstantin.anan...@intel.com>; Yigit, Ferruh > <ferruh.yi...@intel.com> > Subject: Re: [dpdk-dev] [PATCH v2 2/5] net/i40e: fix bitmask of supported Tx > flags > > Hi Jingjing, > > On Sat, 4 Feb 2017 11:36:12 +0800, Jingjing Wu <jingjing...@intel.com> > wrote: > > Some Tx offload flags are missed in bitmask of all supported packet Tx > > flags by i40e. > > This patch fixes it. > > Could you detail which flag was missing? > Is it PKT_TX_TUNNEL_MASK? > If yes, shouldn't we have a "Fixes:" line? > > I think most of the patchset should be merged in one patch, because > changing only the mbuf part (PKT_TX_OFFLOAD_MASK) would break the > drivers that checks the offload bits at init, and this is not suitable, > especially if > we want to be able to do git bisect. > > > My suggestion is to have: > > 1- fix i40 (add missing tunnel mask?) > 2- fix missing MACSET in TX_OFFLOAD_MASK > 3- change TX_OFFLOAD_MASK to include all flags (this impacts all > drivers using TX_OFFLOAD_MASK) > > OK. Will change according to your suggestion. It's clearer. Thanks
Jingjing
