> -----Original Message-----
> From: Jerin Jacob [mailto:jerin.ja...@caviumnetworks.com]
> Sent: Monday, February 6, 2017 8:23 AM
> To: Van Haaren, Harry <harry.van.haa...@intel.com>
> Cc: dev@dpdk.org; Richardson, Bruce <bruce.richard...@intel.com>
> Subject: Re: [PATCH v2 02/15] eventdev: add APIs for extended stats
>
> On Tue, Jan 31, 2017 at 04:14:20PM +0000, Harry van Haaren wrote:
> > From: Bruce Richardson <bruce.richard...@intel.com>
> >
> > Add in APIs for extended stats so that eventdev implementations can report
> > out information on their internal state. The APIs are based on, but not
> > identical to, the equivalent ethdev functions.
>
> The APIs Looks good. One minor comment though,
>
> Can you add statistics specific to per event queue and event
> port?, To improve the cases like below in the application code(taken from
> app/test/test_sw_eventdev.c).
>
> IMO, it is useful because,
> - ethdev has similar semantics
> - majority of the implementations will have port and queue specific
> statistics counters
I'm not totally sure what you're asking but if I understand correctly, you're
suggesting a struct based stats API like this?
struct rte_event_dev_port_stats {
uint64_t rx;
uint64_t tx;
...
};
struct rte_event_dev_queue_stats {
uint64_t rx;
uint64_t tx;
...
};
/** a get function to get a specific port's statistics. The *stats* pointer is
filled in */
int rte_event_dev_port_stats_get(dev, uint8_t port_id, struct
rte_event_dev_port_stats *stats);
/** a get function to get a specific queue's statistics. The *stats* pointer is
filled in */
int rte_event_dev_queue_stats_get(dev, uint8_t queue_id, struct
rte_event_dev_queue_stats *stats);
Is this what you meant, or did I misunderstand?
>
> + for (i = 0; i < MAX_PORTS; i++) {
> + char name[32];
> + snprintf(name, sizeof(name), "port_%u_rx", i);
> + stats->port_rx_pkts[i] = rte_event_dev_xstats_by_name_get(
> + dev_id, name, &port_rx_pkts_ids[i]);
>
> + for (i = 0; i < MAX_QIDS; i++) {
> + char name[32];
> + snprintf(name, sizeof(name), "qid_%u_rx", i);
> + stats->qid_rx_pkts[i] = rte_event_dev_xstats_by_name_get(
> + dev_id, name, &qid_rx_pkts_ids[i]);
>
