Re: [dpdk-dev] [EXT] [PATCH v3 01/15] drivers: introduce mlx5 crypto PMD

2021-05-11 Thread Akhil Goyal
> From: Akhil Goyal > > > > > > > +fmt_name = 'mlx5_crypto' > > > > > > > +deps += ['common_mlx5', 'eal', 'cryptodev'] > > > > > > > > > > > > I don't see a reason for eal dependency. Do you really need it? > > > > > > > > > > See RTE_LOG_REGISTER. > > > > > > > > Compilation works fine even after

Re: [dpdk-dev] [EXT] [PATCH v3 01/15] drivers: introduce mlx5 crypto PMD

2021-05-11 Thread Matan Azrad
From: Akhil Goyal > > > > > > +fmt_name = 'mlx5_crypto' > > > > > > +deps += ['common_mlx5', 'eal', 'cryptodev'] > > > > > > > > > > I don't see a reason for eal dependency. Do you really need it? > > > > > > > > See RTE_LOG_REGISTER. > > > > > > Compilation works fine even after removing this d

Re: [dpdk-dev] [EXT] [PATCH v3 01/15] drivers: introduce mlx5 crypto PMD

2021-05-11 Thread Akhil Goyal
> > > > > > > + > > > > > +fmt_name = 'mlx5_crypto' > > > > > +deps += ['common_mlx5', 'eal', 'cryptodev'] > > > > > > > > I don't see a reason for eal dependency. Do you really need it? > > > > > > See RTE_LOG_REGISTER. > > > > Compilation works fine even after removing this dependency. > > I beli

Re: [dpdk-dev] [EXT] [PATCH v3 01/15] drivers: introduce mlx5 crypto PMD

2021-05-10 Thread Bruce Richardson
On Sun, May 09, 2021 at 09:32:45AM +, Akhil Goyal wrote: > > > > + > > > > +fmt_name = 'mlx5_crypto' > > > > +deps += ['common_mlx5', 'eal', 'cryptodev'] > > > > > > I don't see a reason for eal dependency. Do you really need it? > > > > See RTE_LOG_REGISTER. > > Compilation works fine even a

Re: [dpdk-dev] [EXT] [PATCH v3 01/15] drivers: introduce mlx5 crypto PMD

2021-05-09 Thread Matan Azrad
> -Original Message- > From: Akhil Goyal > Sent: Sunday, May 9, 2021 12:33 PM > To: Matan Azrad ; dev@dpdk.org > Cc: Suanming Mou ; NBU-Contact-Thomas > Monjalon ; Shiri Kuzin > Subject: RE: [EXT] [PATCH v3 01/15] drivers: introduce mlx5 crypto PMD > > External email: Use caution open

Re: [dpdk-dev] [EXT] [PATCH v3 01/15] drivers: introduce mlx5 crypto PMD

2021-05-09 Thread Akhil Goyal
> > > + > > > +fmt_name = 'mlx5_crypto' > > > +deps += ['common_mlx5', 'eal', 'cryptodev'] > > > > I don't see a reason for eal dependency. Do you really need it? > > See RTE_LOG_REGISTER. Compilation works fine even after removing this dependency. I believe it is internally managed in cryptodev.

Re: [dpdk-dev] [EXT] [PATCH v3 01/15] drivers: introduce mlx5 crypto PMD

2021-05-09 Thread Matan Azrad
Hi Akhil Thanks for the review, I know it was too tied for you to review, so, I really appreciate.. From: Akhil Goyal > > diff --git a/drivers/crypto/mlx5/meson.build > > b/drivers/crypto/mlx5/meson.build new file mode 100644 index > > 00..fd00283665 > > --- /dev/null > > +++ b/drivers/c

Re: [dpdk-dev] [EXT] [PATCH v3 01/15] drivers: introduce mlx5 crypto PMD

2021-05-08 Thread Akhil Goyal
> diff --git a/drivers/crypto/mlx5/meson.build > b/drivers/crypto/mlx5/meson.build > new file mode 100644 > index 00..fd00283665 > --- /dev/null > +++ b/drivers/crypto/mlx5/meson.build > @@ -0,0 +1,26 @@ > +# SPDX-License-Identifier: BSD-3-Clause > +# Copyright 2021 Mellanox Technologies, L