Hi Akhil Thanks for the review, I know it was too tied for you to review, so, I really appreciate..
From: Akhil Goyal > > diff --git a/drivers/crypto/mlx5/meson.build > > b/drivers/crypto/mlx5/meson.build new file mode 100644 index > > 0000000000..fd00283665 > > --- /dev/null > > +++ b/drivers/crypto/mlx5/meson.build > > @@ -0,0 +1,26 @@ > > +# SPDX-License-Identifier: BSD-3-Clause # Copyright 2021 Mellanox > > +Technologies, Ltd > > + > > +if not is_linux > > + build = false > > + reason = 'only supported on Linux' > > + subdir_done() > > +endif > > + > > +fmt_name = 'mlx5_crypto' > > +deps += ['common_mlx5', 'eal', 'cryptodev'] > > I don't see a reason for eal dependency. Do you really need it? See RTE_LOG_REGISTER. > > +sources = files( > > + 'mlx5_crypto.c', > > +) > > +cflags_options = [ > > + '-std=c11', > > + '-Wno-strict-prototypes', > > + '-D_BSD_SOURCE', > > + '-D_DEFAULT_SOURCE', > > + '-D_XOPEN_SOURCE=600', > > +] > > Any specific reason to use '-Wno-strict-prototypes' > Compilation works without this as well. We use it in Mellanox driver usually. This is internal mlx5 code convention. > > +foreach option:cflags_options > > + if cc.has_argument(option) > > + cflags += option > > + endif > > +endforeach
