> -----Original Message----- > From: Akhil Goyal <gak...@marvell.com> > Sent: Sunday, May 9, 2021 12:33 PM > To: Matan Azrad <ma...@nvidia.com>; dev@dpdk.org > Cc: Suanming Mou <suanmi...@nvidia.com>; NBU-Contact-Thomas > Monjalon <tho...@monjalon.net>; Shiri Kuzin <shi...@nvidia.com> > Subject: RE: [EXT] [PATCH v3 01/15] drivers: introduce mlx5 crypto PMD > > External email: Use caution opening links or attachments > > > > > > + > > > > +fmt_name = 'mlx5_crypto' > > > > +deps += ['common_mlx5', 'eal', 'cryptodev'] > > > > > > I don't see a reason for eal dependency. Do you really need it? > > > > See RTE_LOG_REGISTER. > > Compilation works fine even after removing this dependency. > I believe it is internally managed in cryptodev. Yes, but it is better to add the libs we use directly. > > > > +sources = files( > > > > + 'mlx5_crypto.c', > > > > +) > > > > +cflags_options = [ > > > > + '-std=c11', > > > > + '-Wno-strict-prototypes', > > > > + '-D_BSD_SOURCE', > > > > + '-D_DEFAULT_SOURCE', > > > > + '-D_XOPEN_SOURCE=600', > > > > +] > > > > > > Any specific reason to use '-Wno-strict-prototypes' > > > Compilation works without this as well. > > > > We use it in Mellanox driver usually. > > This is internal mlx5 code convention. > > > Ok.
- [dpdk-dev] [PATCH v2 12/15] crypto/mlx5: add WQE set init... Matan Azrad
- [dpdk-dev] [PATCH v2 13/15] crypto/mlx5: add enqueue and ... Matan Azrad
- [dpdk-dev] [PATCH v2 14/15] crypto/mlx5: add statistic ge... Matan Azrad
- [dpdk-dev] [PATCH v2 15/15] crypto/mlx5: set feature flag... Matan Azrad
- Re: [dpdk-dev] [PATCH v2 00/15] drivers: introduce mlx5 c... Matan Azrad
- [dpdk-dev] [PATCH v3 00/15] drivers: introduce mlx5 crypt... Matan Azrad
- [dpdk-dev] [PATCH v3 01/15] drivers: introduce mlx5 ... Matan Azrad
- Re: [dpdk-dev] [EXT] [PATCH v3 01/15] drivers: i... Akhil Goyal
- Re: [dpdk-dev] [EXT] [PATCH v3 01/15] driver... Matan Azrad
- Re: [dpdk-dev] [EXT] [PATCH v3 01/15] dr... Akhil Goyal
- Re: [dpdk-dev] [EXT] [PATCH v3 01/1... Matan Azrad
- Re: [dpdk-dev] [EXT] [PATCH v3 ... Akhil Goyal
- Re: [dpdk-dev] [EXT] [PATCH v3 ... Matan Azrad
- Re: [dpdk-dev] [EXT] [PATCH v3 ... Akhil Goyal
- Re: [dpdk-dev] [EXT] [PATCH v3 01/1... Bruce Richardson
- [dpdk-dev] [PATCH v3 04/15] crypto/mlx5: add basic o... Matan Azrad
- [dpdk-dev] [PATCH v3 02/15] crypto/mlx5: add DEK obj... Matan Azrad
- [dpdk-dev] [PATCH v3 05/15] crypto/mlx5: support que... Matan Azrad
- [dpdk-dev] [PATCH v3 03/15] crypto/mlx5: support ses... Matan Azrad
- Re: [dpdk-dev] [EXT] [PATCH v3 03/15] crypto/mlx... Akhil Goyal
- Re: [dpdk-dev] [EXT] [PATCH v3 03/15] crypto... Matan Azrad