On Sun, May 09, 2021 at 09:32:45AM +0000, Akhil Goyal wrote: > > > > + > > > > +fmt_name = 'mlx5_crypto' > > > > +deps += ['common_mlx5', 'eal', 'cryptodev'] > > > > > > I don't see a reason for eal dependency. Do you really need it? > > > > See RTE_LOG_REGISTER. > > Compilation works fine even after removing this dependency. > I believe it is internally managed in cryptodev.
Yes, meson dependencies are recursive, so taking in e.g. cryptodev also pulls in all dependencies of cryptodev, including EAL. Having the deps explicitly called out makes things a little clearer for the reader, but having a minimum set of dependencies called out can make meson runs a little faster as it doesn't have as much checking and pruning of dependencies to do. [this was more a problem with older meson releases, less no now.] This is why the deps list in DPDK are generally fairly short. Either way, whatever builds is fine. :-) /Bruce
