> > > + > > > +fmt_name = 'mlx5_crypto' > > > +deps += ['common_mlx5', 'eal', 'cryptodev'] > > > > I don't see a reason for eal dependency. Do you really need it? > > See RTE_LOG_REGISTER.
Compilation works fine even after removing this dependency. I believe it is internally managed in cryptodev. > > > > +sources = files( > > > + 'mlx5_crypto.c', > > > +) > > > +cflags_options = [ > > > + '-std=c11', > > > + '-Wno-strict-prototypes', > > > + '-D_BSD_SOURCE', > > > + '-D_DEFAULT_SOURCE', > > > + '-D_XOPEN_SOURCE=600', > > > +] > > > > Any specific reason to use '-Wno-strict-prototypes' > > Compilation works without this as well. > > We use it in Mellanox driver usually. > This is internal mlx5 code convention. > Ok.
