RE: [PATCH v5 20/22] cfgfile: fix section count with no name

2025-07-23 Thread Dumitrescu, Cristian
> -Original Message- > From: Richardson, Bruce > Sent: Wednesday, July 23, 2025 4:08 PM > To: Marchand, David > Cc: dev@dpdk.org; Dumitrescu, Cristian ; Allain > Legacy > Subject: Re: [PATCH v5 20/22] cfgfile: fix section count with no name > > On Wed,

RE: [PATCH V2] examples/pipeline: fix include path for rte_log.h

2024-02-14 Thread Dumitrescu, Cristian
Hi Patrick, See my comment below under your reply. From: Patrick Robb Sent: Wednesday, February 14, 2024 7:32 PM To: Aaron Conole Cc: Ferruh Yigit ; Dumitrescu, Cristian ; dev@dpdk.org; sta...@dpdk.org; Marchand, David ; Richardson, Bruce Subject: Re: [PATCH V2] examples/pipeline: fix

RE: [PATCH V2] examples/pipeline: fix include path for rte_log.h

2024-02-14 Thread Dumitrescu, Cristian
Hi Ferruh, > -Original Message- > From: Ferruh Yigit > Sent: Wednesday, February 14, 2024 11:22 AM > To: Dumitrescu, Cristian ; dev@dpdk.org > Cc: sta...@dpdk.org; Marchand, David ; Aaron > Conole ; Richardson, Bruce > > Subject: Re: [PATCH V2] examples/pipeli

RE: [PATCH] examples/pipeline: fix include path for rte_log.h

2024-02-13 Thread Dumitrescu, Cristian
Hi David, > -Original Message- > From: David Marchand > Sent: Tuesday, February 13, 2024 4:19 PM > To: Dumitrescu, Cristian > Cc: dev@dpdk.org; sta...@dpdk.org > Subject: Re: [PATCH] examples/pipeline: fix include path for rte_log.h > > > Wrt $Subject, cop

RE: [dpdk-dev] [RFC] ethdev: support Tx queue free descriptor query

2024-01-04 Thread Dumitrescu, Cristian
ster, Steven ; > sk...@marvell.com; mtetsu...@gmail.com; vbu...@marvell.com; > viachesl...@nvidia.com; Wang, Xiao W ; > cloud.wangxiao...@huawei.com; yisen.zhu...@huawei.com; Wang, Yong > ; xuanziya...@huawei.com; Dumitrescu, Cristian > ; Jerin Jacob > Subject: [dpdk-dev] [RFC] et

RE: [RFC] ethdev: introduce entropy calculation

2024-01-04 Thread Dumitrescu, Cristian
> -Original Message- > From: Ori Kam > Sent: Wednesday, December 27, 2023 3:20 PM > To: Andrew Rybchenko ; NBU-Contact- > Thomas Monjalon (EXTERNAL) ; Stephen Hemminger > ; Ferruh Yigit > Cc: Dumitrescu, Cristian ; Dariusz Sosnowski > ; dev@dpdk.org; Raslan Da

RE: [RFC] ethdev: introduce entropy calculation

2023-12-14 Thread Dumitrescu, Cristian
Hi Ori, A few questions on top of Ferruh's questions for better understanding the concept inlined below: > -Original Message- > From: Ori Kam > Sent: Thursday, December 14, 2023 2:17 PM > To: Ferruh Yigit ; Dariusz Sosnowski > ; Dumitrescu, Cristian > ; NBU-

RE: [PATCH] cfgfile: increase value length

2023-12-06 Thread Dumitrescu, Cristian
> -Original Message- > From: Richardson, Bruce > Sent: Wednesday, December 6, 2023 1:22 PM > To: Vipin Varghese > Cc: dev@dpdk.org; Dumitrescu, Cristian ; > Ferruh Yigit > Subject: Re: [PATCH] cfgfile: increase value length > > On Wed, Dec 06, 2023

RE: [PATCH 01/11] doc: add Traffic Manager feature

2023-11-28 Thread Dumitrescu, Cristian
> -Original Message- > From: Ferruh Yigit > Sent: Tuesday, November 28, 2023 10:32 AM > To: Huisong Li ; dev@dpdk.org; tho...@monjalon.net; > Hemant Agrawal ; Balasubramanian Manoharan > ; Dumitrescu, Cristian > ; Jerin Jacob > > Cc: liuyongl...@huawei.com

RE: [PATCH 1/2] pipeline: fix calloc parameters

2023-11-06 Thread Dumitrescu, Cristian
> -Original Message- > From: Ferruh Yigit > Sent: Thursday, November 2, 2023 1:09 PM > To: Dumitrescu, Cristian ; R, Kamalakannan > > Cc: dev@dpdk.org; sta...@dpdk.org > Subject: [PATCH 1/2] pipeline: fix calloc parameters > > gcc [1] generates warning [2]

RE: [PATCH v4 03/28] ethdev: mark rte_mtr API's as stable

2023-10-23 Thread Dumitrescu, Cristian
> -Original Message- > From: Stephen Hemminger > Sent: Friday, October 20, 2023 9:32 PM > To: Dumitrescu, Cristian > Cc: dev@dpdk.org; Thomas Monjalon ; Ferruh Yigit > ; Andrew Rybchenko > > Subject: Re: [PATCH v4 03/28] ethdev: mark rte_mtr API's as st

RE: [PATCH v4 03/28] ethdev: mark rte_mtr API's as stable

2023-10-20 Thread Dumitrescu, Cristian
> -Original Message- > From: Stephen Hemminger > Sent: Thursday, October 19, 2023 8:10 PM > To: dev@dpdk.org > Cc: Stephen Hemminger ; Thomas Monjalon > ; Dumitrescu, Cristian > ; Ferruh Yigit ; > Andrew Rybchenko > Subject: [PATCH v4 03/28] ethdev: m

RE: [PATCH v4 04/28] ethdev: mark rte_tm API's as stable

2023-10-20 Thread Dumitrescu, Cristian
> -Original Message- > From: Stephen Hemminger > Sent: Thursday, October 19, 2023 8:10 PM > To: dev@dpdk.org > Cc: Stephen Hemminger ; Thomas Monjalon > ; Dumitrescu, Cristian > ; Ferruh Yigit ; > Andrew Rybchenko > Subject: [PATCH v4 04/28] ethdev:

RE: [PATCH v4 13/28] sched: remove experimental

2023-10-20 Thread Dumitrescu, Cristian
> -Original Message- > From: Stephen Hemminger > Sent: Thursday, October 19, 2023 8:10 PM > To: dev@dpdk.org > Cc: Stephen Hemminger ; Dumitrescu, > Cristian > Subject: [PATCH v4 13/28] sched: remove experimental > > The overcommit and PIE support was a

RE: [PATCH v4 15/28] meter: remove experimental warning from comments

2023-10-20 Thread Dumitrescu, Cristian
> -Original Message- > From: Stephen Hemminger > Sent: Thursday, October 19, 2023 8:10 PM > To: dev@dpdk.org > Cc: Stephen Hemminger ; Richardson, Bruce > ; Dumitrescu, Cristian > > Subject: [PATCH v4 15/28] meter: remove experimental warning from >

RE: [PATCH v4 27/28] table: remove experimental from API

2023-10-20 Thread Dumitrescu, Cristian
> -Original Message- > From: Stephen Hemminger > Sent: Thursday, October 19, 2023 8:10 PM > To: dev@dpdk.org > Cc: Stephen Hemminger ; Dumitrescu, > Cristian > Subject: [PATCH v4 27/28] table: remove experimental from API > > Though this library is marke

RE: [PATCH v4 28/28] port: make API's stable

2023-10-20 Thread Dumitrescu, Cristian
> -Original Message- > From: Stephen Hemminger > Sent: Thursday, October 19, 2023 8:10 PM > To: dev@dpdk.org > Cc: Stephen Hemminger ; Dumitrescu, > Cristian > Subject: [PATCH v4 28/28] port: make API's stable > > Follow the guidelines already in depr

RE: [PATCH v3 0/3] fix test-pipeline issues

2023-10-18 Thread Dumitrescu, Cristian
> -Original Message- > From: Feifei Wang > Sent: Tuesday, September 12, 2023 7:39 AM > Cc: dev@dpdk.org; n...@arm.com; Feifei Wang > Subject: [PATCH v3 0/3] fix test-pipeline issues > > For test-pipeline application, there are some problems with the normal > operation of the program a

RE: [PATCH v4] app/testpmd: enable cli for programmable action

2023-10-07 Thread Dumitrescu, Cristian
> -Original Message- > From: Zhang, Qi Z > Sent: Saturday, October 7, 2023 11:48 AM > To: Singh, Aman Deep ; Zhang, Yuying > > Cc: dev@dpdk.org; Dumitrescu, Cristian ; > or...@nvidia.com; ferruh.yi...@amd.com; Zhang, Qi Z > Subject: [PATCH v4] app/testpmd: ena

RE: [PATCH v3] app/testpmd: enable cli for programmable action

2023-10-06 Thread Dumitrescu, Cristian
Hi Qi, > > +#define ACTION_PROG_NAME_SIZE_MAX 32 > +#define ACTION_PROG_ARG_NUM_MAX 16 > +#define ACTION_PROG_ARG_VALUE_SIZE_MAX 32 Let's be a bit more generous with some of these sizes, please. The action name might be hierarchical, i.e. include the control block and table path separated

RE: [PATCH] ethdev: add flow API support for P4-programmable devices

2023-09-25 Thread Dumitrescu, Cristian
Hi Ori, Will implement your comments and send the V2 straight away. Answers inline. > -Original Message- > From: Ori Kam > Sent: Thursday, September 21, 2023 5:39 PM > To: Dumitrescu, Cristian ; dev@dpdk.org; > NBU-Contact-Thomas Monjalon (EXTERNAL) ; > david.march.

RE: [PATCH 31/36] net/softnic: fix Rx and Tx queue state

2023-09-18 Thread Dumitrescu, Cristian
> -Original Message- > From: Jie Hai > Sent: Friday, September 8, 2023 12:29 PM > To: dev@dpdk.org; Dumitrescu, Cristian ; > Lijun Ou ; Konstantin Ananyev > <"konstantin.v.ananyev@yandex.rukonstantin.ananyev"@huawei.com>; > Thomas Monjalon ; Ferru

RE: DPDK community: RTE_FLOW support for P4-programmable devices

2023-09-11 Thread Dumitrescu, Cristian
> -Original Message- > From: Ori Kam > Sent: Friday, September 1, 2023 7:58 AM > To: Jerin Jacob > Cc: Ferruh Yigit ; Dumitrescu, Cristian > ; Morten Brørup > ; Zhang, Qi Z ; NBU- > Contact-Thomas Monjalon (EXTERNAL) ; > david.march...@redhat.com; Richardson, B

RE: DPDK community: RTE_FLOW support for P4-programmable devices

2023-08-28 Thread Dumitrescu, Cristian
> > We just set up a community call for next week to discuss in more details the > > proposal for RTE_FLOW extensions to support P4-programmable devices > > https://mails.dpdk.org/archives/dev/2023-August/273703.html and look for > > ways to converge and make progress. > > > > All the people from T

RE: [PATCH] ethdev: introduce generic flow item and action

2023-08-16 Thread Dumitrescu, Cristian
> -Original Message- > From: Ferruh Yigit > Sent: Wednesday, August 16, 2023 6:08 PM > To: Morten Brørup ; Dumitrescu, Cristian > ; Zhang, Qi Z ; Ori > Kam ; Jerin Jacob > Cc: NBU-Contact-Thomas Monjalon (EXTERNAL) ; > david.march...@redhat.com; Richardson, Bruc

DPDK community: RTE_FLOW support for P4-programmable devices

2023-08-16 Thread Dumitrescu, Cristian
Hi folks, We just set up a community call for next week to discuss in more details the proposal for RTE_FLOW extensions to support P4-programmable devices https://mails.dpdk.org/archives/dev/2023-August/273703.html and look for ways to converge and make progress. All the people from To: and CC

RE: [PATCH] ethdev: introduce generic flow item and action

2023-08-16 Thread Dumitrescu, Cristian
Hi Morten, > > > > > > In order to avoid conflicts between P4 and non-P4 generic flow > > items/actions, > > > the generic type should include information about how to interpret the > > > information, which is why I suggest making it a Vendor-Specific type, with > > > vendor-specific TLV's (mana

RE: [PATCH] ethdev: introduce generic flow item and action

2023-08-16 Thread Dumitrescu, Cristian
Hi Ori, > > > Can you show me what items/actions are missing in rte_flow? > > > > The number of flow items (protocol headers, but also metadata) and flow > > actions > > that users can define in their P4 programs is infinite, so unfortunately > > Ori, as > > much > > as I want to grant you this

RE: [PATCH] ethdev: introduce generic flow item and action

2023-08-02 Thread Dumitrescu, Cristian
> -Original Message- > From: Ori Kam > Sent: Wednesday, August 2, 2023 5:06 PM > To: Ori Kam ; Morten Brørup > ; Dumitrescu, Cristian > ; Jerin Jacob > Cc: Zhang, Qi Z ; NBU-Contact-Thomas Monjalon > (EXTERNAL) ; david.march...@redhat.com; > Richardson,

RE: [PATCH] ethdev: introduce generic flow item and action

2023-08-02 Thread Dumitrescu, Cristian
> -Original Message- > From: Ori Kam > Sent: Wednesday, August 2, 2023 4:47 PM > To: Morten Brørup ; Dumitrescu, Cristian > ; Jerin Jacob > Cc: Zhang, Qi Z ; NBU-Contact-Thomas Monjalon > (EXTERNAL) ; david.march...@redhat.com; > Richardson, Bruce ; jer...@

RE: [PATCH] ethdev: introduce generic flow item and action

2023-08-02 Thread Dumitrescu, Cristian
> -Original Message- > From: Morten Brørup > Sent: Wednesday, August 2, 2023 4:25 PM > To: Dumitrescu, Cristian ; Jerin Jacob > > Cc: Zhang, Qi Z ; tho...@monjalon.net; > or...@nvidia.com; david.march...@redhat.com; Richardson, Bruce > ; jer...@marvell.c

RE: [PATCH] ethdev: introduce generic flow item and action

2023-08-02 Thread Dumitrescu, Cristian
bo...@dpdk.org; Mcnamara, John ; Zhang, > Helin ; dev@dpdk.org; Dumitrescu, Cristian > > Subject: Re: [PATCH] ethdev: introduce generic flow item and action > > On Wed, Aug 2, 2023 at 4:31 PM Morten Brørup > wrote: > > > > > From: Morten Brørup [mailto:m...@sm

RE: [PATCH] ethdev: introduce generic flow item and action

2023-08-02 Thread Dumitrescu, Cristian
ell.com; ferruh.yi...@amd.com > Cc: cristian.dumiter...@intel.com; techbo...@dpdk.org; Mcnamara, John > ; Zhang, Helin ; > dev@dpdk.org; Dumitrescu, Cristian > Subject: RE: [PATCH] ethdev: introduce generic flow item and action > > > From: Qi Zhang [mailto:qi.z.zh...@intel.com] &

RE: [RFC] lib/ethdev: introduce table driven APIs

2023-08-02 Thread Dumitrescu, Cristian
> -Original Message- > From: Dumitrescu, Cristian > Sent: Wednesday, July 19, 2023 2:39 PM > To: Ori Kam ; Jerin Jacob ; > Zhang, Qi Z > Cc: NBU-Contact-Thomas Monjalon (EXTERNAL) ; > david.march...@redhat.com; Richardson, Bruce > ; jer...@marvell.com; ferruh.y

Threads using mempools

2023-08-01 Thread Dumitrescu, Cristian
Hi folks, Is there a way in DPDK to create a POSIX thread in the driver/app and hook it up to an existing mempool by creating a mempool cache on the fly for this thread? The regular RTE lcores and service cores seem to be the only threads that have access to mempools, is my observation correct

RE: [PATCH] doc: postpone deprecation of pipeline legacy API

2023-07-20 Thread Dumitrescu, Cristian
> -Original Message- > From: Richardson, Bruce > Sent: Wednesday, July 19, 2023 5:09 PM > To: Dumitrescu, Cristian > Cc: dev@dpdk.org; Nicolau, Radu ; R, > Kamalakannan ; Suresh Narayane, Harshad > > Subject: Re: [PATCH] doc: postpone deprecation of pipelin

RE: [RFC] lib/ethdev: introduce table driven APIs

2023-07-19 Thread Dumitrescu, Cristian
Hi folks, > -Original Message- > From: Ori Kam > Sent: Tuesday, June 20, 2023 12:11 PM > To: Jerin Jacob ; Zhang, Qi Z > > Cc: Dumitrescu, Cristian ; NBU-Contact- > Thomas Monjalon (EXTERNAL) ; > david.march...@redhat.com; Richardson, Bruce > ; jer...@marvel

RE: [PATCH v5] bitmap: add scan from offset function

2023-07-03 Thread Dumitrescu, Cristian
> -Original Message- > From: Volodymyr Fialko > Sent: Monday, July 3, 2023 1:39 PM > To: dev@dpdk.org; Dumitrescu, Cristian > Cc: jer...@marvell.com; ano...@marvell.com; tho...@monjalon.net; > Volodymyr Fialko > Subject: [PATCH v5] bitmap: add scan from offset fu

RE: [dpdk-dev] [PATCH 06/10] lib/librte_pipeline: fix the use of unsafe strcpy

2023-07-03 Thread Dumitrescu, Cristian
> -Original Message- > From: Stephen Hemminger > Sent: Friday, June 30, 2023 7:09 PM > To: Min Hu (Connor) > Cc: dev@dpdk.org; ferruh.yi...@intel.com; Dumitrescu, Cristian > ; jer...@marvell.com; > jianjay.z...@huawei.com; jia@intel.com; g.si...@nxp

RE: [PATCH v4] bitmap: add scan from offset function

2023-07-03 Thread Dumitrescu, Cristian
> -Original Message- > From: Volodymyr Fialko > Sent: Monday, July 3, 2023 10:31 AM > To: dev@dpdk.org; Dumitrescu, Cristian > Cc: jer...@marvell.com; ano...@marvell.com; tho...@monjalon.net; > Volodymyr Fialko > Subject: [PATCH v4] bitmap: add scan

RE: [PATCH v3] bitmap: add scan from offset function

2023-06-23 Thread Dumitrescu, Cristian
> -Original Message- > From: Thomas Monjalon > Sent: Thursday, June 22, 2023 6:45 PM > To: Volodymyr Fialko > Cc: dev@dpdk.org; Dumitrescu, Cristian ; > jer...@marvell.com; ano...@marvell.com > Subject: Re: [PATCH v3] bitmap: add scan from offset function

RE: [PATCH v3] bitmap: add scan from offset function

2023-06-21 Thread Dumitrescu, Cristian
> -Original Message- > From: Volodymyr Fialko > Sent: Wednesday, June 21, 2023 11:01 AM > To: dev@dpdk.org; Dumitrescu, Cristian > Cc: jer...@marvell.com; ano...@marvell.com; tho...@monjalon.net; > Volodymyr Fialko > Subject: [PATCH v3] bitmap: add scan

RE: [PATCH v2] bitmap: add scan from offset function

2023-06-19 Thread Dumitrescu, Cristian
> -Original Message- > From: Volodymyr Fialko > Sent: Tuesday, June 13, 2023 4:40 PM > To: dev@dpdk.org; Dumitrescu, Cristian > Cc: jer...@marvell.com; ano...@marvell.com; tho...@monjalon.net; > Volodymyr Fialko > Subject: [PATCH v2] bitmap: add scan

RE: [PATCH] bitmap: add scan init at given position

2023-06-08 Thread Dumitrescu, Cristian
Hi Volodymyr, Thanks for your patch, comments below under your code: > -Original Message- > From: Thomas Monjalon > Sent: Thursday, June 1, 2023 4:26 PM > To: Dumitrescu, Cristian ; Volodymyr Fialko > > Cc: dev@dpdk.org; jer...@marvell.com; ano...@marvell.com >

RE: [dpdk-dev] [PATCH v1] examples/ip_pipeline: fix build issue with GCC 13

2023-05-02 Thread Dumitrescu, Cristian
> -Original Message- > From: jer...@marvell.com > Sent: Tuesday, May 2, 2023 2:51 PM > To: dev@dpdk.org; Dumitrescu, Cristian ; > Singh, Jasvinder > Cc: tho...@monjalon.net; david.march...@redhat.com; > ferruh.yi...@xilinx.com; step...@networkplumber.org

RE: [PATCH 28/33] doc: update softnic guide

2023-03-22 Thread Dumitrescu, Cristian
> -Original Message- > From: Ferruh Yigit > Sent: Wednesday, March 22, 2023 12:00 AM > To: Mcnamara, John ; Dumitrescu, Cristian > > Cc: Thomas Monjalon ; Andrew Rybchenko > ; dev@dpdk.org > Subject: [PATCH 28/33] doc: update softnic guide > > -

RE: [PATCH 1/2] examples/qos_sched: fix config entries in wrong sections

2023-03-21 Thread Dumitrescu, Cristian
> -Original Message- > From: Richardson, Bruce > Sent: Tuesday, March 21, 2023 1:14 PM > To: dev@dpdk.org > Cc: Richardson, Bruce ; sta...@dpdk.org; > Dumitrescu, Cristian > Subject: [PATCH 1/2] examples/qos_sched: fix config entries in wrong sections > &

RE: [PATCH 2/2] examples/qos_sched: report error if no pipes configured

2023-03-21 Thread Dumitrescu, Cristian
> -Original Message- > From: Richardson, Bruce > Sent: Tuesday, March 21, 2023 1:14 PM > To: dev@dpdk.org > Cc: Richardson, Bruce ; Dumitrescu, Cristian > > Subject: [PATCH 2/2] examples/qos_sched: report error if no pipes configured > > Have the QoS s

RE: [PATCH] app/testpmd: fix closing softnic port before ethdev ports

2023-03-10 Thread Dumitrescu, Cristian
> -Original Message- > From: David Marchand > Sent: Friday, March 10, 2023 1:49 PM > To: Dumitrescu, Cristian > Cc: Ferruh Yigit ; Stephen Hemminger > ; Jangra, Yogesh ; > Singh, Aman Deep ; Zhang, Yuying > ; dev@dpdk.org; R, Kamalakannan > ; Suresh Narayan

RE: [PATCH] app/testpmd: fix closing softnic port before ethdev ports

2023-03-10 Thread Dumitrescu, Cristian
> -Original Message- > From: Ferruh Yigit > Sent: Friday, March 10, 2023 12:00 PM > To: Dumitrescu, Cristian ; Stephen Hemminger > ; Jangra, Yogesh ; > Singh, Aman Deep ; Zhang, Yuying > > Cc: dev@dpdk.org; R, Kamalakannan ; Suresh > Narayane, Harshad

RE: [PATCH] app/testpmd: fix closing softnic port before ethdev ports

2023-03-10 Thread Dumitrescu, Cristian
> -Original Message- > From: Singh, Aman Deep > Sent: Friday, March 10, 2023 9:09 AM > To: Stephen Hemminger ; Dumitrescu, Cristian > > Cc: Jangra, Yogesh ; dev@dpdk.org; R, > Kamalakannan ; Suresh Narayane, Harshad > > Subject: Re: [PATCH] app/testpmd: fix

RE: [PATCH] app/testpmd: fix closing softnic port before ethdev ports

2023-03-09 Thread Dumitrescu, Cristian
> -Original Message- > From: Dumitrescu, Cristian > Sent: Thursday, March 9, 2023 5:20 PM > To: Stephen Hemminger ; Jangra, Yogesh > > Cc: dev@dpdk.org; R, Kamalakannan ; Suresh > Narayane, Harshad > Subject: RE: [PATCH] app/testpmd: fix closing softnic

RE: [PATCH] app/testpmd: fix closing softnic port before ethdev ports

2023-03-09 Thread Dumitrescu, Cristian
> -Original Message- > From: Jangra, Yogesh > Sent: Thursday, March 9, 2023 2:43 PM > To: dev@dpdk.org > Cc: Dumitrescu, Cristian ; Jangra, Yogesh > ; R, Kamalakannan ; > Suresh Narayane, Harshad > Subject: [PATCH] app/testpmd: fix closing softnic port before e

RE: [PATCH] app/testpmd: fix closing softnic port before ethdev ports

2023-03-09 Thread Dumitrescu, Cristian
> -Original Message- > From: Stephen Hemminger > Sent: Thursday, March 9, 2023 4:31 PM > To: Jangra, Yogesh > Cc: dev@dpdk.org; Dumitrescu, Cristian ; R, > Kamalakannan ; Suresh Narayane, Harshad > > Subject: Re: [PATCH] app/testpmd: fix closing softnic

RE: [PATCH] examples/qos_sched: fix buffer overflow on mbuf free

2023-03-08 Thread Dumitrescu, Cristian
> -Original Message- > From: Richardson, Bruce > Sent: Wednesday, March 8, 2023 2:09 PM > To: dev@dpdk.org > Cc: Richardson, Bruce ; Ajmera, Megha > ; Dumitrescu, Cristian > > Subject: [PATCH] examples/qos_sched: fix buffer overflow on mbuf free > >

RE: [PATCH v4 02/19] remove repeated word 'to'

2023-02-22 Thread Dumitrescu, Cristian
> -Original Message- > From: Stephen Hemminger > Sent: Wednesday, February 22, 2023 4:25 PM > To: dev@dpdk.org > Cc: Stephen Hemminger ; Dumitrescu, Cristian > ; Hunt, David > Subject: [PATCH v4 02/19] remove repeated word 'to' > > Found by doing

RE: [PATCH v3] hash: add XOR32 hash function

2023-02-20 Thread Dumitrescu, Cristian
HI Bili, Comments inline below: > diff --git a/lib/hash/rte_hash_xor.h b/lib/hash/rte_hash_xor.h > new file mode 100644 > index 00..7004f83ec2 > --- /dev/null > +++ b/lib/hash/rte_hash_xor.h > @@ -0,0 +1,65 @@ > +/* SPDX-License-Identifier: BSD-3-Clause > + * Copyright(c) 2023 Intel Cor

RE: [PATCH v3] hash: add XOR32 hash function

2023-02-20 Thread Dumitrescu, Cristian
Hi Bili, Would it be possible to also remove the endianness conversion from this hash function? What would be the impact if the rte_cpu_to_be() functions are removed? Thanks, Cristian

RE: [PATCH 4/4] examples/qos_sched: remove limit on core ids

2023-02-17 Thread Dumitrescu, Cristian
> -Original Message- > From: Richardson, Bruce > Sent: Friday, February 3, 2023 10:06 AM > To: dev@dpdk.org > Cc: Singh, Jasvinder ; Richardson, Bruce > ; Dumitrescu, Cristian > > Subject: [PATCH 4/4] examples/qos_sched: remove limit on core ids > > Th

RE: [PATCH 3/4] examples/qos_sched: use bigger bursts on dequeue

2023-02-17 Thread Dumitrescu, Cristian
> -Original Message- > From: Richardson, Bruce > Sent: Friday, February 3, 2023 10:06 AM > To: dev@dpdk.org > Cc: Singh, Jasvinder ; Richardson, Bruce > ; Dumitrescu, Cristian > > Subject: [PATCH 3/4] examples/qos_sched: use bigger bursts on dequeue > >

RE: [PATCH 2/4] examples/qos_sched: remove TX buffering

2023-02-17 Thread Dumitrescu, Cristian
> -Original Message- > From: Richardson, Bruce > Sent: Friday, February 3, 2023 10:06 AM > To: dev@dpdk.org > Cc: Singh, Jasvinder ; Richardson, Bruce > ; Dumitrescu, Cristian > > Subject: [PATCH 2/4] examples/qos_sched: remove TX buffering > > Sinc

RE: [PATCH 1/4] examples/qos_sched: fix errors when TX port not up

2023-02-17 Thread Dumitrescu, Cristian
> -Original Message- > From: Richardson, Bruce > Sent: Friday, February 3, 2023 10:06 AM > To: dev@dpdk.org > Cc: Singh, Jasvinder ; Richardson, Bruce > ; sta...@dpdk.org; Dumitrescu, Cristian > > Subject: [PATCH 1/4] examples/qos_sched: fix errors when TX port

RE: [PATCH] sched: fix for tc_ov_enable flag position in subport structure.

2023-02-06 Thread Dumitrescu, Cristian
> -Original Message- > From: Thomas Monjalon > Sent: Monday, February 6, 2023 7:43 AM > To: Ajmera, Megha > Cc: sta...@dpdk.org; dev@dpdk.org; Singh, Jasvinder > ; Dumitrescu, Cristian > ; marcinx.danilew...@intel.com; David > Marchand > Subject:

RE: [PATCH V4 00/11] pipeline: add IPsec support

2023-01-26 Thread Dumitrescu, Cristian
> -Original Message- > From: Thomas Monjalon > Sent: Thursday, January 26, 2023 9:17 AM > To: Dumitrescu, Cristian > Cc: dev@dpdk.org > Subject: Re: [PATCH V4 00/11] pipeline: add IPsec support > > 12/01/2023 19:53, Cristian Dumitrescu: > > This patch se

RE: [PATCH] sched: fix for tc_ov_enable flag position in subport structure.

2023-01-10 Thread Dumitrescu, Cristian
> -Original Message- > From: Ajmera, Megha > Sent: Monday, January 9, 2023 2:55 PM > To: dev@dpdk.org; Singh, Jasvinder ; Dumitrescu, > Cristian > Cc: sta...@dpdk.org; marcinx.danilew...@intel.com > Subject: [PATCH] sched: fix for tc_ov_enable flag position in

RE: [PATCH] sched: fix for demo failure in debug mode

2023-01-09 Thread Dumitrescu, Cristian
> -Original Message- > From: Ajmera, Megha > Sent: Thursday, January 5, 2023 12:29 PM > To: dev@dpdk.org; Singh, Jasvinder ; Dumitrescu, > Cristian > Cc: sta...@dpdk.org > Subject: [PATCH] sched: fix for demo failure in debug mode > > This issue is happenin

RE: [PATCH V3 02/21] net/softnic: remove flow support

2022-12-01 Thread Dumitrescu, Cristian
> -Original Message- > From: Ferruh Yigit > Sent: Wednesday, November 30, 2022 11:19 AM > To: Dumitrescu, Cristian ; Thomas Monjalon > > Cc: Jangra, Yogesh ; dev@dpdk.org > Subject: Re: [PATCH V3 02/21] net/softnic: remove flow support > > On 9/1/2022 3

RE: [PATCH v6] mailmap: add file to DPDK

2022-11-25 Thread Dumitrescu, Cristian
> -Original Message- > From: David Marchand > Sent: Friday, November 25, 2022 2:54 PM > To: dev@dpdk.org > Cc: ferruh.yi...@amd.com; Richardson, Bruce > ; Thomas Monjalon > Subject: [PATCH v6] mailmap: add file to DPDK > > From: Bruce Richardson > > Since a number of contributors to

RE: [PATCH 07/14] examples/qos_sched: fix whitespace

2022-11-09 Thread Dumitrescu, Cristian
> -Original Message- > From: Stephen Hemminger > Sent: Wednesday, November 9, 2022 7:15 PM > To: dev@dpdk.org > Cc: Stephen Hemminger ; Dumitrescu, > Cristian > Subject: [PATCH 07/14] examples/qos_sched: fix whitespace > > Add space after keywords.

RE: [PATCH v6 3/3] sched: support for 100G+ rates in subport/pipe config

2022-10-28 Thread Dumitrescu, Cristian
> -Original Message- > From: Ajmera, Megha > Sent: Friday, October 28, 2022 10:56 AM > To: dev@dpdk.org; Singh, Jasvinder ; > Dumitrescu, Cristian ; > step...@networkplumber.org > Cc: sta...@dpdk.org > Subject: [PATCH v6 3/3] sched: support for 100G+ rates

RE: [PATCH v4 3/3] sched: support for 100G+ rates in subport/pipe config

2022-10-24 Thread Dumitrescu, Cristian
Hi Megha, Comments inline below. > -Original Message- > From: Ajmera, Megha > Sent: Thursday, October 20, 2022 10:48 AM > To: dev@dpdk.org; Singh, Jasvinder ; > Dumitrescu, Cristian ; > step...@networkplumber.org > Cc: sta...@dpdk.org > Subject: [PATCH v4 3/3]

RE: [PATCH 3/3] sched: support for 100G+ rates in subport/pipe config

2022-10-18 Thread Dumitrescu, Cristian
> -Original Message- > From: Ajmera, Megha > Sent: Tuesday, October 18, 2022 6:40 AM > To: Dumitrescu, Cristian ; dev@dpdk.org; > Singh, Jasvinder > Cc: sta...@dpdk.org > Subject: RE: [PATCH 3/3] sched: support for 100G+ rates in subport/pipe > config

RE: [PATCH 2/3] sched: removed unused subport field in hqos profile

2022-10-11 Thread Dumitrescu, Cristian
> -Original Message- > From: Ajmera, Megha > Sent: Thursday, October 6, 2022 8:01 PM > To: dev@dpdk.org; Singh, Jasvinder ; > Dumitrescu, Cristian > Cc: sta...@dpdk.org > Subject: [PATCH 2/3] sched: removed unused subport field in hqos profile > > Remove

RE: [PATCH 1/3] sched: fix subport profile id not set correctly

2022-10-11 Thread Dumitrescu, Cristian
> -Original Message- > From: Ajmera, Megha > Sent: Thursday, October 6, 2022 8:01 PM > To: dev@dpdk.org; Singh, Jasvinder ; > Dumitrescu, Cristian > Cc: sta...@dpdk.org > Subject: [PATCH 1/3] sched: fix subport profile id not set correctly > > In rte

RE: [PATCH 3/3] sched: support for 100G+ rates in subport/pipe config

2022-10-11 Thread Dumitrescu, Cristian
> -Original Message- > From: Ajmera, Megha > Sent: Thursday, October 6, 2022 8:01 PM > To: dev@dpdk.org; Singh, Jasvinder ; > Dumitrescu, Cristian > Cc: sta...@dpdk.org > Subject: [PATCH 3/3] sched: support for 100G+ rates in subport/pipe config > > Confi

RE: [PATCH v2] sched: Fix subport profile id not set correctly.

2022-10-05 Thread Dumitrescu, Cristian
> -Original Message- > From: Ajmera, Megha > Sent: Wednesday, October 5, 2022 6:23 PM > To: dev@dpdk.org; Singh, Jasvinder ; > Dumitrescu, Cristian > Cc: sta...@dpdk.org > Subject: [PATCH v2] sched: Fix subport profile id not set correctly. > > In rte

RE: [PATCH v5 0/7] ethdev: separate metering and marking from policing

2022-09-27 Thread Dumitrescu, Cristian
> -Original Message- > From: Alexander Kozyrev > Sent: Monday, September 26, 2022 7:48 PM > To: Dumitrescu, Cristian ; dev@dpdk.org > Cc: jerinjac...@gmail.com; Ori Kam ; NBU-Contact- > Thomas Monjalon (EXTERNAL) ; > ivan.ma...@oktetlabs.ru; andrew.rybche...@okte

RE: [PATCH v5 0/7] ethdev: separate metering and marking from policing

2022-09-27 Thread Dumitrescu, Cristian
> -Original Message- > From: Alexander Kozyrev > Sent: Monday, September 26, 2022 3:58 PM > To: dev@dpdk.org > Cc: Dumitrescu, Cristian ; > jerinjac...@gmail.com; or...@nvidia.com; tho...@monjalon.net; > ivan.ma...@oktetlabs.ru; andrew.rybche...@oktetlabs.ru; >

RE: [PATCH V3 2/7] table: add entry ID for learner tables

2022-09-26 Thread Dumitrescu, Cristian
> -Original Message- > From: Thomas Monjalon > Sent: Saturday, September 24, 2022 9:25 AM > To: Dumitrescu, Cristian > Cc: dev@dpdk.org > Subject: Re: [PATCH V3 2/7] table: add entry ID for learner tables > > 30/08/2022 20:58, Cristian Dumitres

RE: SWX table question

2022-09-08 Thread Dumitrescu, Cristian
Hi Morten, > -Original Message- > From: Morten Brørup > Sent: Thursday, September 8, 2022 2:49 PM > To: Dumitrescu, Cristian > Cc: dev@dpdk.org > Subject: SWX table question > > Thank you for an interesting presentation today, Cristian. > > It made me awa

RE: [PATCH v2 1/1] ethdev: add protocol param to color table update

2022-08-23 Thread Dumitrescu, Cristian
> -Original Message- > From: sk...@marvell.com > Sent: Tuesday, August 23, 2022 11:23 AM > To: Dumitrescu, Cristian ; Singh, Aman Deep > ; Zhang, Yuying ; > Nithin Dabilpuram ; Kiran Kumar K > ; Sunil Kumar Kori ; Satha > Rao ; Singh, Jasvinder > ; Thoma

RE: [PATCH V5 01/17] pipeline: add pipeline name

2022-07-28 Thread Dumitrescu, Cristian
> -Original Message- > From: Richardson, Bruce > Sent: Thursday, July 28, 2022 9:22 AM > To: Dumitrescu, Cristian > Cc: dev@dpdk.org; R, Kamalakannan > Subject: Re: [PATCH V5 01/17] pipeline: add pipeline name > > On Wed, Jul 27, 2022 at 11:01:16PM +, C

RE: [PATCH v6] sched: enable CMAN at runtime

2022-06-21 Thread Dumitrescu, Cristian
Hi Marcin, The code changes in the library (rte-sched.c) look good to me, but I do have some questions for the qos_sched app and the Soft NIC driver on how CMAN gets enabled/disabled. How do we control whether congestion management (CMAN) should be disabled on enabled (WRED/PIE)? It looks to

RE: [PATCH v5] ched: enable CMAN at runtime

2022-06-20 Thread Dumitrescu, Cristian
> -Original Message- > From: Danilewicz, MarcinX > Sent: Monday, June 20, 2022 2:57 PM > To: dev@dpdk.org; Singh, Jasvinder ; > Dumitrescu, Cristian > Cc: Ajmera, Megha > Subject: [PATCH v5] ched: enable CMAN at runtime > Title: ched -> sched

RE: [PATCH v4] sched: enable CMAN at runtime

2022-06-17 Thread Dumitrescu, Cristian
> -Original Message- > From: Danilewicz, MarcinX > Sent: Monday, June 13, 2022 10:09 AM > To: dev@dpdk.org; Singh, Jasvinder ; > Dumitrescu, Cristian > Cc: Ajmera, Megha > Subject: [PATCH v4] sched: enable CMAN at runtime > > Added changes to enable CMAN

RE: [PATCH] pipeline: fix comparison

2022-06-16 Thread Dumitrescu, Cristian
> -Original Message- > From: Thomas Monjalon > Sent: Wednesday, June 15, 2022 8:06 PM > To: Suresh Narayane, Harshad ; > Dumitrescu, Cristian > Cc: dev@dpdk.org > Subject: Re: [PATCH] pipeline: fix comparison > > 13/06/2022 13:52, Cristian Dumitrescu:

RE: [PATCH v3] sched: enable CMAN at runtime

2022-06-08 Thread Dumitrescu, Cristian
> -Original Message- > From: Danilewicz, MarcinX > Sent: Wednesday, June 8, 2022 10:42 AM > To: dev@dpdk.org; Singh, Jasvinder ; > Dumitrescu, Cristian > Cc: Ajmera, Megha > Subject: [PATCH v3] sched: enable CMAN at runtime > > Added changes to enabl

RE: [PATCH v3 0/7] ethdev: separate metering and marking from policing

2022-06-08 Thread Dumitrescu, Cristian
> -Original Message- > From: Alexander Kozyrev > Sent: Wednesday, June 1, 2022 4:44 AM > To: dev@dpdk.org > Cc: Dumitrescu, Cristian ; > jerinjac...@gmail.com; or...@nvidia.com; tho...@monjalon.net; > ivan.ma...@oktetlabs.ru; andrew.rybche...@oktetlabs.ru; >

RE: [PATCH] examples/pipeline: fix build

2022-06-07 Thread Dumitrescu, Cristian
> -Original Message- > From: Ali Alnubani > Sent: Thursday, June 2, 2022 1:34 PM > To: dev@dpdk.org > Cc: Dumitrescu, Cristian > Subject: [PATCH] examples/pipeline: fix build > > This patch fixes the following build failure seen on Ubuntu 16.04 >

RE: [PATCH v10] sched: enable traffic class oversubscription conditionally

2022-05-31 Thread Dumitrescu, Cristian
> -Original Message- > From: Danilewicz, MarcinX > Sent: Tuesday, May 31, 2022 10:49 AM > To: dev@dpdk.org; Singh, Jasvinder ; > Dumitrescu, Cristian > Cc: Ajmera, Megha > Subject: [PATCH v10] sched: enable traffic class oversubscription > conditionally >

RE: [PATCH v9] sched: enable traffic class oversubscription conditionally

2022-05-30 Thread Dumitrescu, Cristian
Hi Marcin, Comments inline below. > diff --git a/lib/sched/rte_sched.h b/lib/sched/rte_sched.h > index 5ece64e527..317ab3b68e 100644 > --- a/lib/sched/rte_sched.h > +++ b/lib/sched/rte_sched.h > @@ -579,6 +579,24 @@ rte_sched_port_enqueue(struct rte_sched_port > *port, struct rte_mbuf **pkts, uin

RE: [PATCH v7] sched: enable traffic class oversubscription conditionally

2022-05-30 Thread Dumitrescu, Cristian
Hi Marcin, > > > > Still only changes in rte_sched.c and no change in rte_sched.h for the API > to > > configure this feature? > > Yes, because you said to remove whole > rte_sched_subport_tc_ov_config(struct rte_sched_port *port, > uint32_t subport_id, > bool tc_ov_enable) > here

RE: [PATCH v7] sched: enable traffic class oversubscription conditionally

2022-05-30 Thread Dumitrescu, Cristian
Hi Marcin, Comments inline below. > -Original Message- > From: Danilewicz, MarcinX > Sent: Monday, May 30, 2022 12:55 PM > To: dev@dpdk.org; Singh, Jasvinder ; > Dumitrescu, Cristian > Cc: Ajmera, Megha > Subject: [PATCH v7] sched: enable traffic class oversubsc

RE: [PATCH v5 3/3] rte_pie: fix incorrect floating point math

2022-05-30 Thread Dumitrescu, Cristian
> -Original Message- > From: Stephen Hemminger > Sent: Thursday, May 26, 2022 9:27 PM > To: dev@dpdk.org > Cc: Stephen Hemminger ; Dumitrescu, > Cristian ; Singh, Jasvinder > ; Wojciech Liguzinski > > Subject: [PATCH v5 3/3] rte_pie: fix incorrect floating p

RE: [PATCH v5 2/3] rte_pie: remove unnecessary floating point

2022-05-30 Thread Dumitrescu, Cristian
> -Original Message- > From: Stephen Hemminger > Sent: Thursday, May 26, 2022 9:27 PM > To: dev@dpdk.org > Cc: Stephen Hemminger ; Dumitrescu, > Cristian ; Singh, Jasvinder > ; Wojciech Liguzinski > > Subject: [PATCH v5 2/3] rte_pie: remove unnecessary flo

RE: [PATCH v2] sched: enable CMAN at runtime

2022-05-30 Thread Dumitrescu, Cristian
Hi Marcin, Comments inline below. > -Original Message- > From: Danilewicz, MarcinX > Sent: Thursday, May 12, 2022 2:11 PM > To: dev@dpdk.org; Singh, Jasvinder ; > Dumitrescu, Cristian > Cc: Ajmera, Megha > Subject: [PATCH v2] sched: enable CMAN at runtime > &

RE: [PATCH v2] sched: enable CMAN at runtime

2022-05-30 Thread Dumitrescu, Cristian
> -Original Message- > From: Danilewicz, MarcinX > Sent: Thursday, May 12, 2022 2:11 PM > To: dev@dpdk.org; Singh, Jasvinder ; > Dumitrescu, Cristian > Cc: Ajmera, Megha > Subject: [PATCH v2] sched: enable CMAN at runtime > > Added changes to enable CMAN

RE: [PATCH v6] sched: enable traffic class oversubscription conditionally

2022-05-30 Thread Dumitrescu, Cristian
> -Original Message- > From: Danilewicz, MarcinX > Sent: Monday, May 30, 2022 9:45 AM > To: dev@dpdk.org; Singh, Jasvinder ; > Dumitrescu, Cristian > Cc: Ajmera, Megha > Subject: [PATCH v6] sched: enable traffic class oversubscription conditionally > >

RE: [PATCH v6] sched: enable traffic class oversubscription conditionally

2022-05-30 Thread Dumitrescu, Cristian
Hi Marcin, Comments inline below. > @@ -2403,8 +2481,16 @@ grinder_schedule(struct rte_sched_port *port, > uint32_t pkt_len = pkt->pkt_len + port->frame_overhead; > uint32_t be_tc_active; > > - if (!grinder_credits_check(port, subport, pos)) > - return 0; > + sw

RE: [PATCH v6] sched: enable traffic class oversubscription conditionally

2022-05-30 Thread Dumitrescu, Cristian
> -Original Message- > From: Danilewicz, MarcinX > Sent: Monday, May 30, 2022 9:45 AM > To: dev@dpdk.org; Singh, Jasvinder ; > Dumitrescu, Cristian > Cc: Ajmera, Megha > Subject: [PATCH v6] sched: enable traffic class oversubscription conditionally > >

  1   2   3   4   5   6   7   8   9   10   >