> -----Original Message-----
> From: Ajmera, Megha <megha.ajm...@intel.com>
> Sent: Wednesday, October 5, 2022 6:23 PM
> To: dev@dpdk.org; Singh, Jasvinder <jasvinder.si...@intel.com>;
> Dumitrescu, Cristian <cristian.dumitre...@intel.com>
> Cc: sta...@dpdk.org
> Subject: [PATCH v2] sched: Fix subport profile id not set correctly.
>
> In rte_sched_subport_config() API, subport_profile_id is not set correctly.
>
> Fixes: ac6fcb841b0f ("sched: update subport rate dynamically")
> Cc: cristian.dumitre...@intel.com
>
> Signed-off-by: Megha Ajmera <megha.ajm...@intel.com>
> ---
> lib/sched/rte_sched.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/lib/sched/rte_sched.c b/lib/sched/rte_sched.c
> index c5fa9e4582..c91697131d 100644
> --- a/lib/sched/rte_sched.c
> +++ b/lib/sched/rte_sched.c
> @@ -1257,8 +1257,6 @@ rte_sched_subport_config(struct rte_sched_port
> *port,
>
> n_subports++;
>
> - subport_profile_id = 0;
> -
> /* Port */
> port->subports[subport_id] = s;
>
> --
> 2.25.1
Hi Megha,
I noticed several patches from you that all fix small things, can you please
put all of them into a series as opposed to isolated patches? This is to avoid
apply issues due to dependency order. No need for a cover letter in this case.
Can you please also pay attention to the details in the patch title and
description:
-title needs to have a lower case letter after "sched: "
-title needs to start with a verb
-title needs to be short and clear
-description needs to make sense
Thanks,
Cristian
