Hi Marcin, The code changes in the library (rte-sched.c) look good to me, but I do have some questions for the qos_sched app and the Soft NIC driver on how CMAN gets enabled/disabled.
How do we control whether congestion management (CMAN) should be disabled on enabled (WRED/PIE)? It looks to me like you are always enabling WRED by default, which is incorrect: we should have CMAN disabled by default (in init.c). My preferred way to configure CMAN is: a) CMAN should be disabled by default b) If the CMAN parameters get configured in the profile.cfg, then and only then CMAN should be enabled according to the configuration. In init.c, we can safely set the subport CMAN parameters to NULL as the built-in default when the profile.cfg is not provided, so we can safely remove the WRED params from there. In cfg_file.c, we need to have a good way to disable/enable CMAN. In profile.cfg, please remove the WRED lines as opposed to commenting them out. Is this OK with you? Also, have you tested the qos_sched app and the Soft NIC driver with all 3 configuration files? Thanks, Cristian
