[Bug 1166] [dpdk-23.03][asan]vf_smoke/vf_tx_rx_queue: AddressSanitizer: stack-buffer-overflow error when quit testpmd

2023-02-28 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=1166 David Marchand (david.march...@redhat.com) changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED

RE: release candidate 23.03-rc1

2023-02-28 Thread Jiang, YuX
> -Original Message- > From: Jiang, YuX > Sent: Thursday, February 23, 2023 4:39 PM > To: Thomas Monjalon ; dev (dev@dpdk.org) > > Cc: Kovacevic, Marko ; Mcnamara, John > ; Richardson, Bruce > ; Ferruh Yigit > Subject: RE: release candidate 23.03-rc1 > > > -Original Message- > > F

回复: [PATCH v3 1/3] ethdev: enable direct rearm with separate API

2023-02-28 Thread Feifei Wang
Hi, Morten > -邮件原件- > 发件人: Morten Brørup > 发送时间: Tuesday, February 28, 2023 4:09 PM > 收件人: Konstantin Ananyev ; Feifei > Wang ; Konstantin Ananyev > ; tho...@monjalon.net; Ferruh Yigit > ; Andrew Rybchenko > > 抄送: dev@dpdk.org; nd ; Honnappa Nagarahalli > ; Ruifeng Wang > ; nd > 主题: RE:

[Bug 1171] [dpdk-23.03]vhost-user+virtio-pmd with vIOMMU core dumped

2023-02-28 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=1171 Bug ID: 1171 Summary: [dpdk-23.03]vhost-user+virtio-pmd with vIOMMU core dumped Product: DPDK Version: 22.03 Hardware: All OS: All Status: UNCONFIRMED

RE: [PATCH v4 03/12] app/mldev: add test case to validate device ops

2023-02-28 Thread Anup Prabhu
> -Original Message- > From: Srikanth Yalavarthi > Sent: Tuesday, February 7, 2023 9:20 PM > To: Srikanth Yalavarthi > Cc: dev@dpdk.org; Shivah Shankar Shankar Narayan Rao > ; Jerin Jacob Kollanukkaran > ; Anup Prabhu ; Prince Takkar > ; Parijat Shukla > Subject: [PATCH v4 03/12] app/m

RE: [v1, 00/10] fips_validation application improvements

2023-02-28 Thread Gowrishankar Muthukrishnan
I have fixed it in v2 and CI passed. http://mails.dpdk.org/archives/test-report/2023-February/360464.html Thanks, Gowrishankar > -Original Message- > From: Akhil Goyal > Sent: Tuesday, February 28, 2023 1:09 PM > To: Akhil Goyal ; Dooley, Brian > ; Gowrishankar Muthukrishnan > ; dev@dpdk.

[PATCH 5/5] app/testpmd: add error recovery usage demo

2023-02-28 Thread Chengwen Feng
This patch adds error recovery usage demo which will: 1. stop packet forwarding when the RTE_ETH_EVENT_ERR_RECOVERING event is received. 2. restart packet forwarding when the RTE_ETH_EVENT_RECOVERY_SUCCESS event is received. 3. prompt the ports that fail to recovery and need to be removed whe

[PATCH 3/5] net/bnxt: fix race-condition when report error recovery

2023-02-28 Thread Chengwen Feng
If set data path functions to dummy functions before reports error recovering event, there maybe a race-condition with data path threads, this patch fixes it by setting data path functions to dummy functions only after reports such event. Fixes: e11052f3a46f ("net/bnxt: support proactive error han

[PATCH 1/5] ethdev: fix race-condition of proactive error handling mode

2023-02-28 Thread Chengwen Feng
In the proactive error handling mode, the PMD will set the data path pointers to dummy functions and then try recovery, in this period the application may still invoking data path API. This will introduce a race-condition with data path which may lead to crash [1]. Although the PMD added delay aft

[PATCH 4/5] net/bnxt: use fp ops setup function

2023-02-28 Thread Chengwen Feng
Use rte_eth_fp_ops_setup() instead of directly manipulating rte_eth_fp_ops variable. Cc: sta...@dpdk.org Signed-off-by: Chengwen Feng --- drivers/net/bnxt/bnxt_cpr.c| 5 + drivers/net/bnxt/bnxt_ethdev.c | 5 + 2 files changed, 2 insertions(+), 8 deletions(-) diff --git a/drivers/ne

[PATCH 0/5] fix race-condition of proactive error handling mode

2023-02-28 Thread Chengwen Feng
This patch fixes race-condition of proactive error handling mode, the discussion thread [1]. [1] http://patchwork.dpdk.org/project/dpdk/patch/20230220060839.1267349-2-ashok.k.kal...@intel.com/ Chengwen Feng (5): ethdev: fix race-condition of proactive error handling mode net/hns3: replace fp

[PATCH 2/5] net/hns3: replace fp ops config function

2023-02-28 Thread Chengwen Feng
This patch replace hns3_eth_dev_fp_ops_config() with rte_eth_fp_ops_setup(). Cc: sta...@dpdk.org Signed-off-by: Chengwen Feng --- drivers/net/hns3/hns3_rxtx.c | 21 +++-- 1 file changed, 3 insertions(+), 18 deletions(-) diff --git a/drivers/net/hns3/hns3_rxtx.c b/drivers/net/hn

[PATCH v3 2/2] app/testpmd: add support for bonding port's LACP negotiation

2023-02-28 Thread Chaoyong He
From: Long Wu If bonding port is mode4 with disabling dedicated queue and there are no other packets, forward loop will not call port's TX function and bonding port will not send LACP packets. Add sending LACP packets periodically in forward loop to avoid LACP negotiation failed. Signed-off-by:

[PATCH v3 1/2] net/bonding: add independent LACP sending function

2023-02-28 Thread Chaoyong He
From: Long Wu Sending LACP control packets depends on calling the bonding port's sending function if we disable dedicated queue. In some cases app would not call the bonding port's sending function if there are only LACP control packets and the negotiation between the two bonding ports will fail.

[PATCH v3 0/2] enhance bonding PMD to support the LACP negotiation

2023-02-28 Thread Chaoyong He
App may not support the LACP negotiation in some cases. This patch series solves this problem and add logics to testpmd app to support the forward of bonding port in mode 4 with the disabled dedicated queue. --- v2: * Export symbol to solve the link problem. v3: * Add 'rte_experimental' flags to n

RE: [PATCH v2] net/ice: fix ice dcf control thread crash

2023-02-28 Thread Zhang, Ke1X
> -Original Message- > From: Thomas Monjalon > Sent: Monday, February 20, 2023 8:30 AM > To: Tyler Retzlaff ; Zhang, Ke1X > > Cc: dev@dpdk.org; Zhang, Qi Z ; Yang, Qiming > ; dev@dpdk.org; david.march...@redhat.com > Subject: Re: [PATCH v2] net/ice: fix ice dcf control thread crash > > 1

Re: [PATCH 1/2] app/testpmd: change rule type

2023-02-28 Thread Ferruh Yigit
On 2/22/2023 2:11 PM, Eli Britstein wrote: > Change rule type to be uintptr_t (instead of currently uint32_t) to be > able to accomodate larger IDs, as a pre-step towards allowing user-id > to flows. > No objection to extend id storage type, but I am not clear why allowing user-id justifies this,

Re: [PATCH 0/2] add support for RSS parsing of SCTP packet

2023-02-28 Thread Ferruh Yigit
On 2/21/2023 5:52 AM, Chaoyong He wrote: > Add support for RSS parsing of SCTP packets and modify the logic to > return the right RSS configuration. > > Depends-on: series-27102 ("net/nfp: standardize the use of RSS-related") > > Long Wu (2): > net/nfp: add support for RSS parsing of SCTP packe

Re: [PATCH] net/mana: fix incorrectly reported counters in stats

2023-02-28 Thread Ferruh Yigit
On 2/22/2023 11:27 PM, lon...@linuxonhyperv.com wrote: > From: Long Li > > For per port counters and we should report summed values from all queues. > > Cc: sta...@dpdk.org Fixes: e350b56889bb ("net/mana: report queue statistics") Cc: sta...@dpdk.org > Signed-off-by: Long Li Acked-by

RE: [PATCH 2/2] ethdev: fix race condition in fast-path ops setup

2023-02-28 Thread Honnappa Nagarahalli
> -Original Message- > From: Konstantin Ananyev > Sent: Thursday, February 23, 2023 7:31 AM > To: Fengchengwen ; Honnappa Nagarahalli > ; Stephen Hemminger > ; Ruifeng Wang ; > Ajit Khaparde (ajit.khapa...@broadcom.com) > > Cc: Ashok Kaladi ; jer...@marvell.com; > tho...@monjalon.net; d

RE: [EXT] [PATCH] ipsec_mb: expect ENOTSUP in ipsec_mb_create()

2023-02-28 Thread Ji, Kai
Is there any validation to this changes ? I Can't remember the exact reason why EEXIST returned, somehow we need to handle that case. Regards Kai > -Original Message- > From: Akhil Goyal > Sent: Monday, February 27, 2023 6:27 PM > To: Karas, Krzysztof ; Thomas Monjalon > ; Ji, Kai

Re: [PATCH] ethdev: initialize id in eth_representor_cmp()

2023-02-28 Thread Ferruh Yigit
On 2/20/2023 4:44 PM, Krzysztof Karas wrote: > When Link Time Optimization is enabled, compiler may > complain about "id" in eth_representor_cmp() being > uninitialized. > > To suppress the warning it is enough to add explicit > initialization of the variable causing the issue. > > Signed-off-by:

RE: [PATCH v2 04/16] test/bbdev: add timeout for latency tests

2023-02-28 Thread Chautru, Nicolas
Hi Maxime, > -Original Message- > From: Maxime Coquelin > Sent: Monday, February 27, 2023 1:45 AM > To: Vargas, Hernan ; dev@dpdk.org; > gak...@marvell.com; Rix, Tom > Cc: Chautru, Nicolas ; Zhang, Qi Z > > Subject: Re: [PATCH v2 04/16] test/bbdev: add timeout for latency tests > > >

Re: [PATCH] maintainers: update ENA PMD maintainers list

2023-02-28 Thread Ferruh Yigit
On 1/11/2023 4:04 PM, Ferruh Yigit wrote: > On 12/27/2022 12:09 PM, Brandes, Shai wrote: > >> >> The main driver maintenance is now handled by Amazon, and the new Amazon >> maintainer has been added (Ron Beider). >> >> As Semihalf interaction with the ENA PMD is going to be limited, Marcin >> Wo

[PATCH v1] eventdev: fix invalid memory free operation

2023-02-28 Thread Abdullah Sevincer
This commit fixes invalid memory free operation caused by extending xstats ID width from 32 to 64 bits. Telemetry application crashed when freeing memory, hence, the telemetry app could not display xstats. Fixes: 1bdfe4d76e98 ("eventdev: increase xstats ID width to 64 bits") Cc: sta...@dpdk.org

Re: [PATCH] kni: fix build with Linux 6.3

2023-02-28 Thread David Marchand
On Tue, Feb 28, 2023 at 6:29 PM Ferruh Yigit wrote: > > KNI calls `get_user_pages_remote()` API which is using `FOLL_TOUCH` > flag, but `FOLL_TOUCH` is no more in public headers since v6.3, > causing a build error. Something looks strange with what kni was doing. Looking at get_user_pages_remote

Re: [PATCH v3 0/9] Testpmd code cleanup

2023-02-28 Thread Ferruh Yigit
On 2/20/2023 6:34 PM, David Marchand wrote: > Here is a series to reduce code duplication in testpmd. > > This work started from looking at Robin series on reporting lcore busy > cycles in telemetry, which is then added in testpmd [1]. > While looking at the forward engines code, I saw way too muc

Re: [PATCH v3 4/9] app/testpmd: fix packet transmission in noisy VNF engine

2023-02-28 Thread Ferruh Yigit
On 2/20/2023 6:34 PM, David Marchand wrote: > nb_rx relates to the number of packets received from the driver. > nb_tx is the total number of packets transmitted by this forward engine. > > Fix the retry stage, for dequeued packets, as it was incorrectly > passing nb_rx / nb_tx as bounds of the tm

Re: [PATCH v3 3/9] app/testpmd: rework ieee1588 engine fwd configuration

2023-02-28 Thread Ferruh Yigit
On 2/20/2023 6:34 PM, David Marchand wrote: > This fwd engine currently ignores the forwarding configuration. > Force it explicitly when initialising the stream. > The code is then more consistent with other fwd engines (i.e. receiving > on fs->rx_port, transmitting on fs->tx_port). > > Signed-off

Re: [RFC 1/2] eal: add bitset type

2023-02-28 Thread Tyler Retzlaff
On Tue, Feb 28, 2023 at 10:39:15AM +0100, Mattias Rönnblom wrote: > Introduce a set of functions and macros that operate on sets of bits, > kept in arrays of 64-bit elements. > > RTE bitset is designed for bitsets which are larger than what fits in > a single machine word (i.e., 64 bits). For very

Re: [PATCH v3 9/9] app/testpmd: factorize fwd engine Tx

2023-02-28 Thread Ferruh Yigit
On 2/20/2023 6:35 PM, David Marchand wrote: > Reduce code duplication by introducing a helper that takes care of > transmitting, retrying if enabled and incrementing tx counter. > inc_tx_burst_stats() is then unneeded and removed. > > Signed-off-by: David Marchand Reviewed-by: Ferruh Yigit

[PATCH] ethdev: remove telemetry Rx mbuf alloc failed field

2023-02-28 Thread Ferruh Yigit
'eth_dev->data->rx_mbuf_alloc_failed' field is not directly exposed to user via ethdev APIs but it is used internally to set "stats->rx_nombuf' which is exposed via ehtdev stat APIs. But telemetry exposes this field to user via "/ethdev/info", instead user can get 'rx_nombuf' value from stats via

RE: [PATCH v1] ethdev: remove bitfields from trace

2023-02-28 Thread Ali Alnubani
> -Original Message- > From: Ankur Dwivedi > Sent: Tuesday, February 28, 2023 5:55 PM > To: dev@dpdk.org > Cc: Ali Alnubani ; jer...@marvell.com; > ferruh.yi...@amd.com; Ankur Dwivedi > Subject: [PATCH v1] ethdev: remove bitfields from trace > > To capture bitfield variables in trace, th

[v2, 10/10] examples/fips_validation: add extra space in JSON buffer

2023-02-28 Thread Gowrishankar Muthukrishnan
Current test buffer to copy input data of maximum possible length did not account NULL character, due to which a last input character is always ignored and it causes tests like RSA SIGVER for modulo of 4096 bits to fail. This patch fixes it. Fixes: 0b65d54f3a4 ("examples/fips_validation: fix JSON

[v2, 09/10] examples/fips_validation: fix AES XTS to read seq number

2023-02-28 Thread Gowrishankar Muthukrishnan
Fix AES XTS test to read sequence number correctly. Fixes: f8e431ed8f6 ("examples/fips_validation: add parsing for AES-XTS") Signed-off-by: Gowrishankar Muthukrishnan --- examples/fips_validation/fips_validation_xts.c | 13 + 1 file changed, 9 insertions(+), 4 deletions(-) diff --g

[PATCH] kni: fix build with Linux 6.3

2023-02-28 Thread Ferruh Yigit
KNI calls `get_user_pages_remote()` API which is using `FOLL_TOUCH` flag, but `FOLL_TOUCH` is no more in public headers since v6.3, causing a build error. `FOLL_*` defines in Linux kernel first moved to another header [1], later some of them moved to memory subsystem internal header [2] for 6.3 Q

[v2, 08/10] examples/fips_validation: fix AES GCM validation tests

2023-02-28 Thread Gowrishankar Muthukrishnan
AES GCM validation tests fail in FIPS validation due to incorrect fields populated in response file. This patch fixes them. Fixes: 5b540bebac8e ("examples/fips_validation: fix GMAC decryption output") Signed-off-by: Gowrishankar Muthukrishnan --- examples/fips_validation/fips_validation_gcm.c |

[v2, 07/10] examples/fips_validation: add SHA3 algorithms in ECDSA test

2023-02-28 Thread Gowrishankar Muthukrishnan
Add SHA3 algorithms in ECDSA as supported. Signed-off-by: Gowrishankar Muthukrishnan --- examples/fips_validation/fips_validation_ecdsa.c | 4 1 file changed, 4 insertions(+) diff --git a/examples/fips_validation/fips_validation_ecdsa.c b/examples/fips_validation/fips_validation_ecdsa.c i

[v2, 06/10] examples/fips_validation: add ECDSA keygen support

2023-02-28 Thread Gowrishankar Muthukrishnan
Add support to validate ECDSA keygen mode tests. Signed-off-by: Gowrishankar Muthukrishnan --- .../fips_validation/fips_validation_ecdsa.c | 52 +++ examples/fips_validation/main.c | 13 + 2 files changed, 65 insertions(+) diff --git a/examples/fips_validatio

[v2, 05/10] examples/fips_validation: add CCM JSON validation

2023-02-28 Thread Gowrishankar Muthukrishnan
Add support in fips_validation to parse CCM JSON vectors. Signed-off-by: Gowrishankar Muthukrishnan --- doc/guides/sample_app_ug/fips_validation.rst | 1 + examples/fips_validation/fips_validation.c| 2 + examples/fips_validation/fips_validation.h| 3 + .../fips_validation/fips_va

[v2, 04/10] examples/fips_validation: add SHAKE validation

2023-02-28 Thread Gowrishankar Muthukrishnan
Add support in fips_validation to parse SHAKE algorithms. Signed-off-by: Gowrishankar Muthukrishnan --- v2: - fixed type punning reported in CI. --- doc/guides/sample_app_ug/fips_validation.rst | 1 + examples/fips_validation/fips_validation.h| 4 +- .../fips_validation/fips_validation_

[v2, 03/10] examples/fips_validation: fix integer parse in test case

2023-02-28 Thread Gowrishankar Muthukrishnan
Parsing integer value in test case vector does not store it because only string was expected. This patch adds handling for integer value as well. Fixes: 58cc98801eb ("examples/fips_validation: add JSON parsing") Signed-off-by: Gowrishankar Muthukrishnan --- examples/fips_validation/fips_validat

[v2, 02/10] examples/fips_validation: add SHA3 validation

2023-02-28 Thread Gowrishankar Muthukrishnan
Add support in fips_validation to parse SHA3 algorithms. Signed-off-by: Gowrishankar Muthukrishnan --- doc/guides/sample_app_ug/fips_validation.rst | 5 +- examples/fips_validation/fips_validation.h| 1 + .../fips_validation/fips_validation_hmac.c| 8 ++ .../fips_validation/fips_vali

[v2, 01/10] examples/fips_validation: fix MCT output for SHA

2023-02-28 Thread Gowrishankar Muthukrishnan
MCT test for SHA need not print message string along with digest value. Fixes: d5c247145c2 ("examples/fips_validation: add parsing for SHA") Signed-off-by: Gowrishankar Muthukrishnan --- examples/fips_validation/fips_validation_sha.c | 8 ++-- examples/fips_validation/main.c

[v2, 00/10] fips_validation application improvements

2023-02-28 Thread Gowrishankar Muthukrishnan
This patch series adds support for SHA3, SHAKE, AES-CCM JSON test vectors and fixes existing algorithms to support NIST test vectors. v2: - fixed type punning SHAKE test function. Gowrishankar Muthukrishnan (10): examples/fips_validation: fix MCT output for SHA examples/fips_validation: add

Re: [PATCH v2 0/2] configure RSS and handle metadata correctly

2023-02-28 Thread Ferruh Yigit
On 2/21/2023 3:55 AM, Chaoyong He wrote: > Select the appropriate RSS configuration in the initial process logic > and modify the logic of processing metadata based on RSS configuration > in the RX function. > > --- > v2: > * Correct spelling error > v3: > * Correct spelling error > --- > Long Wu

[Bug 1170] Link status is not correclty updated for E810 NIC (ice driver) on Windows

2023-02-28 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=1170 Bug ID: 1170 Summary: Link status is not correclty updated for E810 NIC (ice driver) on Windows Product: DPDK Version: 22.11 Hardware: All OS: Windows S

[PATCH 4/5] net/mlx5: support enhanced CQE zipping in vector Rx burst

2023-02-28 Thread Alexander Kozyrev
Add Enhanced CQE compression support to vectorized Rx burst routines. Adopt the same algorithm as scalar Rx burst routines have today. 1. Retrieve the validity_iteration_count from CQEs and use it to check if the CQE is ready to be processed instead of the owner_bit. 2. Do not invalidate reserved C

[PATCH 5/5] net/mlx5: enable enhanced CQE compression

2023-02-28 Thread Alexander Kozyrev
Extend rxq_cqe_comp_en devarg to allow the Enhanced CQE Compression layout to be enabled by a user. Setting the 8th bit turns it on. For example, rxq_cqe_comp_en=0x84 means the L3/L4 Header miniCQE format and the Enhanced CQE Compression layout. Enhanced CQE Compression can be enabled only if it is

[PATCH 2/5] common/mlx5: add CQE validity iteration count

2023-02-28 Thread Alexander Kozyrev
The validity iteration count replaces the functionality of the owner bit in terms of indicating that a new CQE was written to buffer. On iteration=k on the CQ buffer, only entries with the iteration_count=k should be treated as new CQEs or mini CQE arrays. The validity iteration count is used when

[PATCH 1/5] common/mlx5: detect enhanced CQE compression capability

2023-02-28 Thread Alexander Kozyrev
Enhanced CQE Compression is designed for better latency and SW utilization. Check the HCA capabilities to see if Enhanced CQE Compression is supported. Basic or Enhanced CQE Compression can be set as the CQE Compression Layout. Enhanced CQE Compression can be selected only if it is supported by the

[PATCH 3/5] net/mlx5: support enhanced CQE compression in Rx burst

2023-02-28 Thread Alexander Kozyrev
net/mlx5: support enhanced CQE compression Enhanced CQE compression changes the structure of the compression block and the number of miniCQEs per miniCQE array. Adapt to these changes in the datapath by defining a new parsing mechanism of a miniCQE array: 1. The title CQE is no longer marked as th

[PATCH 0/5] net/mlx5: enhanced CQE compression layout

2023-02-28 Thread Alexander Kozyrev
Support Enhanced CQE Compression Layout in mlx5 driver for better latency and SW utilization. Alexander Kozyrev (5): common/mlx5: detect enhanced CQE compression capability common/mlx5: add CQE validity iteration count net/mlx5: support enhanced CQE compression in Rx burst net/mlx5: suppor

Re: [PATCH v1] ethdev: remove bitfields from trace

2023-02-28 Thread Ferruh Yigit
On 2/28/2023 3:55 PM, Ankur Dwivedi wrote: > To capture bitfield variables in trace, the pointer to the structure > containing the bitfields was referenced. But during trace point > registration the pointer contains invalid address. Referencing this > invalid address causes segmentation fault. > >

Re: [EXT] Re: [PATCH v1 1/2] ethdev: fix null pointer dereference

2023-02-28 Thread Ferruh Yigit
On 2/28/2023 3:40 PM, Ankur Dwivedi wrote: >> -- >> On 2/23/2023 12:30 PM, Ankur Dwivedi wrote: >>> The speed_fec_capa pointer can be null. So dereferencing the pointer >>> is removed and only the pointer is captured in trace funct

RE: [EXT] Re: [PATCH v11 1/4] lib: add generic support for reading PMU events

2023-02-28 Thread Morten Brørup
> From: Morten Brørup > Sent: Tuesday, 28 February 2023 14.16 > > > From: Konstantin Ananyev [mailto:konstantin.anan...@huawei.com] > > Sent: Tuesday, 28 February 2023 13.05 > > > > > > > >> Add support for programming PMU counters and reading their values > in > > > > > >> runtime bypassing kerne

Re: [PATCH v7 18/21] net/cpfl: add HW statistics

2023-02-28 Thread Ferruh Yigit
On 2/28/2023 2:24 PM, Bruce Richardson wrote: > On Tue, Feb 28, 2023 at 01:34:43PM +, Ferruh Yigit wrote: >> On 2/28/2023 1:29 PM, Zhang, Qi Z wrote: >>> >>> -Original Message- From: Ferruh Yigit Sent: Tuesday, February 28, 2023 8:33 PM To: Richardson, Bruce C

Re: [EXT] Re: [PATCH v1 1/2] ethdev: fix null pointer dereference

2023-02-28 Thread Ferruh Yigit
On 2/28/2023 3:40 PM, Ankur Dwivedi wrote: >> -- >> On 2/23/2023 12:30 PM, Ankur Dwivedi wrote: >>> The speed_fec_capa pointer can be null. So dereferencing the pointer >>> is removed and only the pointer is captured in trace funct

RE: [RFC 0/2] Add high-performance timer facility

2023-02-28 Thread Morten Brørup
> From: Mattias Rönnblom [mailto:mattias.ronnb...@ericsson.com] > Sent: Tuesday, 28 February 2023 10.39 I have been looking for a high performance timer library (for use in a fast path TCP stack), and this looks very useful, Mattias. My initial feedback is based on quickly skimming the patch sou

[PATCH v1] ethdev: remove bitfields from trace

2023-02-28 Thread Ankur Dwivedi
To capture bitfield variables in trace, the pointer to the structure containing the bitfields was referenced. But during trace point registration the pointer contains invalid address. Referencing this invalid address causes segmentation fault. This patch removes the capture of bitfield variables i

Re: [EXT] Re: [v1, 00/10] fips_validation application improvements

2023-02-28 Thread Patrick Robb
Hi Akhil, One 2023 goal for UNH is implementing an email based retesting framework. Once that work is completed, you will be able to trigger a retest yourself under circumstances where waiting for dependent patches is needed. On Tue, Feb 28, 2023 at 10:02 AM Akhil Goyal wrote: > Hi Patrick, > >

RE: [EXT] Re: [PATCH v1 1/2] ethdev: fix null pointer dereference

2023-02-28 Thread Ankur Dwivedi
>-- >On 2/23/2023 12:30 PM, Ankur Dwivedi wrote: >> The speed_fec_capa pointer can be null. So dereferencing the pointer >> is removed and only the pointer is captured in trace function. >> Fixed few more trace functions in which n

RE: [PATCH v5 00/10] dts: add hello world testcase

2023-02-28 Thread Wathsala Wathawana Vithanage
From: Juraj Linkeš Sent: Monday, February 27, 2023 3:29 AM To: Wathsala Wathawana Vithanage Cc: tho...@monjalon.net; Honnappa Nagarahalli ; lijuan...@intel.com; bruce.richard...@intel.com; pr...@iol.unh.edu; dev@dpdk.org; nd Subject: Re: [PATCH v5 00/10] dts: add hello world testcase Hi Ju

RE: [EXT] Re: [v1, 00/10] fips_validation application improvements

2023-02-28 Thread Akhil Goyal
Hi Patrick, The issue reported by CI in below link is not an issue, as the patchset was dependent on another patch which is already merged. Now we are observing a new issue which is coming only on CentOS I believe. CI reports are not useful in case there are dependent patches. There should be a

Re: [PATCH v1 2/2] ethdev: pass structure pointer

2023-02-28 Thread Ferruh Yigit
On 2/23/2023 12:30 PM, Ankur Dwivedi wrote: > The rte_eth_xstat_name structure is of size 64 bytes. Instead of passing > the structure as value it is passed as a pointer, to avoid copy of 64 bytes > in function call stack. > > Signed-off-by: Ankur Dwivedi > --- > lib/ethdev/ethdev_trace.h | 4 ++

Re: [PATCH v1 1/2] ethdev: fix null pointer dereference

2023-02-28 Thread Ferruh Yigit
On 2/23/2023 12:30 PM, Ankur Dwivedi wrote: > The speed_fec_capa pointer can be null. So dereferencing the pointer is > removed and only the pointer is captured in trace function. > Fixed few more trace functions in which null pointer can be dereferenced. > > Coverity issue: 383238 > Bugzilla ID:

[PATCH] dma/idxd: add verbose option to config script

2023-02-28 Thread Bruce Richardson
In case there are issues when configuring a device instance using the dpdk_idxd_cfg.py script, add a "verbose" mode option to it. This allows the user to see what changes are being made, and therefore which operation, if any, within the config fails. Signed-off-by: Bruce Richardson --- drivers/d

Re: [v1, 00/10] fips_validation application improvements

2023-02-28 Thread Patrick Robb
Hello Akhil and Gowrishankar, We saw the same issue with running the fips sample app under CI testing here at the UNH Community Lab: http://mails.dpdk.org/archives/test-report/2023-February/350635.html. We reported a warn because it failed on the compilation stage (as opposed to a failure of the a

Re: [PATCH v7 18/21] net/cpfl: add HW statistics

2023-02-28 Thread Bruce Richardson
On Tue, Feb 28, 2023 at 01:34:43PM +, Ferruh Yigit wrote: > On 2/28/2023 1:29 PM, Zhang, Qi Z wrote: > > > > > >> -Original Message- > >> From: Ferruh Yigit > >> Sent: Tuesday, February 28, 2023 8:33 PM > >> To: Richardson, Bruce > >> Cc: Liu, Mingxia ; dev@dpdk.org; Xing, Beilei >

RE: [PATCH v7 18/21] net/cpfl: add HW statistics

2023-02-28 Thread Zhang, Qi Z
> -Original Message- > From: Ferruh Yigit > Sent: Tuesday, February 28, 2023 9:35 PM > To: Zhang, Qi Z ; Richardson, Bruce > > Cc: Liu, Mingxia ; dev@dpdk.org; Xing, Beilei > ; Zhang, Yuying ; Wu, > Jingjing > Subject: Re: [PATCH v7 18/21] net/cpfl: add HW statistics > > On 2/28/2023

Re: [PATCH v1 1/2] ethdev: fix null pointer dereference

2023-02-28 Thread Ferruh Yigit
On 2/28/2023 1:17 PM, Jerin Jacob wrote: > On Tue, Feb 28, 2023 at 6:16 PM Ferruh Yigit wrote: >> >> On 2/28/2023 11:29 AM, David Marchand wrote: >>> On Tue, Feb 28, 2023 at 12:05 PM Ferruh Yigit wrote: On 2/23/2023 12:30 PM, Ankur Dwivedi wrote: > The speed_fec_capa pointer can be

Re: [PATCH v7 18/21] net/cpfl: add HW statistics

2023-02-28 Thread Ferruh Yigit
On 2/28/2023 1:29 PM, Zhang, Qi Z wrote: > > >> -Original Message- >> From: Ferruh Yigit >> Sent: Tuesday, February 28, 2023 8:33 PM >> To: Richardson, Bruce >> Cc: Liu, Mingxia ; dev@dpdk.org; Xing, Beilei >> ; Zhang, Yuying ; Wu, >> Jingjing >> Subject: Re: [PATCH v7 18/21] net/cpfl:

RE: [PATCH v7 18/21] net/cpfl: add HW statistics

2023-02-28 Thread Zhang, Qi Z
> -Original Message- > From: Ferruh Yigit > Sent: Tuesday, February 28, 2023 8:33 PM > To: Richardson, Bruce > Cc: Liu, Mingxia ; dev@dpdk.org; Xing, Beilei > ; Zhang, Yuying ; Wu, > Jingjing > Subject: Re: [PATCH v7 18/21] net/cpfl: add HW statistics > > On 2/28/2023 12:24 PM, Ferruh

[Bug 1169] [vhost]VDPA example is aborting when VM starts

2023-02-28 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=1169 Bug ID: 1169 Summary: [vhost]VDPA example is aborting when VM starts Product: DPDK Version: 23.03 Hardware: All OS: All Status: UNCONFIRMED Severity: normal

[Bug 1167] apps segfault at startup in debug mode

2023-02-28 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=1167 Ferruh YIGIT (ferr...@gmail.com) changed: What|Removed |Added Ever confirmed|0 |1 Resolution|DUPLICATE

Re: [PATCH v1 1/2] ethdev: fix null pointer dereference

2023-02-28 Thread Jerin Jacob
On Tue, Feb 28, 2023 at 6:16 PM Ferruh Yigit wrote: > > On 2/28/2023 11:29 AM, David Marchand wrote: > > On Tue, Feb 28, 2023 at 12:05 PM Ferruh Yigit wrote: > >> > >> On 2/23/2023 12:30 PM, Ankur Dwivedi wrote: > >>> The speed_fec_capa pointer can be null. So dereferencing the pointer is > >>> r

RE: [EXT] Re: [PATCH v11 1/4] lib: add generic support for reading PMU events

2023-02-28 Thread Morten Brørup
> From: Konstantin Ananyev [mailto:konstantin.anan...@huawei.com] > Sent: Tuesday, 28 February 2023 13.05 > > > > > >> Add support for programming PMU counters and reading their values in > > > > >> runtime bypassing kernel completely. > > > > >> > > > > >> This is especially useful in cases where

Re: [PATCH v1 1/2] ethdev: fix null pointer dereference

2023-02-28 Thread Ferruh Yigit
On 2/28/2023 11:29 AM, David Marchand wrote: > On Tue, Feb 28, 2023 at 12:05 PM Ferruh Yigit wrote: >> >> On 2/23/2023 12:30 PM, Ankur Dwivedi wrote: >>> The speed_fec_capa pointer can be null. So dereferencing the pointer is >>> removed and only the pointer is captured in trace function. >>> Fixe

Re: [PATCH v7 18/21] net/cpfl: add HW statistics

2023-02-28 Thread Ferruh Yigit
On 2/28/2023 12:24 PM, Ferruh Yigit wrote: > On 2/28/2023 12:12 PM, Bruce Richardson wrote: >> On Tue, Feb 28, 2023 at 12:04:53PM +, Ferruh Yigit wrote: >>> On 2/28/2023 11:47 AM, Liu, Mingxia wrote: >>> >>> Comment moved down, please don't top post, it makes very hard to follow >>> discussion.

Re: [PATCH v7 18/21] net/cpfl: add HW statistics

2023-02-28 Thread Ferruh Yigit
On 2/28/2023 12:12 PM, Bruce Richardson wrote: > On Tue, Feb 28, 2023 at 12:04:53PM +, Ferruh Yigit wrote: >> On 2/28/2023 11:47 AM, Liu, Mingxia wrote: >> >> Comment moved down, please don't top post, it makes very hard to follow >> discussion. >> -Original Message- From: Ferruh Y

Re: [PATCH v7 18/21] net/cpfl: add HW statistics

2023-02-28 Thread Bruce Richardson
On Tue, Feb 28, 2023 at 12:04:53PM +, Ferruh Yigit wrote: > On 2/28/2023 11:47 AM, Liu, Mingxia wrote: > > Comment moved down, please don't top post, it makes very hard to follow > discussion. > > >> -Original Message- From: Ferruh Yigit > >> Sent: Tuesday, February 28, 2023 6:02 PM

Re: [PATCH v7 18/21] net/cpfl: add HW statistics

2023-02-28 Thread Ferruh Yigit
On 2/28/2023 11:47 AM, Liu, Mingxia wrote: Comment moved down, please don't top post, it makes very hard to follow discussion. >> -Original Message- >> From: Ferruh Yigit >> Sent: Tuesday, February 28, 2023 6:02 PM >> To: Liu, Mingxia ; dev@dpdk.org; Xing, Beilei >> ; Zhang, Yuying >> S

RE: [EXT] Re: [PATCH v11 1/4] lib: add generic support for reading PMU events

2023-02-28 Thread Konstantin Ananyev
> > > >> Add support for programming PMU counters and reading their values in > > > >> runtime bypassing kernel completely. > > > >> > > > >> This is especially useful in cases where CPU cores are isolated i.e > > > >> run dedicated tasks. In such cases one cannot use standard perf > > > >> utilit

RE: [EXT] Re: [PATCH v11 1/4] lib: add generic support for reading PMU events

2023-02-28 Thread Konstantin Ananyev
> >> >> Add support for programming PMU counters and reading their values > >> >> in runtime bypassing kernel completely. > >> >> > >> >> This is especially useful in cases where CPU cores are isolated i.e > >> >> run dedicated tasks. In such cases one cannot use standard perf > >> >> utility wit

RE: [PATCH v7 18/21] net/cpfl: add HW statistics

2023-02-28 Thread Liu, Mingxia
OK, got it. As our previous design did have flaws. And if we don't want to affect correctness of telemetry, we have to redesign the idpf common module code, which means a lot of work to do, so can we lower the priority of this issue? Thanks, BR, mingxia > -Original Message- > From: Ferru

RE: [EXT] Re: [PATCH v11 1/4] lib: add generic support for reading PMU events

2023-02-28 Thread Konstantin Ananyev
> >> diff --git a/lib/pmu/rte_pmu.h b/lib/pmu/rte_pmu.h new file > >> mode > >> 100644 index 00..6b664c3336 > >> --- /dev/null > >> +++ b/lib/pmu/rte_pmu.h > >> @@ -0,0 +1,212 @@ > >> +/* SPDX-License-Identifier: BSD-3-Clause > >

Re: [PATCH v7 12/21] net/cpfl: support RSS

2023-02-28 Thread Ferruh Yigit
On 2/28/2023 11:28 AM, Liu, Mingxia wrote: > > >> -Original Message- >> From: Ferruh Yigit >> Sent: Tuesday, February 28, 2023 5:50 AM >> To: Liu, Mingxia ; dev@dpdk.org; Xing, Beilei >> ; Zhang, Yuying >> Subject: Re: [PATCH v7 12/21] net/cpfl: support RSS >> >> On 2/16/2023 12:30 AM,

Re: [PATCH v7 01/21] net/cpfl: support device initialization

2023-02-28 Thread Ferruh Yigit
On 2/28/2023 11:12 AM, Liu, Mingxia wrote: >>> + >>> +To get better performance on Intel platforms, please follow the >>> +:doc:`../linux_gsg/nic_perf_intel_platform`. >>> + >>> + >>> +Pre-Installation Configuration >>> +-- >>> + >>> +Runtime Config Options >>> +

RE: [PATCH v7 11/21] net/cpfl: support write back based on ITR expire

2023-02-28 Thread Liu, Mingxia
Ok, more commit msg will be given next version. > -Original Message- > From: Ferruh Yigit > Sent: Tuesday, February 28, 2023 5:50 AM > To: Liu, Mingxia ; Xing, Beilei > ; > Zhang, Yuying > Cc: dev@dpdk.org > Subject: Re: [PATCH v7 11/21] net/cpfl: support write back based on ITR expire

Re: [PATCH v1 1/2] ethdev: fix null pointer dereference

2023-02-28 Thread David Marchand
On Tue, Feb 28, 2023 at 12:05 PM Ferruh Yigit wrote: > > On 2/23/2023 12:30 PM, Ankur Dwivedi wrote: > > The speed_fec_capa pointer can be null. So dereferencing the pointer is > > removed and only the pointer is captured in trace function. > > Fixed few more trace functions in which null pointer

RE: [PATCH v7 12/21] net/cpfl: support RSS

2023-02-28 Thread Liu, Mingxia
> -Original Message- > From: Ferruh Yigit > Sent: Tuesday, February 28, 2023 5:50 AM > To: Liu, Mingxia ; dev@dpdk.org; Xing, Beilei > ; Zhang, Yuying > Subject: Re: [PATCH v7 12/21] net/cpfl: support RSS > > On 2/16/2023 12:30 AM, Mingxia Liu wrote: > > Add RSS support. > > > > Signed

[Bug 1167] apps segfault at startup in debug mode

2023-02-28 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=1167 Ferruh YIGIT (ferr...@gmail.com) changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|--

RE: [PATCH v7 01/21] net/cpfl: support device initialization

2023-02-28 Thread Liu, Mingxia
> -Original Message- > From: Ferruh Yigit > Sent: Tuesday, February 28, 2023 5:44 AM > To: Liu, Mingxia ; Xing, Beilei > ; > Zhang, Yuying > Cc: dev@dpdk.org; Yigit, Ferruh > Subject: Re: [PATCH v7 01/21] net/cpfl: support device initialization > > On 2/16/2023 12:29 AM, Mingxia Liu

Re: [PATCH v1 1/2] ethdev: fix null pointer dereference

2023-02-28 Thread Ferruh Yigit
On 2/23/2023 12:30 PM, Ankur Dwivedi wrote: > The speed_fec_capa pointer can be null. So dereferencing the pointer is > removed and only the pointer is captured in trace function. > Fixed few more trace functions in which null pointer can be dereferenced. > > Coverity issue: 383238 > Bugzilla ID:

Re: [PATCH v2 1/2] net/nfp: standardize the use of RSS-related codes

2023-02-28 Thread Ferruh Yigit
On 2/28/2023 8:46 AM, Chaoyong He wrote: >> On 2/21/2023 3:55 AM, Chaoyong He wrote: >>> From: Long Wu >>> >>> The usage of RTE_ETH_MQ_RX_RSS and RTE_ETH_MQ_RX_RSS_FLAG are >> mixed in >>> nfp_net_configure(), use RTE_ETH_MQ_RX_RSS_FLAG uniformly. >>> >>> Signed-off-by: Long Wu >>> Reviewed-by: C

[PATCH] crypto/openssl: support SM3/SM4 in openssl

2023-02-28 Thread Sunyang Wu
Added SM3 support in openssl, and added SM4-EBC/ SM4-CBC/SM4-CTR support in openssl. Signed-off-by: Sunyang Wu --- doc/guides/cryptodevs/features/openssl.ini | 4 + doc/guides/cryptodevs/openssl.rst| 4 + drivers/crypto/openssl/rte_openssl_pmd.c | 20 + drivers/crypto/ope

Re: [PATCH v7 03/21] net/cpfl: add Rx queue setup

2023-02-28 Thread Ferruh Yigit
On 2/28/2023 3:03 AM, Liu, Mingxia wrote: > Thanks or your comments, we will use enums to differentiate queues. > > As for 'bufq1'&'bufq2', they are members of struct idpf_rx_queue, defined in > idpf commen module, > And it involves idpf pmd code, so it's better to improve it in the later > fixe

Re: [PATCH v7 18/21] net/cpfl: add HW statistics

2023-02-28 Thread Ferruh Yigit
On 2/28/2023 6:46 AM, Liu, Mingxia wrote: > > >> -Original Message- >> From: Ferruh Yigit >> Sent: Tuesday, February 28, 2023 5:52 AM >> To: Liu, Mingxia ; dev@dpdk.org; Xing, Beilei >> ; Zhang, Yuying >> Subject: Re: [PATCH v7 18/21] net/cpfl: add HW statistics >> >> On 2/16/2023 12:30

RE: [EXT] Re: [PATCH v11 1/4] lib: add generic support for reading PMU events

2023-02-28 Thread Tomasz Duszynski
>-Original Message- >From: Konstantin Ananyev >Sent: Monday, February 27, 2023 9:53 PM >To: Tomasz Duszynski ; Konstantin Ananyev >; >dev@dpdk.org >Subject: RE: [EXT] Re: [PATCH v11 1/4] lib: add generic support for reading >PMU events > > > >> >> Add support for programming PMU counte

Re: [PATCH v7 01/21] net/cpfl: support device initialization

2023-02-28 Thread Ferruh Yigit
On 2/28/2023 2:06 AM, Liu, Mingxia wrote: > Thanks you all! > It's a good question, but as it is experimental version and rc2 is > approaching, > we won't optimize this function now, and will do it at the time of the > official product release. > Hi Mingxia, The discussion is not specific to t

  1   2   >