On Tue, Feb 28, 2023 at 6:29 PM Ferruh Yigit <ferruh.yi...@amd.com> wrote: > > KNI calls `get_user_pages_remote()` API which is using `FOLL_TOUCH` > flag, but `FOLL_TOUCH` is no more in public headers since v6.3, > causing a build error.
Something looks strange with what kni was doing. Looking at get_user_pages_remote implementation, I see it internally passes FOLL_TOUCH in addition to passed gup_flags. And looking at FOLL_TOUCH definition, it seems natural (to me) that this flag would be handled internally. Maybe it changed over time... but then the question is when did passing FOLL_TOUCH become unneeded? Thanks. -- David Marchand