Re: [PATCH v1 1/2] ethdev: fix null pointer dereference

[Ferruh Yigit]

On 2/23/2023 12:30 PM, Ankur Dwivedi wrote:
> The speed_fec_capa pointer can be null. So dereferencing the pointer is
> removed and only the pointer is captured in trace function.
> Fixed few more trace functions in which null pointer can be dereferenced.
> 
> Coverity issue: 383238
> Bugzilla ID: 1162
> Fixes: 6679cf21d608 ("ethdev: add trace points")
> Fixes: ed04fd4072e9 ("ethdev: add trace points for flow")
> 
> Signed-off-by: Ankur Dwivedi <adwiv...@marvell.com>

Hi Ankur,

There is another bug report: https://bugs.dpdk.org/show_bug.cgi?id=1167


As far as I can see that is caused by '__rte_trace_point_register()' is
calling 'register_fn()' [1].

At registering trace point stage, most of the pointers can be invalid,
and this can crash other locations too.

Why 'register_fn()' called withing the trace point register? Can we
remove it?





[1]
#define RTE_TRACE_POINT_REGISTER(trace, name)
        RTE_INIT(trace##_init)
                __rte_trace_point_register(..., (void (*)(void)) trace);

__rte_trace_point_register(handle, name, void (*register_fn)(void)) {
        ...
        register_fn();
        ...
}