> Subject: Re: no printf in drivers code
>
> On Fri, Feb 3, 2023 at 5:40 PM Thomas Monjalon
> wrote:
> >
> > 03/02/2023 17:18, Honnappa Nagarahalli:
> > > From: Thomas Monjalon
> > > >
> > > > We have too many drivers using printf() instead of rte_log().
> > > > Please propose a plan to replac
在 2023/2/3 20:58, Ferruh Yigit 写道:
On 2/3/2023 1:56 AM, lihuisong (C) wrote:
在 2023/2/3 5:10, Thomas Monjalon 写道:
02/02/2023 19:09, Ferruh Yigit:
On 2/2/2023 12:36 PM, Huisong Li wrote:
The dev->data->mac_addrs[0] will be changed to a new MAC address when
applications modify the default MAC
> From: Thomas Monjalon
>
> Hello,
>
> We have too many drivers using printf() instead of rte_log().
> Please propose a plan to replace or remove the calls to printf().
> If no plan, I could propose one but you may not like it :)
>
> Affected drivers are:
> baseband/acc
Will push a pat
On Fri, Feb 03, 2023 at 12:05:04PM +, Bruce Richardson wrote:
> On Thu, Feb 02, 2023 at 10:26:48PM +0100, Morten Brørup wrote:
> > > From: Thomas Monjalon [mailto:tho...@monjalon.net]
> > > Sent: Thursday, 2 February 2023 21.45
> > >
> > > 02/02/2023 21:26, Tyler Retzlaff:
> > > > On Thu, Feb
03/02/2023 21:26, Stephen Hemminger:
> On Fri, 03 Feb 2023 21:18:40 +0100
> Thomas Monjalon wrote:
>
> > 03/02/2023 18:33, Stephen Hemminger:
> > > On Fri, 03 Feb 2023 09:42:45 +0100
> > > Thomas Monjalon wrote:
> > >
> > > > 03/02/2023 01:25, Stephen Hemminger:
> > > > > On Wed, 1 Feb 2023
On Fri, Feb 03, 2023 at 12:19:13PM +, Bruce Richardson wrote:
> On Thu, Feb 02, 2023 at 11:00:23AM -0800, Tyler Retzlaff wrote:
> > On Thu, Feb 02, 2023 at 09:43:58AM +0100, Morten Brørup wrote:
> > > > From: Tyler Retzlaff [mailto:roret...@linux.microsoft.com]
> > > > Sent: Wednesday, 1 Februa
On Fri, 03 Feb 2023 21:18:40 +0100
Thomas Monjalon wrote:
> 03/02/2023 18:33, Stephen Hemminger:
> > On Fri, 03 Feb 2023 09:42:45 +0100
> > Thomas Monjalon wrote:
> >
> > > 03/02/2023 01:25, Stephen Hemminger:
> > > > On Wed, 1 Feb 2023 13:34:41 +
> > > > Shivah Shankar Shankar Narayan
03/02/2023 18:33, Stephen Hemminger:
> On Fri, 03 Feb 2023 09:42:45 +0100
> Thomas Monjalon wrote:
>
> > 03/02/2023 01:25, Stephen Hemminger:
> > > On Wed, 1 Feb 2023 13:34:41 +
> > > Shivah Shankar Shankar Narayan Rao wrote:
> > >
> > > > --- a/lib/eal/include/rte_log.h
> > > > +++ b/lib
Add pipeline support for the Receive Side Scaling (RSS) hashing. While
the pipeline already supports the stateless hashing schemes, the RSS
scheme uses a key configured by the control plane and preserved
between successive RSS hash invocations.
Signed-off-by: Cristian Dumitrescu
Signed-off-by: Ka
Do a clean shutdown of testpmd when a signal is received; instead of
having testpmd kill itself. This fixes the problem where a signal could
be received in the middle of a PMD and then the signal handler would
call PMD's close routine leading to locking problems.
The cmdline structure no longer n
If end of file is reached on input, then cmdline_poll() will
return 1 (ie file has something); and then the cmdline_in()
call to read will return 0. With the existing code,
caller has no way to tell that end of file has been reached
and will retry forever.
A good way to handle this is to make end
The function cmdline_poll() returns values from rdline_status enum
but that was moved to being defined only in cmdline_private.h.
For proper use of the API the return value needs to be visible
to callers. This was not a problem before because cmdline_poll()
was not used anywhere.
Fixes: f8f8dc289
This patchset keeps uncovering bad practices in the cmdline library
around end of file and signal handling.
Stephen Hemminger (3):
cmdline: make rdline status not private
cmdline: handle EOF in cmdline_poll
testpmd: cleanup cleanly from signal
app/test-pmd/cmdline.c| 29 +--
On 2/3/2023 7:57 AM, Chaoyong He wrote:
> This patch series is aimed to allow the DPDK app to deal with
> the error as necessary, by:
> * Remove the usage of rte_panic()
> * Remove the usage of ASSERT()
>
> James Hershaw (3):
> net/nfp: remove panic usage during reconfig
> net/nfp: remove pani
On 2/2/2023 10:00 AM, Rongwei Liu wrote:
> Support IPv6 routing extension header matching with new rte_flow item.
> Add encapsulation support for IPv6 routing extension header.
>
> v6: use non doxgen style comments for 'segments'.
> v5: remove flex array 'segments'.
> v4: use flex array to define
On Fri, Feb 3, 2023 at 5:40 PM Thomas Monjalon wrote:
>
> 03/02/2023 17:18, Honnappa Nagarahalli:
> > From: Thomas Monjalon
> > >
> > > We have too many drivers using printf() instead of rte_log().
> > > Please propose a plan to replace or remove the calls to printf().
> > > If no plan, I could p
On Fri, Feb 03, 2023 at 11:45:04AM -0500, Ben Magistro wrote:
>In our case we have other libraries that we are using that have
>required us to specify a minimum c++ version (14/17 most recently for
>one) so it doesn't feel like a big ask/issue to us (provided things
>don't start con
On Tue, 6 Dec 2022 10:05:09 -0500
Mike Pattrick wrote:
> +
> +static __rte_always_inline void
> +mem_set_dump(__rte_unused void *ptr, __rte_unused size_t size, __rte_unused
> bool enable)
> +{
> +#ifdef MADV_DONTDUMP
> + if (madvise(ptr, size, enable ? MADV_DODUMP : MADV_DONTDUMP) == -1) {
On 11/24/2022 7:33 AM, Junfeng Guo wrote:
> Add support for dev_ops of stats_get and stats_reset.
>
> Queue stats update will be moved into xstat [1], but the basic stats
> items may still be required. So we just keep the remaining ones and
> will implement the queue stats via xstats in the coming
On Fri, 03 Feb 2023 09:42:45 +0100
Thomas Monjalon wrote:
> 03/02/2023 01:25, Stephen Hemminger:
> > On Wed, 1 Feb 2023 13:34:41 +
> > Shivah Shankar Shankar Narayan Rao wrote:
> >
> > > --- a/lib/eal/include/rte_log.h
> > > +++ b/lib/eal/include/rte_log.h
> > > @@ -48,6 +48,7 @@ extern "
On Fri, Feb 03, 2023 at 04:35:14PM +, Conor Walsh wrote:
> rte_log should be used instead of printf within the drivers this patch
> changes a printf within the ioat dma driver's start function to an rte log.
> The printfs within ioat's dump function will be retained.
>
> Signed-off-by: Conor W
From: Thomas Monjalon
The flow item structure includes the protocol definition
from the directory lib/net/, so it is reflected in the guide.
Section title underlining is also fixed around.
Fixes: 3a929df1f286 ("ethdev: support L2TPv2 and PPP procotol")
Cc: sta...@dpdk.org
Signed-off-by: Thomas
From: Thomas Monjalon
Some protocols (ARP, MPLS and HIGIG2) were using uint16_t and uint32_t
types for their 16 and 32-bit fields.
It was correct but not conveying the big endian nature of these fields.
As for other protocols defined in this directory,
all types are explicitly marked as big endi
From: Thomas Monjalon
As announced in the deprecation notice, flow item structures
should re-use the protocol header definitions from the directory lib/net/.
The protocol struct is added in an unnamed union, keeping old field names.
The ARP header struct members are used in testpmd
instead of t
From: Thomas Monjalon
As announced in the deprecation notice, flow item structures
should re-use the protocol header definitions from the directory lib/net/.
In the case of VXLAN-GPE, the protocol struct is added
in an unnamed union, keeping old field names.
The VXLAN headers (including VXLAN-G
From: Thomas Monjalon
As announced in the deprecation notice, flow item structures
should re-use the protocol header definitions from the directory lib/net/.
The protocol struct is added in an unnamed union, keeping old field names.
The GTP header struct members are used in apps and drivers
ins
From: Thomas Monjalon
The VXLAN and VXLAN-GPE headers were including reserved fields
with other fields in big uint32_t struct members.
Some more precise definitions are added as union of the old ones.
The new struct members are smaller in size and in names.
Signed-off-by: Thomas Monjalon
Acke
From: Thomas Monjalon
As announced in the deprecation notice, flow item structures
should re-use the protocol header definitions from the directory lib/net/.
The Ethernet headers (including VLAN) structures are used
instead of the redundant fields in the flow items.
The remaining protocols to cl
There was a plan to have structures from lib/net/ at the beginning
of corresponding flow item structures.
Unfortunately this plan has not been followed up so far.
This series is a step to make the most used items,
compliant with the inheritance design explained above.
The old API is kept in anonymo
In our case we have other libraries that we are using that have required us
to specify a minimum c++ version (14/17 most recently for one) so it
doesn't feel like a big ask/issue to us (provided things don't start
conflicting...hah; not anticipating any issue). Our software is also used
internally
03/02/2023 17:18, Honnappa Nagarahalli:
> From: Thomas Monjalon
> >
> > We have too many drivers using printf() instead of rte_log().
> > Please propose a plan to replace or remove the calls to printf().
> > If no plan, I could propose one but you may not like it :)
>
> Does it make sense to add
> Hello,
>
> We have too many drivers using printf() instead of rte_log().
> Please propose a plan to replace or remove the calls to printf().
> If no plan, I could propose one but you may not like it :)
>
> Affected drivers are:
> baseband/acc
> bus/dpaa
> bus/fslmc
> cry
rte_log should be used instead of printf within the drivers this patch
changes a printf within the ioat dma driver's start function to an rte log.
The printfs within ioat's dump function will be retained.
Signed-off-by: Conor Walsh
---
drivers/dma/ioat/ioat_dmadev.c | 6 +++---
1 file changed, 3
> -Original Message-
> From: Thomas Monjalon
> Sent: Friday, February 3, 2023 7:57 AM
> To: Nicolas Chautru ; hemant.agra...@nxp.com;
> Sachin Saxena ; Gagandeep Singh
> ; Sunil Uttarwar ;
> Bruce Richardson ; Conor Walsh
> ; Chaoyong He ; Niklas
> Soderlund ; Rasesh Mody
> ; Devendra S
> -Original Message-
> From: Thomas Monjalon
> Sent: Friday, February 3, 2023 3:16 PM
> To: David Marchand ; Van Haaren, Harry
>
> Cc: dev@dpdk.org; dpdk...@iol.unh.edu; c...@dpdk.org;
> honnappa.nagaraha...@arm.com; mattias.ronnblom
> ; Morten Brørup
> ; Tyler Retzlaff ;
> Aaron Conole
03/02/2023 16:03, Van Haaren, Harry:
> From: Van Haaren, Harry
> > > The timeout approach just does not have its place in a functional test.
> > > Either this test is rewritten, or it must go to the performance tests
> > > list so that we stop getting false positives.
> > > Can you work on this?
>
On 2/3/2023 3:12 PM, Thomas Monjalon wrote:
> 03/02/2023 16:02, Ferruh Yigit:
>> On 2/2/2023 5:16 PM, Thomas Monjalon wrote:
>>> 02/02/2023 13:44, Ferruh Yigit:
--- a/lib/net/rte_gre.h
+++ b/lib/net/rte_gre.h
@@ -28,6 +28,8 @@ extern "C" {
*/
__extension__
struct r
On Fri, Feb 03, 2023 at 03:03:38PM +, Van Haaren, Harry wrote:
> > -Original Message-
> > From: Van Haaren, Harry
> > Sent: Tuesday, January 31, 2023 5:25 PM
> > To: David Marchand
> > Cc: dev@dpdk.org; dpdk...@iol.unh.edu; c...@dpdk.org;
> > honnappa.nagaraha...@arm.com; mattias.ronnb
03/02/2023 16:02, Ferruh Yigit:
> On 2/2/2023 5:16 PM, Thomas Monjalon wrote:
> > 02/02/2023 13:44, Ferruh Yigit:
> >> --- a/lib/net/rte_gre.h
> >> +++ b/lib/net/rte_gre.h
> >> @@ -28,6 +28,8 @@ extern "C" {
> >> */
> >> __extension__
> >> struct rte_gre_hdr {
> >> + union {
> >> +
On Fri, Feb 03, 2023 at 09:09:14AM -0500, Ben Magistro wrote:
>Since this topic keeps coming up in other threads I'll chime in with my
>$0.01 here. We've been using CentOS 7 for awhile (and working on
>migrating off) but have had to leverage devtoolset/llvmtoolset for
>various reas
> -Original Message-
> From: Van Haaren, Harry
> Sent: Tuesday, January 31, 2023 5:25 PM
> To: David Marchand
> Cc: dev@dpdk.org; dpdk...@iol.unh.edu; c...@dpdk.org;
> honnappa.nagaraha...@arm.com; mattias.ronnblom
> ; tho...@monjalon.net; Morten Brørup
> ; Tyler Retzlaff ;
> Aaron Conole
On 2/2/2023 5:20 PM, Thomas Monjalon wrote:
> 02/02/2023 13:45, Ferruh Yigit:
>> --- a/lib/ethdev/rte_flow.h
>> +++ b/lib/ethdev/rte_flow.h
>> @@ -642,8 +642,8 @@ struct rte_flow_item_higig2_hdr {
>> static const struct rte_flow_item_higig2_hdr rte_flow_item_higig2_hdr_mask
>> = {
>> .hdr =
On 2/2/2023 5:16 PM, Thomas Monjalon wrote:
> 02/02/2023 13:44, Ferruh Yigit:
>> --- a/lib/net/rte_gre.h
>> +++ b/lib/net/rte_gre.h
>> @@ -28,6 +28,8 @@ extern "C" {
>> */
>> __extension__
>> struct rte_gre_hdr {
>> + union {
>> + struct {
>> #if RTE_BYTE_ORDER == RTE_LITTL
On 1/13/23 03:56, Cheng Jiang wrote:
To improve the performance of async vhost packed ring. We remove the
unnecessary data copy in async vhost packed ring. And add the batch
data path in both enqueue data path and dequeue data path.
v2: fixed net header settings.
Cheng Jiang (3):
vhost: r
On 1/19/23 13:30, Chengwen Feng wrote:
This patch addes private dump for vhost and virtio PMDs.
Chengwen Feng (2):
net/virtio: support private dump
net/vhost: support private dump
drivers/net/vhost/rte_eth_vhost.c | 21 +
drivers/net/virtio/virtio_ethdev.c | 19
On 1/4/23 03:39, Wenwu Ma wrote:
In vhost sync batch enqueue, the "num_buffers" of
virtio net header is not be set, but it should be
set to 1 if the mrg_rxbuf feature is turned on,
This patch fix the issue.
Fixes: ef861692c398 ("vhost: add packed ring batch enqueue")
Cc: sta...@dpdk.org
Sign
On 12/15/22 04:48, Abhishek Maheshwari wrote:
Amending the match table for vdpa/ifcvf driver to work with virtio-blk
devices that have default subsystem IDs.
Cc: sta...@dpdk.org
Signed-off-by: Abhishek Maheshwari
---
v3:
* Removing match with ANY_IDs
* Adding support for only default subsy
On 12/14/22 08:47, Andy Pei wrote:
When we use "sw-live-migration=1" in arguments, we run in SW assisted
live migration mode.
In SW assisted live migration mode, driver will stop the device and
setup a mediated virtio ring to relay the communication between the
virtio driver and the VDPA devi
On 12/13/22 08:37, Andy Pei wrote:
For block device, we make sure no IO is inflight before we
stop device. We terminate the notify relay process and wait
for all inflight IOs to be completed. So in this period, we
wait for hardware to update used index, there is no need to
relay new kick.
Sig
On 12/12/22 08:12, Andy Pei wrote:
In the case using argument "sw-live-migration=1" to enable SW assisted live
migration, we take QEMU as front end for example, after source VM migrates
to destination VM, we keep vdpa process for source VM there, we kill the
QEMU process for source VM, and res
On 12/7/22 17:54, Mike Pattrick wrote:
Currently if an application wants to include shared hugepages in
coredumps in conjunction with the vhost library, the coredump will be
larger than expected and include unneeded virtual machine memory.
This patch will mark all vhost huge pages as DONTDUMP
On 12/1/22 08:32, Andy Pei wrote:
"sw_fallback_lm=0" means driver does not provide live migration assistance.
so hardware assistance is needed to support live migration.
However registers for live migration in BAR4 are not implemented.
In the case, we just return error after display some logs.
On 11/14/22 04:04, Hao Chen wrote:
When we run dpdk vdpa in the nested virtual machine vm-L1 and ping
test in vm-L2, the ping is not good. The reason for troubleshooting is
that the virtio net in vm-L2 sends control information to the vring,
and the qemu back-end device in vm-L1 cannot obtain
On 1/4/23 03:39, Wenwu Ma wrote:
In vhost sync batch enqueue, the "num_buffers" of
virtio net header is not be set, but it should be
set to 1 if the mrg_rxbuf feature is turned on,
This patch fix the issue.
Fixes: ef861692c398 ("vhost: add packed ring batch enqueue")
Cc: sta...@dpdk.org
Sign
Just to close the loop on this, most of our nics have been dual port. When
looking at this I forgot/didn't realize this one was a quad port nic so
some ports were still controlled by the kernel which explains the observed
behavior. Also thanks for the explanation around an existing DDP being
foun
> From: Bruce Richardson [mailto:bruce.richard...@intel.com]
> Sent: Friday, 3 February 2023 14.57
>
> Having read through the whole thread a second time, I am starting to
> realise how complex a problem this could be. From what I read, I would
> tend
> towards the opinion that we shouldn't provid
Since this topic keeps coming up in other threads I'll chime in with my
$0.01 here. We've been using CentOS 7 for awhile (and working on migrating
off) but have had to leverage devtoolset/llvmtoolset for various reasons.
I remember a discussion of installing a different compiler coming up but
don'
Hello,
We have too many drivers using printf() instead of rte_log().
Please propose a plan to replace or remove the calls to printf().
If no plan, I could propose one but you may not like it :)
Affected drivers are:
baseband/acc
bus/dpaa
bus/fslmc
crypto/caam_jr
On Thu, Feb 02, 2023 at 09:44:52PM +0100, Morten Brørup wrote:
> > From: Tyler Retzlaff [mailto:roret...@linux.microsoft.com]
> > Sent: Thursday, 2 February 2023 20.00
> >
> > On Thu, Feb 02, 2023 at 09:43:58AM +0100, Morten Brørup wrote:
> > > > From: Tyler Retzlaff [mailto:roret...@linux.microso
When multiple physical ports are connected to a single DPDK port,
(example: kernel bonding, DPDK bonding, failsafe, etc.),
we want to know which physical port is used for Rx and Tx.
This patch allows to map a Rx queue with a physical port by using
a flow rule. The new item is called RTE_FLOW_ITEM_
When multiple physical ports are connected to a single DPDK port,
(example: kernel bonding, DPDK bonding, failsafe, etc.),
we want to know which physical port is used for Rx and Tx.
This patch maps a DPDK Tx queue with a physical port,
by adding tx_phy_affinity setting in Tx queue.
The affinity nu
When multiple physical ports are connected to a single DPDK port,
(example: kernel bonding, DPDK bonding, failsafe, etc.),
we want to know which physical port is used for Rx and Tx.
This patch maps a DPDK Tx queue with a physical port,
by adding tx_phy_affinity setting in Tx queue.
The affinity nu
The option RTE_LIBRTE_IEEE1588 has no effect on any library
unlike its name.
Also we are suppose to enable/disable features dynamically,
not at compilation time.
And the best is that this macro is neither documented,
nor in rte_config.h.
It looks to be a mistake keeping this flag, so it is remov
On 2/3/2023 1:56 AM, lihuisong (C) wrote:
>
> 在 2023/2/3 5:10, Thomas Monjalon 写道:
>> 02/02/2023 19:09, Ferruh Yigit:
>>> On 2/2/2023 12:36 PM, Huisong Li wrote:
The dev->data->mac_addrs[0] will be changed to a new MAC address when
applications modify the default MAC address by .mac_addr
Release status meeting minutes 2023-02-02
=
Agenda:
* Release Dates
* Subtrees
* Roadmaps
* LTS
* Defects
* Opens
Participants:
* AMD
* ARM
* Intel
* Nvidia
* Red Hat
Release Dates
-
The following are the proposed current dates for 23.03:
On Thu, Feb 02, 2023 at 11:00:23AM -0800, Tyler Retzlaff wrote:
> On Thu, Feb 02, 2023 at 09:43:58AM +0100, Morten Brørup wrote:
> > > From: Tyler Retzlaff [mailto:roret...@linux.microsoft.com]
> > > Sent: Wednesday, 1 February 2023 22.41
> > >
> > > On Wed, Feb 01, 2023 at 01:07:59AM +, Honna
On Thu, Feb 02, 2023 at 10:26:48PM +0100, Morten Brørup wrote:
> > From: Thomas Monjalon [mailto:tho...@monjalon.net]
> > Sent: Thursday, 2 February 2023 21.45
> >
> > 02/02/2023 21:26, Tyler Retzlaff:
> > > On Thu, Feb 02, 2023 at 02:23:39PM -0500, Ben Magistro wrote:
> > > > Hello,
> > > >
> > >
On 1/17/23 23:36, Nicolas Chautru wrote:
In this serie we are renaming the ACC200PMD to a more generic
VRB PMD (Intel vRAN Boost). The 2nd commit is also making sure this
is future prood to be able to support both the first implementation
of VRB (The one in SPR-EE) as well as future implementa
On 1/30/2023 6:50 PM, Rongwei Liu wrote:
If flex item is referenced in async flow either by
pattern template or action template, currently testpmd
complains "flex item has flow references". Flex items should
be flushed after async flow resources cleanup.
Signed-off-by: Rongwei Liu
Acked-by: O
On 1/28/23 04:06, Hao Chen wrote:
When 'virtio_is_Ready' returns 1, 'vdpa_dev->ops->dev_conf' will be
called, and the vdpa driver called 'rte_vhost_get_vhost_vring' to
get the vring addr info from 'vhost_devices->virtqueue[]'.
virtio_is_ready's nr_vring is VIRTIO_BUILTIN_NUM_VQS_TO_BE_READY(2)
From: Beilei Xing
This patch refines API name for all virtual channel functions.
Signed-off-by: Beilei Xing
---
drivers/common/idpf/idpf_common_device.c | 24
drivers/common/idpf/idpf_common_virtchnl.c | 70 +++---
drivers/common/idpf/idpf_common_virtchnl.h | 36
From: Beilei Xing
Refine API name for all data path functions.
Signed-off-by: Beilei Xing
---
drivers/common/idpf/idpf_common_rxtx.c| 20 ++--
drivers/common/idpf/idpf_common_rxtx.h| 32 +--
drivers/common/idpf/idpf_common_rxtx_avx512.c | 8 ++---
drive
From: Beilei Xing
This patch refines API name for queue config functions.
Signed-off-by: Beilei Xing
---
drivers/common/idpf/idpf_common_rxtx.c| 42
drivers/common/idpf/idpf_common_rxtx.h| 38 +++---
drivers/common/idpf/idpf_common_rxtx_avx512.c | 2 +-
From: Beilei Xing
This patch refines API name for all vport related functions.
Signed-off-by: Beilei Xing
---
drivers/common/idpf/idpf_common_device.c | 8
drivers/common/idpf/idpf_common_device.h | 10 +-
drivers/common/idpf/version.map | 14 --
drivers/
From: Beilei Xing
Move avx512 vector path for single queue to common module.
Signed-off-by: Beilei Xing
---
drivers/common/idpf/idpf_common_rxtx.h| 20 +
.../idpf/idpf_common_rxtx_avx512.c} | 4 +--
drivers/common/idpf/meson.build | 30 +
From: Beilei Xing
Add timestamp filed to idpf_adapter structure.
Move scalar Rx/Tx data path for both single queue and split queue
to common module.
Signed-off-by: Mingxia Liu
Signed-off-by: Beilei Xing
---
drivers/common/idpf/idpf_common_device.h | 5 +
drivers/common/idpf/idpf_common_logs
From: Beilei Xing
Move vector queue setup for single queue model to common module.
Signed-off-by: Beilei Xing
---
drivers/common/idpf/idpf_common_rxtx.c | 57 ++
drivers/common/idpf/idpf_common_rxtx.h | 2 +
drivers/common/idpf/version.map| 1 +
drivers/net/id
From: Beilei Xing
Refine rxq setup and txq setup.
Move some help functions of queue setup and queue release
to common module.
Signed-off-by: Beilei Xing
---
drivers/common/idpf/idpf_common_rxtx.c | 414 +
drivers/common/idpf/idpf_common_rxtx.h | 57 ++
drivers/common/idpf/meson.bu
From: Beilei Xing
Add idpf_rxq and idpf_txq structure in common module.
Move idpf_vc_config_rxq and idpf_vc_config_txq functions
to common module.
Signed-off-by: Beilei Xing
---
drivers/common/idpf/idpf_common_device.h | 2 +
drivers/common/idpf/idpf_common_rxtx.h | 112 +
From: Beilei Xing
Move vector flags from idpf_adapter_ext structure to
idpf_vport structure.
Signed-off-by: Beilei Xing
---
drivers/common/idpf/idpf_common_device.h | 5 +
drivers/net/idpf/idpf_ethdev.h | 5 -
drivers/net/idpf/idpf_rxtx.c | 22 ++
From: Beilei Xing
Move queue module fields from idpf_adapter_ext structure to
idpf_adapter structure.
Refine some parameter and function name, and move function
idpf_create_vport_info_init to common module.
Signed-off-by: Beilei Xing
---
drivers/common/idpf/idpf_common_device.c | 36 ++
From: Beilei Xing
Move ptype_tbl field to idpf_adapter structure.
Move get_pkt_type to common module.
Signed-off-by: Beilei Xing
---
drivers/common/idpf/idpf_common_device.c | 216 +++
drivers/common/idpf/idpf_common_device.h | 7 +
drivers/common/idpf/meson.build
From: Beilei Xing
Introduce idpf_config_irq_map/idpf_config_irq_unmap functions
in common module, and refine config rxq irqs function.
Refine device start function with some irq error handling. Besides,
vport->stopped should be initialized at the end of the function.
Signed-off-by: Jingjing Wu
From: Beilei Xing
Move configure RSS to common module.
Signed-off-by: Beilei Xing
---
drivers/common/idpf/idpf_common_device.c | 25 +++
drivers/common/idpf/idpf_common_device.h | 2 ++
drivers/common/idpf/version.map | 1 +
drivers/net/idpf/idpf_ethdev.c
From: Beilei Xing
Move most of the virtual channel functions to idpf common module.
Signed-off-by: Wenjun Wu
Signed-off-by: Beilei Xing
---
drivers/common/idpf/base/idpf_controlq_api.h | 4 -
drivers/common/idpf/base/meson.build | 2 +-
drivers/common/idpf/idpf_common_device.c
From: Beilei Xing
Introduce idpf_vport_init and idpf_vport_deinit functions
in common module.
Signed-off-by: Wenjun Wu
Signed-off-by: Beilei Xing
---
drivers/common/idpf/idpf_common_device.c | 115 +
drivers/common/idpf/idpf_common_device.h | 13 +-
drivers/common/idpf/id
From: Beilei Xing
Introduce idpf_adapter_init and idpf_adapter_deinit
functions in common module.
And also introduce idpf_adapter_ext_init and
idpf_adapter_ext_deinit functions.
Signed-off-by: Wenjun Wu
Signed-off-by: Beilei Xing
---
drivers/common/idpf/base/idpf_controlq_api.h | 2 -
drive
From: Beilei Xing
Move idpf_vport structure to common module, remove ethdev dependency.
Also remove unused functions.
Signed-off-by: Wenjun Wu
Signed-off-by: Beilei Xing
---
drivers/common/idpf/idpf_common_device.h | 59 ++
drivers/net/idpf/idpf_ethdev.c | 10 +-
drivers/net/i
From: Beilei Xing
Add structure idpf_adapter in common module, the structure includes
some basic fields.
Introduce structure idpf_adapter_ext in PMD, this structure includes
extra fields except idpf_adapter.
Signed-off-by: Wenjun Wu
Signed-off-by: Beilei Xing
---
drivers/common/idpf/idpf_comm
From: Beilei Xing
Refactor idpf pmd by introducing idpf common module, which will be also
consumed by a new PMD - CPFL (Control Plane Function Library) PMD.
v2 changes:
- Refine irq map/unmap functions.
- Fix cross compile issue.
v3 changes:
- Embed vport_info field into the vport structure.
The qos_sched app was limited to using lcores between 0 and 64 only,
even if RTE_MAX_LCORE was set to a higher value (as it is by default).
Remove some of the checks on the lcore ids in order to support running
with core ids > 64.
Signed-off-by: Bruce Richardson
---
examples/qos_sched/args.c | 7
While performance of the QoS block drops sharply if the dequeue size is
greater than or equal to the enqueue size, increasing the dequeue size
to just under the enqueue one gives improved performance when the
scheduler is not keeping up with the line rate.
Signed-off-by: Bruce Richardson
---
doc
Since the qos_sched app does batch dequeues from the QoS block, there is
little point in trying to batch further in the app - just send out the
full burst of packets that were received from the QoS block. With modern
CPUs and write-combining doorbells, the cost of doing smaller TX's is
reduced anyw
The TX port config will fail if the port is not up, so wait 10 seconds
on startup for it to start.
Fixes: de3cfa2c9823 ("sched: initial import")
Cc: sta...@dpdk.org
Signed-off-by: Bruce Richardson
---
examples/qos_sched/init.c | 10 ++
1 file changed, 10 insertions(+)
diff --git a/exam
This patchset contains a set of fixes and improvements for the qos_sched
application. After this patchset the code is shorter, and also seems a
little faster in my performance tests.
Bruce Richardson (4):
examples/qos_sched: fix errors when TX port not up
examples/qos_sched: remove TX bufferin
On Fri, Feb 3, 2023 at 5:56 AM Stephen Hemminger
wrote:
>
> On Wed, 1 Feb 2023 13:34:41 +
> Shivah Shankar Shankar Narayan Rao wrote:
>
> > +struct rte_ml_dev_info {
> > + const char *driver_name;
> > + /**< Driver name */
> > + int16_t max_models;
>
> Why is max_models signed? ot
On Fri, Feb 3, 2023 at 5:58 AM Stephen Hemminger
wrote:
>
> On Wed, 1 Feb 2023 13:34:41 +
> Shivah Shankar Shankar Narayan Rao wrote:
>
> > +#define RTE_ML_STR_MAX 128
> > +/**< Maximum length of name string */
>
> Fixed length strings do create long term technical issues.
> But this is big e
On Fri, Feb 3, 2023 at 5:55 AM Stephen Hemminger
wrote:
>
> On Wed, 1 Feb 2023 13:34:41 +
> Shivah Shankar Shankar Narayan Rao wrote:
>
> > --- a/lib/eal/include/rte_log.h
> > +++ b/lib/eal/include/rte_log.h
> > @@ -48,6 +48,7 @@ extern "C" {
> > #define RTE_LOGTYPE_EFD 18 /**< Log rel
On 1/28/2023 4:15 AM, Ferruh Yigit wrote:
In testpmd port start function, 'need_check_link_status' variable is
used to detect if a link check is required after port is started.
Intention is if at least one port is started, link check should be
called, and initially 'need_check_link_status' used
> -Original Message-
> From: Srikanth Yalavarthi
> Sent: Friday, December 9, 2022 12:59 AM
> To: Srikanth Yalavarthi
> Cc: dev@dpdk.org; Shivah Shankar Shankar Narayan Rao
> ; Jerin Jacob Kollanukkaran
> ; Anup Prabhu
> Subject: [PATCH v3 11/12] app/mldev: enable reporting stats in mld
1 - 100 of 114 matches
Mail list logo
