Re: [PATCH 2/2] app/testpmd: add disable-flow-flush parameter

2023-01-30 Thread Singh, Aman Deep
On 1/26/2023 12:07 AM, Ferruh Yigit wrote: On 12/15/2022 1:41 AM, Chengwen Feng wrote: This patch adds "--disable-flow-flush" parameter, which could used to disable port flow flush when stop port. It allows testing keep flow rules or shared flow objects across restart. Signed-off-by: Chengwen

Re: [PATCH] net/sfc: export pick transfer proxy callback to representors

2023-01-30 Thread Andrew Rybchenko
On 1/31/23 10:24, Ivan Malov wrote: Currently, the "pick transfer proxy ethdev" callback is only advertised for non-representor (in example, main PF) ethdevs. That does not sit well with the original idea of this method, which is to let applications discover the privileged port to use for transfe

答复: [[SPF Failed]][PATCH v2] net/i40e: rework maximum frame size configuration

2023-01-30 Thread 韩爽
Why i40e_dev_link_update must be called with wait_to_complete when link interrupt is enabled ? I think it's may have the same issue as ice_link_update, please check: https://patches.dpdk.org/project/dpdk/patch/1669207333-8769-1-git-send-email-hanshuan...@gmail.com/ -邮件原件- 发件人: Simei Su

[PATCH] net/sfc: export pick transfer proxy callback to representors

2023-01-30 Thread Ivan Malov
Currently, the "pick transfer proxy ethdev" callback is only advertised for non-representor (in example, main PF) ethdevs. That does not sit well with the original idea of this method, which is to let applications discover the privileged port to use for transfer flow management instead of any given

RE: [PATCH v2 2/3] net/mlx5: add ICMPv6 ID and sequence match support

2023-01-30 Thread Leo Xu (Networking SW)
Hi Thomas, PSB > -Original Message- > From: Thomas Monjalon > Sent: Wednesday, January 18, 2023 4:55 PM > To: Leo Xu (Networking SW) > Cc: dev@dpdk.org; Matan Azrad ; Slava Ovsiienko > > Subject: Re: [PATCH v2 2/3] net/mlx5: add ICMPv6 ID and sequence match > support > > External emai

RE: [PATCH v2 3/3] net/mlx5/hws: add ICMPv6 ID and sequence match support

2023-01-30 Thread Leo Xu (Networking SW)
Hi Thomas, PSB > -Original Message- > From: Thomas Monjalon > Sent: Wednesday, January 18, 2023 4:58 PM > To: Leo Xu (Networking SW) > Cc: dev@dpdk.org; Matan Azrad ; Slava Ovsiienko > > Subject: Re: [PATCH v2 3/3] net/mlx5/hws: add ICMPv6 ID and sequence match > support > > External

[PATCH v2] net/i40e: rework maximum frame size configuration

2023-01-30 Thread Simei Su
This patch removes unnecessary link status check and adds link update. Fixes: a4ba77367923 ("net/i40e: enable maximum frame size at port level") Fixes: 2184f7cdeeaa ("net/i40e: fix max frame size config at port level") Fixes: 719469f13b11 ("net/i40e: fix jumbo frame Rx with X722") Cc: sta...@dpdk.

RE: [PATCH v2 1/3] ethdev: add ICMPv6 ID and sequence

2023-01-30 Thread Leo Xu (Networking SW)
Hi Thomas, Thanks for those comments. PSB > -Original Message- > From: Thomas Monjalon > Sent: Wednesday, January 18, 2023 5:31 PM > To: Leo Xu (Networking SW) > Cc: dev@dpdk.org; Bing Zhao ; Ori Kam > ; Aman Singh ; Yuying > Zhang ; Ferruh Yigit ; > Andrew Rybchenko ; Olivier Matz > ;

RE: Google Virtual NIC (GVE) PMD

2023-01-30 Thread Guo, Junfeng
> -Original Message- > From: Ferruh Yigit > Sent: Wednesday, January 18, 2023 23:32 > To: Levend Sayar ; Guo, Junfeng > > Cc: dev@dpdk.org; Jeroen de Borst ; Rushil > Gupta ; Jordan Kimbrough > Subject: Re: Google Virtual NIC (GVE) PMD > > On 1/18/2023 1:47 PM, Levend Sayar wrote: > >

RE: [PATCH 4/4] crypto/cnxk: add error interrupt event query handler

2023-01-30 Thread Srujana Challa
Hi Akhil, Please find the correct description inline, Thanks, Srujana. > > Subject: [PATCH 4/4] crypto/cnxk: add error interrupt event query > > handler > > > > Adds RTE_CRYPTODEV_EVENT_ERROR query handler for cn9k/cn10k PMD. > > The query handler finds the next queue pair ID with pending error

[PATCH V6] ethdev: fix one address occupies two entries in MAC addrs

2023-01-30 Thread Huisong Li
The dev->data->mac_addrs[0] will be changed to a new MAC address when applications modify the default MAC address by .mac_addr_set(). However, if the new default one has been added as a non-default MAC address by .mac_addr_add(), the .mac_addr_set() doesn't remove it from the mac_addrs list. As a r

RE: [EXT] [PATCH 1/4] compressdev: add LZ4 algorithm support

2023-01-30 Thread Akhil Goyal
> -Original Message- > From: Michael Baum > Sent: Tuesday, January 31, 2023 2:07 AM > To: Akhil Goyal ; dev@dpdk.org; Mahipal Challa > ; Fan Zhang ; Ashish Gupta > > Cc: Matan Azrad ; Fiona Trahe ; > NBU-Contact-Thomas Monjalon (EXTERNAL) > Subject: RE: [EXT] [PATCH 1/4] compressdev: a

RE: [PATCH v7] ethdev: add special flags when creating async transfer table

2023-01-30 Thread Rongwei Liu
HI Ivan: BR Rongwei > -Original Message- > From: Ivan Malov > Sent: Tuesday, January 31, 2023 13:30 > To: Rongwei Liu > Cc: Matan Azrad ; Slava Ovsiienko > ; Ori Kam ; NBU-Contact- > Thomas Monjalon (EXTERNAL) ; Aman Singh > ; Yuying Zhang ; > Ferruh Yigit ; Andrew Rybchenko > ; dev@dpd

回复: [PATCH v3 0/3] Direct re-arming of buffers on receive side

2023-01-30 Thread Feifei Wang
+ping konstantin, Would you please give some comments for this patch series? Thanks very much. Best Regards Feifei

RE: [PATCH v7] ethdev: add special flags when creating async transfer table

2023-01-30 Thread Ivan Malov
Hi Rongwei, OK, I hear ya. Thanks for persevering. I still hope community will comment on the possibility to provide a hint mechanism for always-the-same match items, with the perspective of becoming more versatile. Other than that, your current patch might be OK, but, again, I think other revie

RE: [PATCH v3] app/dma-perf: introduce dma-perf application

2023-01-30 Thread Hu, Jiayu
Hi Bruce, > -Original Message- > From: Richardson, Bruce > Sent: Wednesday, January 18, 2023 12:52 AM > To: Jiang, Cheng1 > Cc: tho...@monjalon.net; m...@smartsharesystems.com; dev@dpdk.org; > Hu, Jiayu ; Ding, Xuan ; Ma, > WenwuX ; Wang, YuanX > ; He, Xingguang > Subject: Re: [PATCH v3

RE: [PATCH v1 20/21] net/virtio-user: advertize control VQ support with vDPA

2023-01-30 Thread Xia, Chenbo
> -Original Message- > From: Maxime Coquelin > Sent: Wednesday, November 30, 2022 11:57 PM > To: dev@dpdk.org; Xia, Chenbo ; > david.march...@redhat.com; epere...@redhat.com > Cc: Maxime Coquelin > Subject: [PATCH v1 20/21] net/virtio-user: advertize control VQ support > with vDPA > > Th

[PATCH] net/iavf: add check for mbuf

2023-01-30 Thread Mingjin Ye
The scalar Tx path would send wrong mbuf that causes the kernel driver to fire the MDD event. This patch adds mbuf detection in tx_prepare to fix this issue, rte_errno will be set to EINVAL and returned if the verification fails. Fixes: 3fd32df381f8 ("net/iavf: check Tx packet with correct UP and

RE: [PATCH v1 18/21] net/virtio-user: add new callback to enable control queue

2023-01-30 Thread Xia, Chenbo
> -Original Message- > From: Maxime Coquelin > Sent: Wednesday, November 30, 2022 11:57 PM > To: dev@dpdk.org; Xia, Chenbo ; > david.march...@redhat.com; epere...@redhat.com > Cc: Maxime Coquelin > Subject: [PATCH v1 18/21] net/virtio-user: add new callback to enable > control queue > >

RE: [PATCH v1 16/21] net/virtio-user: allocate shadow control queue

2023-01-30 Thread Xia, Chenbo
> -Original Message- > From: Maxime Coquelin > Sent: Wednesday, November 30, 2022 11:57 PM > To: dev@dpdk.org; Xia, Chenbo ; > david.march...@redhat.com; epere...@redhat.com > Cc: Maxime Coquelin > Subject: [PATCH v1 16/21] net/virtio-user: allocate shadow control queue > > If the backen

RE: [PATCH v1 17/21] net/virtio-user: send shadow virtqueue info to the backend

2023-01-30 Thread Xia, Chenbo
> -Original Message- > From: Maxime Coquelin > Sent: Wednesday, November 30, 2022 11:57 PM > To: dev@dpdk.org; Xia, Chenbo ; > david.march...@redhat.com; epere...@redhat.com > Cc: Maxime Coquelin > Subject: [PATCH v1 17/21] net/virtio-user: send shadow virtqueue info to > the backend > >

RE: [PATCH v1 15/21] net/virtio-user: get max number of queue pairs from device

2023-01-30 Thread Xia, Chenbo
> -Original Message- > From: Maxime Coquelin > Sent: Wednesday, November 30, 2022 11:57 PM > To: dev@dpdk.org; Xia, Chenbo ; > david.march...@redhat.com; epere...@redhat.com > Cc: Maxime Coquelin > Subject: [PATCH v1 15/21] net/virtio-user: get max number of queue pairs > from device > >

RE: [PATCH v1 14/21] net/virtio-user: use proper type for number of queue pairs

2023-01-30 Thread Xia, Chenbo
> -Original Message- > From: Maxime Coquelin > Sent: Wednesday, November 30, 2022 11:57 PM > To: dev@dpdk.org; Xia, Chenbo ; > david.march...@redhat.com; epere...@redhat.com > Cc: Maxime Coquelin > Subject: [PATCH v1 14/21] net/virtio-user: use proper type for number of > queue pairs > >

RE: [PATCH v1 13/21] net/virtio-user: simplify queues setup

2023-01-30 Thread Xia, Chenbo
> -Original Message- > From: Maxime Coquelin > Sent: Wednesday, November 30, 2022 11:57 PM > To: dev@dpdk.org; Xia, Chenbo ; > david.march...@redhat.com; epere...@redhat.com > Cc: Maxime Coquelin > Subject: [PATCH v1 13/21] net/virtio-user: simplify queues setup > > The only reason two l

RE: [PATCH v1 12/21] net/virtio-user: fix device starting failure handling

2023-01-30 Thread Xia, Chenbo
> -Original Message- > From: Maxime Coquelin > Sent: Wednesday, November 30, 2022 11:57 PM > To: dev@dpdk.org; Xia, Chenbo ; > david.march...@redhat.com; epere...@redhat.com > Cc: Maxime Coquelin ; sta...@dpdk.org > Subject: [PATCH v1 12/21] net/virtio-user: fix device starting failure > h

RE: [PATCH v1 21/21] net/virtio-user: remove max queues limitation

2023-01-30 Thread Xia, Chenbo
Hi Maxime, > -Original Message- > From: Maxime Coquelin > Sent: Wednesday, November 30, 2022 11:57 PM > To: dev@dpdk.org; Xia, Chenbo ; > david.march...@redhat.com; epere...@redhat.com > Cc: Maxime Coquelin > Subject: [PATCH v1 21/21] net/virtio-user: remove max queues limitation > > Th

Re: net/bnxt: wrong link status when lsc_intr is used

2023-01-30 Thread Somnath Kotur
On Thu, Jan 19, 2023 at 7:07 PM Edwin Brossette wrote: > > Hello, > Hi Edwin, Thanks for reaching out, here's my attempt at answering your questions > I am trying to operate a Broadcom BCM57414 2x10G nic using dpdk bnxt pmd. I > use DPDK 22.11. > However, doing so I stumbled over a number of dif

RE: [PATCH v2 1/3] ethdev: add ICMPv6 ID and sequence

2023-01-30 Thread Leo Xu (Networking SW)
Hi, PSB > -Original Message- > From: Ferruh Yigit > Sent: Thursday, January 26, 2023 6:45 PM > To: Leo Xu (Networking SW) ; dev@dpdk.org > Cc: Bing Zhao ; Ori Kam ; Aman Singh > ; Yuying Zhang ; > NBU-Contact-Thomas Monjalon (EXTERNAL) ; Andrew > Rybchenko ; Olivier Matz > > Subject: Re

RE: [PATCH v2 0/3] support match icmpv6 ID and sequence

2023-01-30 Thread Leo Xu (Networking SW)
Hi, PSB > -Original Message- > From: Ferruh Yigit > Sent: Thursday, January 26, 2023 6:47 PM > To: Leo Xu (Networking SW) > Cc: Matan Azrad ; dev@dpdk.org; Slava Ovsiienko > > Subject: Re: [PATCH v2 0/3] support match icmpv6 ID and sequence > > External email: Use caution opening links

[dpdk-dev] [PATCH] common/cnxk: fix second pass flow rule layer type

2023-01-30 Thread psatheesh
From: Satheesh Paul When installing flow rule for second pass packets, set the LA LTYPE to LA_CPT_HDR. Fixes: 4968b362b63 ("common/cnxk: support CPT second pass flow rules") Cc: sta...@dpdk.org Signed-off-by: Satheesh Paul Reviewed-by: Kiran Kumar K --- drivers/common/cnxk/roc_npc_mcam.c

[PATCH V5 5/5] app/testpmd: stop forwarding in new or destroy event

2023-01-30 Thread Huisong Li
When testpmd receives the new or destroy event, the port related information will be updated. Testpmd must stop packet forwarding before updating the information to avoid some serious problems. Signed-off-by: Huisong Li --- app/test-pmd/testpmd.c | 4 1 file changed, 4 insertions(+) diff -

[PATCH V5 4/5] app/testpmd: add attach and detach port for multiple process

2023-01-30 Thread Huisong Li
The port information needs to be updated due to attaching and detaching port. Currently, it is done in the same thread as removing or probing device, which doesn't satisfy the operation of attaching and detaching device in multiple process. If this operation is performed in one process, the other

[PATCH V5 3/5] app/testpmd: check the validity of the port

2023-01-30 Thread Huisong Li
This patch checks the validity of port id for all events in 'eth_event_callback()'. Signed-off-by: Huisong Li Acked-by: Aman Singh --- app/test-pmd/testpmd.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c index e366f81a0f

[PATCH V5 1/5] drivers/bus: restore driver assignment at front of probing

2023-01-30 Thread Huisong Li
The driver assignment was moved back at the end of the device probing because there is no something to use rte_driver during the phase of probing. See commit 391797f04208 ("drivers/bus: move driver assignment to end of probing") However, it is necessary for probing callback to reference rte_driver

[PATCH V5 2/5] ethdev: fix skip valid port in probing callback

2023-01-30 Thread Huisong Li
The event callback in application may use the macro RTE_ETH_FOREACH_DEV to iterate over all enabled ports to do something(like, verifying the port id validity) when receive a probing event. If the ethdev state of a port is not RTE_ETH_DEV_UNUSED, this port will be considered as a valid port. Howev

[PATCH V5 0/5] app/testpmd: support multiple process attach and detach port

2023-01-30 Thread Huisong Li
This patchset fix some bugs and support attaching and detaching port in primary and secondary. --- -v5: move 'ALLOCATED' state to the back of 'REMOVED' to avoid abi break. -v4: fix a misspelling. -v3: #1 merge patch 1/6 and patch 2/6 into patch 1/5, and add modification for other bus

RE: [PATCH v2] net/i40e: support enabling/disabling source pruning

2023-01-30 Thread Zhang, Ke1X
> -Original Message- > From: David Marchand > Sent: Monday, January 30, 2023 4:58 PM > To: Zhang, Ke1X ; m...@smartsharesystems.com; > tho...@monjalon.net; ferruh.yi...@amd.com > Cc: dev@dpdk.org; Matz, Olivier ; Zhang, Yuying > ; Xing, Beilei > Subject: Re: [PATCH v2] net/i40e: support

RE: [PATCH v3 1/8] ethdev: add IPv6 routing extension header definition

2023-01-30 Thread Rongwei Liu
Hi Stephen BR Rongwei > -Original Message- > From: Stephen Hemminger > Sent: Tuesday, January 31, 2023 11:02 > To: Rongwei Liu > Cc: Matan Azrad ; Slava Ovsiienko > ; Ori Kam ; NBU-Contact- > Thomas Monjalon (EXTERNAL) ; Aman Singh > ; Yuying Zhang ; > Ferruh Yigit ; Andrew Rybchenko >

RE: [PATCH v3] malloc: enhance NUMA affinity heuristic

2023-01-30 Thread You, KaisenX
> -Original Message- > From: David Marchand > Sent: 2023年1月3日 21:32 > To: dev@dpdk.org > Cc: Matz, Olivier ; ferruh.yi...@amd.com; You, > KaisenX ; zhou...@loongson.cn; Burakov, Anatoly > > Subject: [PATCH v3] malloc: enhance NUMA affinity heuristic > > Trying to allocate memory on th

RE: [PATCH v3 1/8] ethdev: add IPv6 routing extension header definition

2023-01-30 Thread Rongwei Liu
HI Stephen BR Rongwei > -Original Message- > From: Stephen Hemminger > Sent: Tuesday, January 31, 2023 10:56 > To: Rongwei Liu > Cc: Matan Azrad ; Slava Ovsiienko > ; Ori Kam ; NBU-Contact- > Thomas Monjalon (EXTERNAL) ; Aman Singh > ; Yuying Zhang ; > Ferruh Yigit ; Andrew Rybchenko >

Re: [PATCH v2 2/2] ring: add ring info telemetry cmd

2023-01-30 Thread Jie Hai
Hi, Konstantin, Thanks for your review. All accepted and fixed in v3. Jie Hai On 2023/1/23 1:49, Konstantin Ananyev wrote: This patch supports dump of the info of ring by its name. An example using this command is shown below: --> /ring/info,MP_mb_pool_0 {    "/ring/info": { "name": "M

Re: [PATCH v2 1/2] ring: add ring list telemetry cmd

2023-01-30 Thread Jie Hai
On 2023/1/23 0:40, Konstantin Ananyev wrote: Hi Jie, This patch supports the list of rings with telemetry cmd. An example using this command is shown below: --> /ring/list {    "/ring/list": [ "HT_:7d:00.2", "MP_mb_pool_0"    ] } Signed-off-by: Jie Hai ---   lib/ring/meson.bu

RE: [PATCH v7] ethdev: add special flags when creating async transfer table

2023-01-30 Thread Rongwei Liu
HI Ivan BR Rongwei > -Original Message- > From: Ivan Malov > Sent: Tuesday, January 31, 2023 07:00 > To: Rongwei Liu > Cc: Matan Azrad ; Slava Ovsiienko > ; Ori Kam ; NBU-Contact- > Thomas Monjalon (EXTERNAL) ; Aman Singh > ; Yuying Zhang ; > Ferruh Yigit ; Andrew Rybchenko > ; dev@dpdk

Re: [PATCH v3 1/8] ethdev: add IPv6 routing extension header definition

2023-01-30 Thread Stephen Hemminger
On Mon, 30 Jan 2023 05:59:33 +0200 Rongwei Liu wrote: > +/** > + * @warning > + * @b EXPERIMENTAL: this structure may change without prior notice > + * > + * RTE_FLOW_ITEM_TYPE_IPV6_ROUTING_EXT. > + * > + * Matches an IPv6 routing extension header. > + */ > +struct rte_flow_item_ipv6_routing_ext

[PATCH] examples/l3fwd-power: support CPPC cpufreq

2023-01-30 Thread Jie Hai
Currently the l3fwd-power only supports ACPI cpufreq and Pstate cpufreq, This patch adds CPPC cpufreq. Signed-off-by: Jie Hai --- examples/l3fwd-power/main.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/examples/l3fwd-power/main.c b/examples/l3fwd-power/main.c ind

Re: [PATCH v10 1/2] cmdline: handle EOF in cmdline_poll

2023-01-30 Thread Stephen Hemminger
On Mon, 30 Jan 2023 22:12:42 + Ferruh Yigit wrote: > On 1/30/2023 8:09 PM, Stephen Hemminger wrote: > > If end of file is reached on input, then cmdline_read_char() > > will return 0. The problem is that cmdline_poll() was not checking > > for this and would continue and not return the status

RE: [PATCH v4 3/3] ethdev: add standby flags for live migration

2023-01-30 Thread Rongwei Liu
HI Jerin: BR Rongwei > -Original Message- > From: Jerin Jacob > Sent: Tuesday, January 31, 2023 01:10 > To: Rongwei Liu > Cc: dev@dpdk.org; Matan Azrad ; Slava Ovsiienko > ; Ori Kam ; NBU-Contact- > Thomas Monjalon (EXTERNAL) ; > step...@networkplumber.org; Raslan Darawsheh ; > Ferruh Y

[PATCH] test/mbuf: fix mbuf_autotest retest fail

2023-01-30 Thread Jie Hai
Retest "mbuf_autotest" will fail because the mbuf pool was not freed after previous test successful done. This patch fixes it. Fixes: efc6f9104c80 ("mbuf: fix reset on mbuf free") Cc: sta...@dpdk.org Signed-off-by: Jie Hai --- app/test/test_mbuf.c | 1 + 1 file changed, 1 insertion(+) diff --g

[PATCH v3 2/2] ring: add ring info telemetry cmd

2023-01-30 Thread Jie Hai
This patch supports dump of the info of ring by its name. An example using this command is shown below: --> /ring/info,MP_mb_pool_0 { "/ring/info": { "name": "MP_mb_pool_0", "socket": 0, "flags": 0, "producer_type": "MP", "consumer_type": "MC", "size": 262144, "mask":

[PATCH v3 1/2] ring: add ring list telemetry cmd

2023-01-30 Thread Jie Hai
This patch supports the list of rings with telemetry cmd. An example using this command is shown below: --> /ring/list { "/ring/list": [ "HT_:7d:00.2", "MP_mb_pool_0" ] } Signed-off-by: Jie Hai Acked-by: Konstantin Ananyev --- lib/ring/meson.build | 1 + lib/ring/rte_ring.c |

[PATCH v3 0/2] add ring telemetry cmds

2023-01-30 Thread Jie Hai
This patch set supports telemetry list rings and dump info of a ring by its name. v1->v2: 1. Add space after "switch". 2. Fix wrong strlen parameter. v2->v3: 1. Remove prefix "rte_" for static function. 2. Add Acked-by Konstantin Ananyev for PATCH 1. 3. Introduce functions to return strings inste

RE: [PATCH v3 1/8] ethdev: add IPv6 routing extension header definition

2023-01-30 Thread Rongwei Liu
HI Stephen BR Rongwei > -Original Message- > From: Stephen Hemminger > Sent: Tuesday, January 31, 2023 00:48 > To: Rongwei Liu > Cc: Matan Azrad ; Slava Ovsiienko > ; Ori Kam ; NBU-Contact- > Thomas Monjalon (EXTERNAL) ; Aman Singh > ; Yuying Zhang ; > Ferruh Yigit ; Andrew Rybchenko >

RE: [PATCH v3 1/8] ethdev: add IPv6 routing extension header definition

2023-01-30 Thread Rongwei Liu
HI Stephen: BR Rongwei > -Original Message- > From: Stephen Hemminger > Sent: Tuesday, January 31, 2023 00:50 > To: Rongwei Liu > Cc: Matan Azrad ; Slava Ovsiienko > ; Ori Kam ; NBU-Contact- > Thomas Monjalon (EXTERNAL) ; Aman Singh > ; Yuying Zhang ; > Ferruh Yigit ; Andrew Rybchenko >

RE: [PATCH v3 1/8] ethdev: add IPv6 routing extension header definition

2023-01-30 Thread Rongwei Liu
HI Stephen: BR Rongwei > -Original Message- > From: Stephen Hemminger > Sent: Tuesday, January 31, 2023 00:48 > To: Rongwei Liu > Cc: Matan Azrad ; Slava Ovsiienko > ; Ori Kam ; NBU-Contact- > Thomas Monjalon (EXTERNAL) ; Aman Singh > ; Yuying Zhang ; > Ferruh Yigit ; Andrew Rybchenko >

Re: [PATCH] net/gve: add support for basic stats

2023-01-30 Thread Joshua Washington
Hello, I tested it out, and the updates to testpmd seem to work. Before applying the second patch: -- Forward statistics for port 0 -- RX-packets: 0 RX-dropped: 0 RX-total: 0 TX-packets: 43769238 TX-dropped: 62634

RE: [PATCH v7] ethdev: add special flags when creating async transfer table

2023-01-30 Thread Ivan Malov
Hi Rongwei, Thanks for the professional attitude. Hope this discussion gets us on the same page. Please see below. On Mon, 30 Jan 2023, Rongwei Liu wrote: HI Ivan BR Rongwei -Original Message- From: Ivan Malov Sent: Monday, January 30, 2023 15:40 To: Rongwei Liu Cc: Matan Azrad ;

Re: [PATCH v10 0/2] testpmd: handle signals safely

2023-01-30 Thread Ferruh Yigit
On 1/30/2023 8:09 PM, Stephen Hemminger wrote: > Fixing the signal handling in testpmd requires also > fixing EOF handling in cmdline_poll() > > Stephen Hemminger (2): > cmdline: handle EOF in cmdline_poll > testpmd: cleanup cleanly from signal > I confirm this solves the EOF issue, but plea

Re: [PATCH v10 1/2] cmdline: handle EOF in cmdline_poll

2023-01-30 Thread Ferruh Yigit
On 1/30/2023 8:09 PM, Stephen Hemminger wrote: > If end of file is reached on input, then cmdline_read_char() > will return 0. The problem is that cmdline_poll() was not checking > for this and would continue and not return the status. > > Fixes: 9251cd97a6be ("cmdline: add internal wrappers for c

RE: [EXT] [PATCH 1/4] compressdev: add LZ4 algorithm support

2023-01-30 Thread Michael Baum
On Mon, Jan 30, 2023 at 20:35 PM Akhil Goyal wrote: > > > +/** > > + * Block checksum flag. > > + * If this flag is set, each data block will be followed by a 4-bytes > > checksum, > > + * calculated by using the xxHash-32 algorithm on the raw (compressed) data > > + * block. The intention is t

Re: [PATCH v10 4/4] eal: deprecation notice for rte thread setname API

2023-01-30 Thread Tyler Retzlaff
On Mon, Jan 30, 2023 at 05:19:20PM +0100, David Marchand wrote: > On Mon, Jan 30, 2023 at 4:47 PM Thomas Monjalon wrote: > > > > Hi, > > > > The title should start with a verb. > > I suppose it can be fixed while merging with a title like: > > doc: announce deprecation of thread naming function >

Re: Commit broke 32-bit testpmd app

2023-01-30 Thread Sampath Peechu (speechu)
Hi Maxime, Could you please let us know if you got a chance to look at the debugs logs I provided? Thanks, Sampath From: Sampath Peechu (speechu) Date: Tuesday, December 6, 2022 at 1:08 PM To: Maxime Coquelin , chenbo@intel.com , dev@dpdk.org Cc: Roger Melton (rmelton) Subject: Re: Com

Re: [PATCH v9] testpmd: cleanup cleanly from signal

2023-01-30 Thread Stephen Hemminger
On Mon, 30 Jan 2023 18:48:25 + Ferruh Yigit wrote: > On 1/25/2023 6:32 PM, Stephen Hemminger wrote: > > Do a clean shutdown of testpmd when a signal is received; instead of > > having testpmd kill itself. This fixes the problem where a signal could > > be received in the middle of a PMD and

[PATCH v10 2/2] testpmd: cleanup cleanly from signal

2023-01-30 Thread Stephen Hemminger
Do a clean shutdown of testpmd when a signal is received; instead of having testpmd kill itself. This fixes the problem where a signal could be received in the middle of a PMD and then the signal handler would call PMD's close routine leading to locking problems. An added benefit is it gets rid o

[PATCH v10 0/2] testpmd: handle signals safely

2023-01-30 Thread Stephen Hemminger
Fixing the signal handling in testpmd requires also fixing EOF handling in cmdline_poll() Stephen Hemminger (2): cmdline: handle EOF in cmdline_poll testpmd: cleanup cleanly from signal app/test-pmd/cmdline.c | 30 ++-- app/test-pmd/testpmd.c | 77

[PATCH v10 1/2] cmdline: handle EOF in cmdline_poll

2023-01-30 Thread Stephen Hemminger
If end of file is reached on input, then cmdline_read_char() will return 0. The problem is that cmdline_poll() was not checking for this and would continue and not return the status. Fixes: 9251cd97a6be ("cmdline: add internal wrappers for character input") Signed-off-by: Stephen Hemminger --- l

RE: [EXT] [PATCH] compressdev: fix end of comp PMD list macro conflict

2023-01-30 Thread Akhil Goyal
> The "rte_compressdev_info_get()" function retrieves the contextual > information of a device. > The output structure "dev_info" contains a list of devices supported > capabilities for each supported algorithm. > > In this function description, it says the element after the last valid > element h

RE: [PATCH] test/crypto: add missing MAC-I to PDCP vectors

2023-01-30 Thread Akhil Goyal
> Subject: [PATCH] test/crypto: add missing MAC-I to PDCP vectors > > Existing PDCP 12-bit C/U-plane output vectors with NULL encryption + NULL > integrity do not contain the MAC-I (32-bit of all zeros according to the > specification). > Vectors for other SN length (5, 18 bits) have the MAC-I set

RE: [PATCH v2 2/3] app/test: add SHAKE test cases

2023-01-30 Thread Akhil Goyal
> Subject: [PATCH v2 2/3] app/test: add SHAKE test cases > > Add test cases for SHAKE hash algorithm for Digest and Digest-Verify. > > Signed-off-by: Volodymyr Fialko > --- Acked-by: Akhil Goyal

RE: [PATCH v2 1/3] cryptodev: add SHAKE algorithm

2023-01-30 Thread Akhil Goyal
> -Original Message- > From: Volodymyr Fialko > Sent: Thursday, January 12, 2023 4:18 PM > To: dev@dpdk.org; Akhil Goyal ; Fan Zhang > > Cc: Jerin Jacob Kollanukkaran ; Anoob Joseph > ; Volodymyr Fialko > Subject: [PATCH v2 1/3] cryptodev: add SHAKE algorithm > > Add SHAKE to enum of

RE: [PATCH 4/4] crypto/cnxk: add error interrupt event query handler

2023-01-30 Thread Akhil Goyal
> Subject: [PATCH 4/4] crypto/cnxk: add error interrupt event query handler > > Adds RTE_CRYPTODEV_EVENT_ERROR query handler for cn9k/cn10k PMD. > The query handler finds the next queue pair ID with pending error > interrupt event if any, starting from the given queue pair index, > for the device.

RE: [PATCH 3/4] cryptodev: introduce query API for error interrupt event

2023-01-30 Thread Akhil Goyal
> Subject: [PATCH 3/4] cryptodev: introduce query API for error interrupt event > > An event RTE_CRYPTODEV_EVENT_ERROR gets fired when crypto PMD receives > an error interrupt. This patch adds query function for the application, > to get more info about the event. > > Signed-off-by: Srujana Chall

Re: [PATCH v9] testpmd: cleanup cleanly from signal

2023-01-30 Thread Ferruh Yigit
On 1/25/2023 6:32 PM, Stephen Hemminger wrote: > Do a clean shutdown of testpmd when a signal is received; instead of > having testpmd kill itself. This fixes the problem where a signal could > be received in the middle of a PMD and then the signal handler would > call PMD's close routine leading

RE: [EXT] [PATCH v2 1/4] crypto/ccp: remove some printf

2023-01-30 Thread Akhil Goyal
> A DPDK application must _not_ use printf. > Use log framework. > > Fixes: ef4b04f87fa6 ("crypto/ccp: support device init") > Cc: sta...@dpdk.org > > Signed-off-by: David Marchand First 3 patches of the series applied to dpdk-next-crypto Please submit the last patch again with the required cha

RE: [EXT] [PATCH 1/4] compressdev: add LZ4 algorithm support

2023-01-30 Thread Akhil Goyal
> +/** > + * Block checksum flag. > + * If this flag is set, each data block will be followed by a 4-bytes > checksum, > + * calculated by using the xxHash-32 algorithm on the raw (compressed) data > + * block. The intention is to detect data corruption (storage or transmission > + * errors) immed

RE: [RFC v2 6/9] net/gve: support basic Rx data path for DQO

2023-01-30 Thread Honnappa Nagarahalli
> -Original Message- > From: Junfeng Guo > Sent: Monday, January 30, 2023 12:27 AM > To: qi.z.zh...@intel.com; jingjing...@intel.com; ferruh.yi...@amd.com; > beilei.x...@intel.com > Cc: dev@dpdk.org; xiaoyun...@intel.com; helin.zh...@intel.com; Junfeng Guo > ; Rushil Gupta ; Jordan > Ki

RE: [RFC v2 7/9] net/gve: support basic stats for DQO

2023-01-30 Thread Honnappa Nagarahalli
Few comments inline > -Original Message- > From: Junfeng Guo > Sent: Monday, January 30, 2023 12:27 AM > To: qi.z.zh...@intel.com; jingjing...@intel.com; ferruh.yi...@amd.com; > beilei.x...@intel.com > Cc: dev@dpdk.org; xiaoyun...@intel.com; helin.zh...@intel.com; Junfeng Guo > ; Rushil G

Re: [PATCH v4 3/3] ethdev: add standby flags for live migration

2023-01-30 Thread Jerin Jacob
On Mon, Jan 30, 2023 at 8:17 AM Rongwei Liu wrote: > > Hi Jerin > > BR > Rongwei > > > -Original Message- > > From: Jerin Jacob > > Sent: Monday, January 23, 2023 21:20 > > To: Rongwei Liu > > Cc: dev@dpdk.org; Matan Azrad ; Slava Ovsiienko > > ; Ori Kam ; NBU-Contact- > > Thomas Monjalo

[PATCH v2 1/2] ethdev: add PHY affinity match item

2023-01-30 Thread Jiawei Wang
For the multiple hardware ports connect to a single DPDK port (mhpsdp), currently, there is no information to indicate the packet belongs to which hardware port. This patch introduces a new phy affinity item in rte flow API, and the phy affinity value reflects the physical port of the received pac

[PATCH v2 2/2] ethdev: introduce the PHY affinity field in Tx queue API

2023-01-30 Thread Jiawei Wang
For the multiple hardware ports connect to a single DPDK port (mhpsdp), the previous patch introduces the new rte flow item to match the phy affinity of the received packets. This patch adds the tx_phy_affinity setting in Tx queue API, the affinity value reflects packets be sent to which hardware

[PATCH v2 0/2] add new PHY affinity in the flow item and Tx queue API

2023-01-30 Thread Jiawei Wang
For the multiple hardware ports connect to a single DPDK port (mhpsdp), currently, there is no information to indicate the packet belongs to which hardware port. This patch introduces a new phy affinity item in rte flow API, and the phy affinity value reflects the physical phy affinity of the rece

Re: [PATCH v3 1/8] ethdev: add IPv6 routing extension header definition

2023-01-30 Thread Stephen Hemminger
On Mon, 30 Jan 2023 05:59:33 +0200 Rongwei Liu wrote: > +static size_t > +rte_flow_item_ipv6_routing_ext_conv(void *buf, const void *data) > +{ > + struct rte_flow_item_ipv6_routing_ext *dst = buf; > + const struct rte_flow_item_ipv6_routing_ext *src = data; > + size_t len; > + > +

Re: [PATCH v10 4/4] eal: deprecation notice for rte thread setname API

2023-01-30 Thread David Marchand
On Mon, Jan 30, 2023 at 4:47 PM Thomas Monjalon wrote: > > Hi, > > The title should start with a verb. > I suppose it can be fixed while merging with a title like: > doc: announce deprecation of thread naming function Yes, I will handle it. > 24/01/2023 19:12, Tyler Retzlaff: > > Notify deprecat

RE: [EXT] Re: [PATCH v6 2/6] ethdev: add trace points for ethdev (part one)

2023-01-30 Thread Ankur Dwivedi
>-Original Message- >From: Ferruh Yigit >Sent: Monday, January 23, 2023 10:59 PM >To: Ankur Dwivedi ; dev@dpdk.org; David >Marchand >Cc: tho...@monjalon.net; david.march...@redhat.com; m...@ashroe.eu; >or...@nvidia.com; ch...@att.com; humi...@huawei.com; >linvi...@tuxdriver.com; ciara.lo

Re: [PATCH v10 4/4] eal: deprecation notice for rte thread setname API

2023-01-30 Thread Thomas Monjalon
Hi, The title should start with a verb. I suppose it can be fixed while merging with a title like: doc: announce deprecation of thread naming function 24/01/2023 19:12, Tyler Retzlaff: > Notify deprecation of rte_thread_setname API, it will be removed as it > exposes platform-specific thread det

RE: [EXT] Re: [PATCH v2] eventdev: add trace points

2023-01-30 Thread Amit Prakash Shukla
Thanks Jerin for the review and feedback. Sure, I will send next version of the patch without symbols. > -Original Message- > From: Jerin Jacob > Sent: Monday, January 30, 2023 8:02 PM > To: Amit Prakash Shukla > Cc: Jerin Jacob Kollanukkaran ; Abhinandan Gujjar > ; Naga Harish K S V >

RE: [PATCH v7] ethdev: add special flags when creating async transfer table

2023-01-30 Thread Rongwei Liu
HI Ivan BR Rongwei > -Original Message- > From: Ivan Malov > Sent: Monday, January 30, 2023 15:40 > To: Rongwei Liu > Cc: Matan Azrad ; Slava Ovsiienko > ; Ori Kam ; NBU-Contact- > Thomas Monjalon (EXTERNAL) ; Aman Singh > ; Yuying Zhang ; > Ferruh Yigit ; Andrew Rybchenko > ; dev@dpdk.

Re: [RFC] ethdev: add template table insertion and matching types

2023-01-30 Thread Thomas Monjalon
23/01/2023 23:02, Alexander Kozyrev: > > 21/01/2023 00:06, Alexander Kozyrev: > > > > 14/12/2022 03:21, Alexander Kozyrev: > > > > > Bring more flexibility and control over both flow rule insertion > > > > > and packet matching mechanisms. Introduce 2 new flow table types: > > > > > > > > > > 1. Al

Re: [PATCH v2 1/3] eventdev/eth_rx: add params set/get APIs

2023-01-30 Thread Jerin Jacob
On Mon, Jan 30, 2023 at 3:26 PM Naga Harish K, S V wrote: > > > > > -Original Message- > > From: Jerin Jacob > > Sent: Saturday, January 28, 2023 4:24 PM > > To: Naga Harish K, S V > > Cc: jer...@marvell.com; Carrillo, Erik G ; > > Gujjar, > > Abhinandan S ; dev@dpdk.org; > > Jayatheert

Re: [PATCH v2] eventdev: add trace points

2023-01-30 Thread Jerin Jacob
On Mon, Jan 30, 2023 at 3:44 PM Amit Prakash Shukla wrote: > > Add trace points for eventdev functions. > > Signed-off-by: Amit Prakash Shukla > --- > diff --git a/lib/eventdev/version.map b/lib/eventdev/version.map > index 4405cd38eb..f6ab242a3d 100644 > --- a/lib/eventdev/version.map > +++ b/l

RE: [PATCH] test/crypto: fix typo in AES test

2023-01-30 Thread Ji, Kai
Acked-by: Kai Ji > -Original Message- > From: Vikash Poddar > Sent: Monday, January 30, 2023 12:03 PM > To: Thomas Monjalon ; Akhil Goyal > ; Fan Zhang > Cc: dev@dpdk.org; Poddar, Vikash ChandraX > ; shi...@nvidia.com > Subject: [PATCH] test/crypto: fix typo in AES test > > Fix the spe

Re: [PATCH v2 1/2] vhost: fix possible FDs leak

2023-01-30 Thread David Marchand
On Mon, Jan 30, 2023 at 10:46 AM Maxime Coquelin wrote: > > > > On 1/29/23 10:25, David Marchand wrote: > > On Fri, Jan 27, 2023 at 5:55 PM Maxime Coquelin > > wrote: > >> > >> On failure, read_vhost_message() only closed the message > >> FDs if the header size was unexpected, but there are other

RE: [EXT] Re: [PATCH v6 1/6] eal: trace: add trace point emit for blob

2023-01-30 Thread Ankur Dwivedi
>-Original Message- >From: Ferruh Yigit >Sent: Wednesday, January 25, 2023 9:40 PM >To: Ankur Dwivedi ; dev@dpdk.org >Cc: tho...@monjalon.net; david.march...@redhat.com; m...@ashroe.eu; >or...@nvidia.com; ch...@att.com; humi...@huawei.com; >linvi...@tuxdriver.com; ciara.lof...@intel.com;

[PATCH v3 11/11] app/testpmd: adjust cleanup sequence when quitting

2023-01-30 Thread Rongwei Liu
If flex item is referenced in async flow either by pattern template or action template, currently testpmd complains "flex item has flow references". Flex items should be flushed after async flow resources cleanup. Signed-off-by: Rongwei Liu Acked-by: Ori Kam --- app/test-pmd/testpmd.c | 2 +- 1

[PATCH v3 10/11] doc/mlx5: update mlx5 doc

2023-01-30 Thread Rongwei Liu
Add flex item matching and modify field feature into mlx5 documents. Signed-off-by: Rongwei Liu Acked-by: Ori Kam --- doc/guides/nics/mlx5.rst | 1 + 1 file changed, 1 insertion(+) diff --git a/doc/guides/nics/mlx5.rst b/doc/guides/nics/mlx5.rst index f137f156f9..aceeeb462c 100644 --- a/doc/gu

[PATCH v3 09/11] app/testpmd: raw encap with flex item support

2023-01-30 Thread Rongwei Liu
Application should retrieve raw_encap buffer from spec->pattern if it is flex item. Signed-off-by: Rongwei Liu Acked-by: Ori Kam --- app/test-pmd/cmdline_flow.c | 26 +- 1 file changed, 17 insertions(+), 9 deletions(-) diff --git a/app/test-pmd/cmdline_flow.c b/app/test

[PATCH v3 08/11] net/mlx5: return error for sws modify field

2023-01-30 Thread Rongwei Liu
Return unsupported error message when application tries to modify flex item field. Validation of packet modifications actions for SW Steering checked if either source or destination field of MODIFY_FIELD action was a flex item. When DEC_TTL action is used, DEC_TTL action does not have any action c

[PATCH v3 07/11] net/mlx5: add flex item modify field implementation

2023-01-30 Thread Rongwei Liu
Add flex item modify field HWS implementation. The minimum modify boundary is one byte. Signed-off-by: Rongwei Liu Acked-by: Viacheslav Ovsiienko --- drivers/common/mlx5/mlx5_prm.h | 1 + drivers/net/mlx5/mlx5_flow.h| 3 + drivers/net/mlx5/mlx5_flow_dv.c | 165 +

[PATCH v3 06/11] net/mlx5/hws: add hws flex item matching support

2023-01-30 Thread Rongwei Liu
Support flex item matching in hws and syntax follows sws exactly. Flex item should be created in advance and follow current json mapping logic. Signed-off-by: Rongwei Liu Reviewed-by: Alex Vesker Acked-by: Viacheslav Ovsiienko --- drivers/net/mlx5/hws/mlx5dr_definer.c | 83 ++

[PATCH v3 04/11] net/mlx5: add IPv6 protocol as flex item input

2023-01-30 Thread Rongwei Liu
Support IPv6 protocol as new flex item input link. Signed-off-by: Rongwei Liu Acked-by: Viacheslav Ovsiienko --- drivers/net/mlx5/mlx5_flow_flex.c | 19 +++ 1 file changed, 19 insertions(+) diff --git a/drivers/net/mlx5/mlx5_flow_flex.c b/drivers/net/mlx5/mlx5_flow_flex.c inde

[PATCH v3 05/11] net/mlx5: adopt new flex item prm definition

2023-01-30 Thread Rongwei Liu
Per newest PRM definition, sample_id stands for 3 parts of information instead of single uint32_t id: sample_id + modify_filed_id + format_select_dw. Also new FW capability bits have been introduces to identify the new capability. Signed-off-by: Rongwei Liu Acked-by: Viacheslav Ovsiienko --- d

  1   2   >