Hi Thomas, PSB
> -----Original Message----- > From: Thomas Monjalon <tho...@monjalon.net> > Sent: Wednesday, January 18, 2023 4:55 PM > To: Leo Xu (Networking SW) <yongqu...@nvidia.com> > Cc: dev@dpdk.org; Matan Azrad <ma...@nvidia.com>; Slava Ovsiienko > <viachesl...@nvidia.com> > Subject: Re: [PATCH v2 2/3] net/mlx5: add ICMPv6 ID and sequence match > support > > External email: Use caution opening links or attachments > > > 20/12/2022 08:44, Leo Xu: > > --- a/doc/guides/nics/mlx5.rst > > +++ b/doc/guides/nics/mlx5.rst > > @@ -405,7 +405,7 @@ Limitations > > - The input buffer, providing the removal size, is not validated. > > - The buffer size must match the length of the headers to be removed. > > > > -- ICMP(code/type/identifier/sequence number) / ICMP6(code/type) > matching, IP-in-IP and MPLS flow matching are all > > +- ICMP(code/type/identifier/sequence number) / > ICMP6(code/type/identifier/sequence number) matching, IP-in-IP and MPLS > flow matching are all > > You can split the line after the comma. Ok, thanks. > > > mutually exclusive features which cannot be supported together > > (see :ref:`mlx5_firmware_config`). > > > > diff --git a/doc/guides/rel_notes/release_23_03.rst > b/doc/guides/rel_notes/release_23_03.rst > > index 5af9c43dd9..011c2489f7 100644 > > --- a/doc/guides/rel_notes/release_23_03.rst > > +++ b/doc/guides/rel_notes/release_23_03.rst > > @@ -60,6 +60,12 @@ New Features > > Added ``icmp6_echo`` item in rte_flow to support ID and sequence > > matching in ICMPv6 echo request/reply packets. > > > > +* **Updated Mellanox mlx5 driver.** > > + > > + Updated the Mellanox mlx5 driver with new features and improvements, > including: > > This sentence above can be removed. > We don't have this in recent release notes to keep it short. Ok, thanks, will update it in next patch. > > > + > > + * Added support for matching on ICMPv6 ID and sequence fields. > >
