Hi Thomas, PSB
> -----Original Message----- > From: Thomas Monjalon <tho...@monjalon.net> > Sent: Wednesday, January 18, 2023 4:58 PM > To: Leo Xu (Networking SW) <yongqu...@nvidia.com> > Cc: dev@dpdk.org; Matan Azrad <ma...@nvidia.com>; Slava Ovsiienko > <viachesl...@nvidia.com> > Subject: Re: [PATCH v2 3/3] net/mlx5/hws: add ICMPv6 ID and sequence match > support > > External email: Use caution opening links or attachments > > > 20/12/2022 08:44, Leo Xu: > > This patch adds ICMPv6 ID and sequence match support for HWS. > > Since type and code of ICMPv6 echo is already specified by ITEM type: > > RTE_FLOW_ITEM_TYPE_ICMP6_ECHO_REQUEST > > RTE_FLOW_ITEM_TYPE_ICMP6_ECHO_REPLY > > mlx5 pmd will set appropriate type and code automatically: > > Echo request: type(128), code(0) > > Echo reply: type(129), code(0) > > type and code provided by application will be ignored > > > > This patch also fixes these issues in ICMP definer. > > 1. Parsing inner ICMP item gets and overwrites the outer IP_PROTOCOL > > function, which will remove the outer L4 match incorrectly. Fix this > > by getting correct inner function. > > 2. Member order of mlx5_ifc_header_icmp_bits doesn't follow ICMP format. > > Reorder them to make it more consistent. > > Please don't fix stuff in the same patch as a new feature. > You should have one patch per fix. > The code for the new feature may be squashed in the other mlx5 patch for the > feature. > Thanks for that good catch. Actually, those "fix stuff" related sentences should be removed. I leave it there by accident. Will remove them, in next patch
