On Mon, Jan 30, 2023 at 05:19:20PM +0100, David Marchand wrote: > On Mon, Jan 30, 2023 at 4:47 PM Thomas Monjalon <tho...@monjalon.net> wrote: > > > > Hi, > > > > The title should start with a verb. > > I suppose it can be fixed while merging with a title like: > > doc: announce deprecation of thread naming function > > Yes, I will handle it. > > > 24/01/2023 19:12, Tyler Retzlaff: > > > Notify deprecation of rte_thread_setname API, it will be removed as it > > > exposes platform-specific thread details. The functionality it provided > > > is now available via the new rte_lcore_set_name API. > > > > > > Signed-off-by: Tyler Retzlaff <roret...@linux.microsoft.com> > > > Acked-by: Morten Brørup <m...@smartsharesystems.com> > > > Acked-by: David Marchand <david.march...@redhat.com> > > > --- > > > +* eal: The function ``rte_thread_setname`` is planned to be deprecated > > > + starting with the 23.07 release subject to the replacement API > > > + rte_thread_set_name being marked as stable and planned to be removed > > > + by the 23.11 release. > > > > Minor: it would be clearer if adding some commas after "release" and > > "stable". > > And this too. > > > > > > > For the series, > > Acked-by: Thomas Monjalon <tho...@monjalon.net> > > Thanks.
thank you both, i'll rebase the rte_ctrl_thread_create patch series once this is merged to get it moving forward again.
