RE: [PATCH v6 3/4] mempool: fix cache flushing algorithm

2022-10-14 Thread Morten Brørup
> From: Olivier Matz [mailto:olivier.m...@6wind.com] > Sent: Friday, 14 October 2022 21.51 > > On Fri, Oct 14, 2022 at 05:57:39PM +0200, Morten Brørup wrote: > > > From: Olivier Matz [mailto:olivier.m...@6wind.com] > > > Sent: Friday, 14 October 2022 16.01 > > > > > > Hi Morten, Andrew, > > > > >

[PATCH v2] dumpcap: fix select interface

2022-10-14 Thread Arshdeep Kaur
The change to do argument process before EAL init broke the support of select-interface option. Fix by setting flag and doing select-interface later. Fixes: a8dde09f97df ("app/dumpcap: allow help/version without primary process") Signed-off-by: Arshdeep Kaur --- app/dumpcap/main.c | 8 +++-

Re: [PATCH v1] dumpcap: fix select interface

2022-10-14 Thread Stephen Hemminger
On Fri, 14 Oct 2022 13:33:25 -0700 Arshdeep Kaur wrote: > The change to do argument process before EAL init broke > the support of select-interface option. Fix by setting flag > and doing select-interface later. > > Fixes: cbb44143be74 ("app/dumpcap: add new packet capture application") > > Sig

[PATCH 2/2] event/sw: fix invalid log in selftest

2022-10-14 Thread Olivier Matz
The log should display the value, not the id. Fixes: e21df4b062b5 ("test/eventdev: add SW xstats tests") Cc: sta...@dpdk.org Signed-off-by: Olivier Matz --- drivers/event/sw/sw_evdev_selftest.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/event/sw/sw_evdev_sel

[PATCH 1/2] event/sw: fix missing flow ID init in selftest

2022-10-14 Thread Olivier Matz
The issue is seen by unit tests: > root@dpdk-VF-dut247:~/dpdk# MALLOC_PERTURB_=204 \ > DPDK_TEST=eventdev_selftest_sw \ > /root/dpdk/x86_64-native-linuxapp-gcc/app/test/dpdk-test -c 0xff > (...) > *** Running XStats ID Reset test... > 12: 1761: qid_0_port_2_pinned_flows value , expected 1 got

[PATCH v1] dumpcap: fix select interface

2022-10-14 Thread Arshdeep Kaur
The change to do argument process before EAL init broke the support of select-interface option. Fix by setting flag and doing select-interface later. Fixes: cbb44143be74 ("app/dumpcap: add new packet capture application") Signed-off-by: Arshdeep Kaur --- app/dumpcap/main.c | 8 +++- 1 file

Re: [PATCH v6 3/4] mempool: fix cache flushing algorithm

2022-10-14 Thread Olivier Matz
On Fri, Oct 14, 2022 at 05:57:39PM +0200, Morten Brørup wrote: > > From: Olivier Matz [mailto:olivier.m...@6wind.com] > > Sent: Friday, 14 October 2022 16.01 > > > > Hi Morten, Andrew, > > > > On Sun, Oct 09, 2022 at 05:08:39PM +0200, Morten Brørup wrote: > > > > From: Andrew Rybchenko [mailto:an

[PATCH] raw/cnxk_bphy: extend pffunc address access

2022-10-14 Thread jpalider
From: Jakub Palider Allows retrieval of SSO and NPA pffunc addresses without device ownership and initialization. Signed-off-by: Jakub Palider --- drivers/raw/cnxk_bphy/cnxk_bphy.c| 16 drivers/raw/cnxk_bphy/rte_pmd_bphy.h | 23 +++ 2 files changed, 39

Re: [PATCH 2/4] eventdev: have ethernet Rx adapter appropriately report idle

2022-10-14 Thread Jerin Jacob
On Thu, Oct 13, 2022 at 3:23 PM Mattias Rönnblom wrote: > > On 2022-10-13 03:32, Naga Harish K, S V wrote: > > > > > >> -Original Message- > >> From: Jayatheerthan, Jay > >> Sent: Tuesday, October 11, 2022 12:40 PM > >> To: mattias.ronnblom ; Carrillo, Erik G > >> ; Gujjar, Abhinandan S >

[RFC 1/2] testpmd: make f_quit flag volatile

2022-10-14 Thread Stephen Hemminger
Since f_quit is set in a signal handler it needs to be marked as volatile. Otherwise, compler is allowed to optimize away access to it. Signed-off-by: Stephen Hemminger --- app/test-pmd/testpmd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/test-pmd/testpmd.c b/app/tes

[RFC 2/2] testpmd: cleanup cleanly from signal

2022-10-14 Thread Stephen Hemminger
The original behavior of testpmd was to kill itself when it received a SIGINT or SIGTERM. This makes it hard to use testpmd in test automation where forwarding loop is started and then stopped via SIGTERM. Signed-off-by: Stephen Hemminger --- app/test-pmd/testpmd.c | 76 +

RE: [PATCH v2] usertools: telemetry json support pretty print

2022-10-14 Thread Morten Brørup
> From: Bruce Richardson [mailto:bruce.richard...@intel.com] > Sent: Friday, 14 October 2022 17.30 > > On Fri, Oct 14, 2022 at 08:01:11AM -0700, Stephen Hemminger wrote: > > On Fri, 14 Oct 2022 14:02:10 +0100 > > Bruce Richardson wrote: > > > > > On Fri, Oct 14, 2022 at 12:44:33PM +, Power, C

RE: [PATCH v6 3/4] mempool: fix cache flushing algorithm

2022-10-14 Thread Morten Brørup
> From: Olivier Matz [mailto:olivier.m...@6wind.com] > Sent: Friday, 14 October 2022 16.01 > > Hi Morten, Andrew, > > On Sun, Oct 09, 2022 at 05:08:39PM +0200, Morten Brørup wrote: > > > From: Andrew Rybchenko [mailto:andrew.rybche...@oktetlabs.ru] > > > Sent: Sunday, 9 October 2022 16.52 > > > >

Re: [PATCH v2] usertools: telemetry json support pretty print

2022-10-14 Thread Bruce Richardson
On Fri, Oct 14, 2022 at 08:01:11AM -0700, Stephen Hemminger wrote: > On Fri, 14 Oct 2022 14:02:10 +0100 > Bruce Richardson wrote: > > > On Fri, Oct 14, 2022 at 12:44:33PM +, Power, Ciara wrote: > > > Hi Chengwen, > > > > > > > -Original Message- > > > > From: David Marchand > > >

Re: [PATCH v2] usertools: telemetry json support pretty print

2022-10-14 Thread Stephen Hemminger
On Fri, 14 Oct 2022 14:02:10 +0100 Bruce Richardson wrote: > On Fri, Oct 14, 2022 at 12:44:33PM +, Power, Ciara wrote: > > Hi Chengwen, > > > > > -Original Message- > > > From: David Marchand > > > Sent: Friday 14 October 2022 10:50 > > > To: Chengwen Feng > > > Cc: tho...@monjal

Re: [PATCH] usertools/pmdinfo: remove dependency to ldd

2022-10-14 Thread Olivier Matz
Hi Robin, On Thu, Oct 13, 2022 at 03:41:25PM +0200, Robin Jarry wrote: > Some environments (buildroot) do not have the ldd utility installed by > default. However, ldd is often only a wrapper shell script that actually > checks that the arguments are valid ELF files and executes them with > the LD

Re: [PATCH v4] mempool: fix get objects from mempool with cache

2022-10-14 Thread Olivier Matz
On Sat, Oct 08, 2022 at 10:56:06PM +0200, Thomas Monjalon wrote: > 07/10/2022 12:44, Andrew Rybchenko: > > From: Morten Brørup > > > > A flush threshold for the mempool cache was introduced in DPDK version > > 1.3, but rte_mempool_do_generic_get() was not completely updated back > > then, and som

Re: [PATCH v6 4/4] mempool: flush cache completely on overflow

2022-10-14 Thread Olivier Matz
On Sun, Oct 09, 2022 at 04:44:08PM +0200, Morten Brørup wrote: > > From: Andrew Rybchenko [mailto:andrew.rybche...@oktetlabs.ru] > > Sent: Sunday, 9 October 2022 15.38 > > To: Olivier Matz > > Cc: dev@dpdk.org; Morten Brørup; Bruce Richardson > > Subject: [PATCH v6 4/4] mempool: flush cache complet

Re: [PATCH v6 3/4] mempool: fix cache flushing algorithm

2022-10-14 Thread Olivier Matz
Hi Morten, Andrew, On Sun, Oct 09, 2022 at 05:08:39PM +0200, Morten Brørup wrote: > > From: Andrew Rybchenko [mailto:andrew.rybche...@oktetlabs.ru] > > Sent: Sunday, 9 October 2022 16.52 > > > > On 10/9/22 17:31, Morten Brørup wrote: > > >> From: Andrew Rybchenko [mailto:andrew.rybche...@oktetlab

Re: [PATCH] doc: update sample action description for mlx5

2022-10-14 Thread Thomas Monjalon
14/10/2022 12:14, Jiawei Wang: > This patch adds mlx5 description about E-Switch mirroring > flow (RTE_FLOW_ACTION_TYPE_SAMPLE with sample ratio=1) with > encap action, then supports the uplink port only in the sample > actions list or in the one flow. > > Signed-off-by: Jiawei Wang [...] > + -

Re: baseband PMD APIs

2022-10-14 Thread Thomas Monjalon
14/10/2022 03:46, Chautru, Nicolas: > Hi, > There are a few options: > 1) Keep as is, but not too scalable to keep on adding PMD APIs. Still there > is no plan on adding more API, so no rush. > 2) Keep API internal only (but in that case only work with static lib I > believe) > 3) Take out off

Re: [PATCH v2] usertools: telemetry json support pretty print

2022-10-14 Thread Bruce Richardson
On Fri, Oct 14, 2022 at 12:44:33PM +, Power, Ciara wrote: > Hi Chengwen, > > > -Original Message- > > From: David Marchand > > Sent: Friday 14 October 2022 10:50 > > To: Chengwen Feng > > Cc: tho...@monjalon.net; dev@dpdk.org; Power, Ciara > > > > Subject: Re: [PATCH v2] usertools:

RE: [PATCH v2] usertools: telemetry json support pretty print

2022-10-14 Thread Power, Ciara
Hi Chengwen, > -Original Message- > From: David Marchand > Sent: Friday 14 October 2022 10:50 > To: Chengwen Feng > Cc: tho...@monjalon.net; dev@dpdk.org; Power, Ciara > > Subject: Re: [PATCH v2] usertools: telemetry json support pretty print > > On Fri, Oct 14, 2022 at 5:31 AM Chengwe

Re: [PATCH v2] doc: fix support table for ETH and VLAN flow items

2022-10-14 Thread Ilya Maximets
On 10/14/22 11:41, fengchengwen wrote: > Hi Ilya, > >I have some questions about has_vlan/has_more_vlan fields: I think, these questions are more for rte_flow maintainers, but I'll try answer. Maintainers can correct me if I'm wrong. > >a\ DPDK framework support cvlan-tag(0x8100) and s

RE: [EXT] [PATCH resend v3 0/6] crypto/uadk: introduce uadk crypto driver

2022-10-14 Thread Akhil Goyal
> Hi Zhangfei, > > Hi, Akhil > > > > On 2022/10/11 下午5:22, Akhil Goyal wrote: > > gakhil@cavium-SR1-T640:/home/gakhil/up/uadk$ make > > make all-recursive > > make[1]: Entering directory '/home/gakhil/up/uadk' > > Making all in . > > make[2]: Entering directory '/home/gakh

[v3 18/18] net/mlx5/hws: Enable HWS

2022-10-14 Thread Alex Vesker
Replace stub implenation of HWS with mlx5dr code. Signed-off-by: Alex Vesker --- drivers/common/mlx5/linux/meson.build| 2 + drivers/net/mlx5/hws/meson.build | 18 + drivers/net/mlx5/{mlx5_dr.h => hws/mlx5dr.h} | 210 -- drivers/net/mlx5/hws/mlx5dr_internal.h

[v3 16/18] net/mlx5/hws: Add HWS action object

2022-10-14 Thread Alex Vesker
Action objects are used for executing different HW actions over packets. Each action contains the HW resources and parameters needed for action use over the HW when creating a rule. Signed-off-by: Erez Shitrit Signed-off-by: Alex Vesker --- drivers/net/mlx5/hws/mlx5dr_action.c | 2221 +

[v3 17/18] net/mlx5/hws: Add HWS debug layer

2022-10-14 Thread Alex Vesker
From: Hamdan Igbaria The debug layer is used to generate a debug CSV file containing details of the context, table, matcher, rules and other useful debug information. Signed-off-by: Hamdan Igbaria Signed-off-by: Alex Vesker --- drivers/net/mlx5/hws/mlx5dr_debug.c | 462 +++

[v3 15/18] net/mlx5/hws: Add HWS rule object

2022-10-14 Thread Alex Vesker
HWS rule objects reside under the matcher, each rule holds the configuration for the packet fields to match on and the set of actions to execute over the packet that has the requested fields. Rules can be created asynchronously in parallel over multiple queues to different matchers. Each rule is co

[v3 14/18] net/mlx5/hws: Add HWS matcher object

2022-10-14 Thread Alex Vesker
HWS matcher resides under the table object, each table can have multiple chained matcher with different attributes. Each matcher represents a combination of match and action templates. Each matcher can contain multiple configurations based on the templates. Packets are steered from the table to the

[v3 12/18] net/mlx5/hws: Add HWS context object

2022-10-14 Thread Alex Vesker
Context is the first mlx5dr object created, all sub object: table, matcher, rule, action are created using the context. The context holds the capabilities and send queues used for configuring the offloads to the HW. Signed-off-by: Alex Vesker --- drivers/net/mlx5/hws/mlx5dr_context.c | 223 +

[v3 13/18] net/mlx5/hws: Add HWS table object

2022-10-14 Thread Alex Vesker
HWS table resides under the context object, each context can have multiple tables with different steering types RX/TX/FDB. The table is not only a logical object but it is also represented in the HW, packets can be steered to the table and from there to other tables. Signed-off-by: Erez Shitrit S

[v3 11/18] net/mlx5/hws: Add HWS definer layer

2022-10-14 Thread Alex Vesker
Definers are HW objects that are used for matching, rte items are translated to definers, each definer holds the fields and bit-masks used for HW flow matching. The definer layer is used for finding the most efficient definer for each set of items. In addition to definer creation we also calculate

[v3 08/18] net/mlx5/hws: Add HWS command layer

2022-10-14 Thread Alex Vesker
From: Erez Shitrit The command layer is used to communicate with the FW, query capabilities and allocate FW resources needed for HWS. Signed-off-by: Erez Shitrit Signed-off-by: Alex Vesker --- drivers/common/mlx5/mlx5_prm.h| 607 ++- drivers/net/mlx5/hws/mlx5dr_cmd.c | 948

[v3 10/18] net/mlx5/hws: Add HWS send layer

2022-10-14 Thread Alex Vesker
HWS configures flows to the HW using a QP, each WQE has the details of the flow we want to offload. The send layer allocates the resources needed to send the request to the HW as well as managing the queues, getting completions and handling failures. Signed-off-by: Mark Bloch Signed-off-by: Alex

[v3 09/18] net/mlx5/hws: Add HWS pool and buddy

2022-10-14 Thread Alex Vesker
From: Erez Shitrit HWS needs to manage different types of device memory in an efficient and quick way. For this, memory pools are being used. Signed-off-by: Erez Shitrit Signed-off-by: Alex Vesker --- drivers/net/mlx5/hws/mlx5dr_buddy.c | 201 + drivers/net/mlx5/hws/mlx5dr_buddy.h |

[v3 06/18] net/mlx5: provide the available tag registers

2022-10-14 Thread Alex Vesker
From: Bing Zhao The available tags that can be used by the application are fixed after startup. A global array is used to store the information and transfer the TAG item directly from the ID to the REG_C_x. Signed-off-by: Bing Zhao --- drivers/net/mlx5/linux/mlx5_os.c | 2 + drivers/net/mlx5

[v3 07/18] net/mlx5: Add additional glue functions for HWS

2022-10-14 Thread Alex Vesker
Add missing glue support for HWS mlx5dr layer. The new glue functions are needed for mlx5dv create matcher and action, which are used as the kernel root table as well as for capabilities query like device name and ports info. Signed-off-by: Alex Vesker --- drivers/common/mlx5/linux/mlx5_glue.c |

[v3 03/18] net/mlx5: add hardware steering item translation function

2022-10-14 Thread Alex Vesker
From: Suanming Mou As hardware steering root table flows still work under FW steering mode. This commit provides shared item tranlsation code for hardware steering root table flows. Signed-off-by: Suanming Mou --- drivers/net/mlx5/mlx5_flow.c| 10 +-- drivers/net/mlx5/mlx5_flow.h| 52

[v3 05/18] common/mlx5: query set capability of registers

2022-10-14 Thread Alex Vesker
From: Bing Zhao In the flow table capabilities, new fields are added to query the capability to set, add, copy to a REG_C_x. The set capability are queried and saved for the future usage. Signed-off-by: Bing Zhao --- drivers/common/mlx5/mlx5_devx_cmds.c | 30 +++ drivers/commo

[v3 02/18] net/mlx5: split flow item matcher and value translation

2022-10-14 Thread Alex Vesker
From: Suanming Mou As hardware steering mode translates flow matcher and value in two different stages, split the flow item matcher and value translation to help reuse the code. Signed-off-by: Suanming Mou --- drivers/net/mlx5/mlx5_flow.h| 32 + drivers/net/mlx5/mlx5_flow_dv.c | 2314 +++

[v3 04/18] net/mlx5: add port to metadata conversion

2022-10-14 Thread Alex Vesker
From: Dariusz Sosnowski This patch initial version of functions used to: - convert between ethdev port_id and internal tag/mask value, - convert between IB context and internal tag/mask value. Signed-off-by: Dariusz Sosnowski --- drivers/net/mlx5/linux/mlx5_os.c | 10 +- drivers/net/mlx5/

[v3 01/18] net/mlx5: split flow item translation

2022-10-14 Thread Alex Vesker
From: Suanming Mou In order to share the item translation code with hardware steering mode, this commit splits flow item translation code to a dedicate function. Signed-off-by: Suanming Mou --- drivers/net/mlx5/mlx5_flow_dv.c | 1915 --- 1 file changed, 979 insertio

[v3 00/18] net/mlx5: Add HW steering low level support

2022-10-14 Thread Alex Vesker
Mellanox ConnetX devices supports packet matching, packet modification and redirection. These functionalities are also referred to as flow-steering. To configure a steering rule, the rule is written to the device owned memory, this memory is accessed and cached by the device when processing a packe

RE: [EXT] [PATCH resend v3 0/6] crypto/uadk: introduce uadk crypto driver

2022-10-14 Thread Akhil Goyal
Hi Zhangfei, > Hi, Akhil > > On 2022/10/11 下午5:22, Akhil Goyal wrote: > gakhil@cavium-SR1-T640:/home/gakhil/up/uadk$ make > make all-recursive > make[1]: Entering directory '/home/gakhil/up/uadk' > Making all in . > make[2]: Entering directory '/home/gakhil/up/uadk' > >>>

Re: [PATCH] doc: add deprecation notice for inconsistent socket_id types

2022-10-14 Thread Jerin Jacob
On Fri, Oct 14, 2022 at 1:39 PM Markus Theil wrote: > > DPDK uses many different types for socket_id's in its whole code > base. This leads to many warnings and casts in DPDK-based applications > compiled with -Wconversion. > > Announce a treewide consolidation to the return type of rte_socket_id

RE: [EXT] [PATCH v2] common/qat: read hw slice configuration

2022-10-14 Thread Akhil Goyal
> Read slice configuration of QAT capabilities. > This will allow to recognize if specific hw function > is available on particular device. > > Signed-off-by: Arek Kusztal Spit the patch into 2. - common/qat for adding the function pointer and implementation - crypto/qat for calling that function

[Bug 1076] [dpdk 22.11] kernel/linux/kni meson build failed with gcc 11.3.1 on rhel9.0

2022-10-14 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=1076 Ferruh YIGIT (ferr...@gmail.com) changed: What|Removed |Added Ever confirmed|0 |1 Resolution|INVALID

[PATCH] doc: update sample action description for mlx5

2022-10-14 Thread Jiawei Wang
This patch adds mlx5 description about E-Switch mirroring flow (RTE_FLOW_ACTION_TYPE_SAMPLE with sample ratio=1) with encap action, then supports the uplink port only in the sample actions list or in the one flow. Signed-off-by: Jiawei Wang --- doc/guides/nics/mlx5.rst | 2 ++ 1 file changed, 2

RE: [PATCH v3] app/testpmd: fix incorrect queues state of secondary process

2022-10-14 Thread Zhou, YidingX
> > > + if (rte_eal_process_type() != RTE_PROC_PRIMARY) { > > + struct fwd_stream *fs = fwd_streams[i]; > > + struct rte_eth_dev_data *dev_rx_data, > *dev_tx_data; > > + > > + dev_rx_data = (&rte_eth_de

Re: [PATCH v3 17/30] baseband/acc100: add HARQ index helper function

2022-10-14 Thread Maxime Coquelin
On 10/12/22 04:53, Hernan Vargas wrote: Refactor code to use the HARQ index helper function and make harq_idx uint32. Signed-off-by: Hernan Vargas No new line Reviewed-by: Maxime Coquelin --- drivers/baseband/acc/rte_acc100_pmd.c | 29 +++ 1 file changed, 12 i

Re: [PATCH v3 16/30] baseband/acc100: add scatter-gather support

2022-10-14 Thread Maxime Coquelin
On 10/12/22 04:53, Hernan Vargas wrote: Add flag to support scatter-gather for the mbuf Signed-off-by: Hernan Vargas No new line Reviewed-by: Maxime Coquelin --- drivers/baseband/acc/rte_acc100_pmd.c | 37 ++- 1 file changed, 25 insertions(+), 12 deletions(-)

Re: [PATCH v3 15/30] baseband/acc100: add enqueue status

2022-10-14 Thread Maxime Coquelin
On 10/12/22 04:53, Hernan Vargas wrote: Add enqueue status as part of rte_bbdev_queue_data. This is a new feature to update queue status and indicate the reason why a previous enqueue may or may not have consumed all requested operations. Signed-off-by: Hernan Vargas No new line Reviewed

Re: [PATCH v3 14/30] baseband/acc100: fix debug print for LDPC FCW

2022-10-14 Thread Maxime Coquelin
On 10/12/22 04:53, Hernan Vargas wrote: Print full size of FCW LDPC structure on debug messages. This is just a cosmetic fix, no need to fix on previous code base. Signed-off-by: Hernan Vargas No new line Reviewed-by: Maxime Coquelin --- drivers/baseband/acc/rte_acc100_pmd.c | 2 +-

Re: [PATCH v3 13/30] baseband/acc100: reset pointer after rte_free

2022-10-14 Thread Maxime Coquelin
On 10/12/22 04:53, Hernan Vargas wrote: Set local pointer to NULL after rte_free. This needs to be set explicitly since logic may check for null pointers. Fixes: 060e7672930 ("baseband/acc100: add queue configuration") Cc: sta...@dpdk.org Signed-off-by: Hernan Vargas No new line Reviewe

Re: [PATCH v3 12/30] baseband/acc100: add protection for NULL HARQ input

2022-10-14 Thread Maxime Coquelin
On 10/12/22 04:53, Hernan Vargas wrote: It is possible to cause an invalid HW operation in case the user provides the BBDEV API and HARQ operation with input enabled and zero input. Adding protection for that case. Fixes: 5ad5060f8f7 ("baseband/acc100: add LDPC processing functions") Cc: sta.

Re: [PATCH v3 11/30] baseband/acc100: set device min alignment to 1

2022-10-14 Thread Maxime Coquelin
On 10/12/22 04:53, Hernan Vargas wrote: Historical mistakes, there should be no 64B alignment requirement for the buffer being processed. Any 1B alignment is sufficient. Fixes: 9200ffa5cd5 ("baseband/acc100: add info get function") Cc: sta...@dpdk.org Signed-off-by: Hernan Vargas No new l

RE: [PATCH 3/3] net/txgbe: fix security session destroy

2022-10-14 Thread Jiawen Wu
On Thursday, October 13, 2022 8:19 PM, Radu Nicolau wrote: > Replace mempool_put with memset 0, the internal session memory block is no > longer allocated from > a mempool > > Fixes: 3f3fc3308bd0 ("security: remove private mempool usage") > Cc: gak...@marvell.com > > Signed-off-by: Radu Nicolau

Re: [PATCH v3 10/30] baseband/acc100: fix clearing PF IR outside handler

2022-10-14 Thread Maxime Coquelin
On 10/12/22 04:53, Hernan Vargas wrote: Clearing of PF info ring outside of handler may cause interrupt to be missed. A condition in the ACC100 PMD implementation may cause an interrupt functional handler call to be missed due to related bit being cleared when checking PF info ring status. Fi

Re: [PATCH v3 09/30] baseband/acc100: reduce input length for CRC24B

2022-10-14 Thread Maxime Coquelin
On 10/12/22 04:53, Hernan Vargas wrote: Input length should be reduced only for CRC24B. Fixes: 5ad5060f8f7 ("baseband/acc100: add LDPC processing functions") Cc: sta...@dpdk.org Signed-off-by: Hernan Vargas --- drivers/baseband/acc/rte_acc100_pmd.c | 3 +-- 1 file changed, 1 insertion(+)

Re: [PATCH v3 08/30] baseband/acc100: allocate ring/queue mem when NULL

2022-10-14 Thread Maxime Coquelin
On 10/12/22 04:53, Hernan Vargas wrote: Allocate info ring, tail pointers and HARQ layout memory for a device only if it hasn't already been allocated. Fixes: 06531464151 ("baseband/acc100: support interrupt") Cc: sta...@dpdk.org Signed-off-by: Hernan Vargas --- drivers/baseband/acc/rte_a

RE: [PATCH] app/testpmd: remove useless check

2022-10-14 Thread Wang, YuanX
Hi Singh, > -Original Message- > From: Singh, Aman Deep > Sent: Friday, October 14, 2022 5:37 PM > To: Wang, YuanX ; Zhang, Yuying > > Cc: dev@dpdk.org; Ding, Xuan ; Tang, Yaqi > > Subject: Re: [PATCH] app/testpmd: remove useless check > > Thanks for the patch Yuan. > > On 10/12/2022

[PATCH] net/iavf: fix SPI check

2022-10-14 Thread Radu Nicolau
Return error if SPI from the flow spec doesn't match the one from the crypto session. Fixes: 6bc987ecb860 ("net/iavf: support IPsec inline crypto") Cc: sta...@dpdk.org Signed-off-by: Radu Nicolau --- drivers/net/iavf/iavf_ipsec_crypto.c | 14 +++--- 1 file changed, 3 insertions(+), 11 d

Re: [PATCH v2] usertools: telemetry json support pretty print

2022-10-14 Thread David Marchand
On Fri, Oct 14, 2022 at 5:31 AM Chengwen Feng wrote: > > Currently, the dpdk-telemetry.py show json in raw format, which is not > good for human reading. > > E.g. The command '/ethdev/xstats,0' will output: > {"/ethdev/xstats": {"rx_good_packets": 0, "tx_good_packets": 0, > "rx_good_bytes": 0, "tx

Re: [PATCH v3 07/30] baseband/acc100: enforce additional check on FCW

2022-10-14 Thread Maxime Coquelin
On 10/12/22 04:53, Hernan Vargas wrote: Enforce additional check on Frame Control Word validity and add stronger alignment for decompression mode. Fixes: 5ad5060f8f7 ("baseband/acc100: add LDPC processing functions") Cc: sta...@dpdk.org Signed-off-by: Hernan Vargas --- drivers/baseband/ac

Re: [PATCH v2] doc: fix support table for ETH and VLAN flow items

2022-10-14 Thread fengchengwen
Hi Ilya, I have some questions about has_vlan/has_more_vlan fields: a\ DPDK framework support cvlan-tag(0x8100) and svlan-tag(0x88A8), and also deprecated qinq-tag(eg. 0x9100) b\ If has_vlan is used, does it mean that all the VLAN tags(0x8100/88A8/9100) must be matched ? I think

Re: [PATCH v2] net/nfp: add the feature of RSS based on VXLAN inner layer

2022-10-14 Thread Ferruh Yigit
On 10/14/2022 10:40 AM, Ferruh Yigit wrote: On 10/14/2022 10:09 AM, Chaoyong He wrote: diff --git a/drivers/net/nfp/nfp_ethdev.c b/drivers/net/nfp/nfp_ethdev.c index e131021..d938e01 100644 --- a/drivers/net/nfp/nfp_ethdev.c +++ b/drivers/net/nfp/nfp_ethdev.c @@ -33,7 +33,6 @@   #include "nfpcor

Re: [PATCH v2] net/nfp: add the feature of RSS based on VXLAN inner layer

2022-10-14 Thread Ferruh Yigit
On 10/14/2022 10:09 AM, Chaoyong He wrote: diff --git a/drivers/net/nfp/nfp_ethdev.c b/drivers/net/nfp/nfp_ethdev.c index e131021..d938e01 100644 --- a/drivers/net/nfp/nfp_ethdev.c +++ b/drivers/net/nfp/nfp_ethdev.c @@ -33,7 +33,6 @@ #include "nfpcore/nfp_nsp.h" #include "nfp_common.h" -#

Re: [PATCH v3 06/30] baseband/acc100: check for unlikely operation vals

2022-10-14 Thread Maxime Coquelin
On 10/12/22 04:53, Hernan Vargas wrote: Add unlikely checks for NULL operation values. Fixes: f404dfe35cc ("baseband/acc100: support 4G processing") Cc: sta...@dpdk.org Signed-off-by: Hernan Vargas Reviewed-by: Maxime Coquelin --- drivers/baseband/acc/rte_acc100_pmd.c | 10 ++

Re: [PATCH] app/testpmd: remove useless check

2022-10-14 Thread Singh, Aman Deep
Thanks for the patch Yuan. On 10/12/2022 7:59 PM, Yuan Wang wrote: Protocol header sequence checking is supported in the ethdev library, the application does not need to do it again. I would like to rephrase the patch title to make it more specific. Like "remove useless check" to "remove unuse

Re: [PATCH v3 05/30] baseband/acc100: check turbo dec/enc input

2022-10-14 Thread Maxime Coquelin
On 10/12/22 04:53, Hernan Vargas wrote: Add NULL check for the turbo decoder and encoder input length. Fixes: 3bfc5f60403 ("baseband/acc100: add debug function to validate input") Do not wrap the fixes line, even if checkpatch emits a warning. Cc: sta...@dpdk.org Signed-off-by: Hernan Va

Re: [PATCH v3 04/30] baseband/acc100: add LDPC encoder padding function

2022-10-14 Thread Maxime Coquelin
On 10/12/22 04:53, Hernan Vargas wrote: LDPC Encoder input may need to be padded to avoid small beat for ACC100. Padding 5GDL input buffer length (BLEN) to avoid case (BLEN % 64) <= 8. Adding protection for corner case to avoid for 5GDL occurrence of last beat within the ACC100 fabric with <=

RE: [PATCH] net/nfp: add the feature of RSS based on VXLAN inner layer

2022-10-14 Thread Chaoyong He
> On 10/14/2022 2:15 AM, Chaoyong He wrote: > >> On 10/10/2022 7:28 AM, Chaoyong He wrote: > >>> Add the logics to support the feature of RSS packets based on the > >>> inner layer of VXLAN tunnel. > >>> > >>> Signed-off-by: Chaoyong He > >>> Reviewed-by: Niklas Söderlund > >>> > >>> Depends-on:

Re: [PATCH v3 03/30] baseband/acc100: memory leak fix

2022-10-14 Thread Maxime Coquelin
On 10/12/22 04:53, Hernan Vargas wrote: Move check for undefined device before allocating queue data structure. Coverity issue: 375803, 375813, 375819, 375827, 375831 Fixes: 060e7672930 ("baseband/acc100: add queue configuration") Cc: sta...@dpdk.org Signed-off-by: Hernan Vargas No new li

Re: [PATCH v3 02/30] baseband/acc100: add function to check AQ availability

2022-10-14 Thread Maxime Coquelin
On 10/12/22 04:53, Hernan Vargas wrote: It is possible for some corner case to run more batch enqueue than supported. A protection is required to avoid that corner case. Enhance all ACC100 enqueue operations with check to see if there is room in the atomic queue for enqueueing batches into the

RE: [PATCH v2 14/14] net/idpf: add support for timestamp offload

2022-10-14 Thread Guo, Junfeng
> -Original Message- > From: Andrew Rybchenko > Sent: Monday, October 3, 2022 22:22 > To: Guo, Junfeng ; Zhang, Qi Z > ; Wu, Jingjing ; Xing, > Beilei > Cc: dev@dpdk.org; Wang, Xiao W ; Qiao, > Wenjing > Subject: Re: [PATCH v2 14/14] net/idpf: add support for timestamp > offload > >

RE: [PATCH v2 13/14] net/idpf: add AVX512 data path for single queue model

2022-10-14 Thread Guo, Junfeng
> -Original Message- > From: Andrew Rybchenko > Sent: Monday, October 3, 2022 22:21 > To: Guo, Junfeng ; Zhang, Qi Z > ; Wu, Jingjing ; Xing, > Beilei > Cc: dev@dpdk.org; Wang, Xiao W ; Wu, > Wenjun1 ; Thomas Monjalon > > Subject: Re: [PATCH v2 13/14] net/idpf: add AVX512 data path for

RE: [PATCH v2 10/14] net/idpf: add support for mtu configuration

2022-10-14 Thread Guo, Junfeng
> -Original Message- > From: Andrew Rybchenko > Sent: Monday, October 3, 2022 22:12 > To: Guo, Junfeng ; Zhang, Qi Z > ; Wu, Jingjing ; Xing, > Beilei > Cc: dev@dpdk.org; Wang, Xiao W > Subject: Re: [PATCH v2 10/14] net/idpf: add support for mtu configuration > > On 9/5/22 13:58, Junf

RE: [PATCH v2 08/14] net/idpf: add support for basic Rx/Tx datapath

2022-10-14 Thread Guo, Junfeng
> -Original Message- > From: Andrew Rybchenko > Sent: Monday, October 3, 2022 22:03 > To: Guo, Junfeng ; Zhang, Qi Z > ; Wu, Jingjing ; Xing, > Beilei > Cc: dev@dpdk.org; Wang, Xiao W ; Li, Xiaoyun > > Subject: Re: [PATCH v2 08/14] net/idpf: add support for basic Rx/Tx > datapath > >

RE: [PATCH v2 06/14] net/idpf: add support for packet type get

2022-10-14 Thread Guo, Junfeng
> -Original Message- > From: Andrew Rybchenko > Sent: Monday, October 3, 2022 21:59 > To: Guo, Junfeng ; Zhang, Qi Z > ; Wu, Jingjing ; Xing, > Beilei > Cc: dev@dpdk.org; Wang, Xiao W ; Wu, > Wenjun1 > Subject: Re: [PATCH v2 06/14] net/idpf: add support for packet type get > > On 9/5/

RE: [PATCH v2 03/14] net/idpf: add support for device initialization

2022-10-14 Thread Guo, Junfeng
> -Original Message- > From: Andrew Rybchenko > Sent: Monday, October 3, 2022 21:44 > To: Guo, Junfeng ; Zhang, Qi Z > ; Wu, Jingjing ; Xing, > Beilei > Cc: dev@dpdk.org; Wang, Xiao W ; Li, Xiaoyun > > Subject: Re: [PATCH v2 03/14] net/idpf: add support for device > initialization > >

RE: [PATCH v2 04/14] net/idpf: add support for queue operations

2022-10-14 Thread Guo, Junfeng
> -Original Message- > From: Andrew Rybchenko > Sent: Monday, October 3, 2022 21:48 > To: Guo, Junfeng ; Zhang, Qi Z > ; Wu, Jingjing ; Xing, > Beilei > Cc: dev@dpdk.org; Wang, Xiao W ; Li, Xiaoyun > > Subject: Re: [PATCH v2 04/14] net/idpf: add support for queue operations > > On 9/5

RE: [PATCH v2 02/14] net/idpf/base: add logs and OS specific implementation

2022-10-14 Thread Guo, Junfeng
> -Original Message- > From: Andrew Rybchenko > Sent: Monday, October 3, 2022 21:20 > To: Guo, Junfeng ; Zhang, Qi Z > ; Wu, Jingjing ; Xing, > Beilei > Cc: dev@dpdk.org; Wang, Xiao W > Subject: Re: [PATCH v2 02/14] net/idpf/base: add logs and OS specific > implementation > > On 9/5/2

RE: [PATCH v2 01/14] net/idpf/base: introduce base code

2022-10-14 Thread Guo, Junfeng
> -Original Message- > From: Andrew Rybchenko > Sent: Monday, October 3, 2022 21:20 > To: Guo, Junfeng ; Zhang, Qi Z > ; Wu, Jingjing ; Xing, > Beilei > Cc: dev@dpdk.org; Wang, Xiao W > Subject: Re: [PATCH v2 01/14] net/idpf/base: introduce base code > > On 9/5/22 13:58, Junfeng Guo w

Re: [PATCH v3 01/30] baseband/acc100: fix ring availability calculation

2022-10-14 Thread Maxime Coquelin
Hi Hernan, On 10/12/22 04:53, Hernan Vargas wrote: Refactor of the queue availability computation to prevent the application to dequeue more than what may have been enqueued. Fixes: 5ad5060f8f7 ("baseband/acc100: add LDPC processing functions") Cc: sta...@dpdk.org Signed-off-by: Hernan Vargas

[PATCH v2] net/nfp: add the feature of RSS based on VXLAN inner layer

2022-10-14 Thread Chaoyong He
Add the logics to support the feature of RSS packets based on the inner layer of VXLAN tunnel. Signed-off-by: Chaoyong He Reviewed-by: Niklas Söderlund * Changes since v1 - Don't expose the dependency relation of header files to source files. Depends-on: series-24819 ("preparation for the rte_

Re: [PATCH v4 2/2] build: export dpdk_includes for subproject usage

2022-10-14 Thread Bruce Richardson
On Fri, Oct 14, 2022 at 09:51:18AM +0200, Markus Theil wrote: > In order to perform things like LTO more easily in > our DPDK applications, we use DPDK as a meson subproject. > Also export includes in order to be usable in this context. > > Signed-off-by: Markus Theil > --- Acked-by: Bruce Richar

Re: [PATCH v4 1/2] build: allow to conditionally build apps

2022-10-14 Thread Bruce Richardson
On Fri, Oct 14, 2022 at 09:51:17AM +0200, Markus Theil wrote: > Makes apps configurable from meson, like already > possible for drivers. > > Signed-off-by: Markus Theil > --- Seems reasonable enough. Acked-by: Bruce Richardson

Re: [PATCH] net/nfp: add the feature of RSS based on VXLAN inner layer

2022-10-14 Thread Ferruh Yigit
On 10/14/2022 2:15 AM, Chaoyong He wrote: On 10/10/2022 7:28 AM, Chaoyong He wrote: Add the logics to support the feature of RSS packets based on the inner layer of VXLAN tunnel. Signed-off-by: Chaoyong He Reviewed-by: Niklas Söderlund Depends-on: series-24819 ("preparation for the rte_flow

Re: [EXT] [PATCH v3 5/9] trace: fix dynamically enabling trace points

2022-10-14 Thread Jerin Jacob
On Fri, Oct 14, 2022 at 1:49 PM David Marchand wrote: > > On Fri, Oct 14, 2022 at 6:27 AM Jerin Jacob wrote: > > > > On Fri, Oct 14, 2022 at 12:41 AM David Marchand > > wrote: > > > > > > On Thu, Oct 13, 2022 at 7:07 PM Harman Kalra wrote: > > > > > > > > > > With the whole traces fixes series

Re: [EXT] [PATCH v3 5/9] trace: fix dynamically enabling trace points

2022-10-14 Thread David Marchand
On Fri, Oct 14, 2022 at 6:27 AM Jerin Jacob wrote: > > On Fri, Oct 14, 2022 at 12:41 AM David Marchand > wrote: > > > > On Thu, Oct 13, 2022 at 7:07 PM Harman Kalra wrote: > > > > > > > > With the whole traces fixes series applied first, then the new "trace: > > > > take live traces via telemetr

[PATCH] doc: add deprecation notice for inconsistent socket_id types

2022-10-14 Thread Markus Theil
DPDK uses many different types for socket_id's in its whole code base. This leads to many warnings and casts in DPDK-based applications compiled with -Wconversion. Announce a treewide consolidation to the return type of rte_socket_id in DPDK 23.11. Signed-off-by: Markus Theil --- doc/guides/rel

Re: [PATCH v3 2/2] build: export dpdk_includes for subproject usage.

2022-10-14 Thread Markus Theil
On 10/13/22 18:38, Bruce Richardson wrote: Rather than changing all these meson.build files, I think we should be able to check in drivers/meson.build if the "headers" array is empty. If not, then add the include path, otherwise skip it. Thanks for the feedback. Changed in v4. /Bruce

[PATCH v2 1/2] eal: expose lcore pthread id

2022-10-14 Thread Markus Theil
From: Michael Pfeiffer Also expose the pthread id of each lcore, in order to allow modification of pthread attributes, for example use rte_thread_setname without executing pthread_self() on the maybe already running lcore. The rte_lcore_to_thread_id function is added to API. Signed-off-by: Mich

[PATCH v2 2/2] eal: prevent OOB read in rte_lcore_to_socket_id

2022-10-14 Thread Markus Theil
rte_lcore_to_socket_id did not check the lcore_id range before accessing an array with RTE_MAX_LCORE elements. Signed-off-by: Markus Theil --- lib/eal/common/eal_common_lcore.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/lib/eal/common/eal_common_lcore.c b/lib/eal/common/eal_common_l

[PATCH v4 2/2] build: export dpdk_includes for subproject usage

2022-10-14 Thread Markus Theil
In order to perform things like LTO more easily in our DPDK applications, we use DPDK as a meson subproject. Also export includes in order to be usable in this context. Signed-off-by: Markus Theil --- drivers/meson.build | 4 lib/meson.build | 1 + meson.build | 1 + 3 files cha

[PATCH v4 1/2] build: allow to conditionally build apps

2022-10-14 Thread Markus Theil
Makes apps configurable from meson, like already possible for drivers. Signed-off-by: Markus Theil --- app/meson.build | 13 - meson_options.txt | 4 2 files changed, 16 insertions(+), 1 deletion(-) diff --git a/app/meson.build b/app/meson.build index 93d8c15032..96b9a78d3a

[PATCH V2] doc: add ice in-tree driver version for Intel NICs

2022-10-14 Thread Yu Jiang
doc: add ice in-tree driver version for Intel NICs ice in-tree driver test starts from 22.07, cover vf-tso,vf-checksum_offload,vf-rss, vf-jumboframe,vm_hotplug etc.. basic vf function. Signed-off-by: Yu Jiang --- v2: - add detailed commit log - correct "out-tree" to "out of tree" --- --- doc/gu

Re: [PATCH V1] doc: add ice in-tree driver version for Intel NICs

2022-10-14 Thread David Marchand
Hello, On Fri, Oct 14, 2022 at 7:08 AM Yu.Jiang wrote: > > doc: add ice in-tree driver version for Intel NICs I had asked about such tests [1], months ago, but I never got a reply. - Glad to see Intel is testing with some distribution kernels, but what about the latest kernel? - It is still un