> -----Original Message----- > From: Andrew Rybchenko <andrew.rybche...@oktetlabs.ru> > Sent: Monday, October 3, 2022 21:20 > To: Guo, Junfeng <junfeng....@intel.com>; Zhang, Qi Z > <qi.z.zh...@intel.com>; Wu, Jingjing <jingjing...@intel.com>; Xing, > Beilei <beilei.x...@intel.com> > Cc: dev@dpdk.org; Wang, Xiao W <xiao.w.w...@intel.com> > Subject: Re: [PATCH v2 01/14] net/idpf/base: introduce base code > > On 9/5/22 13:58, Junfeng Guo wrote: > > Introduce base code for IDPF (Infrastructure Data Path Function) PMD. > > > > Signed-off-by: Beilei Xing <beilei.x...@intel.com> > > Signed-off-by: Junfeng Guo <junfeng....@intel.com> > > I'm OK to import base driver in one patch, but it should not be > the first patch with dead code which is not actually built > just after the patch. > > The first patch should add a driver stub which is built. > Subsequent patches should add base driver and functionality > to the ethdev driver itself.
Sure, thanks for the advice! We will do some refactor work and move the base driver at common folder. That would look better in the coming version. Thanks!
