> -----Original Message----- > From: Andrew Rybchenko <andrew.rybche...@oktetlabs.ru> > Sent: Monday, October 3, 2022 21:20 > To: Guo, Junfeng <junfeng....@intel.com>; Zhang, Qi Z > <qi.z.zh...@intel.com>; Wu, Jingjing <jingjing...@intel.com>; Xing, > Beilei <beilei.x...@intel.com> > Cc: dev@dpdk.org; Wang, Xiao W <xiao.w.w...@intel.com> > Subject: Re: [PATCH v2 02/14] net/idpf/base: add logs and OS specific > implementation > > On 9/5/22 13:58, Junfeng Guo wrote: > > Add PMD logs. > > Add some MACRO definations and small functions which are specific > > for DPDK. > > > > Signed-off-by: Beilei Xing <beilei.x...@intel.com> > > Signed-off-by: Junfeng Guo <junfeng....@intel.com> > > The patch adds dead code as well. Added headers are used > nowhere. > > One more question is what's the point to have two things in one > patch? Typically such descriptions suggest that it could be > separate patches in a right order.
Sure, will improve this in the coming version patchset. Thanks!
