[dpdk-dev] [PATCH v3] net/i40e: add Tx preparation for simple Tx data path

2021-04-19 Thread Leyi Rong
Introduce i40e_simple_prep_pkts() as the preparation function for simple Tx data path, as it's for sanity check for simple Tx. Suggested-by: Konstantin Ananyev Signed-off-by: Leyi Rong --- drivers/net/i40e/i40e_rxtx.c | 39 +++- drivers/net/i40e/i40e_rxtx.h | 2

[dpdk-dev] 回复: [PATCH v1 3/4] net/mlx5: fix rebuild bug for Memory Region cache

2021-04-19 Thread Feifei Wang
Hi, Slava Thanks very much for your explanation. I can understand the app can wait all mbufs are returned to the memory pool, and then it can free this mbufs, I agree with this. As a result, I will remove the bug fix patch from this series and just replace the smp barrier with C11 thread fence.

Re: [dpdk-dev] [PATCH v2] net/i40e: add Tx preparation for simple Tx data path

2021-04-19 Thread Rong, Leyi
> -Original Message- > From: Ananyev, Konstantin > Sent: Monday, April 19, 2021 6:59 PM > To: Rong, Leyi ; Zhang, Qi Z > Cc: dev@dpdk.org > Subject: RE: [PATCH v2] net/i40e: add Tx preparation for simple Tx data path > > Hi Leyi, > > > Introduce i40e_simple_prep_pkts() as the preparat

Re: [dpdk-dev] [PATCH 2/2] net/bnxt: cap max Rx rings for Thor

2021-04-19 Thread Ajit Khaparde
On Mon, Apr 19, 2021 at 12:28 PM Ajit Khaparde wrote: > > For Thor devices, RSS table can only accommodate 512 Rx queues. > When RSS is enabled, Cap the max Rx rings to 512. > For non-RSS case, the number will be limited by number of VNICs. > > Signed-off-by: Ajit Khaparde > Reviewed-by: Lance Ri

Re: [dpdk-dev] [PATCH 1/2] net/bnxt: fix resource cleanup

2021-04-19 Thread Ajit Khaparde
On Mon, Apr 19, 2021 at 12:28 PM Ajit Khaparde wrote: > > Fix resource cleanup in port close. > Once the pointers are freed, set them to NULL. > Make sure access to the pointers is validated before use. > > Fixes: bb81e07323bb ("net/bnxt: support LED on/off") > Fixes: 804e746c7b73 ("net/bnxt: add

[dpdk-dev] [PATCH] net/bnxt: fix cancelling health check alarm

2021-04-19 Thread Kalesh A P
From: Kalesh AP Driver cancels the health check alarm only if error recovery is enabled in the FW. This can cause an issue. There is a small window where the driver receives the async event from fw and port close is invoked immediately. Driver clears BNXT_FLAG_RECOVERY_ENABLED flag when it gets t

Re: [dpdk-dev] [RFC 0/2] add Tx prepare support for bonding device

2021-04-19 Thread Chengchang Tang
On 2021/4/20 9:26, Ferruh Yigit wrote: > On 4/16/2021 12:04 PM, Chengchang Tang wrote: >> This patch add Tx prepare for bonding device. >> >> Currently, the bonding driver has not implemented the callback of >> rte_eth_tx_prepare function. Therefore, the TX prepare function of the >> slave devices

Re: [dpdk-dev] [PATCH v2] net/igc: fix Rx packet size error

2021-04-19 Thread Wang, Haiyue
> -Original Message- > From: Zhang, AlvinX > Sent: Tuesday, April 20, 2021 10:05 > To: Wang, Haiyue ; Guo, Jia > Cc: dev@dpdk.org; Zhang, AlvinX ; sta...@dpdk.org > Subject: [PATCH v2] net/igc: fix Rx packet size error > > When DEV_RX_OFFLOAD_KEEP_CRC is enabled, the PMD will minus 4 byt

[dpdk-dev] [PATCH v3 4/4] doc: update async vhost register/unregister

2021-04-19 Thread Jiayu Hu
This patch is to update programmer guide for register/unregister copy devices in vhost. Signed-off-by: Jiayu Hu --- doc/guides/prog_guide/vhost_lib.rst | 14 +++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git a/doc/guides/prog_guide/vhost_lib.rst b/doc/guides/prog_guide

[dpdk-dev] [PATCH v3 3/4] vhost: fix unnecessary vring_state_changed call

2021-04-19 Thread Jiayu Hu
When VHOST_USER_F_PROTOCOL_FEATURES is not negotiated, there is no need for vhost_user_set_vring_kick() to notify the application of vring enabled, as vhost_user_msg_handler() also notifies the application. This patch is to remove unnecessary vring_state_changed() call. Fixes: 966027b4b3a3 ("vhos

[dpdk-dev] [PATCH v3 2/4] vhost: remove unnecessary free

2021-04-19 Thread Jiayu Hu
This patch removes unnecessary rte_free() for async_pkts_info and async_descs_split. Signed-off-by: Jiayu Hu Reviewed-by: Maxime Coquelin Tested-by: Yinan Wang --- lib/librte_vhost/vhost_user.c | 7 --- 1 file changed, 7 deletions(-) diff --git a/lib/librte_vhost/vhost_user.c b/lib/librte

[dpdk-dev] [PATCH v3 1/4] vhost: fix uninitialized vhost queue

2021-04-19 Thread Jiayu Hu
This patch allocates vhost queue by rte_zmalloc() to avoid undefined values. Fixes: a277c7159876 ("vhost: refactor code structure") Cc: sta...@dpdk.org Signed-off-by: Jiayu Hu Reviewed-by: Maxime Coquelin Tested-by: Yinan Wang --- lib/librte_vhost/vhost.c | 2 +- 1 file changed, 1 insertion(+

[dpdk-dev] [PATCH v3 0/4] Refactor async vhost control path

2021-04-19 Thread Jiayu Hu
This patch set refactors async vhost control path. Change log == v3: - correct fix commit - update doc and commit log v2: - correct fix commit - update commit lo Jiayu Hu (4): vhost: fix uninitialized vhost queue vhost: remove unnecessary free vhost: fix unnecessary vring_state_chan

Re: [dpdk-dev] [PATCH 1/3] examples/flow_classify: fix check of port and core

2021-04-19 Thread Min Hu (Connor)
在 2021/4/20 9:08, Thomas Monjalon 写道: 27/03/2021 08:40, Min Hu (Connor): fix check of port and core in flow_classify example. Fixes: bab16ddaf2c1 ("examples/flow_classify: add sample application") Cc: sta...@dpdk.org Signed-off-by: Min Hu (Connor) --- RTE_ETH_FOREACH_DEV(port) -

Re: [dpdk-dev] [PATCH v4 1/4] app/testpmd: add packet id for IP fragment

2021-04-19 Thread Jack Min
On Mon, 21-04-19, 16:40, Ferruh Yigit wrote: > On 4/19/2021 8:43 AM, Jack Min wrote: > > On Tue, 21-04-13, 16:10, Jeff Guo wrote: > > > Add the new items to support the flow configuration for IP fragment > > > packets. > > > > > > Signed-off-by: Ting Xu > > > Signed-off-by: Jeff Guo > > > --- >

Re: [dpdk-dev] [PATCH v2] mbuf: support eCPRI hardware packet type

2021-04-19 Thread Liu, Lingyu
Hi Olivier, This new packet type will be used by iavf driver to map ECPRI hardware packet. This is the patch which will use this new hardware packet type. http://patchwork.dpdk.org/project/dpdk/patch/20210420083817.10741-3-lingyu@intel.com/ Best Regards, Lingyu Liu > -Original Message

[dpdk-dev] [PATCH v2] net/igc: fix Rx packet size error

2021-04-19 Thread Alvin Zhang
When DEV_RX_OFFLOAD_KEEP_CRC is enabled, the PMD will minus 4 bytes of CRC from the size of a packet, but the NIC will strip the CRC because the CRC strip bit in DVMOLR register is not cleared. This will cause the size of a packet to be 4 bytes less. This patch updates the CRC strip bit according

[dpdk-dev] [PATCH V3 2/2] net/iavf: update PTYPE mapping for eCPRI

2021-04-19 Thread Lingyu Liu
1.Map IPV4/IPV6 UDP eCPRI to L4_UDP_TUNNEL_ECPRI ptype. 2.Add L2_ETHER_ECPRI ptype and map ETHER eCPRI to L2_ETHER_ECPRI ptype. Signed-off-by: Lingyu Liu --- drivers/net/iavf/iavf_rxtx.c | 52 ++-- 1 file changed, 32 insertions(+), 20 deletions(-) diff --git a/dr

[dpdk-dev] [PATCH V3 1/2] mbuf: support eCPRI hardware packet type

2021-04-19 Thread Lingyu Liu
Add L2_ETHER_ECPRI and L4_UDP_TUNNEL_ECPRI in RTE_PTYPE. Signed-off-by: Lingyu Liu Acked-by: Hemant Agrawal --- app/test-pmd/util.c | 25 - lib/librte_mbuf/rte_mbuf_ptype.c | 2 ++ lib/librte_mbuf/rte_mbuf_ptype.h | 22 ++ 3 files change

[dpdk-dev] [PATCH V3 0/2] mbuf:add eCPRI hardware packet type mapping

2021-04-19 Thread Lingyu Liu
Create eCPRI hardward packet in mbuf and add mapping in iavf. Lingyu Liu (2): mbuf: support eCPRI hardware packet type net/iavf: update PTYPE mapping for eCPRI --- V3 change: - create patch set and add the second patch app/test-pmd/util.c | 25 +-- drivers/net/iavf

Re: [dpdk-dev] [PATCH v2 1/1] raw/ifpga/base: check size before assigning

2021-04-19 Thread Xu, Rosen
Thanks all. -Original Message- From: Yigit, Ferruh Sent: Tuesday, April 20, 2021 9:01 AM To: Zhang, Tianfei ; Zhang, Qi Z ; Huang, Wei ; dev@dpdk.org; Xu, Rosen Cc: sta...@dpdk.org Subject: Re: [PATCH v2 1/1] raw/ifpga/base: check size before assigning On 4/20/2021 1:13 AM, Zhang, Ti

Re: [dpdk-dev] [PATCH v2] app/testpmd: support the query of link flow ctrl info

2021-04-19 Thread Ferruh Yigit
On 4/20/2021 2:34 AM, Li, Xiaoyun wrote: Hi -Original Message- From: Min Hu (Connor) Sent: Monday, April 19, 2021 16:28 To: dev@dpdk.org Cc: Yigit, Ferruh ; Li, Xiaoyun Subject: [PATCH v2] app/testpmd: support the query of link flow ctrl info From: Huisong Li This patch supports th

Re: [dpdk-dev] [PATCH] net/bonding: fix add bonded device itself as its slave

2021-04-19 Thread Ferruh Yigit
On 4/15/2021 8:09 AM, Min Hu (Connor) wrote: From: Chengchang Tang Adding the bond device as its own slave should be forbidden. This will cause a recursive endless loop in many subsequent operations, and eventually lead to coredump. This problem was found in testpmd, the related logs are as fo

Re: [dpdk-dev] [PATCH v2] app/testpmd: support the query of link flow ctrl info

2021-04-19 Thread Li, Xiaoyun
Hi > -Original Message- > From: Min Hu (Connor) > Sent: Monday, April 19, 2021 16:28 > To: dev@dpdk.org > Cc: Yigit, Ferruh ; Li, Xiaoyun > Subject: [PATCH v2] app/testpmd: support the query of link flow ctrl info > > From: Huisong Li > > This patch supports the query of the link flow

Re: [dpdk-dev] [RFC 0/2] add Tx prepare support for bonding device

2021-04-19 Thread Ferruh Yigit
On 4/16/2021 12:04 PM, Chengchang Tang wrote: This patch add Tx prepare for bonding device. Currently, the bonding driver has not implemented the callback of rte_eth_tx_prepare function. Therefore, the TX prepare function of the slave devices will never be invoked. When hardware offloading such

Re: [dpdk-dev] [PATCH v2] examples/l3fwd: skip TX queue drain on first iteration

2021-04-19 Thread Thomas Monjalon
08/04/2021 23:35, Kathleen Capella: > Initialize prev_tsc to cur_tsc. This avoids running the TX queue drain > in the first iteration of the packet processing loop. > > Signed-off-by: Kathleen Capella > Reviewed-by: Honnappa Nagarahalli Applied, thanks

Re: [dpdk-dev] [PATCH 1/3 v4] ethdev: add Rx offload to drop error packets

2021-04-19 Thread Ferruh Yigit
On 2/18/2021 8:37 PM, Thomas Monjalon wrote: 18/02/2021 21:32, Ferruh Yigit: On 10/15/2020 2:23 PM, nipun.gu...@nxp.com wrote: From: Nipun Gupta This change adds a Rx offload capability and configuration to enable hardware to drop the packets in case of any error in the packets such as L3 che

Re: [dpdk-dev] [PATCH 1/2] net/ring: refactor to reduce indentation in probe

2021-04-19 Thread Ferruh Yigit
On 10/2/2020 11:47 PM, Ferruh Yigit wrote: No functional change. Signed-off-by: Ferruh Yigit self nack. This patch is was just refactoring without functional change, but missing reviews, dropping it for now.

Re: [dpdk-dev] [PATCH 1/3] examples/flow_classify: fix check of port and core

2021-04-19 Thread Thomas Monjalon
27/03/2021 08:40, Min Hu (Connor): > fix check of port and core in flow_classify example. > > Fixes: bab16ddaf2c1 ("examples/flow_classify: add sample application") > Cc: sta...@dpdk.org > > Signed-off-by: Min Hu (Connor) > --- > RTE_ETH_FOREACH_DEV(port) > - if (rte_eth_dev_so

Re: [dpdk-dev] [PATCH] ethdev: add security flow item

2021-04-19 Thread Ferruh Yigit
On 2/17/2021 5:36 PM, Ferruh Yigit wrote: On 9/24/2020 11:07 AM, Tejasree Kondoj wrote: Hi Ori, Please see inline. Thanks, Tejasree -Original Message- From: Ori Kam Sent: Thursday, September 24, 2020 3:22 PM To: Tejasree Kondoj ; Asaf Penso ; Stephen Hemminger Cc: Akhil Goyal ; Rad

Re: [dpdk-dev] [PATCH 1/2] ethdev: add flow action type update as an offload

2021-04-19 Thread Ferruh Yigit
On 2/17/2021 2:10 PM, Thomas Monjalon wrote: 17/02/2021 14:45, Ferruh Yigit: On 7/3/2020 3:34 PM, Ferruh Yigit wrote: On 11/19/2019 11:09 AM, Thomas Monjalon wrote: 19/11/2019 11:59, Andrew Rybchenko: On 11/19/19 12:50 PM, Thomas Monjalon wrote: 19/11/2019 10:24, Andrew Rybchenko: On 11/8/1

Re: [dpdk-dev] [PATCH] examples/ptpclient: delete wrong comments

2021-04-19 Thread Thomas Monjalon
12/04/2021 10:04, Ferruh Yigit: > On 4/10/2021 10:11 AM, Min Hu (Connor) wrote: > >> This patch deletes the comments which are wrong and unnecessary. > >> > >> Fixes: ab129e9065a5 ("examples/ptpclient: add minimal PTP client") > >> Cc: sta...@dpdk.org > >> > >> Signed-off-by: Min Hu (Connor) > >>

Re: [dpdk-dev] [PATCH v2 1/1] raw/ifpga/base: check size before assigning

2021-04-19 Thread Ferruh Yigit
On 4/20/2021 1:13 AM, Zhang, Tianfei wrote: -Original Message- From: Yigit, Ferruh Sent: 2021年4月20日 6:36 To: Zhang, Qi Z ; Huang, Wei ; dev@dpdk.org; Xu, Rosen Cc: sta...@dpdk.org; Zhang, Tianfei Subject: Re: [PATCH v2 1/1] raw/ifpga/base: check size before assigning On 4/19/2021 9

Re: [dpdk-dev] [PATCH 2/2] examples/ethtool: add closing port operation

2021-04-19 Thread Thomas Monjalon
08/04/2021 12:14, Min Hu (Connor): > From: Huisong Li > > Currently, ethtool directly ends the process after 'quit' cmd. In this > case, software resources are not released and hardware resources of the > device are not uninstalled. > > This patch adds closing port operation to release resources

Re: [dpdk-dev] [PATCH 1/2] examples/ethtool: fix Rx/Tx queue setup with rte socket id

2021-04-19 Thread Thomas Monjalon
08/04/2021 12:14, Min Hu (Connor): > From: Chengwen Feng > > The ethtool use the socket_id which get from rte_eth_dev_socket_id API > in the init stage, but use the rte_socket_id API to get socket_id when > setting ringparam. > > This patch make sure it call rte_eth_dev_socket_id API to get > so

Re: [dpdk-dev] [PATCH] examples/pipeline: add newline to error messages

2021-04-19 Thread Thomas Monjalon
31/03/2021 15:51, Cristian Dumitrescu: > Add newline to some error messages that were missing it. > > Signed-off-by: Cristian Dumitrescu Applied, thanks

Re: [dpdk-dev] [PATCH 2/2] pipeline: autodetect endianness of action args

2021-04-19 Thread Thomas Monjalon
12/04/2021 01:23, Cristian Dumitrescu: > Each table entry is made up of match fields and action data, with the > latter made up of the action ID and the action arguments. The approach > of having the user specify explicitly the endianness of the action > arguments is difficult to be picked up by P4

Re: [dpdk-dev] [PATCH 0/7] features and bugfix for hns3 PMD

2021-04-19 Thread Ferruh Yigit
On 4/17/2021 10:54 AM, Min Hu (Connor) wrote: This patchset contains 2 features and 5 bugfixes. Chengwen Feng (3): net/hns3: check max SIMD bitwidth net/hns3: Rx vector add compile-time verify net/hns3: fix FDIR lock bug Huisong Li (4): net/hns3: remove redundant code about mbx n

Re: [dpdk-dev] [PATCH] pipeline: fix endianness conversions

2021-04-19 Thread Thomas Monjalon
03/04/2021 02:17, Cristian Dumitrescu: > The SWX pipeline instructions work with operands of different types: > header fields (h.header.field), packet meta-data (m.field), extern > object mailbox field (e.obj.field), extern function (f.field), action > data read from table entries (t.field), or imm

Re: [dpdk-dev] [PATCH] pipeline: adjust error code for internal function

2021-04-19 Thread Thomas Monjalon
30/03/2021 12:19, Cristian Dumitrescu: > Adjusting the error code for the internal function instruction_config > to match the rest of the code which is returning a negative value on > error. Cosmetic change. > > Signed-off-by: Cristian Dumitrescu Applied, thanks

Re: [dpdk-dev] [PATCH v2] lib/mempool: distinguish debug counters from cache and pool

2021-04-19 Thread Dharmik Thakkar
Hi Olivier, Apologies for the delayed response! I’m stepping in since Joyce is on vacation. I have updated the patch with the required changes. Thank you! > On Apr 7, 2021, at 9:28 AM, Olivier Matz wrote:

Re: [dpdk-dev] [PATCH] pipeline: validate header on emit

2021-04-19 Thread Thomas Monjalon
26/03/2021 21:29, Cristian Dumitrescu: > Enhance the behavior of the emit instruction to ignore invalid > headers, as mandated by the P4 language specification. > > Signed-off-by: Cristian Dumitrescu Applied, thanks

Re: [dpdk-dev] [PATCH] pipeline: add table statistics

2021-04-19 Thread Thomas Monjalon
17/04/2021 01:46, Cristian Dumitrescu: > Add support for table statistics for the SWX pipeline. For each table, > we maintain a counter for lookup hit packets, one for lookup miss > packets and one packet counter for each table action. > > Signed-off-by: Cristian Dumitrescu > Signed-off-by: Yoges

Re: [dpdk-dev] [PATCH] pipeline: relax table match field requirements

2021-04-19 Thread Thomas Monjalon
15/04/2021 23:15, Cristian Dumitrescu: > The match fields for a given table have to be part of the same header > or the metadata structure. This commit removes the requirement that > the list of match fields must observe the order of fields within their > structure. For example, the h.ipv4.dst_addr

Re: [dpdk-dev] [PATCH] pipeline: add drop instruction to the SWX pipeline

2021-04-19 Thread Thomas Monjalon
26/03/2021 23:11, Cristian Dumitrescu: > Enabled the TX instruction to accept an immediate value for the output > port argument. The drop instruction is simply an alias to the TX > instruction for the last output port of the pipeline. > > Signed-off-by: Cristian Dumitrescu Applied, thanks

Re: [dpdk-dev] [PATCH 1/7] net/hns3: check max SIMD bitwidth

2021-04-19 Thread Ferruh Yigit
On 4/17/2021 10:54 AM, Min Hu (Connor) wrote: From: Chengwen Feng This patch supports check max SIMD bitwidth when choosing NEON and SVE vector path. Signed-off-by: Chengwen Feng Signed-off-by: Min Hu (Connor) This patch already part of another patchset [1] and merged there. [1] https://p

Re: [dpdk-dev] [PATCH v2 1/1] raw/ifpga/base: check size before assigning

2021-04-19 Thread Zhang, Tianfei
> -Original Message- > From: Yigit, Ferruh > Sent: 2021年4月20日 6:36 > To: Zhang, Qi Z ; Huang, Wei ; > dev@dpdk.org; Xu, Rosen > Cc: sta...@dpdk.org; Zhang, Tianfei > Subject: Re: [PATCH v2 1/1] raw/ifpga/base: check size before assigning > > On 4/19/2021 9:12 AM, Zhang, Qi Z wrote: >

Re: [dpdk-dev] [PATCH v2] app/testpmd: support the query of link flow ctrl info

2021-04-19 Thread Ferruh Yigit
On 4/19/2021 9:28 AM, Min Hu (Connor) wrote: From: Huisong Li This patch supports the query of the link flow control parameter on a port. The command format is as follows: show port flow_ctrl Signed-off-by: Huisong Li Signed-off-by: Min Hu (Connor) Reviewed-by: Ferruh Yigit

[dpdk-dev] [PATCH v3 2/2] lib/mempool: distinguish debug counters from cache and pool

2021-04-19 Thread Dharmik Thakkar
From: Joyce Kong If cache is enabled, objects will be retrieved/put from/to cache, subsequently from/to the common pool. Now the debug stats calculate the objects retrieved/put from/to cache and pool together, it is better to distinguish them. Signed-off-by: Joyce Kong Signed-off-by: Dharmik Th

[dpdk-dev] [PATCH v3 1/2] lib/mempool: make stats macro generic

2021-04-19 Thread Dharmik Thakkar
Make __MEMPOOL_STAT_ADD macro more generic and delete __MEMPOOL_CONTIG_BLOCKS_STAT_ADD macro Suggested-by: Olivier Matz Signed-off-by: Dharmik Thakkar Reviewed-by: Ruifeng Wang Reviewed-by: Honnappa Nagarahalli --- lib/librte_mempool/rte_mempool.h | 34 +++- 1 file

[dpdk-dev] [PATCH v3 0/2] lib/mempool: add debug stats

2021-04-19 Thread Dharmik Thakkar
- Add debug counters for objects put/get to/from the cache and the common pool. - Make __MEMPOOL_STAT_ADD() more generic --- v3: - Add a patch to make stat add macro generic - Remove other stat add/subtract macros - Rename counters for better understanding - Add put/get cache bulk counters v2

Re: [dpdk-dev] [PATCH v5 1/2] ethdev: introduce conntrack flow action and item

2021-04-19 Thread Ferruh Yigit
On 4/19/2021 7:07 PM, Thomas Monjalon wrote: 19/04/2021 19:51, Bing Zhao: This commit introduces the conntrack action and item. [...] Signed-off-by: Bing Zhao Acked-by: Ori Kam Acked-by: Thomas Monjalon Series applied to dpdk-next-net/main, thanks.

[dpdk-dev] [PATCH 2/2] net/bnxt: cap max Rx rings for Thor

2021-04-19 Thread Ajit Khaparde
For Thor devices, RSS table can only accommodate 512 Rx queues. When RSS is enabled, Cap the max Rx rings to 512. For non-RSS case, the number will be limited by number of VNICs. Signed-off-by: Ajit Khaparde Reviewed-by: Lance Richardson --- drivers/net/bnxt/bnxt.h| 13 + dr

[dpdk-dev] [PATCH 1/2] net/bnxt: fix resource cleanup

2021-04-19 Thread Ajit Khaparde
Fix resource cleanup in port close. Once the pointers are freed, set them to NULL. Make sure access to the pointers is validated before use. Fixes: bb81e07323bb ("net/bnxt: support LED on/off") Fixes: 804e746c7b73 ("net/bnxt: add hardware resource manager init code") Fixes: 1d0704f4d793 ("net/bnxt

[dpdk-dev] [PATCH v6 09/10] app/testpmd: fix unused function warnings

2021-04-19 Thread Jie Zhou
Function print_fdir_mask and print_fdir_flex_payload is only called when either i40e or ixgbe presents. Add #if defined to remove "unused function" compilation warning. Signed-Off-By: j...@microsoft.com Signed-off-by: Jie Zhou --- app/test-pmd/config.c | 82 +-

[dpdk-dev] [PATCH v6 10/10] app/testpmd: enable building testpmd on Windows

2021-04-19 Thread Jie Zhou
From: Jie Zhou - Disable unsupported Apps on Windows - Enable building of testpmd on Windows Signed-off-by: Jie Zhou Signed-off-by: Jie Zhou --- app/meson.build| 4 app/pdump/meson.build | 6 ++ app/proc-info/meson.build | 6 ++ app/test-

[dpdk-dev] [PATCH v6 07/10] app/testpmd: replace POSIX specific code

2021-04-19 Thread Jie Zhou
- Make printf format OS independent - Replace htons with RTE_BE16 - Replace POSIX specific inet_aton with OS independent inet_pton - Replace sleep with rte_delay_us_sleep - Repalce random with rte_rand - #ifndef mman related code for now Signed-off-by: Jie Zhou Signed-off-by: Jie Zhou ---

[dpdk-dev] [PATCH v6 08/10] app/testpmd: fix headers inclusion

2021-04-19 Thread Jie Zhou
- Include rte_os_shim.h in testpmd.h - Remove redundant headers Signed-off-by: Jie Zhou Signed-off-by: Jie Zhou --- app/test-pmd/cmdline.c | 3 --- app/test-pmd/cmdline_flow.c | 2 -- app/test-pmd/parameters.c | 1 - app/test-pmd/testpmd.h | 1 + 4 files changed, 1 insertion(+), 6 d

[dpdk-dev] [PATCH v6 06/10] app/testpmd: fix parse_fec_mode return type

2021-04-19 Thread Jie Zhou
Fix parse_fec_mode to return fec_capa instead of mode Signed-off-by: Jie Zhou Signed-off-by: Jie Zhou --- app/test-pmd/cmdline.c | 6 +++--- app/test-pmd/config.c | 4 ++-- app/test-pmd/testpmd.h | 2 +- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/app/test-pmd/cmdline.c b/ap

[dpdk-dev] [PATCH v6 05/10] app/testpmd: add clock_gettime_monotonic

2021-04-19 Thread Jie Zhou
Add clock_gettime_monotonic for testpmd on Windows Signed-off-by: Jie Zhou Signed-off-by: Jie Zhou --- app/test-pmd/config.c | 33 - 1 file changed, 32 insertions(+), 1 deletion(-) diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c index ef0b9784d..a5f8f

[dpdk-dev] [PATCH v6 04/10] app/testpmd: resolve name collisions

2021-04-19 Thread Jie Zhou
Resolve name collisions with Windows types Signed-off-by: Jie Zhou Signed-off-by: Jie Zhou --- app/test-pmd/cmdline_flow.c | 494 ++-- 1 file changed, 247 insertions(+), 247 deletions(-) diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c inde

[dpdk-dev] [PATCH v6 03/10] eal/windows: add device event stubs

2021-04-19 Thread Jie Zhou
Add device event stubs in eal_dev.c for Windows Signed-off-by: Jie Zhou Signed-off-by: Jie Zhou --- lib/librte_eal/windows/eal_dev.c | 33 ++ lib/librte_eal/windows/meson.build | 1 + 2 files changed, 34 insertions(+) create mode 100644 lib/librte_eal/windows/eal

[dpdk-dev] [PATCH v6 01/10] lib: build libraries that testpmd depends on

2021-04-19 Thread Jie Zhou
Enable building libraries that testpmd depends on Signed-off-by: Jie Zhou Signed-off-by: Jie Zhou --- lib/meson.build | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/lib/meson.build b/lib/meson.build index 4eed83e57..3483570ac 100644 --- a/lib/meson.build +++ b/lib/mes

[dpdk-dev] [PATCH v6 02/10] eal/windows: add necessary macros

2021-04-19 Thread Jie Zhou
Add required macros by testpmd on Windows in rte_os_shim.h Signed-off-by: Jie Zhou Signed-off-by: Jie Zhou --- lib/librte_eal/windows/include/rte_os_shim.h | 9 + 1 file changed, 9 insertions(+) diff --git a/lib/librte_eal/windows/include/rte_os_shim.h b/lib/librte_eal/windows/include

[dpdk-dev] [PATCH v6 00/10] app/testpmd: enable testpmd on Windows

2021-04-19 Thread Jie Zhou
This patchset is to enable testpmd on windows. It mainly includes: - Enable building libraries on Windows that testpmd depends on - Add necessary macros required by testpmd on Windows in rte_os_shim.h - Add device event stubs for Windows - Resolve name collisions with Windows types - Add clock_gett

Re: [dpdk-dev] [PATCH v4 1/4] app/testpmd: add packet id for IP fragment

2021-04-19 Thread Ferruh Yigit
On 4/19/2021 6:45 PM, Ori Kam wrote: Hi Jeff and Ting, -Original Message- From: Jeff Guo Sent: Tuesday, April 13, 2021 11:10 AM Subject: [PATCH v4 1/4] app/testpmd: add packet id for IP fragment Add the new items to support the flow configuration for IP fragment packets. Signed-off-b

Re: [dpdk-dev] [PATCH 2/2] app/testpmd: fix link speed for a specified port

2021-04-19 Thread Ferruh Yigit
On 4/19/2021 7:21 AM, Min Hu (Connor) wrote: From: Huisong Li When we use the following cmd to modify the link speed of specified port: "port config speed xxx duplex xxx", we have to stop all ports. It's not necessary. Fixes: 82113036e4e5 ("ethdev: redesign link speed config") Cc: sta...@dpdk

Re: [dpdk-dev] [PATCH v2 1/1] raw/ifpga/base: check size before assigning

2021-04-19 Thread Ferruh Yigit
On 4/19/2021 9:12 AM, Zhang, Qi Z wrote: -Original Message- From: Huang, Wei Sent: Thursday, April 8, 2021 4:52 PM To: dev@dpdk.org; Xu, Rosen ; Zhang, Qi Z Cc: sta...@dpdk.org; Zhang, Tianfei ; Yigit, Ferruh ; Huang, Wei Subject: [PATCH v2 1/1] raw/ifpga/base: check size before ass

[dpdk-dev] [PATCH v2] doc: update minimum supported kernel

2021-04-19 Thread Stephen Hemminger
The DPDK project is only committed to supporting upstream kernel versions that are still in support. The 3.16 kernel has reached End Of Life (in June 2020). The next LTS kernel is 4.4 and is supported until February 2020. This does not change the existing policy that distribution kernels that are

Re: [dpdk-dev] [PATCH v5 11/14] net/mlx5: aso flow meter send WQE and CQE handle

2021-04-19 Thread Thomas Monjalon
19/04/2021 23:46, Ferruh Yigit: > On 4/15/2021 4:11 PM, Li Zhang wrote: > > ASO flow meter send WQE and CQE handle functions > > > > Can you please update patch title, to stat with the action? You mean "start" with the action verb. > And can you please clarify the abbreviations used, same for a

Re: [dpdk-dev] [PATCH V1] doc: update recommended kernel version for i40e

2021-04-19 Thread Stephen Hemminger
On Wed, 15 Jan 2020 10:29:06 +0800 Ye Xiaolong wrote: > On 01/14, Kevin Traynor wrote: > >On 14/01/2020 19:10, Kevin Traynor wrote: > >> On 14/01/2020 02:28, Ye Xiaolong wrote: > >>> On 01/03, Chen, Zhaoyan wrote: > Update supported Intel NIC driver version and firmware version for 19.

Re: [dpdk-dev] [PATCH v5 00/14] Add ASO meter support in MLX5 PMD

2021-04-19 Thread Thomas Monjalon
19/04/2021 23:42, Ferruh Yigit: > On 4/15/2021 4:11 PM, Li Zhang wrote: > > To support more meters and better performance, > > MLX HW provide ASO flow meter. > > It can expose millions of ASO flow meter context's in HW. > > This ASO object can allocate the large bulk meter objects. > > This patch s

Re: [dpdk-dev] [PATCH v5 11/14] net/mlx5: aso flow meter send WQE and CQE handle

2021-04-19 Thread Ferruh Yigit
On 4/15/2021 4:11 PM, Li Zhang wrote: ASO flow meter send WQE and CQE handle functions Can you please update patch title, to stat with the action? And can you please clarify the abbreviations used, same for all patch commit logs? Thanks. Signed-off-by: Li Zhang Acked-by: Matan Azrad <

Re: [dpdk-dev] [PATCH v5 00/14] Add ASO meter support in MLX5 PMD

2021-04-19 Thread Ferruh Yigit
On 4/15/2021 4:11 PM, Li Zhang wrote: To support more meters and better performance, MLX HW provide ASO flow meter. It can expose millions of ASO flow meter context's in HW. This ASO object can allocate the large bulk meter objects. This patch set implement the ASO flow meter for mlx5 driver. MLX

Re: [dpdk-dev] [PATCH v4 3/3] net/pcap: build on Windows

2021-04-19 Thread Tyler Retzlaff
On Fri, Apr 16, 2021 at 01:10:55AM +0300, Dmitry Kozlyuk wrote: > Implement OS-dependent functions and enable build for Windows. > Account for different library name in Windows libpcap distributions. > > Signed-off-by: Dmitry Kozlyuk Acked-by: Tyler Retzlaff > --- > Tyler, IIRC you were review

[dpdk-dev] [PATCH v2] config/arm: add support for Marvell CN10K

2021-04-19 Thread pbhagavatula
From: Pavan Nikhilesh Add config support to cross compile for Marvell CN10K SoC. Marvell CN10K SoC is based on ARM Neoverse N2 cores. Signed-off-by: Nithin Dabilpuram Signed-off-by: Pavan Nikhilesh Acked-by: Jerin Jacob --- v2 Changes: - Rebase with ToT. config/arm/arm64_cn10k_linux_gcc |

Re: [dpdk-dev] [dpdk-ci] [PATCH] eal/windows: fix build warnings in MinGW

2021-04-19 Thread Lincoln Lavoie
Is that related to a recent patch (I think it was David's, but don't quote me on that) that enabled a debug build mode when it sees git repo info within the build root? Cheers, Lincoln On Mon, Apr 19, 2021 at 4:09 PM Dmitry Kozlyuk wrote: > 2021-04-19 15:29 (UTC-0400), Aaron Conole: > > Thomas

Re: [dpdk-dev] [dpdk-ci] [PATCH] eal/windows: fix build warnings in MinGW

2021-04-19 Thread Dmitry Kozlyuk
2021-04-19 15:29 (UTC-0400), Aaron Conole: > Thomas Monjalon writes: > > > 19/04/2021 20:06, Tal Shnaiderman: > >> > > 2021-04-18 19:04 (UTC+), Tal Shnaiderman: > >> > > > > 18/04/2021 19:08, Tal Shnaiderman: > >> > > > > > the strncasecmp marco defined in rte_os_shim.h is already > >>

Re: [dpdk-dev] [PATCH] eal/windows: fix build warnings in MinGW

2021-04-19 Thread Dmitry Kozlyuk
Hi Tal, 2021-04-19 18:06 (UTC+), Tal Shnaiderman: > I also noticed warnings in clang on my setup that are related to > rte_os_shim.h: > > [185/314] Compiling C object > drivers/a715181@@tmp_rte_common_mlx5@sta/common_mlx5_mlx5_common_mp.c.obj. > In file included from ../drivers/common/mlx5/

Re: [dpdk-dev] [EXTERNAL] Re: [PATCH v5 5/9] app/testpmd: add clock_gettime_monotonic

2021-04-19 Thread Thomas Monjalon
19/04/2021 20:34, Tyler Retzlaff: > > > Originally and internally, the function was added into eal. But then > > > restricted the functionality just inside testpmd to avoid currently > > > seems unnecessary version change, per a discussion in community meeting > > > several weeks back. If we believ

Re: [dpdk-dev] [dpdk-ci] [PATCH] eal/windows: fix build warnings in MinGW

2021-04-19 Thread Aaron Conole
Thomas Monjalon writes: > 19/04/2021 20:06, Tal Shnaiderman: >> > > 2021-04-18 19:04 (UTC+), Tal Shnaiderman: >> > > > > 18/04/2021 19:08, Tal Shnaiderman: >> > > > > > the strncasecmp marco defined in rte_os_shim.h is already >> > > > > > defined in MinGW-w64, as a result the compiler prints

Re: [dpdk-dev] [PATCH] eal/windows: fix build warnings in MinGW

2021-04-19 Thread Dmitry Kozlyuk
2021-04-19 06:57 (UTC+), Tal Shnaiderman: > [...] > > > > 18/04/2021 19:08, Tal Shnaiderman: > > > > > the strncasecmp marco defined in rte_os_shim.h is already defined > > > > > in MinGW-w64, as a result the compiler prints out the warning > > > > > below on function redefinition whenever co

Re: [dpdk-dev] [PATCH v1 3/4] net/mlx5: fix rebuild bug for Memory Region cache

2021-04-19 Thread Slava Ovsiienko
Hi, Feifei Please, see below > > Hi, Feifei > > > > Sorry, I do not follow what this patch fixes. Do we have some > > issue/bug with MR cache in practice? > > This patch fixes the bug which is based on logical deduction, and it doesn't > actually happen. > > > > > Each Tx queue has its ow

Re: [dpdk-dev] [PATCH v2] table: relax requirements for table entry action data

2021-04-19 Thread Thomas Monjalon
26/03/2021 21:22, Cristian Dumitrescu: > From: Churchill Khangar > > Currently, the table entry action data is required to be NULL when the > action data size is zero. We now require that action data is ignored > when the action data size is zero. This is to allow for a table entry > instance to

Re: [dpdk-dev] [PATCH] eal/windows: fix build warnings in MinGW

2021-04-19 Thread Thomas Monjalon
19/04/2021 20:06, Tal Shnaiderman: > > > 2021-04-18 19:04 (UTC+), Tal Shnaiderman: > > > > > 18/04/2021 19:08, Tal Shnaiderman: > > > > > > the strncasecmp marco defined in rte_os_shim.h is already > > > > > > defined in MinGW-w64, as a result the compiler prints out the > > > > > > warning bel

Re: [dpdk-dev] [PATCH v5 5/9] app/testpmd: add clock_gettime_monotonic

2021-04-19 Thread Thomas Monjalon
19/04/2021 20:04, Jie Zhou: > On Sun, Apr 18, 2021 at 05:20:42PM +, Tal Shnaiderman wrote: > > > --- a/app/test-pmd/config.c > > > +++ b/app/test-pmd/config.c > > > @@ -63,6 +63,12 @@ > > > > > > #define NS_PER_SEC 1E9 > > > > > > +#ifdef RTE_EXEC_ENV_WINDOWS > > > +#define _clock_gettime_mo

Re: [dpdk-dev] [PATCH v8 2/2] app/testpmd: add support for integrity item

2021-04-19 Thread Ajit Khaparde
On Mon, Apr 19, 2021 at 5:45 AM Gregory Etelson wrote: > > From: Ori Kam > > The integrity item allows the application to match > on the integrity of a packet. > > use example: > match that packet integrity checks are ok. The checks depend on > packet layers. For example ICMP packet will not chec

Re: [dpdk-dev] [PATCH v8 1/2] ethdev: add packet integrity checks

2021-04-19 Thread Ajit Khaparde
::[snip]:: > Example of usage: > 1. check packets from all possible layers for integrity. >flow create integrity spec packet_ok = 1 mask packet_ok = 1 . > > 2. Check only packet with layer 4 (UDP / TCP) >flow create integrity spec l3_ok = 1, l4_ok = 1 mask l3_ok = 1 l4_ok = 1 > > Signed

Re: [dpdk-dev] [PATCH 1/2] ethdev: make flow API primary/secondary process safe

2021-04-19 Thread Thomas Monjalon
19/04/2021 19:45, Stephen Hemminger: > On Mon, 19 Apr 2021 19:14:08 +0200 > Thomas Monjalon wrote: > > The compilation fails on MinGW: > > error: implicit declaration of function ‘pthread_mutexattr_init’ > > Sorry, don't have all the variants. How do you handle the lack of > compatibility on Wind

Re: [dpdk-dev] [PATCH v5 1/2] ethdev: introduce conntrack flow action and item

2021-04-19 Thread Thomas Monjalon
19/04/2021 19:51, Bing Zhao: > This commit introduces the conntrack action and item. [...] > Signed-off-by: Bing Zhao > Acked-by: Ori Kam Acked-by: Thomas Monjalon It makes me think we should work together to simplify the whole rte_flow guide and makes it clearer.

Re: [dpdk-dev] [PATCH] eal/windows: fix build warnings in MinGW

2021-04-19 Thread Tal Shnaiderman
> Subject: Re: [dpdk-dev] [PATCH] eal/windows: fix build warnings in MinGW > > External email: Use caution opening links or attachments > > > > Subject: Re: [PATCH] eal/windows: fix build warnings in MinGW > > > > External email: Use caution opening links or attachments > > > > > > Hi Tal, > > >

Re: [dpdk-dev] [PATCH v5 5/9] app/testpmd: add clock_gettime_monotonic

2021-04-19 Thread Jie Zhou
On Sun, Apr 18, 2021 at 05:20:42PM +, Tal Shnaiderman wrote: > > Subject: [dpdk-dev] [PATCH v5 5/9] app/testpmd: add > > clock_gettime_monotonic > > > > External email: Use caution opening links or attachments > > > > > > Add clock_gettime_monotonic for testpmd on Windows > > > > Signed-off

[dpdk-dev] [PATCH v5 0/2] ethdev: introduce conntrack flow action and item

2021-04-19 Thread Bing Zhao
This patch set includes the conntrack action and item definitions as well as the testpmd CLI proposal. Documents of release notes and guides are also updated. --- v2: add testpmd CLI proposal v3: add doc update v4: fix building and address comments for doc and header file v5: squash doc update int

[dpdk-dev] [PATCH v5 2/2] app/testpmd: add CLI for conntrack

2021-04-19 Thread Bing Zhao
The command line for testing connection tracking is added. To create a conntrack object, 3 parts are needed. set conntrack com peer ... set conntrack orig scale ... set conntrack rply scale ... This will create a full conntrack action structure for the indirect action. After the indirect acti

[dpdk-dev] [PATCH v5 1/2] ethdev: introduce conntrack flow action and item

2021-04-19 Thread Bing Zhao
This commit introduces the conntrack action and item. Usually the HW offloading is stateless. For some stateful offloading like a TCP connection, HW module will help provide the ability of a full offloading w/o SW participation after the connection was established. The basic usage is that in the

Re: [dpdk-dev] [PATCH] table: fix out of bounds write

2021-04-19 Thread Thomas Monjalon
07/04/2021 12:59, Cristian Dumitrescu: > Fix out of bounds write. The allocated string size was incorrect. > > Coverity issue: 369670 > Fixes: 66440b7b22f2 ("table: add wildcard match table type") > > Signed-off-by: Cristian Dumitrescu Applied, thanks

Re: [dpdk-dev] [PATCH 04/10] app/regex: fix division by zero

2021-04-19 Thread Ori Kam
Hi Min, > -Original Message- > From: Min Hu (Connor) > Sent: Monday, April 19, 2021 4:35 PM > Subject: [PATCH 04/10] app/regex: fix division by zero > > Variable nb_jobs, which may be zero, is used as a denominator. > > This patch fixed it. > > Fixes: f5cffb7eb7fb ("app/regex: read dat

Re: [dpdk-dev] [PATCH 1/2] ethdev: make flow API primary/secondary process safe

2021-04-19 Thread Stephen Hemminger
On Mon, 19 Apr 2021 19:14:08 +0200 Thomas Monjalon wrote: > About the title, better to say "multi-process" and do not > commit on being completely safe for the whole API. > It is just fixing the mutex for multi-process, > and this mutex is for driver not being natively multi-thread. > > The comp

Re: [dpdk-dev] [PATCH v4 1/4] app/testpmd: add packet id for IP fragment

2021-04-19 Thread Ori Kam
Hi Jeff and Ting, > -Original Message- > From: Jeff Guo > Sent: Tuesday, April 13, 2021 11:10 AM > Subject: [PATCH v4 1/4] app/testpmd: add packet id for IP fragment > > Add the new items to support the flow configuration for IP fragment > packets. > > Signed-off-by: Ting Xu > Signed-o

Re: [dpdk-dev] [PATCH] port: fix dead code in ring

2021-04-19 Thread Thomas Monjalon
07/04/2021 12:59, Cristian Dumitrescu: > Fix logically dead code in ring port. > > Coverity issue: 369664 > Fixes: 77a413017c2d ("port: add ring SWX port") > > Signed-off-by: Cristian Dumitrescu It's not really fixing dead code but allocation check. With title fixed, applied, thanks.

  1   2   3   >