Hi Tal, 2021-04-19 18:06 (UTC+0000), Tal Shnaiderman: > I also noticed warnings in clang on my setup that are related to > rte_os_shim.h: > > [185/314] Compiling C object > drivers/a715181@@tmp_rte_common_mlx5@sta/common_mlx5_mlx5_common_mp.c.obj. > In file included from ../drivers/common/mlx5/mlx5_common_mp.c:13: > In file included from ..\drivers\common/mlx5/mlx5_common_utils.h:8: > In file included from ..\drivers\common/mlx5/mlx5_common.h:17: > ..\lib/librte_eal/windows/include\rte_os_shim.h:22:51: warning: token pasting > of ',' and __VA_ARGS__ is a GNU extension > [-Wgnu-zero-variadic-macro-arguments] > #define open(path, flags, ...) _open(path, flags, ##__VA_ARGS__) > ^ > However don't see it in CI, I'm using clang version 9.0.1
This warning only appears with --buildtype=debug, that's why I missed it. I don't see a good way to fix it except #define open _open, RTE_FMT_xxx approach is not applicable here.
