19/04/2021 23:42, Ferruh Yigit:
> On 4/15/2021 4:11 PM, Li Zhang wrote:
> > To support more meters and better performance,
> > MLX HW provide ASO flow meter.
> > It can expose millions of ASO flow meter context's in HW.
> > This ASO object can allocate the large bulk meter objects.
> > This patch set implement the ASO flow meter for mlx5 driver.
> > MLX5 PMD driver will be responsible for ASO flow meter manage to HW.
> >
>
> What is ASO?
> Search yields "Advanced Steering Operation" but that seems Mellanox jargon,
> would you mind adding some mlx documentation to describe it? If there are
> some
> design considerations around it, it may be good to document that too.
> Also please provide the long version of the abbreviation in the commit log,
> at
> least at first usage of it.
>
> And what do you think mentioning from this new support in the release notes?
Yes, new PMD feature should be announced in the release notes,
it seems to be a miss.
> > doc/guides/nics/mlx5.rst | 6 +
> > drivers/common/mlx5/mlx5_devx_cmds.c | 68 ++
> > drivers/common/mlx5/mlx5_devx_cmds.h | 26 +-
> > drivers/common/mlx5/mlx5_prm.h | 81 +-
> > drivers/common/mlx5/version.map | 1 +
> > drivers/net/mlx5/linux/mlx5_os.c | 20 +-
> > drivers/net/mlx5/meson.build | 2 +-
> > drivers/net/mlx5/mlx5.c | 98 +-
> > drivers/net/mlx5/mlx5.h | 258 +++++-
> > drivers/net/mlx5/mlx5_flow.c | 334 +++++--
> > drivers/net/mlx5/mlx5_flow.h | 212 ++---
> > .../mlx5/{mlx5_flow_age.c => mlx5_flow_aso.c} | 289 +++++-
> > drivers/net/mlx5/mlx5_flow_dv.c | 792 +++++++++++-----
> > drivers/net/mlx5/mlx5_flow_meter.c | 873 ++++++++++++------
> > drivers/net/mlx5/mlx5_utils.h | 90 ++
> > 15 files changed, 2320 insertions(+), 830 deletions(-)
