Thanks all. -----Original Message----- From: Yigit, Ferruh <ferruh.yi...@intel.com> Sent: Tuesday, April 20, 2021 9:01 AM To: Zhang, Tianfei <tianfei.zh...@intel.com>; Zhang, Qi Z <qi.z.zh...@intel.com>; Huang, Wei <wei.hu...@intel.com>; dev@dpdk.org; Xu, Rosen <rosen...@intel.com> Cc: sta...@dpdk.org Subject: Re: [PATCH v2 1/1] raw/ifpga/base: check size before assigning
On 4/20/2021 1:13 AM, Zhang, Tianfei wrote: > > >> -----Original Message----- >> From: Yigit, Ferruh <ferruh.yi...@intel.com> >> Sent: 2021年4月20日 6:36 >> To: Zhang, Qi Z <qi.z.zh...@intel.com>; Huang, Wei >> <wei.hu...@intel.com>; dev@dpdk.org; Xu, Rosen <rosen...@intel.com> >> Cc: sta...@dpdk.org; Zhang, Tianfei <tianfei.zh...@intel.com> >> Subject: Re: [PATCH v2 1/1] raw/ifpga/base: check size before >> assigning >> >> On 4/19/2021 9:12 AM, Zhang, Qi Z wrote: >>> >>> >>>> -----Original Message----- >>>> From: Huang, Wei <wei.hu...@intel.com> >>>> Sent: Thursday, April 8, 2021 4:52 PM >>>> To: dev@dpdk.org; Xu, Rosen <rosen...@intel.com>; Zhang, Qi Z >>>> <qi.z.zh...@intel.com> >>>> Cc: sta...@dpdk.org; Zhang, Tianfei <tianfei.zh...@intel.com>; >>>> Yigit, Ferruh <ferruh.yi...@intel.com>; Huang, Wei >>>> <wei.hu...@intel.com> >>>> Subject: [PATCH v2 1/1] raw/ifpga/base: check size before assigning >>>> >>>> In max10_staging_area_init(), variable "size" from fdt_get_reg() >>>> may be invalid, it should be checked before assigning to member >>>> variable >> "staging_area_size" >>>> of structure "intel_max10_device". >>>> >>>> Coverity issue: 367480, 367482 >>>> Fixes: 96ebfcf8125c ("raw/ifpga/base: add SPI and MAX10 device >>>> driver") >>>> >>>> Signed-off-by: Wei Huang <wei.hu...@intel.com> >>>> --- >>> >>> Applied to dpdk-next-net-intel. >>> >> >> This patch is missing the maintainer ack. >> >> Rosen, Tianfei, can you please review the patch? > > It looks good for me. > > Acked-by: Tianfei zhang <tianfei.zh...@intel.com> > Thanks, added in next-net.