Re: [dpdk-dev] [PATCH 1/2] common/octeontx2: sync cpt mailbox

2020-10-06 Thread Anoob Joseph
> -Original Message- > From: Ankur Dwivedi > Sent: Friday, July 31, 2020 7:22 PM > To: dev@dpdk.org > Cc: akhil.go...@nxp.com; Jerin Jacob Kollanukkaran ; > Nithin Kumar Dabilpuram ; Anoob Joseph > ; Tejasree Kondoj ; Ankur > Dwivedi > Subject: [PATCH 1/2] common/octeontx2: sync cpt mailb

Re: [dpdk-dev] [PATCH v3 0/7] BBDEV test updates

2020-10-06 Thread Akhil Goyal
Hi Nic, > > Hi Akhil, > Just a heads up on this bbdev related serie in case you missed it. > It would be useful to have all the bbdev changes into rc1. > + Tom This patchset is not reviewed much and I have a lot of back log to clear for API layer. I am planning to pick it in RC2, or if I get som

Re: [dpdk-dev] [PATCH v2 2/2] ethdev: make rte_flow API thread safe

2020-10-06 Thread Ori Kam
Hi Suanming, > -Original Message- > From: Suanming Mou > Sent: Wednesday, October 7, 2020 3:50 AM > Subject: RE: [dpdk-dev] [PATCH v2 2/2] ethdev: make rte_flow API thread safe > > > > > -Original Message- > > From: Ajit Khaparde > > Sent: Wednesday, October 7, 2020 7:18 AM >

Re: [dpdk-dev] [PATCH v4 2/2] app/testpmd: support shared action

2020-10-06 Thread Ori Kam
Hi Andrey, > -Original Message- > From: Andrey Vesnovaty > Sent: Tuesday, October 6, 2020 11:09 PM > To: dev@dpdk.org > > Subject: [PATCH v4 2/2] app/testpmd: support shared action > > This patch adds shared action support to testpmd CLI. > > All shared actions created via testpmd CLI a

Re: [dpdk-dev] [PATCH v4 1/2] ethdev: add flow shared action API

2020-10-06 Thread Ori Kam
Hi Andrey, PSB, Best, Ori > -Original Message- > From: Andrey Vesnovaty > Sent: Tuesday, October 6, 2020 11:09 PM > Subject: [PATCH v4 1/2] ethdev: add flow shared action API > > This commit introduces extension of DPDK flow action API enabling > sharing of single rte_flow_action in mult

Re: [dpdk-dev] [PATCH v6 1/1] net/mlx5: support match ICMP identifier fields

2020-10-06 Thread Li Zhang
Hi Ori, My latest patch V6 as below: Please help review it. https://patchwork.dpdk.org/patch/79613/ Thanks, Regards, Li Zhang > -Original Message- > From: Ori Kam > Sent: Tuesday, October 6, 2020 8:07 PM > To: Li Zhang ; Dekel Peled ; Slava > Ovsiienko ; Matan Azrad > Cc: dev@dpdk.org;

Re: [dpdk-dev] [PATCH v2] raw/dpaa2_qdma: fix missing parentheses

2020-10-06 Thread Nipun Gupta
Acked by: Nipun Gupta > -Original Message- > From: wangyunjian > Sent: Wednesday, September 9, 2020 6:42 AM > To: dev@dpdk.org > Cc: Nipun Gupta ; jerry.lili...@huawei.com; > xudin...@huawei.com; Yunjian Wang ; > sta...@dpdk.org > Subject: [dpdk-dev] [PATCH v2] raw/dpaa2_qdma: fix missin

[dpdk-dev] [PATCH v3 3/3] test/event_crypto_adapter: free resources during exit

2020-10-06 Thread Ankur Dwivedi
The resources held by crypto adapter should be freed when the test suite exits. Signed-off-by: Ankur Dwivedi --- app/test/test_event_crypto_adapter.c | 22 ++ 1 file changed, 22 insertions(+) diff --git a/app/test/test_event_crypto_adapter.c b/app/test/test_event_crypto_ada

[dpdk-dev] [PATCH v3 2/3] test/event_crypto_adapter: fix function arguments

2020-10-06 Thread Ankur Dwivedi
The arguments passed to rte_event_crypto_adapter_caps_get() and rte_event_crypto_adapter_create() are incorrect. In the rte_event_crypto_adapter_caps_get(), event device id should be the first argument and cryptodev id should be the second argument. In the rte_event_crypto_adapter_create(), the ev

[dpdk-dev] [PATCH v3 1/3] test/event_crypto_adapter: return error with unsupported mode

2020-10-06 Thread Ankur Dwivedi
The capability of a hardware event device should be checked before creating a event crypto adapter in a particular mode. The test case returns error if the mode is not supported. Signed-off-by: Ankur Dwivedi --- app/test/test_event_crypto_adapter.c | 33 +++- 1 file chang

[dpdk-dev] [PATCH v3 0/3] Bug fixes in event crypto adapter test

2020-10-06 Thread Ankur Dwivedi
This patch series resolves bugs in the event crypto adapter test application. v3: * In the "test/event_crypto_adapter: fix function arguments" patch, fixed arguments of rte_event_crypto_adapter_caps_get(). * In the "test/event_crypto_adapter: free resources during exit" patch, the following ch

Re: [dpdk-dev] [PATCH v2 08/17] net/fm10k: add checks for max SIMD bitwidth

2020-10-06 Thread Wang, Xiao W
Hi Ciara, BRs, Xiao > -Original Message- > From: Power, Ciara > Sent: Friday, August 28, 2020 12:13 AM > To: dev@dpdk.org > Cc: Power, Ciara ; Zhang, Qi Z > ; Wang, Xiao W > Subject: [PATCH v2 08/17] net/fm10k: add checks for max SIMD bitwidth > > When choosing a vector path to take, a

Re: [dpdk-dev] [PATCH v3 01/11] ethdev: add extensions attributes to IPv6 item

2020-10-06 Thread Ajit Khaparde
On Mon, Oct 5, 2020 at 1:37 AM Dekel Peled wrote: > > Using the current implementation of DPDK, an application cannot match on > IPv6 packets, based on the existing extension headers, in a simple way. > > Field 'Next Header' in IPv6 header indicates type of the first extension > header only. Follo

Re: [dpdk-dev] [PATCH v2 2/2] ethdev: make rte_flow API thread safe

2020-10-06 Thread Ajit Khaparde
> > +static inline void > > +flow_lock(struct rte_eth_dev *dev) > > Maybe change the name to flow_safe_enter > Since this function doesn't always lock. I feel fts_enter() sounds better. > > > +{ > > + if (!(dev->data->dev_flags & > > RTE_ETH_DEV_FLOW_OPS_THREAD_SAFE)) > > + pthread

[dpdk-dev] [PATCH v2] net/netvsc: fix txq leak in error path

2020-10-06 Thread wangyunjian
From: Yunjian Wang In hn_dev_tx_queue_setup() allocated memory for txq, we don't free it when error happens and it will lead to memory leak. We can check for tx_free_thresh at the beginning of the function to fix it, before calling txq = rte_zmalloc_socket(). Fixes: cc0251813277 ("net/netvsc: s

Re: [dpdk-dev] [PATCH v3] net/bnxt: support fast mbuf free

2020-10-06 Thread Ajit Khaparde
On Tue, Oct 6, 2020 at 10:37 AM Lance Richardson wrote: > > Add support for DEV_TX_OFFLOAD_MBUF_FAST_FREE to bnxt > vector mode transmit. This offload may be enabled > only when multi-segment transmit is not needed, all > transmitted mbufs for a given queue will be allocated > from the same pool,

Re: [dpdk-dev] [PATCH] net/bnxt: fix link update op

2020-10-06 Thread Ajit Khaparde
On Tue, Oct 6, 2020 at 8:47 AM Kalesh A P wrote: > > From: Kalesh AP > > 1. When port is stopped, we can forcibly set the link status for the >device to down. > 2. VFs and MH PFs do not have the privilege to bring the link down. >As a result driver prints "Link Up" when port is stopped. >

Re: [dpdk-dev] [PATCH v3 15/18] member: add checks for max SIMD bitwidth

2020-10-06 Thread Wang, Yipeng1
> -Original Message- > From: Power, Ciara > Sent: Wednesday, September 30, 2020 6:04 AM > To: dev@dpdk.org > Cc: Power, Ciara ; Wang, Yipeng1 > ; Gobriel, Sameh > Subject: [PATCH v3 15/18] member: add checks for max SIMD bitwidth > > When choosing a vector path to take, an extra conditio

Re: [dpdk-dev] [PATCH v3 16/18] efd: add checks for max SIMD bitwidth

2020-10-06 Thread Wang, Yipeng1
> -Original Message- > From: Power, Ciara > Sent: Wednesday, September 30, 2020 6:04 AM > To: dev@dpdk.org > Cc: Power, Ciara ; Marohn, Byron > ; Wang, Yipeng1 > Subject: [PATCH v3 16/18] efd: add checks for max SIMD bitwidth > > When choosing a vector path to take, an extra condition mu

Re: [dpdk-dev] [PATCH v2 2/2] ethdev: make rte_flow API thread safe

2020-10-06 Thread Suanming Mou
> -Original Message- > From: Ajit Khaparde > Sent: Wednesday, October 7, 2020 7:18 AM > To: Ori Kam > Cc: Suanming Mou ; Ori Kam > ; John McNamara ; > Marko Kovacevic ; NBU-Contact-Thomas > Monjalon ; Ferruh Yigit ; > Andrew Rybchenko ; dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v2 2

Re: [dpdk-dev] [PATCH V15 3/3] app/testpmd: add FEC command

2020-10-06 Thread humin (Q)
HI,Ferruh, how about only considering the first patch:ethdev:add fec API. If this patch looks great to you, I wish it could be merged into 20.11. To that patch, app/testpmd add fec command, I will fix it later. thanks. -- 胡敏 Hu

Re: [dpdk-dev] [PATCH v3 0/7] BBDEV test updates

2020-10-06 Thread Chautru, Nicolas
Hi Akhil, Just a heads up on this bbdev related serie in case you missed it. It would be useful to have all the bbdev changes into rc1. + Tom Thanks again, Nic > -Original Message- > From: Chautru, Nicolas > Sent: Tuesday, August 18, 2020 5:06 PM > To: dev@dpdk.org; akhil.go...@nxp.c

Re: [dpdk-dev] [PATCH v5] bus/pci: netuio interface for windows

2020-10-06 Thread Kadam, Pallavi
On 9/29/2020 1:28 AM, Tal Shnaiderman wrote: Subject: [PATCH v5] bus/pci: netuio interface for windows This patch adds implementations to probe PCI devices bound to netuio with the help of "netuio" class device changes. Now Windows will support both "netuio" and "net" device class and can set

[dpdk-dev] [PATCH v6] bus/pci: netuio interface for windows

2020-10-06 Thread Pallavi Kadam
This patch adds implementations to probe PCI devices bound to netuio with the help of "netuio" class device changes. Now Windows will support both "netuio" and "net" device class and can set kernel driver type based on the device class selection. Note: Few definitions and structures have been copi

Re: [dpdk-dev] [PATCH] librte_eal: fix mcslock hang on weak memory

2020-10-06 Thread Thomas Monjalon
31/08/2020 20:45, Honnappa Nagarahalli: > > Hi Diogo, > > Thanks for your explanation. > > As documented in https://developer.arm.com/documentation/ddi0487/fc B2.9.5 > Load-Exclusive and Store-Exclusive instruction usage restrictions: > " Between the Load-Exclusive and the Store-Exclusive, the

Re: [dpdk-dev] [PATCH v3] mempool: enhance dump function to print ops name

2020-10-06 Thread Thomas Monjalon
> Enhance the dump function to also print the ops index > and associated mempool ops name > > Signed-off-by: Hemant Agrawal > Acked-by: Andrew Rybchenko Applied, thanks

Re: [dpdk-dev] port: fix unused value

2020-10-06 Thread Thomas Monjalon
> This patch fixes an unused value in pcap source port by > removing the setting to the value. > > Coverity issue: 362020 > Fixes: d4b42133d85b ("port: add pcap file source") > Cc: roy.fan.zh...@intel.com > Cc: sta...@dpdk.org > > Signed-off-by: Fan Zhang Applied, thanks

[dpdk-dev] [PATCH v3] net/bnxt: support fast mbuf free

2020-10-06 Thread Lance Richardson
Add support for DEV_TX_OFFLOAD_MBUF_FAST_FREE to bnxt vector mode transmit. This offload may be enabled only when multi-segment transmit is not needed, all transmitted mbufs for a given queue will be allocated from the same pool, and all transmitted mbufs will have a reference count of 1. Signed-o

Re: [dpdk-dev] [PATCH 1/7] raw/dpaa2_qdma: change DPAA2 QDMA APIs to rawdev ops

2020-10-06 Thread Thomas Monjalon
Hi, I see a build issue in the first patch, so I didn't check further: drivers/raw/dpaa2_qdma/dpaa2_qdma.c:1158:30: error: initialization of ‘int (*)(const struct rte_rawdev *, void *, size_t)’ {aka ‘int (*)(const struct rte_rawdev *, void *, long unsigned int)’} from incompatible pointer type

Re: [dpdk-dev] [PATCH v2] raw/dpaa2_qdma: fix missing parentheses

2020-10-06 Thread Thomas Monjalon
Nipun, could you review please? 09/09/2020 03:11, wangyunjian: > From: Yunjian Wang > > This issue detected by coverity, CID#279443(Structurally dead code). > > Coverity issue: 279443 > Fixes: c22fab9a6c34 ("raw/dpaa2_qdma: support configuration APIs") > Cc: sta...@dpdk.org > > Signed-off-by:

Re: [dpdk-dev] [PATCH 05/22] event/dlb2: add inline functions

2020-10-06 Thread Eads, Gage
> -Original Message- > From: McDaniel, Timothy > Sent: Friday, September 11, 2020 3:26 PM > Cc: dev@dpdk.org; Carrillo, Erik G ; Eads, Gage > ; Van Haaren, Harry ; > jer...@marvell.com > Subject: [PATCH 05/22] event/dlb2: add inline functions > > Add miscellaneous inline functions that

Re: [dpdk-dev] [dpdk-stable] [PATCH v1 1/2] raw/skeleton: reset rawdev test statistics

2020-10-06 Thread Thomas Monjalon
21/09/2020 23:44, Lukasz Wojciechowski: > Statistics: passed, failed, unsupported and total are kept > in global static variables. As global variables they are initiated > with zeroes. However running test multiple times cumulates results > from previous calls. > > This patch resets statistics wit

[dpdk-dev] [PATCH v2] net/vhost: fix xstats wrong after clearing stats

2020-10-06 Thread David Christensen
The PMD API allows stats and xstats values to be cleared separately. This is a problem for the vhost PMD since some of the xstats values are derived from existing stats values. For example: testpmd> show port xstats all ... tx_unicast_packets: 17562959 ... testpmd> clear port stats all ... show p

Re: [dpdk-dev] [PATCH v1] baseband/turbo_sw: update meson for more dynamic compilation

2020-10-06 Thread Akhil Goyal
> > On Thu, Sep 03, 2020 at 06:05:35PM -0700, Nicolas Chautru wrote: > > The meson for the turbo_sw PMD is updated to prevent the > > requirement for any device specific toplevel flags to be > > passed down (unlike what used to be the case with make). > > The linking to the optional libraries is p

Re: [dpdk-dev] [PATCH v2 2/2] net/virtio: check return from rte_raw_cksum_mbuf

2020-10-06 Thread Thomas Monjalon
> rte_raw_cksum_mbuf can fail, so we should check to see if it > has. If so, return with an error. > > Fixes: 96cb6711939e ("net/virtio: support Rx checksum offload") It is an old bug, so it should be backported, right? Cc: sta...@dpdk.org > Signed-off-by: Chas Williams <3ch...@gmail.com> > ---

Re: [dpdk-dev] [PATCH v1] doc: update bbdev guide

2020-10-06 Thread Akhil Goyal
Hi Nic, > Hi Akhil, > > I have no strong opinion given this is minor doc clarification update. > Also the related feature is not really exercised until 20.11 really (with new > PMD). > Still if you think it is required the change would refer to that commit > 3f3f608142cf48 > Let me know if I sho

Re: [dpdk-dev] [PATCH v4 00/25] raw/ioat: enhancements and new hardware support

2020-10-06 Thread Thomas Monjalon
> This patchset adds some small enhancements, some rework and also support > for new hardware to the ioat rawdev driver. Most rework and enhancements > are largely self-explanatory from the individual patches. Another ioat patch has been merged before. Please could you rebase?

Re: [dpdk-dev] [PATCH 0/2] baseband: fix segfault in Intel drivers

2020-10-06 Thread Akhil Goyal
> Subject: [dpdk-dev] [PATCH 0/2] baseband: fix segfault in Intel drivers > > This series fixes segfaults in fpga_5gnr_fec and fpga_lte_fec > drivers when bbdev debug is enabled. > > Maxime Coquelin (2): > baseband/fpga_5gnr_fec: fix segfaults with debug > baseband/fpga_lte_fec: fix segfaults

Re: [dpdk-dev] [PATCH v1] doc: update bbdev guide

2020-10-06 Thread Chautru, Nicolas
Hi Akhil, > -Original Message- > From: Akhil Goyal > Sent: Tuesday, October 6, 2020 1:53 PM > To: Chautru, Nicolas ; dev@dpdk.org > Cc: dave.bur...@accelercomm.com > Subject: RE: [dpdk-dev] [PATCH v1] doc: update bbdev guide > > > Subject: [dpdk-dev] [PATCH v1] doc: update bbdev guide >

Re: [dpdk-dev] [PATCH v1] app/bbdev: fix test vector symlink

2020-10-06 Thread Akhil Goyal
Acked-by: Liu Tianjiao > Applied to dpdk-next-crypto Thanks.

Re: [dpdk-dev] [PATCH v9 0/3] add basic ethdev stats with data object recursion

2020-10-06 Thread Thomas Monjalon
> This patchset adds support for basic ethdev statistics in Telemetry. > To do this, recursive data object support is needed to report the queue > statistics in a list. With this patch, an array or dictionary supports > uint64_t, int or string array type values, which is used for the ethdev > queue

Re: [dpdk-dev] [PATCH v1] doc: update bbdev guide

2020-10-06 Thread Akhil Goyal
> Subject: [dpdk-dev] [PATCH v1] doc: update bbdev guide > > Clarify the capability assumptions for LLR and HARQ > compression format. > Correct one historical typo. > > Signed-off-by: Nicolas Chautru > --- Should this be cced to stable for back port?

Re: [dpdk-dev] [PATCH v2 1/1] crypto/scheduler: rename slave to worker

2020-10-06 Thread Akhil Goyal
> > > > This patch replaces the usage of the word 'slave' with more > > appropriate word 'worker' in QAT PMD and Scheduler PMD > > as well as in their docs. Also the test app was modified > > to use the new wording. > > > > The Scheduler PMD's public API was modified according to the > > previous d

Re: [dpdk-dev] [PATCH] eal/windows: export all built functions for clang

2020-10-06 Thread Dmitry Kozlyuk
On Fri, 2 Oct 2020 22:18:37 +0300, Tal Shnaiderman wrote: > export for clang build all the functions currently built > on Windows and listed in rte_eal_version.map by adding > them to rte_eal_exports.def. > > Signed-off-by: Tal Shnaiderman > --- > lib/librte_eal/rte_eal_exports.def | 156 > +++

Re: [dpdk-dev] [PATCH] maintainers: improve coverage of arch-specific files

2020-10-06 Thread David Christensen
On 10/6/20 1:22 PM, Thomas Monjalon wrote: The sub-directories of config/ are maintained by different architecture maintainers. Some wildcards are used to describe the lib and drivers files which are specific to some architectures. The EAL Arm files have split responsibilities depending on 3

[dpdk-dev] [PATCH 7/7] pipeline: fix instruction config free

2020-10-06 Thread Cristian Dumitrescu
Fixes: a1711f948d ("pipeline: add SWX Rx and extract instructions") Coverity issue: 362901 Signed-off-by: Cristian Dumitrescu --- lib/librte_pipeline/rte_swx_pipeline.c | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/lib/librte_pipeline/rte_swx_pipeline.c b/lib/l

[dpdk-dev] [PATCH 5/7] pipeline: fix resource leak issue

2020-10-06 Thread Cristian Dumitrescu
Fixes: b32c0a2c5e ("pipeline: add SWX table update high level API") Coverity issue: 362812 Signed-off-by: Cristian Dumitrescu --- lib/librte_pipeline/rte_swx_ctl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/librte_pipeline/rte_swx_ctl.c b/lib/librte_pipeline/rte_swx

[dpdk-dev] [PATCH 6/7] pipeline: fix unused variable issue

2020-10-06 Thread Cristian Dumitrescu
Fixes: 75634474ca ("pipeline: add SWX instruction verifier") Coverity issue: 362855 Signed-off-by: Cristian Dumitrescu --- lib/librte_pipeline/rte_swx_pipeline.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/librte_pipeline/rte_swx_pipeline.c b/lib/librte_pipeline/rte_

[dpdk-dev] [PATCH 2/7] examples/pipeline: fix files for table update

2020-10-06 Thread Cristian Dumitrescu
Fixes: 5074e1d551 ("examples/pipeline: add configuration commands") Coverity issues: 362744, 362745, 362882 Signed-off-by: Cristian Dumitrescu --- examples/pipeline/cli.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/examples/pipeline/cli.c b/examples/pipeline/cli.c

[dpdk-dev] [PATCH 4/7] pipeline: fix memory free issues

2020-10-06 Thread Cristian Dumitrescu
Fixes: 3ca60ceed7 ("pipeline: add SWX pipeline specification file") Coverity issues: 362796, 362804, 362819, 362836, 362858, 362865, 362869 Signed-off-by: Cristian Dumitrescu --- lib/librte_pipeline/rte_swx_pipeline_spec.c | 18 ++ 1 file changed, 18 insertions(+) diff --git a/l

[dpdk-dev] [PATCH 3/7] pipeline: fix argument check

2020-10-06 Thread Cristian Dumitrescu
Fixes: 3ca60ceed7 ("pipeline: add SWX pipeline specification file") Coverity issue: 362789 Signed-off-by: Cristian Dumitrescu --- lib/librte_pipeline/rte_swx_pipeline_spec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/librte_pipeline/rte_swx_pipeline_spec.c b/lib/lib

[dpdk-dev] [PATCH 1/7] pipeline: fix memory leak issue

2020-10-06 Thread Cristian Dumitrescu
Fixes: b32c0a2c5e ("pipeline: add SWX table update high level API") Coverity issue: 362741 Signed-off-by: Cristian Dumitrescu --- lib/librte_pipeline/rte_swx_ctl.c | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/librte_pipeline/rte_swx_ctl.c b/lib/librte_pipeline/rte_swx_ctl.c index 576

Re: [dpdk-dev] [PATCH] crypto/dpaax_sec: fix a null pointer dereference after null check

2020-10-06 Thread Akhil Goyal
> > From: Yunjian Wang > > This patch fixes a null pointer dereference after null check detected by > coverity scan. > > Coverity issue: 349904 > Fixes: 6a0c9d364afc ("crypto/dpaax_sec: support HFN override") > Cc: sta...@dpdk.org Acked-by: Akhil Goyal Applied to dpdk-next-crypto Thanks.

Re: [dpdk-dev] [PATCH v2] lib/telemetry: fix passing full params string to command

2020-10-06 Thread Thomas Monjalon
27/08/2020 11:14, Bruce Richardson: > On Thu, Aug 27, 2020 at 09:39:22AM +0100, Ciara Power wrote: > > Telemetry only passed the first param to the command handler if multiple > > were entered by the user, separated by commas. Telemetry is required to > > pass the full params string to the command,

Re: [dpdk-dev] [PATCH v3] ipsec: remove experimental tag

2020-10-06 Thread Akhil Goyal
> > On 16/09/2020 12:22, Ananyev, Konstantin wrote: > > > > > >> Since librte_ipsec was first introduced in 19.02 and there were no > > >> changes > > >> in it's public API since 19.11, it should be considered mature enough to > > >> remove the 'experimental' tag from it. > > >> The RTE_SATP_LOG2_

[dpdk-dev] [PATCH] maintainers: improve coverage of arch-specific files

2020-10-06 Thread Thomas Monjalon
The sub-directories of config/ are maintained by different architecture maintainers. Some wildcards are used to describe the lib and drivers files which are specific to some architectures. The EAL Arm files have split responsibilities depending on 32/64 suffix, and the common files are shared bet

Re: [dpdk-dev] [PATCH] build: add -moutline-atomics to default Arm build

2020-10-06 Thread Thomas Monjalon
01/10/2020 08:19, Juraj Linkeš: > -moutline-atomics allows LSE instructions to be used if available when > compiling for ARMv8.0 instruction set. It's enabled by default on newer > compilers, such as gcc-10.1. Enable the option so that earlier compiler > versions that support it but don't enable it

Re: [dpdk-dev] [PATCH v3] ipsec: remove experimental tag

2020-10-06 Thread Akhil Goyal
> > On 16/09/2020 12:22, Ananyev, Konstantin wrote: > > > >> Since librte_ipsec was first introduced in 19.02 and there were no changes > >> in it's public API since 19.11, it should be considered mature enough to > >> remove the 'experimental' tag from it. > >> The RTE_SATP_LOG2_NUM enum is also

[dpdk-dev] [PATCH v4 1/2] ethdev: add flow shared action API

2020-10-06 Thread Andrey Vesnovaty
This commit introduces extension of DPDK flow action API enabling sharing of single rte_flow_action in multiple flows. The API intended for PMDs, where multiple HW offloaded flows can reuse the same HW essence/object representing flow action and modification of such an essence/object affects all th

[dpdk-dev] [PATCH v4 2/2] app/testpmd: support shared action

2020-10-06 Thread Andrey Vesnovaty
This patch adds shared action support to testpmd CLI. All shared actions created via testpmd CLI assigned ID for further reference in other CLI commands. Shared action ID supplied as CLI argument or assigned by testpmd is similar to flow ID & limited to scope of testpdm CLI. Create shared action

[dpdk-dev] [PATCH v4 0/2] RTE flow shared action

2020-10-06 Thread Andrey Vesnovaty
This patchset introduces shared action API for RTE flow. V4 changes: * patchset split to: 1. shared action API (this patchset) 2. mlx5 PMD implementation for shared action API * testpmd for shared action CLI documented * release notes for 20.11 updated with shared action feature * misc spellin

Re: [dpdk-dev] [PATCH v2 1/3] test/crypto: replace NITROX PMD specific test suite

2020-10-06 Thread Akhil Goyal
> Subject: [PATCH v2 1/3] test/crypto: replace NITROX PMD specific test suite > > Replace NITROX PMD specific tests with generic test suite. > > Signed-off-by: Nagadheeraj Rottela > --- Applied this patch to dpdk-next-crypto as is it unrelated to rest of the patches. Please fix compilation err

Re: [dpdk-dev] [PATCH v2 2/3] crypto/nitrox: support AES-GCM

2020-10-06 Thread Akhil Goyal
Hi Nagadheeraj, > Subject: [PATCH v2 2/3] crypto/nitrox: support AES-GCM > > This patch adds AES-GCM AEAD algorithm. > > Signed-off-by: Nagadheeraj Rottela > --- This patch is showing compilation error while compiling individually. ./drivers/crypto/nitrox/nitrox_sym_reqmgr.c ../drivers/crypto

Re: [dpdk-dev] [PATCH] app/procinfo: close devices before exit

2020-10-06 Thread Thomas Monjalon
> As well as this is correct thing to close devices before exit, it is > also useful to test the closing devices from secondary process. > > Signed-off-by: Ferruh Yigit Closing in secondary should not affect the primary. Good to test :) Applied, thanks.

Re: [dpdk-dev] [PATCH v7 0/3] gro: add UDP/IPv4 GRO and VXLAN UDP/IPv4 GRO support

2020-10-06 Thread Thomas Monjalon
> From: Yi Yang > > In case that UFO or GSO is enabled, GRO is very necessary, > especially for UDP, it is more so. Many NICs can't support > VXLAN UDP UFO/USO and VLAN UFO/USO, so UDP performance > improvement depends on GSO and GRO to a great extent. > > This patch series added VLAN UDP/IPv4 G

Re: [dpdk-dev] [PATCH -v2] doc: remove orphan PMD feature table

2020-10-06 Thread Akhil Goyal
> Removing a feature table referring erroneously > to a PMD not present in DPDK. > > Fixes: 65f1eec ("doc: add feature matrix table for bbdev") > > Cc: sta...@dpdk.org > > Signed-off-by: Nicolas Chautru Acked-by: Akhil Goyal Applied to dpdk-next-crypto Thanks.

Re: [dpdk-dev] [PATCH v12 00/10] bbdev PMD ACC100

2020-10-06 Thread Akhil Goyal
> > Hi Nicolas, > > The series looks overall good to me now. Thanks for implementing the > suggested changes. > > For what it's worth: > > Acked-by: Maxime Coquelin > Series applied to dpdk-next-crypto Thanks.

Re: [dpdk-dev] [PATCH 0/2] baseband: fix drivers API

2020-10-06 Thread Akhil Goyal
> > The series prefixes drivers APIs with rte__ in > order to avoid namespace pollution. > > These APIs are experimental, so no need to follow the > deprecation process. > Added Fixes commit in patch description. Series applied to dpdk-next-crypto Thanks.

Re: [dpdk-dev] [PATCH 04/22] event/dlb2: add definitions shared with LKM or shared code

2020-10-06 Thread Eads, Gage
> -Original Message- > From: McDaniel, Timothy > Sent: Friday, September 11, 2020 3:26 PM > Cc: dev@dpdk.org; Carrillo, Erik G ; Eads, Gage > ; Van Haaren, Harry ; > jer...@marvell.com > Subject: [PATCH 04/22] event/dlb2: add definitions shared with LKM or shared > code > > Add headers

Re: [dpdk-dev] [PATCH v7 0/8] Enable dynamic config of subport bandwidth

2020-10-06 Thread Dumitrescu, Cristian
> -Original Message- > From: Dharmappa, Savinay > Sent: Tuesday, October 6, 2020 7:02 PM > To: Dumitrescu, Cristian ; Singh, Jasvinder > ; dev@dpdk.org > Cc: Dharmappa, Savinay > Subject: [PATCH v7 0/8] Enable dynamic config of subport bandwidth > > DPDK sched library allows runtime c

Re: [dpdk-dev] [PATCH] eal/windows: export all built functions for clang

2020-10-06 Thread Ranjit Menon
On 10/2/2020 12:18 PM, Tal Shnaiderman wrote: export for clang build all the functions currently built on Windows and listed in rte_eal_version.map by adding them to rte_eal_exports.def. Signed-off-by: Tal Shnaiderman --- lib/librte_eal/rte_eal_exports.def | 156

Re: [dpdk-dev] [PATCH] build: support i686 target on x86 64-bit hosts

2020-10-06 Thread Lance Richardson
On Tue, Oct 6, 2020 at 4:30 AM Thomas Monjalon wrote: > > 25/09/2020 15:27, Lance Richardson: > > Bruce Richardson wrote: > > > On Thu, Sep 24, 2020 at 12:37:42PM -0400, Lance Richardson wrote: > > > > Add meson cross files for building i686 targets using gcc on x86_64 > > > > linux hosts. > > > >

Re: [dpdk-dev] [PATCH] test/crypto: fix device number

2020-10-06 Thread Akhil Goyal
> > Subject: [dpdk-dev] [PATCH] test/crypto: fix device number > > > > In testsuite_setup(), ts_params is configured for first valid device. > > The same device should be used as valid device in > > test_device_configure_invalid_dev_id test case. > > > > Fixes: 202d375c60bc ("app/test: add cryptode

[dpdk-dev] [PATCH v7 6/8] drivers/softnic: update subport rate dynamically

2020-10-06 Thread Savinay Dharmappa
Modify the softnic drivers to build the hierarchical scheduler with default subport bandwidth profile. It also allows to update a subport with different subport rates dynamically. Signed-off-by: Savinay Dharmappa --- .../net/softnic/rte_eth_softnic_internals.h | 11 +- drivers/net/softnic/rte

[dpdk-dev] [PATCH v7 5/8] example/ip_pipeline: update subport rate dynamically

2020-10-06 Thread Savinay Dharmappa
Modify the ip_pipeline application to build the hierarchical scheduler with default subport bandwidth profile. It also allows to update a subport with different subport rates dynamically Signed-off-by: Savinay Dharmappa --- examples/ip_pipeline/cli.c | 68 examples/ip_pipe

[dpdk-dev] [PATCH v7 7/8] app/test_sched: update subport rate dynamically

2020-10-06 Thread Savinay Dharmappa
Modify the test_sched application to build the hierarchical scheduler with default subport bandwidth profile. It also allows to update a subport with different subport rates dynamically Signed-off-by: Savinay Dharmappa --- app/test/test_sched.c | 13 +++-- 1 file changed, 11 insertions(+

[dpdk-dev] [PATCH v7 1/8] sched: add support profile table

2020-10-06 Thread Savinay Dharmappa
Add subport profile table to internal port data structure and update the port config function. Signed-off-by: Savinay Dharmappa Signed-off-by: Jasvinder Singh --- lib/librte_sched/rte_sched.c | 197 ++- lib/librte_sched/rte_sched.h | 25 + 2 files changed, 2

[dpdk-dev] [PATCH v7 4/8] example/qos_sched: update subport rate dynamically

2020-10-06 Thread Savinay Dharmappa
Modify the qos_sched application to build the hierarchical scheduler with default subport bandwidth profile. It also allows to update a subport with different subport rates dynamically. Signed-off-by: Savinay Dharmappa --- examples/qos_sched/cfg_file.c | 151 +++-- e

[dpdk-dev] [PATCH v7 0/8] Enable dynamic config of subport bandwidth

2020-10-06 Thread Savinay Dharmappa
DPDK sched library allows runtime configuration of the pipe profiles to the pipes of the subport once scheduler hierarchy is constructed. However, to change the subport level bandwidth, existing hierarchy needs to be dismantled and whole process of building hierarchy under subport nodes needs to be

[dpdk-dev] [PATCH v7 3/8] sched: update subport rate dynamically

2020-10-06 Thread Savinay Dharmappa
Add support to update subport rate dynamically. Signed-off-by: Savinay Dharmappa --- app/test/test_sched.c| 2 +- drivers/net/softnic/rte_eth_softnic_tm.c | 6 +- examples/ip_pipeline/tmgr.c | 6 +- examples/qos_sched/init.c| 3 +- lib/lib

[dpdk-dev] [PATCH v7 2/8] sched: introduce subport profile add function

2020-10-06 Thread Savinay Dharmappa
API to add new subport bandwidth profile. Signed-off-by: Savinay Dharmappa Signed-off-by: Jasvinder Singh --- lib/librte_sched/rte_sched.c | 66 ++ lib/librte_sched/rte_sched.h | 23 + lib/librte_sched/rte_sched_version.map | 2 + 3 files cha

[dpdk-dev] [PATCH v7 8/8] sched: remove redundant code

2020-10-06 Thread Savinay Dharmappa
Remove redundant data structure fields references from functions and subport level data structures. It also update the release and deprecation note Signed-off-by: Savinay Dharmappa --- doc/guides/rel_notes/deprecation.rst | 6 doc/guides/rel_notes/release_20_11.rst | 1 + lib/librte_sch

Re: [dpdk-dev] [PATCH 1/2] app/test: uninit vdevs in event eth Rx adapter autotest

2020-10-06 Thread Jayatheerthan, Jay
Hi, Request to review the changes below. Regards, Jay > -Original Message- > From: Jayatheerthan, Jay > Sent: Saturday, October 3, 2020 2:36 PM > To: jer...@marvell.com; tho...@monjalon.net; Rao, Nikhil > > Cc: dev@dpdk.org; sta...@dpdk.org; Jayatheerthan, Jay > > Subject: [PATCH 1/2

Re: [dpdk-dev] [PATCH 2/2] app/test: add net null dev creation in Rx adapter autotest

2020-10-06 Thread Jayatheerthan, Jay
Hi, Request to review the changes below. Regards, Jay > -Original Message- > From: Jayatheerthan, Jay > Sent: Saturday, October 3, 2020 2:36 PM > To: jer...@marvell.com; tho...@monjalon.net; Rao, Nikhil > > Cc: dev@dpdk.org; sta...@dpdk.org; Jayatheerthan, Jay > > Subject: [PATCH 2/2

Re: [dpdk-dev] [PATCH 1/2] baseband/fpga_5gnr_fec: fix segfaults with debug

2020-10-06 Thread Chautru, Nicolas
Hi Maxime, > -Original Message- > From: Maxime Coquelin > Sent: Tuesday, October 6, 2020 9:34 AM > To: Chautru, Nicolas ; dev@dpdk.org; > sta...@dpdk.org; t...@redhat.com > Subject: Re: [PATCH 1/2] baseband/fpga_5gnr_fec: fix segfaults with debug > > Hi Nicolas, > > On 10/6/20 6:14 PM,

Re: [dpdk-dev] [RFC PATCH v4 3/3] app/testpmd: handle device recovery event

2020-10-06 Thread Ophir Munk
Hi Kalesh, Please find a few comments. The name you gave to the event (EVENT_RESET) is very close to an already existing one: "EVENT_INTR_RESET". But they are different. EVENT_INTR_RESET originates from a port reset. It requires application reaction. It is widely used. It is documented in *.rst f

[dpdk-dev] [PATCH v3] net/dpaa2: fix build error about timesync functions

2020-10-06 Thread Ferruh Yigit
From: Chenxu Di Some timesync related source files are built only when 'RTE_LIBRTE_IEEE1588' config is set, which is missing in meson. Building with '-DRTE_LIBRTE_IEEE1588' cflag will enable timesync functionality in the files that are build, but it won't build files that require 'RTE_LIBRTE_IEE

[dpdk-dev] [PATCH v3 1/3] examples/l3fwd-acl: add source and destination MAC update

2020-10-06 Thread Konstantin Ananyev
Introduces two changes into l3fwd-acl behaviour to make it behave in the same way as l3fwd: - Add a command-line parameter to allow the user to specify the destination mac address for each ethernet port used. - While forwarding the packet update source and destination mac addresses. Signed

[dpdk-dev] [PATCH v3 3/3] examples/l3fwd-acl: add support for AVX512

2020-10-06 Thread Konstantin Ananyev
Add ability to select AVX512 classify algorithm. Signed-off-by: Konstantin Ananyev --- Depends-on: series-12721 ("acl: introduce AVX512 classify methods") doc/guides/sample_app_ug/l3_forward_access_ctrl.rst | 2 +- examples/l3fwd-acl/main.c | 8 2 files change

[dpdk-dev] [PATCH v3 2/3] examples/l3fwd-acl: allow explicitly select classify method

2020-10-06 Thread Konstantin Ananyev
Replace '--scalar' command-line option with new one: --alg= to allow user explicitly select desired classify method. This is an optional parameter, if not specified default classify algorithm will be used. Signed-off-by: Konstantin Ananyev --- doc/guides/rel_notes/release_20_11.rst| 5

[dpdk-dev] [PATCH v3 0/3] Few enhancements for l3fwd-acl

2020-10-06 Thread Konstantin Ananyev
Improve l3fwd-acl usability. Allow to specify destination MAC and explicitly select classify algorithm. Depends-on: series-12721 ("acl: introduce AVX512 classify methods") Konstantin Ananyev (3): examples/l3fwd-acl: add source and destination MAC update examples/l3fwd-acl: allow explicitly se

Re: [dpdk-dev] [PATCH 03/22] event/dlb2: add private data structures and constants

2020-10-06 Thread Eads, Gage
> -Original Message- > From: McDaniel, Timothy > Sent: Friday, September 11, 2020 3:26 PM > Cc: dev@dpdk.org; Carrillo, Erik G ; Eads, Gage > ; Van Haaren, Harry ; > jer...@marvell.com > Subject: [PATCH 03/22] event/dlb2: add private data structures and constants > > The header file dl

Re: [dpdk-dev] [PATCH 02/22] event/dlb2: add dynamic logging

2020-10-06 Thread Eads, Gage
> -Original Message- > From: McDaniel, Timothy > Sent: Friday, September 11, 2020 3:26 PM > Cc: dev@dpdk.org; Carrillo, Erik G ; Eads, Gage > ; Van Haaren, Harry ; > jer...@marvell.com > Subject: [PATCH 02/22] event/dlb2: add dynamic logging > > This commit adds base support for dynamic l

Re: [dpdk-dev] [PATCH v3 1/2] net: add run-time architecture specific CRC selection

2020-10-06 Thread O'loingsigh, Mairtin
Hi, > -Original Message- > From: Singh, Jasvinder > Sent: Friday, October 2, 2020 4:18 PM > To: O'loingsigh, Mairtin ; Richardson, Bruce > ; De Lara Guarch, Pablo > > Cc: dev@dpdk.org; Ryan, Brendan ; Coyle, David > > Subject: RE: [PATCH v3 1/2] net: add run-time architecture specific C

Re: [dpdk-dev] [[PATCH v3 0/4] pdump HW Rx timestamps for mlx5

2020-10-06 Thread Ferruh Yigit
On 7/24/2020 9:23 PM, Patrick Keroulas wrote: The intention is to produce a pcap with nanosecond precision when Rx timestamp offloading is activated on mlx5 NIC. The packets forwarded by testpmd hold the raw counter but a pcap requires a time unit. Assuming that the NIC clock is already synced w

Re: [dpdk-dev] [PATCH 1/2] baseband/fpga_5gnr_fec: fix segfaults with debug

2020-10-06 Thread Maxime Coquelin
Hi Nicolas, On 10/6/20 6:14 PM, Chautru, Nicolas wrote: > Thanks Maxime > I am not totally sure that this actually got broken in the very commit you > point to (I think that there was another pci generic commit which changed the > assumption when this pointer was set), but it doesn't harm to cha

[dpdk-dev] [PATCH v4 1/2] net: add run-time architecture specific CRC selection

2020-10-06 Thread Mairtin o Loingsigh
This patch adds support for run-time selection of the optimal architecture-specific CRC path, based on the supported instruction set(s) of the CPU. The compiler option checks have been moved from the C files to the meson script. The rte_cpu_get_flag_enabled function is called automatically by the

[dpdk-dev] [PATCH v4 2/2] net: add support for AVX512/VPCLMULQDQ based CRC

2020-10-06 Thread Mairtin o Loingsigh
This patch enables the optimized calculation of CRC32-Ethernet and CRC16-CCITT using the AVX512 and VPCLMULQDQ instruction sets. This CRC implementation is built if the compiler supports the required instruction sets. It is selected at run-time if the host CPU, again, supports the required instruct

[dpdk-dev] [PATCH v4 0/2] net: add CRC run-time checks and AVX512/VPCLMULQDQ based CRC

2020-10-06 Thread Mairtin o Loingsigh
This patchset makes two significant enhancements to the CRC modules of the rte_net library: 1) Adds run-time selection of the optimal architecture-specific CRC path. Previously the selection was solely made at compile-time, meaning it could only be built and run on the same generation of CPU

Re: [dpdk-dev] [PATCH v3 00/14] acl: introduce AVX512 classify methods

2020-10-06 Thread Ananyev, Konstantin
> > On Mon, Oct 5, 2020 at 9:44 PM Konstantin Ananyev > wrote: > > > > These patch series introduce support of AVX512 specific classify > > implementation for ACL library. > > It adds two new algorithms: > > - RTE_ACL_CLASSIFY_AVX512X16 - can process up to 16 flows in parallel. > >It uses 2

  1   2   3   >