Hi Ori, My latest patch V6 as below: Please help review it. https://patchwork.dpdk.org/patch/79613/
Thanks, Regards, Li Zhang > -----Original Message----- > From: Ori Kam <or...@nvidia.com> > Sent: Tuesday, October 6, 2020 8:07 PM > To: Li Zhang <l...@nvidia.com>; Dekel Peled <dek...@nvidia.com>; Slava > Ovsiienko <viachesl...@nvidia.com>; Matan Azrad <ma...@nvidia.com> > Cc: dev@dpdk.org; NBU-Contact-Thomas Monjalon <tho...@monjalon.net>; > Raslan Darawsheh <rasl...@nvidia.com> > Subject: RE: [dpdk-dev] [PATCH v6 1/1] net/mlx5: support match ICMP > identifier fields > > Hi Li > > There was no comment. I acked your patch. > > Thanks, > Ori > > > -----Original Message----- > > From: Li Zhang <l...@nvidia.com> > > Sent: Tuesday, October 6, 2020 8:12 AM > > To: Ori Kam <or...@nvidia.com>; Dekel Peled <dek...@nvidia.com>; Slava > > Ovsiienko <viachesl...@nvidia.com>; Matan Azrad <ma...@nvidia.com> > > Cc: dev@dpdk.org; NBU-Contact-Thomas Monjalon > <tho...@monjalon.net>; > > Raslan Darawsheh <rasl...@nvidia.com> > > Subject: RE: [dpdk-dev] [PATCH v6 1/1] net/mlx5: support match ICMP > > identifier fields > > > > Hi Ori, > > > > What's your comment? > > I can not find it in last mail. > > Can you help give more detail about it? > > > > Thanks, > > Regards, > > Li Zhang > > > > > -----Original Message----- > > > From: Ori Kam <or...@nvidia.com> > > > Sent: Monday, October 5, 2020 6:33 PM > > > To: Li Zhang <l...@nvidia.com>; Dekel Peled <dek...@nvidia.com>; > > > Slava Ovsiienko <viachesl...@nvidia.com>; Matan Azrad > > > <ma...@nvidia.com> > > > Cc: dev@dpdk.org; NBU-Contact-Thomas Monjalon > <tho...@monjalon.net>; > > > Raslan Darawsheh <rasl...@nvidia.com> > > > Subject: RE: [dpdk-dev] [PATCH v6 1/1] net/mlx5: support match ICMP > > > identifier fields > > > > > > Hi Li, > > > > > > > -----Original Message----- > > > > From: dev <dev-boun...@dpdk.org> On Behalf Of Li Zhang > > > > Sent: Monday, October 5, 2020 12:32 PM > > > > To: Dekel Peled <dek...@nvidia.com>; Ori Kam <or...@nvidia.com>; > > > > Slava Ovsiienko <viachesl...@nvidia.com>; Matan Azrad > > > > <ma...@nvidia.com> > > > > Cc: dev@dpdk.org; NBU-Contact-Thomas Monjalon > > > <tho...@monjalon.net>; > > > > Raslan Darawsheh <rasl...@nvidia.com> > > > > Subject: [dpdk-dev] [PATCH v6 1/1] net/mlx5: support match ICMP > > > > identifier fields > > > > > > > > PRM expose fields "Icmp_header_data" in IPv4 ICMP. > > > > Update ICMP mask parameter with ICMP identifier and sequence > > > > number fields. > > > > ICMP sequence number spec with mask, Icmp_header_data low 16 bits > > > > are > > > set. > > > > ICMP identifier spec with mask, Icmp_header_data high 16 bits are set. > > > > > > > > Signed-off-by: Li Zhang <l...@nvidia.com> > > > > --- > > > > > > Acked-by: Ori Kam <or...@nvidia.com> Thanks, Ori
