[dpdk-dev] [PATCH v4] net/ice: refactor the Rx FlexiMD handling

2020-09-21 Thread Haiyue Wang
The hardware supports many kinds of FlexiMDs set into Rx descriptor, and the FlexiMDs can have different offsets in the descriptor according the DDP package setting. The FlexiMDs type and offset are identified by the RXDID, which will be used to setup the queue. For expanding to support different

Re: [dpdk-dev] [PATCH v6 2/3] gro: add VXLAN UDP/IPv4 GRO support

2020-09-21 Thread Jiayu Hu
On Tue, Sep 22, 2020 at 02:23:39PM +0800, yang_y_yi wrote: > Not a question, in next flush, they will be flushed, we have to check > timestamp > in the first time unless we don't strictly follow this time limitation. who will check the timestamp? I did't get the point. IMO, this will cause incon

Re: [dpdk-dev] [PATCH v3] net/ice: refactor the Rx FlexiMD handling

2020-09-21 Thread Guo, Jia
> -Original Message- > From: Wang, Haiyue > Sent: Tuesday, September 22, 2020 2:24 PM > To: Guo, Jia ; dev@dpdk.org > Cc: Zhang, Qi Z ; Jiang, JunyuX > ; Rong, Leyi ; Yang, Qiming > ; Sun, GuinanX ; Guo, > Junfeng > Subject: RE: [PATCH v3] net/ice: refactor the Rx FlexiMD handling > >

Re: [dpdk-dev] [PATCH v6 2/3] gro: add VXLAN UDP/IPv4 GRO support

2020-09-21 Thread yang_y_yi
Not a question, in next flush, they will be flushed, we have to check timestamp in the first time unless we don't strictly follow this time limitation. At 2020-09-22 14:14:00, "Hu, Jiayu" wrote: Fragments of a flow are sorted by frag_oft, but they may have different timestamp. For example, th

Re: [dpdk-dev] [PATCH v3] net/ice: refactor the Rx FlexiMD handling

2020-09-21 Thread Wang, Haiyue
> -Original Message- > From: Guo, Jia > Sent: Tuesday, September 22, 2020 14:15 > To: Wang, Haiyue ; dev@dpdk.org > Cc: Zhang, Qi Z ; Jiang, JunyuX > ; Rong, Leyi > ; Yang, Qiming ; Sun, GuinanX > ; Guo, > Junfeng > Subject: RE: [PATCH v3] net/ice: refactor the Rx FlexiMD handling > >

Re: [dpdk-dev] [PATCH v3] net/ice: refactor the Rx FlexiMD handling

2020-09-21 Thread Guo, Jia
> -Original Message- > From: Wang, Haiyue > Sent: Tuesday, September 22, 2020 2:09 PM > To: Guo, Jia ; dev@dpdk.org > Cc: Zhang, Qi Z ; Jiang, JunyuX > ; Rong, Leyi ; Yang, Qiming > ; Sun, GuinanX ; Guo, > Junfeng > Subject: RE: [PATCH v3] net/ice: refactor the Rx FlexiMD handling > >

Re: [dpdk-dev] [PATCH v6 2/3] gro: add VXLAN UDP/IPv4 GRO support

2020-09-21 Thread Hu, Jiayu
Fragments of a flow are sorted by frag_oft, but they may have different timestamp. For example, there are three fragments, whose frag_oft is: frag[0].frag_oft=0, frag[1].frag_oft=4, frag[2].frag_oft=6; and they are fragments of one UDP packet but are not neighbors. In the first RX burst, host recei

Re: [dpdk-dev] [PATCH v3] net/ice: refactor the Rx FlexiMD handling

2020-09-21 Thread Wang, Haiyue
> -Original Message- > From: Guo, Jia > Sent: Tuesday, September 22, 2020 13:51 > To: Wang, Haiyue ; dev@dpdk.org > Cc: Zhang, Qi Z ; Jiang, JunyuX > ; Rong, Leyi > ; Yang, Qiming ; Sun, GuinanX > ; Guo, > Junfeng > Subject: RE: [PATCH v3] net/ice: refactor the Rx FlexiMD handling > >

Re: [dpdk-dev] [PATCH v3] net/ice: refactor the Rx FlexiMD handling

2020-09-21 Thread Guo, Jia
> -Original Message- > From: Wang, Haiyue > Sent: Tuesday, September 22, 2020 1:42 PM > To: Guo, Jia ; dev@dpdk.org > Cc: Zhang, Qi Z ; Jiang, JunyuX > ; Rong, Leyi ; Yang, Qiming > ; Sun, GuinanX ; Guo, > Junfeng > Subject: RE: [PATCH v3] net/ice: refactor the Rx FlexiMD handling > >

Re: [dpdk-dev] [PATCH v3] net/ice: refactor the Rx FlexiMD handling

2020-09-21 Thread Wang, Haiyue
Hi Jeff, > -Original Message- > From: Guo, Jia > Sent: Tuesday, September 22, 2020 13:35 > To: Wang, Haiyue ; dev@dpdk.org > Cc: Zhang, Qi Z ; Jiang, JunyuX > ; Rong, Leyi > ; Yang, Qiming ; Sun, GuinanX > ; Guo, > Junfeng > Subject: RE: [PATCH v3] net/ice: refactor the Rx FlexiMD hand

[dpdk-dev] [PATCH] net/bnxt: fix to not bring link down during reset recovery

2020-09-21 Thread Somnath Kotur
From: Kalesh AP Driver should not send the phy_cfg request to bring link down during reset recovery. If the driver sends the phy_cfg request in recovery process, then FW needs to re-establish the link which in turn increases the recovery time based on PHY type and link partners. Fixes: df6cd7c1f

Re: [dpdk-dev] [PATCH v3] net/ice: refactor the Rx FlexiMD handling

2020-09-21 Thread Guo, Jia
Hi, haiyue > -Original Message- > From: Wang, Haiyue > Sent: Friday, September 18, 2020 9:06 AM > To: dev@dpdk.org > Cc: Zhang, Qi Z ; Jiang, JunyuX > ; Rong, Leyi ; Yang, Qiming > ; Sun, GuinanX ; Guo, > Junfeng ; Guo, Jia ; Wang, > Haiyue > Subject: [PATCH v3] net/ice: refactor the Rx

Re: [dpdk-dev] [PATCH 2/2] app/testpmd: retain original FDIR mode when configuring DCB

2020-09-21 Thread Ajit Khaparde
On Mon, Sep 7, 2020 at 7:16 PM Wei Hu (Xavier) wrote: > > From: Huisong Li > > Sometimes, we have to start testpmd application with --pkt-filter-mode to > test flow table feature. When using 'port config 0 dcb vt off 4 pfc on' > command, the dcb information are configured in init_port_dcb_config

Re: [dpdk-dev] [PATCH V9 1/3] ethdev: introduce FEC API

2020-09-21 Thread Min Hu (Connor)
在 2020/9/21 21:39, Andrew Rybchenko 写道: On 9/21/20 9:13 AM, Min Hu (Connor) wrote: This patch adds Forward error correction(FEC) support for ethdev. Introduce APIs which support query and config FEC information in hardware. Signed-off-by: Min Hu (Connor) Reviewed-by: Wei Hu (Xavier) Review

Re: [dpdk-dev] [PATCH v1 1/2] raw/skeleton: reset rawdev test statistics

2020-09-21 Thread Hemant Agrawal
Acked-by: Hemant Agrawal

[dpdk-dev] [PATCH v4] bus/pci: netuio interface for windows

2020-09-21 Thread Pallavi Kadam
This patch adds implementations to probe PCI devices bound to netuio with the help of "netuio" class device changes. Now Windows will support both "netuio" and "net" device class and can set kernel driver type based on the device class selection. Note: Few definitions and structures have been copi

Re: [dpdk-dev] CALL to eth PMD maintainers: complete closing of port

2020-09-21 Thread Xu, Rosen
Hi Thomas, Ipn3ke is based on ifpga_bus, and all ethdevs created from ipn3ke are representors. So it's no need to add RTE_ETH_DEV_CLOSE_REMOVE flags into ipn3ke driver. Thanks, Rosen > -Original Message- > From: Thomas Monjalon > Sent: Monday, September 14, 2020 6:16 > To: John W. Linv

Re: [dpdk-dev] [PATCH v6 2/3] gro: add VXLAN UDP/IPv4 GRO support

2020-09-21 Thread yang_y_yi
Jiayu, you didn't get my point. I just show what you want by code, but that isn't a good way. I think current code is most reasonable. Please check my comments in last email, actually, only the first packet of a flow is checked by timestamp, if this flow includes some new items (you're saying),

Re: [dpdk-dev] [PATCH v6 2/3] gro: add VXLAN UDP/IPv4 GRO support

2020-09-21 Thread Jiayu Hu
On Tue, Sep 22, 2020 at 09:29:38AM +0800, yang_y_yi wrote: > Thanks Jiayu, I have fixed other comments except this one: > > > >The items of a flow are ordered by frag_oft, and start_time > >of these items is not always in ascending order. Therefore, > >you cannot skip checking the items after the

[dpdk-dev] [PATCH v4] eal: add cache-line demote support

2020-09-21 Thread Omkar Maslekar
rte_cldemote is similar to a prefetch hint - in reverse. cldemote(addr) enables software to hint to hardware that line is likely to be shared. Useful in core-to-core communications where cache-line is likely to be shared. ARM and PPC implementation is provided with NOP and can be added if any equiv

[dpdk-dev] [PATCH v4] eal: add cache-line demote support

2020-09-21 Thread Omkar Maslekar
We are including this in rte_prefetch.h since it is the most closely related code location.rte_cldemte is similar to a prefetch hint -in reverse Omkar Maslekar (1): EAL: An addition of cache line demote (CLDEMOTE) in rte_prefetch.h doc/guides/rel_notes/release_20_11.rst| 6 ++ lib

Re: [dpdk-dev] [PATCH v6 2/3] gro: add VXLAN UDP/IPv4 GRO support

2020-09-21 Thread yang_y_yi
BTW, start_time is checked for the first packet in a flow, gro_udp4_merge_items(tbl, j) will merge all the packets in this flow once if they can be reassembled, gro_udp4_merge_items(tbl, j) doesn't check start_time, so this still can let some new items in this flow have chance to be merged. At

[dpdk-dev] [PATCH v2 5/5] net/iavf: fix max mtu size packets with vlan tag cannot be received by default

2020-09-21 Thread SteveX Yang
testpmd will initialize default max packet length to 1518 which doesn't include vlan tag size in ether overheader. Once, send the max mtu length packet with vlan tag, the max packet length will exceed 1518 that will cause packets dropped directly from NIC hw side. iavf can support dual vlan tags t

[dpdk-dev] [PATCH v2 0/5] fix default max mtu size when device configured

2020-09-21 Thread SteveX Yang
testpmd will initialize default max packet length to 1518 which does't include vlan tag size in ether overheader. Once, send the max mtu length packet with vlan tag, the max packet length will exceed 1518 that will cause packets dropped directly from NIC hw side. configure the correct default max

[dpdk-dev] [PATCH v2 2/5] net/igc: fix max mtu size packets with vlan tag cannot be received by default

2020-09-21 Thread SteveX Yang
testpmd will initialize default max packet length to 1518 which doesn't include vlan tag size in ether overheader. Once, send the max mtu length packet with vlan tag, the max packet length will exceed 1518 that will cause packets dropped directly from NIC hw side. igc can support single vlan tag t

[dpdk-dev] [PATCH v2 3/5] net/ice: fix max mtu size packets with vlan tag cannot be received by default

2020-09-21 Thread SteveX Yang
testpmd will initialize default max packet length to 1518 which doesn't include vlan tag size in ether overheader. Once, send the max mtu length packet with vlan tag, the max packet length will exceed 1518 that will cause packets dropped directly from NIC hw side. ice can support dual vlan tags th

[dpdk-dev] [PATCH v2 1/5] net/e1000: fix max mtu size packets with vlan tag cannot be received by default

2020-09-21 Thread SteveX Yang
testpmd will initialize default max packet length to 1518 which doesn't include vlan tag size in ether overheader. Once, send the max mtu length packet with vlan tag, the max packet length will exceed 1518 that will cause packets dropped directly from NIC hw side. e1000 can support single vlan tag

[dpdk-dev] [PATCH v2 4/5] net/i40e: fix max mtu size packets with vlan tag cannot be received by default

2020-09-21 Thread SteveX Yang
testpmd will initialize default max packet length to 1518 which doesn't include vlan tag size in ether overheader. Once, send the max mtu length packet with vlan tag, the max packet length will exceed 1518 that will cause packets dropped directly from NIC hw side. But for i40e/i40evf, they should s

Re: [dpdk-dev] [PATCH v3 3/3] net/iavf: enable AVX512 for TX

2020-09-21 Thread Lu, Wenzhuo
Hi Morten, > -Original Message- > From: Morten Brørup > Sent: Tuesday, September 22, 2020 3:11 AM > To: Lu, Wenzhuo ; dev@dpdk.org > Cc: Richardson, Bruce ; Rong, Leyi > > Subject: RE: [dpdk-dev] [PATCH v3 3/3] net/iavf: enable AVX512 for TX > > > From: dev [mailto:dev-boun...@dpdk.org]

Re: [dpdk-dev] [PATCH v6 2/3] gro: add VXLAN UDP/IPv4 GRO support

2020-09-21 Thread yang_y_yi
Thanks Jiayu, I have fixed other comments except this one: >The items of a flow are ordered by frag_oft, and start_time >of these items is not always in ascending order. Therefore, >you cannot skip checking the items after the item whose >start_time is greater than flush_timestamp. This issue al

Re: [dpdk-dev] [PATCH v2 1/2] service: add component useful work attribute

2020-09-21 Thread Honnappa Nagarahalli
> > Hello Harry, > > On Mon, Sep 14, 2020 at 4:36 PM Harry van Haaren > wrote: > > > > This commit adds a new attribute which allows the service to indicate > > if the previous iteration of work was "useful". Useful work here > > implies forward progress was made. > > > > Exposing this informa

Re: [dpdk-dev] [dpdk-stable] [PATCH] metrics: fix resource leak on memory allocation fail

2020-09-21 Thread Honnappa Nagarahalli
> > > If an error occurred when allocating memory for metrics or names, the > > function returned without freeing allocated memory. This is now fixed > > to avoid the resource leak in the case that either metrics or names > > had been successfully allocated memory. > > > > Coverity issue: 362053

Re: [dpdk-dev] [PATCH] net/netvsc: fix rndis packet addresses

2020-09-21 Thread Long Li
>On 21/09/2020 17:04, Kevin Traynor wrote: >> On 18/09/2020 19:53, Long Li wrote: >>> From: Long Li >>> >>> The address should be calculated before type cast, not after. >>> >> >> This is being requested for 18.11.10 as it is fixing a reported >> regression introduced in 18.11.9. >> >> If netvsc m

Re: [dpdk-dev] [EXTERNAL] [PATCH 2/2] eal/windows: implement alarm API

2020-09-21 Thread Khoa To
Hi Dmitry, Since all alarm callbacks are scheduled on the interrupt thread, looks like this implementation of rte_eal_alarm_set() would create a head-of-line blocking issue, as the callbacks are serialized one after the other. Is that correct? If so, while this does not violate the API contract

Re: [dpdk-dev] [PATCH v2 00/17] net/sfc: factor out common driver library

2020-09-21 Thread Ferruh Yigit
On 9/17/2020 7:34 AM, Andrew Rybchenko wrote: Network and vDPA drivers share libefx. So, libefx should be moved to common drivers. DPDK adaptation of the MCDI interface may be shared as well. The new common driver name is sfc_efx since it a new home of libefx base driver. sfc_ prefix is used to

Re: [dpdk-dev] [PATCH v6 11/12] app/testpmd: add port and encap support for sample action

2020-09-21 Thread Ajit Khaparde
On Tue, Sep 8, 2020 at 11:50 PM Jiawei Wang wrote: > > Use sample action with ratio is 1 for mirroring flow, add > supports to set the different port or encap action for mirrored > packets. > > The example of test-pmd command: > > 1. set sample_actions 1 port_id id 1 / end >flow create 0 ... p

[dpdk-dev] [PATCH] net/bnxt: fix PCI per-function stats

2020-09-21 Thread Lance Richardson
Fix to use correct value offset for PCI function stats. Fixes: 5f9374de2a3a ("net/bnxt: add PCI function stats to extended stats") Reviewed-by: Ajit Kumar Khaparde Cc: sta...@dpdk.org Cc: ajit.khapa...@broadcom.com Signed-off-by: Lance Richardson --- drivers/net/bnxt/bnxt_stats.c | 3 ++- 1 f

[dpdk-dev] [PATCH v1 1/2] raw/skeleton: reset rawdev test statistics

2020-09-21 Thread Lukasz Wojciechowski
Statistics: passed, failed, unsupported and total are kept in global static variables. As global variables they are initiated with zeroes. However running test multiple times cumulates results from previous calls. This patch resets statistics with zeroes in testsuite_setup(). To reproduce issue f

[dpdk-dev] [PATCH v1 2/2] raw/skeleton: allow closing already closed rawdev

2020-09-21 Thread Lukasz Wojciechowski
This patch return OK code (0) from skeleton_rawdev_close function if firmware is in SKELETON_FW_READY state. Formerly it returned -EINVAL error code. Returning an error here is troublesome as it disallows proper release of the rawdev. The rte_rawdev_pmd_release function from librte_rawdev library

Re: [dpdk-dev] [PATCH 00/13] app/flow-perf: add support for new items/actions

2020-09-21 Thread Thomas Monjalon
30/08/2020 13:15, Wisam Jaddo: > doc/guides/rel_notes/release_20_08.rst | 17 + It is the wrong release notes. Ferruh, I will fix while pulling next-net.

[dpdk-dev] [PATCH v3] bus/pci: netuio interface for windows

2020-09-21 Thread Pallavi Kadam
This patch adds implementations to probe PCI devices bound to netuio with the help of "netuio" class device changes. Now Windows will support both "netuio" and "net" device class and can set kernel driver type based on the device class selection. Note: Few definitions and structures have been copi

[dpdk-dev] [dpdk-announce] ! DPDK Userpspace Summit starts TOMORROW, 1:00 pm UTC

2020-09-21 Thread Jill Lovato
Quick reminder that if you have not already, please register to attend DPDK Userspace Summit 2020. The virtual experience starts tomorrow, *Tuesday, September 22 at 1:00 pm (13:00) UTC. * Note, this translates to: 6:00 am PST

Re: [dpdk-dev] Duplicating traffic with RTE Flow

2020-09-21 Thread Jan Viktorin
On Fri, 18 Sep 2020 14:23:42 + Asaf Penso wrote: > Hello Jan, > > You can have a look in series [1] where we propose to add APIs to DPDK20.11 > for both mirroring and sampling for packets, with additional actions of the > different traffic. > > [1] > http://patches.dpdk.org/project/dpdk/l

Re: [dpdk-dev] [PATCH] net/memif: relax barrier for zero copy path

2020-09-21 Thread Honnappa Nagarahalli
> > > > Hi Jakub, > > I am trying to review this patch. I am having difficulty in > > understanding the implementation for the queue/ring, appreciate if you > > could help me understand the logic. > > 'ring' refers to a ring buffer holding packet descriptors. These descriptors > hold metadat

[dpdk-dev] [PATCH 4/4] net/memif: relax the load of ring head pointer for M2S ring

2020-09-21 Thread Honnappa Nagarahalli
For M2S rings, ring->head is updated by the receiver and eth_memif_rx function is called in the context of receiving thread. The loads in the sender do not need to synchronize with its own stores. Fixes: a2aafb9aa651 ("net/memif: optimize with one-way barrier") Cc: phil.y...@arm.com Cc: sta...@dpd

[dpdk-dev] [PATCH 1/4] net/memif: do not update local copy of tail in tx function

2020-09-21 Thread Honnappa Nagarahalli
In the case of S2M queues, the receiver synchronizes with the sender (i.e. informs of the packets it has received) using ring->tail. Hence, the sender does not need to update last_tail. In the case of M2S queues, the receiver uses last_tail to keep track of the descriptors it has received. The sen

[dpdk-dev] [PATCH 3/4] net/memif: relax the load of ring head pointer for S2M ring

2020-09-21 Thread Honnappa Nagarahalli
For S2M rings, ring->head is updated by the sender and eth_memif_tx function is called in the context of sending thread. The loads in the sender do not need to synchronize with its own stores. Fixes: a2aafb9aa651 ("net/memif: optimize with one-way barrier") Cc: phil.y...@arm.com Cc: sta...@dpdk.or

[dpdk-dev] [PATCH 2/4] net/memif: relax the load of ring tail pointer for M2S ring

2020-09-21 Thread Honnappa Nagarahalli
For M2S rings, ring->tail is updated by the sender and eth_memif_tx function is called in the context of sending thread. The loads in the sender do not need to synchronize with its own stores. Fixes: a2aafb9aa651 ("net/memif: optimize with one-way barrier") Cc: phil.y...@arm.com Cc: sta...@dpdk.or

Re: [dpdk-dev] [PATCH v3 22/37] doc: remove references to make in contributing guides

2020-09-21 Thread Dumitrescu, Cristian
> -Original Message- > From: Thomas Monjalon > Sent: Monday, September 21, 2020 5:15 PM > To: Power, Ciara ; Dumitrescu, Cristian > > Cc: dev@dpdk.org; Mcnamara, John ; > Kovacevic, Marko ; Richardson, Bruce > > Subject: Re: [dpdk-dev] [PATCH v3 22/37] doc: remove references to make i

Re: [dpdk-dev] [PATCH v3 3/3] net/iavf: enable AVX512 for TX

2020-09-21 Thread Morten Brørup
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Wenzhuo Lu > Sent: Monday, September 21, 2020 10:14 AM > > To enhance the per-core performance, this patch adds some AVX512 > instructions to the data path to handle the TX descriptors. > > Signed-off-by: Wenzhuo Lu > Signed-off-by: Bruce Ri

Re: [dpdk-dev] [PATCH] net/qede: fix qede milliseconds sleep macro

2020-09-21 Thread Jerin Jacob
On Mon, Jul 27, 2020 at 7:47 PM Devendra Singh Rawat wrote: > > The macro defined for milliseconds sleep was not putting the thread > to sleep and was simply calling a delay routine. This fix redefines > the macro to call the correct rte sleep API. > > Fixes: ec94dbc57362 ("qede: add base driver")

Re: [dpdk-dev] [PATCH 3/5] lib/stack: remove redundant orderings for list->len

2020-09-21 Thread Eads, Gage
> -Original Message- > From: Steven Lariau > Sent: Friday, September 11, 2020 10:30 AM > To: Eads, Gage ; Olivier Matz > Cc: dev@dpdk.org; n...@arm.com; dharmik.thak...@arm.com; Steven Lariau > > Subject: [PATCH 3/5] lib/stack: remove redundant orderings for list->len > > The load-ac

Re: [dpdk-dev] [PATCH 5/5] lib/stack: remove pop cas release ordering

2020-09-21 Thread Eads, Gage
> -Original Message- > From: Steven Lariau > Sent: Friday, September 11, 2020 10:30 AM > To: Eads, Gage ; Olivier Matz > Cc: dev@dpdk.org; n...@arm.com; dharmik.thak...@arm.com; Steven Lariau > > Subject: [PATCH 5/5] lib/stack: remove pop cas release ordering > > Replace the store-re

Re: [dpdk-dev] [PATCH 2/5] lib/stack: remove push acquire fence

2020-09-21 Thread Eads, Gage
> -Original Message- > From: Steven Lariau > Sent: Friday, September 11, 2020 10:30 AM > To: Eads, Gage ; Olivier Matz > Cc: dev@dpdk.org; n...@arm.com; dharmik.thak...@arm.com; Steven Lariau > > Subject: [PATCH 2/5] lib/stack: remove push acquire fence > > An acquire fence is used t

Re: [dpdk-dev] [PATCH 4/5] lib/stack: reload head when pop fails

2020-09-21 Thread Eads, Gage
> -Original Message- > From: Steven Lariau > Sent: Friday, September 11, 2020 10:30 AM > To: Eads, Gage ; Olivier Matz > Cc: dev@dpdk.org; n...@arm.com; dharmik.thak...@arm.com; Steven Lariau > > Subject: [PATCH 4/5] lib/stack: reload head when pop fails > > List head must be loaded

Re: [dpdk-dev] [PATCH 1/5] lib/stack: fix inconsistent weak / strong cas

2020-09-21 Thread Eads, Gage
> -Original Message- > From: Steven Lariau > Sent: Friday, September 11, 2020 10:30 AM > To: Eads, Gage ; Olivier Matz > Cc: dev@dpdk.org; n...@arm.com; dharmik.thak...@arm.com; Steven Lariau > > Subject: [PATCH 1/5] lib/stack: fix inconsistent weak / strong cas > > Fix cmpexchange u

Re: [dpdk-dev] [PATCH 00/22] Add DLB2 PMD

2020-09-21 Thread McDaniel, Timothy
> -Original Message- > From: Jerin Jacob > Sent: Monday, September 21, 2020 12:12 PM > To: McDaniel, Timothy > Cc: dpdk-dev ; Carrillo, Erik G ; > Eads, > Gage ; Van Haaren, Harry > ; Jerin Jacob > Subject: Re: [dpdk-dev] [PATCH 00/22] Add DLB2 PMD > > On Sat, Sep 12, 2020 at 2:00 AM

Re: [dpdk-dev] [PATCH 00/22] Add DLB2 PMD

2020-09-21 Thread Jerin Jacob
On Sat, Sep 12, 2020 at 2:00 AM Timothy McDaniel wrote: > > The following patch series adds support for a new eventdev PMD. The DLB2 > PMD adds support for the Intel Dynamic Load Balancer 2.0 (DLB2) > hardware. > The DLB2 is a PCIe device that provides load-balanced, prioritized > scheduling of co

Re: [dpdk-dev] [EXT] [PATCH] net/qede/base: add missing licence

2020-09-21 Thread Jerin Jacob
On Fri, Sep 11, 2020 at 12:53 PM Igor Russkikh wrote: > > > Thanks Ferruh, > > > Adding BSD-3 SPDX license tag. > > > > Fixes: 519438f7c17f ("net/qede/base: re-arrange few structures for DDC") > > Cc: sta...@dpdk.org > > > > Reported-by: Stephen Hemminger > > Signed-off-by: Ferruh Yigit > > ---

Re: [dpdk-dev] [PATCH] net/netvsc: fix rndis packet addresses

2020-09-21 Thread Kevin Traynor
On 21/09/2020 17:04, Kevin Traynor wrote: > On 18/09/2020 19:53, Long Li wrote: >> From: Long Li >> >> The address should be calculated before type cast, not after. >> > > This is being requested for 18.11.10 as it is fixing a reported > regression introduced in 18.11.9. > > If netvsc maintainer

Re: [dpdk-dev] [PATCH v3 22/37] doc: remove references to make in contributing guides

2020-09-21 Thread Thomas Monjalon
17/09/2020 15:44, Power, Ciara: > Hi Thomas, > > One comment inline. > > Thanks, > Ciara > > > >-Original Message- > >From: Thomas Monjalon > >Sent: Monday 7 September 2020 11:21 > >To: Power, Ciara ; dev@dpdk.org > >Cc: Kilheeney, Louise ; Mcnamara, John > >; Kovacevic, Marko > > > >S

Re: [dpdk-dev] [PATCH 0/6] net/enic: minor updates to flow implementation

2020-09-21 Thread Ferruh Yigit
On 9/9/2020 3:00 PM, Hyong Youb Kim wrote: This series enables several flow features such as priorities and egress PORT_ID action. It depends on the ealier patch series that adds VF representors. The 1st patch (remove obsolete code) does not technically belong in the series, but is piggybacked h

Re: [dpdk-dev] [PATCH] ethdev: add security flow item

2020-09-21 Thread Asaf Penso
Regards, Asaf Penso >-Original Message- >From: Tejasree Kondoj >Sent: Monday, September 21, 2020 11:59 AM >To: Asaf Penso ; Stephen Hemminger > >Cc: Akhil Goyal ; Radu Nicolau >; Declan Doherty ; Ori >Kam ; NBU-Contact-Thomas Monjalon >; Ferruh Yigit ; Andrew >Rybchenko ; Jerin Jacob K

Re: [dpdk-dev] [PATCH] net/netvsc: fix rndis packet addresses

2020-09-21 Thread Kevin Traynor
+fixed Souvik email On 21/09/2020 17:04, Kevin Traynor wrote: > On 18/09/2020 19:53, Long Li wrote: >> From: Long Li >> >> The address should be calculated before type cast, not after. >> > > This is being requested for 18.11.10 as it is fixing a reported > regression introduced in 18.11.9. > >

Re: [dpdk-dev] [PATCH] net/netvsc: fix rndis packet addresses

2020-09-21 Thread Kevin Traynor
On 18/09/2020 19:53, Long Li wrote: > From: Long Li > > The address should be calculated before type cast, not after. > This is being requested for 18.11.10 as it is fixing a reported regression introduced in 18.11.9. If netvsc maintainers agree and it is merged in DPDK mainline this week, I c

Re: [dpdk-dev] [dpdk-dev v9 1/4] cryptodev: add crypto data-path service APIs

2020-09-21 Thread Akhil Goyal
Hi Fan, > Hi AKhil > > ... > > IMO, the following union can clarify all doubts. > > @Ananyev, Konstantin: Any suggestions from your side? > > > > /** IV and aad information for various use cases. */ > > union { > > /** Supposed to be used with CPU crypto API call. */ > > struct { >

Re: [dpdk-dev] [PATCH v3] doc: add stack mempool guide

2020-09-21 Thread Eads, Gage
Hi Olivier, > > +Stack Mempool Driver > > + > > + > > +**rte_mempool_stack** is a pure software mempool driver based on the > > +``rte_stack`` DPDK library. A stack-based mempool is often better suited to > > +packet-processing workloads than a ring-based mempool, since its L

Re: [dpdk-dev] [dpdk-dev v9 1/4] cryptodev: add crypto data-path service APIs

2020-09-21 Thread Zhang, Roy Fan
Hi AKhil > -Original Message- > From: Akhil Goyal > Sent: Monday, September 21, 2020 1:00 PM > To: Zhang, Roy Fan ; dev@dpdk.org; Ananyev, > Konstantin ; Thomas Monjalon > > Cc: Trahe, Fiona ; Kusztal, ArkadiuszX > ; Dybkowski, AdamX > ; Bronowski, PiotrX > ; Anoob Joseph > Subject: RE:

Re: [dpdk-dev] [PATCH 0/5] net/enic: add SR-IOV VF representor

2020-09-21 Thread Ferruh Yigit
On 9/9/2020 2:56 PM, Hyong Youb Kim wrote: This series adds VF representors to the driver. It enables single-queue representors and implements enough flow features to run OVS-DPDK offload for default vlan+mac based switching. The flow API handlers and devcmd functions (firmware commands) are now

Re: [dpdk-dev] [dpdk-dev v9 1/4] cryptodev: add crypto data-path service APIs

2020-09-21 Thread Zhang, Roy Fan
Hi Akhil, > -Original Message- > From: Akhil Goyal > Sent: Monday, September 21, 2020 1:00 PM > To: Zhang, Roy Fan ; dev@dpdk.org; Ananyev, > Konstantin ; Thomas Monjalon > > Cc: Trahe, Fiona ; Kusztal, ArkadiuszX > ; Dybkowski, AdamX > ; Bronowski, PiotrX > ; Anoob Joseph > Subject: RE

Re: [dpdk-dev] [PATCH v2 1/2] service: add component useful work attribute

2020-09-21 Thread Van Haaren, Harry
> -Original Message- > From: David Marchand > Sent: Monday, September 21, 2020 3:49 PM > To: Van Haaren, Harry > Cc: dev ; Lukasz Wojciechowski > ; Honnappa Nagarahalli > > Subject: Re: [dpdk-dev] [PATCH v2 1/2] service: add component useful work > attribute > > Hello Harry, > > On Mon

Re: [dpdk-dev] [PATCH v6 2/2] test/service: fix race condition on stopping lcore

2020-09-21 Thread David Marchand
On Mon, Sep 14, 2020 at 4:30 PM Harry van Haaren wrote: > > This commit fixes a potential race condition in the tests > where the lcore running a service would increment a counter > that was already reset by the test-suite thread. The resulting > race-condition incremented value could cause CI fai

Re: [dpdk-dev] [PATCH v2 1/2] service: add component useful work attribute

2020-09-21 Thread David Marchand
Hello Harry, On Mon, Sep 14, 2020 at 4:36 PM Harry van Haaren wrote: > > This commit adds a new attribute which allows the service to indicate > if the previous iteration of work was "useful". Useful work here implies > forward progress was made. > > Exposing this information via an attribute to

Re: [dpdk-dev] [PATCH v4 00/11] bbdev PMD ACC100

2020-09-21 Thread Chautru, Nicolas
Hi Akhil, Just a heads up on this bbdev PMD which is ready and was reviewed for some time by the community. There is one warning on patchwork but it can be ignored (one ack email sent with bad formatting). Thanks and best regards, Nic > -Original Message- > From: Chautru, Nicolas > S

Re: [dpdk-dev] [PATCH v5 02/20] app: remove references to make-based config

2020-09-21 Thread Chautru, Nicolas
Acked-by: Nicolas Chautru Thanks for the update Nic > -Original Message- > From: Power, Ciara > Sent: Monday, September 21, 2020 6:59 AM > To: dev@dpdk.org > Cc: Power, Ciara ; Chautru, Nicolas > ; Doherty, Declan > Subject: [PATCH v5 02/20] app: remove references to make-based config

Re: [dpdk-dev] [PATCH v5 0/2] add Rx buffer size for rxq info structure

2020-09-21 Thread Ferruh Yigit
On 9/21/2020 2:22 PM, Chengchang Tang wrote: In common practice, PMD configure the Rx buffer size which indicate the buffer length could be used for HW in receiving packets according to the data room size of the object in mempool. But in fact, the final value is related to the specifications of H

Re: [dpdk-dev] [PATCH v5 1/2] ethdev: add a field for rxq info structure

2020-09-21 Thread Ferruh Yigit
On 9/21/2020 2:22 PM, Chengchang Tang wrote: Add a field named rx_buf_size in rte_eth_rxq_info to indicate the buffer size used in receiving packets for HW. In this way, upper-layer users can get this information by calling rte_eth_rx_queue_info_get. Signed-off-by: Chengchang Tang Reviewed-by:

[dpdk-dev] [PATCH v5 20/20] doc: update patch cheatsheet to use meson

2020-09-21 Thread Ciara Power
From: Kevin Laatz With 'make' being removed, the patch cheatsheet needs to be updated to remove any references to 'make'. These references have been replaced with meson alternatives in this patch. Signed-off-by: Kevin Laatz --- .../contributing/img/patch_cheatsheet.svg | 582 --

[dpdk-dev] [PATCH v5 14/20] doc: remove references to make from eventdevs guides

2020-09-21 Thread Ciara Power
Make is no longer supported for compiling DPDK, references are now removed in the documentation. Signed-off-by: Ciara Power Reviewed-by: Kevin Laatz --- doc/guides/eventdevs/dpaa.rst | 20 doc/guides/eventdevs/dpaa2.rst | 20 doc/guides/eventde

[dpdk-dev] [PATCH v5 18/20] doc: remove references to make from contributing guide

2020-09-21 Thread Ciara Power
Make is no longer supported for compiling DPDK, references are now removed in the documentation. Signed-off-by: Ciara Power Signed-off-by: Louise Kilheeney --- v5: - Removed reference to test-build.sh used for Make. - Added point back in for handling specific code, reworded as necessary

[dpdk-dev] [PATCH v5 15/20] doc: remove references to make from rawdevs guides

2020-09-21 Thread Ciara Power
Make is no longer supported for compiling DPDK, references are now removed in the documentation. Signed-off-by: Ciara Power Reviewed-by: Kevin Laatz --- doc/guides/rawdevs/dpaa2_cmdif.rst | 21 - doc/guides/rawdevs/dpaa2_qdma.rst| 21 - doc/guides/r

[dpdk-dev] [PATCH v5 19/20] doc: add to release notes to reflect removal of make

2020-09-21 Thread Ciara Power
Added an entry to decribe the removal of the Make build system to the release notes for 20.11. Signed-off-by: Ciara Power --- doc/guides/rel_notes/release_20_11.rst | 3 +++ 1 file changed, 3 insertions(+) diff --git a/doc/guides/rel_notes/release_20_11.rst b/doc/guides/rel_notes/release_20_11

[dpdk-dev] [PATCH v5 17/20] doc: remove reference to make from tools guides

2020-09-21 Thread Ciara Power
Make is no longer supported for compiling DPDK, references are now removed in the documentation. Signed-off-by: Ciara Power Reviewed-by: Kevin Laatz Acked-by: Nicolas Chautru --- v5: - Reworded sentence in pdump doc. - Replaced references to testbbdev binary with dpdk-test-bbdev. - Fixed

[dpdk-dev] [PATCH v5 12/20] doc: remove references to make from cryptodevs guides

2020-09-21 Thread Ciara Power
Make is no longer supported for compiling DPDK, references are now removed in the documentation. Signed-off-by: Ciara Power Reviewed-by: Kevin Laatz --- doc/guides/cryptodevs/aesni_gcm.rst | 4 +- doc/guides/cryptodevs/aesni_mb.rst | 4 +- doc/guides/cryptodevs/armv8.rst | 3 -- doc/gui

[dpdk-dev] [PATCH v5 13/20] doc: remove references to make from compressdevs guides

2020-09-21 Thread Ciara Power
Make is no longer supported for compiling DPDK, references are now removed in the documentation. Signed-off-by: Ciara Power Reviewed-by: Kevin Laatz --- doc/guides/compressdevs/isal.rst | 4 doc/guides/compressdevs/octeontx.rst | 24 ++-- doc/guides/compressdevs/zl

[dpdk-dev] [PATCH v5 16/20] doc: remove references to make from app guides

2020-09-21 Thread Ciara Power
Make is no longer supported for compiling DPDK, references are now removed in the documentation. Signed-off-by: Ciara Power Acked-by: Nicolas Chautru --- doc/guides/sample_app_ug/bbdev_app.rst| 34 ++-- doc/guides/sample_app_ug/cmd_line.rst | 2 +- doc/guides/sample_app_ug/

[dpdk-dev] [PATCH v5 10/20] doc: remove references to make from vdpadevs guides

2020-09-21 Thread Ciara Power
Make is no longer supported for compiling DPDK, references are now removed in the documentation. Signed-off-by: Ciara Power --- doc/guides/vdpadevs/ifc.rst | 13 doc/guides/vdpadevs/mlx5.rst | 40 +++- 2 files changed, 3 insertions(+), 50 deletions(-

[dpdk-dev] [PATCH v5 09/20] doc: remove references to make from NICs guides

2020-09-21 Thread Ciara Power
Make is no longer supported for compiling DPDK, references are now removed in the documentation. Signed-off-by: Ciara Power Reviewed-by: Bruce Richardson --- doc/guides/nics/ark.rst| 26 - doc/guides/nics/atlantic.rst | 4 -- doc/guides/nics/axgbe.rst | 1

[dpdk-dev] [PATCH v5 11/20] doc: remove references to make from bbdevs guides

2020-09-21 Thread Ciara Power
Make is no longer supported for compiling DPDK, references are now removed in the documentation. Signed-off-by: Ciara Power Reviewed-by: Kevin Laatz --- v5: Added meson steps to turbo_sw doc. --- doc/guides/bbdevs/fpga_5gnr_fec.rst | 7 ++- doc/guides/bbdevs/fpga_lte_fec.rst | 7 ++-

[dpdk-dev] [PATCH v5 07/20] doc: remove references to make from platforms guides

2020-09-21 Thread Ciara Power
Make is no longer supported for compiling DPDK, references are now removed in the documentation. Signed-off-by: Ciara Power Reviewed-by: Kevin Laatz --- doc/guides/platform/bluefield.rst | 22 - doc/guides/platform/octeontx.rst | 33 +-- doc/guid

[dpdk-dev] [PATCH v5 08/20] doc: remove references to make from mempool guide

2020-09-21 Thread Ciara Power
Make is no longer supported for compiling DPDK, references are now removed in the documentation. Signed-off-by: Ciara Power Reviewed-by: Kevin Laatz --- doc/guides/mempool/octeontx.rst | 28 +++- doc/guides/mempool/octeontx2.rst | 10 +- 2 files changed, 4 inser

[dpdk-dev] [PATCH v5 05/20] doc: remove references to make from howto guides

2020-09-21 Thread Ciara Power
Make is no longer supported for compiling DPDK, references are now removed in the documentation. Signed-off-by: Ciara Power Reviewed-by: Kevin Laatz --- doc/guides/howto/lm_bond_virtio_sriov.rst | 4 +-- doc/guides/howto/lm_virtio_vhost_user.rst | 4 +-- doc/guides/howto/packet_captur

[dpdk-dev] [PATCH v5 06/20] doc: remove references to make from prog guide

2020-09-21 Thread Ciara Power
Make is no longer supported for compiling DPDK, references are now removed in the documentation. Signed-off-by: Ciara Power Reviewed-by: Kevin Laatz --- doc/guides/prog_guide/env_abstraction_layer.rst | 17 ++--- doc/guides/prog_guide/graph_lib.rst | 6 ++ .../prog_

[dpdk-dev] [PATCH v5 01/20] devtools: remove legacy flags from includes check

2020-09-21 Thread Ciara Power
Make is no longer supported, the test script for make builds is no longer required. Uses of make in other tool scripts are replaced. Signed-off-by: Ciara Power --- devtools/check-includes.sh | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/devtools/check-includes.s

[dpdk-dev] [PATCH v5 02/20] app: remove references to make-based config

2020-09-21 Thread Ciara Power
Make is no longer supported, RTE_SDK, RTE_TARGET and CONFIG options are no longer in use. Signed-off-by: Ciara Power Reviewed-by: Kevin Laatz --- v5: updated binary name to dpdk-test-bbdev --- app/test-bbdev/test-bbdev.py | 13 ++--- app/test/test_cryptodev.c | 89 +-

[dpdk-dev] [PATCH v5 04/20] doc: remove references to make from FreeBSD guide

2020-09-21 Thread Ciara Power
Make is no longer supported for compiling DPDK, references are now removed in the documentation. Signed-off-by: Ciara Power Acked-by: Bruce Richardson --- doc/guides/freebsd_gsg/build_dpdk.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/guides/freebsd_gsg/build_dpdk.

[dpdk-dev] [PATCH v5 03/20] doc: remove references to make from Linux guide

2020-09-21 Thread Ciara Power
Make is no longer supported for compiling DPDK, references are now removed in the documentation. Signed-off-by: Ciara Power Reviewed-by: Bruce Richardson --- doc/guides/linux_gsg/build_dpdk.rst| 16 +++- doc/guides/linux_gsg/build_sample_apps.rst | 18 +++--- doc

[dpdk-dev] [PATCH v5 00/20] remove make support in DPDK

2020-09-21 Thread Ciara Power
This patchset includes the remaining 18 patches that were not merged along with the others in v4, pending rework and more review. *All*, please make the documentation update your highest priority. v5: - Added patch to update cheatsheet. - Added patch to update release notes. - Fixed outstand

Re: [dpdk-dev] [dpdk-stable] [PATCH] net/netvsc: fix rndis packet addresses

2020-09-21 Thread Ferruh Yigit
On 9/18/2020 7:53 PM, Long Li wrote: From: Long Li The address should be calculated before type cast, not after. Fixes: cc02518 ("net/netvsc: split send buffers from Tx descriptors") Cc: sta...@dpdk.org Reported-by: Souvik Dey Signed-off-by: Long Li Applied to dpdk-next-net/main, thanks.

Re: [dpdk-dev] [PATCH V9 1/3] ethdev: introduce FEC API

2020-09-21 Thread Andrew Rybchenko
On 9/21/20 9:13 AM, Min Hu (Connor) wrote: > This patch adds Forward error correction(FEC) support for ethdev. > Introduce APIs which support query and config FEC information in > hardware. > > Signed-off-by: Min Hu (Connor) > Reviewed-by: Wei Hu (Xavier) > Reviewed-by: Chengwen Feng > Reviewed

  1   2   >