> -----Original Message----- > From: Steven Lariau <steven.lar...@arm.com> > Sent: Friday, September 11, 2020 10:30 AM > To: Eads, Gage <gage.e...@intel.com>; Olivier Matz <olivier.m...@6wind.com> > Cc: dev@dpdk.org; n...@arm.com; dharmik.thak...@arm.com; Steven Lariau > <steven.lar...@arm.com> > Subject: [PATCH 3/5] lib/stack: remove redundant orderings for list->len > > The load-acquire of list->len on pop function is redundant. > Only the CAS success needs to be load-acquire. > It synchronizes with the store release in push, to ensure that the > updated head is visible when the new length is visible. > Without this, one thread in pop could see the increased length but the > old list, which doesn't have enough items yet for pop to succeed. > > Signed-off-by: Steven Lariau <steven.lar...@arm.com> > Reviewed-by: Dharmik Thakkar <dharmik.thak...@arm.com> > Reviewed-by: Ruifeng Wang <ruifeng.w...@arm.com> Acked-by: Gage Eads <gage.e...@intel.com> Thanks, Gage
