> -----Original Message----- > From: Steven Lariau <steven.lar...@arm.com> > Sent: Friday, September 11, 2020 10:30 AM > To: Eads, Gage <gage.e...@intel.com>; Olivier Matz <olivier.m...@6wind.com> > Cc: dev@dpdk.org; n...@arm.com; dharmik.thak...@arm.com; Steven Lariau > <steven.lar...@arm.com> > Subject: [PATCH 1/5] lib/stack: fix inconsistent weak / strong cas > > Fix cmpexchange usage of weak / strong. > The generated code is the same on x86 and ARM (there is no weak > cmpexchange), but the old usage was inconsistent. > For push and pop update size, weak is used because cmpexchange is inside > a loop. > For pop update root, strong is used even though cmpexchange is inside a > loop, because there may be a lot of operations to do in a loop iteration > (locate the new head). > > Signed-off-by: Steven Lariau <steven.lar...@arm.com> > Reviewed-by: Dharmik Thakkar <dharmik.thak...@arm.com> > Reviewed-by: Ruifeng Wang <ruifeng.w...@arm.com> Acked-by: Gage Eads <gage.e...@intel.com> Thanks, Gage