> -----Original Message----- > From: David Marchand <david.march...@redhat.com> > Sent: Monday, September 21, 2020 3:49 PM > To: Van Haaren, Harry <harry.van.haa...@intel.com> > Cc: dev <dev@dpdk.org>; Lukasz Wojciechowski > <l.wojciec...@partner.samsung.com>; Honnappa Nagarahalli > <honnappa.nagaraha...@arm.com> > Subject: Re: [dpdk-dev] [PATCH v2 1/2] service: add component useful work > attribute > > Hello Harry, > > On Mon, Sep 14, 2020 at 4:36 PM Harry van Haaren > <harry.van.haa...@intel.com> wrote: > > > > This commit adds a new attribute which allows the service to indicate > > if the previous iteration of work was "useful". Useful work here implies > > forward progress was made. > > > > Exposing this information via an attribute to the application allows > > tracking of CPU cycles as being useful or not-useful, and a CPU load > > estimate can be deduced from that information. > > > > Signed-off-by: Harry van Haaren <harry.van.haa...@intel.com> > > This is missing a unit test. > Getting others' opinion on this addition would be good too.
Thanks for review, sure will add a unit test. +CC Jerin and Mattias; Eventdev SW PMD usage, I'd like to indicate if there has been "useful work" done last iteration. Do you see any easy improvements? Concerns? Regards, -Harry
