[dpdk-dev] [PATCH v4] net/iavf: support gtpu outer and inner co-exist

2020-09-17 Thread Jeff Guo
Although currently only the gtpu inner hash be enabled while not the gtpu outer hash, but the outer protocol still needed to co-exist with inner protocol when configure the gtpu inner hash rule, that would allow the gtpu innner hash support for the different outer protocols. Signed-off-by: Jeff Gu

Re: [dpdk-dev] [PATCH 2/2] build: find max lcore programmatically

2020-09-17 Thread Dharmik Thakkar
> On Sep 17, 2020, at 4:56 AM, Juraj Linkeš wrote: > > > >> -Original Message- >> From: Dharmik Thakkar >> Sent: Friday, September 4, 2020 7:44 AM >> To: Stephen Hemminger >> Cc: Juraj Linkeš ; Jerin Jacob >> ; tho...@monjalon.net; dpdk-dev ; >> nd >> Subject: Re: [dpdk-dev] [PATCH

[dpdk-dev] [PATCH] crypto/armv8: remove crypto enum list end references

2020-09-17 Thread Ruifeng Wang
Removed references to RTE_CRYPTO_CIPHER_LIST_END and RTE_CRYPTO_AUTH_LIST_END. Signed-off-by: Ruifeng Wang Reviewed-by: Phil Yang --- This is follow up of cryptodev change: http://patches.dpdk.org/patch/76330/ drivers/crypto/armv8/armv8_pmd_private.h | 6 ++ drivers/crypto/armv8/rte_armv8_p

Re: [dpdk-dev] [PATCH v4 4/5] net/ice: fix vector rx burst for ice

2020-09-17 Thread Zhang, Qi Z
> -Original Message- > From: Guo, Jia > Sent: Friday, September 18, 2020 12:41 PM > To: Zhang, Qi Z ; Yang, Qiming > ; Xing, Beilei ; Wu, Jingjing > ; Wang, Haiyue > Cc: Zhao1, Wei ; Richardson, Bruce > ; dev@dpdk.org; Zhang, Helin > ; m...@smartsharesystems.com; Yigit, Ferruh > ; step

Re: [dpdk-dev] 18.11.10 (LTS) patches review and test

2020-09-17 Thread Chen, BoX C
> -Original Message- > From: Kevin Traynor > Sent: September 16, 2020 18:10 > To: Chen, BoX C ; Burakov, Anatoly > > Cc: dev@dpdk.org; Abhishek Marathe ; > Akhil Goyal ; Ali Alnubani ; > Walker, Benjamin ; David Christensen > ; Hemant Agrawal ; > Stokes, Ian ; Jerin Jacob ; > Mcnamara, Jo

Re: [dpdk-dev] [PATCH 1/2] config/arm: avoid variable reuse

2020-09-17 Thread Dharmik Thakkar
> On Sep 17, 2020, at 4:33 AM, Juraj Linkeš wrote: > > > >> -Original Message- >> From: dev On Behalf Of Dharmik Thakkar >> Sent: Tuesday, August 25, 2020 11:13 PM >> To: Thomas Monjalon >> Cc: dev@dpdk.org; n...@arm.com; Dharmik Thakkar >> >> Subject: [dpdk-dev] [PATCH 1/2] config

Re: [dpdk-dev] [PATCH v3 1/6] eal: add power management intrinsics

2020-09-17 Thread Jerin Jacob
On Fri, Sep 4, 2020 at 3:49 PM Liang Ma wrote: > > Add two new power management intrinsics, and provide an implementation > in eal/x86 based on UMONITOR/UMWAIT instructions. The instructions > are implemented as raw byte opcodes because there is not yet widespread > compiler support for these inst

Re: [dpdk-dev] [PATCH v4 4/5] net/ice: fix vector rx burst for ice

2020-09-17 Thread Guo, Jia
> -Original Message- > From: Zhang, Qi Z > Sent: Friday, September 18, 2020 11:41 AM > To: Guo, Jia ; Yang, Qiming ; > Xing, Beilei ; Wu, Jingjing ; > Wang, Haiyue > Cc: Zhao1, Wei ; Richardson, Bruce > ; dev@dpdk.org; Zhang, Helin > ; m...@smartsharesystems.com; Yigit, Ferruh > ; step.

Re: [dpdk-dev] [PATCH 0/2] add anti replay support in OCTEON TX2 security

2020-09-17 Thread Anoob Joseph
> > Support for anti replay is added in OCTEON TX2 security PMD. > The functionality has been tested with ipsec-secgw application running in > inline protocol offload mode. > > Ankur Dwivedi (2): > net/octeontx2: add anti replay support in security session > net/octeontx2: add replay check fo

Re: [dpdk-dev] [PATCH 1/2] config: add Graviton2(arm64) meson configuration

2020-09-17 Thread Jerin Jacob
On Thu, Sep 17, 2020 at 10:41 PM Honnappa Nagarahalli wrote: > > > > > > > > > > > On 9/11/20 8:23 PM, Honnappa Nagarahalli wrote: > > > > > > > > > > +Jerin, Hemant, Dharmik > > > > > > > > > > > > > > > Hi Vimal, > > > > > Few comments inline. > > > > > > > > > >> > > > > >> Add meson

[dpdk-dev] [PATCH v2 3/3] net/ice: optimize Tx path on AVX512 vPMD

2020-09-17 Thread Leyi Rong
Optimize Tx path by using AVX512 instructions and vectorize the tx free bufs process. Signed-off-by: Leyi Rong Signed-off-by: Bruce Richardson --- drivers/net/ice/ice_rxtx.h| 4 + drivers/net/ice/ice_rxtx_vec_avx512.c | 155 +- drivers/net/ice/ice_rxtx_vec_

[dpdk-dev] [PATCH v2 2/3] net/ice: add RSS hash parsing in AVX512 path

2020-09-17 Thread Leyi Rong
Support RSS hash parsing in AVX512 data path as the default RXDID is set to #22, that means the RSS hash field locates in the 2nd 16B of each Flex Rx descriptor. Signed-off-by: Leyi Rong --- drivers/net/ice/ice_rxtx_vec_avx512.c | 105 -- 1 file changed, 98 insertions(+),

[dpdk-dev] [PATCH v2 0/3] AVX512 vPMD on ice

2020-09-17 Thread Leyi Rong
This patchset aims to support AVX512 vPMD on ice. Has dependency on http://patches.dpdk.org/cover/76096/ which support SIMD bitwidth selection properly. --- v2: - No internal judgement when RTE_MACHINE_CPUFLAG_AVX512F is set in meson.build. - Add RSS hash parsing as default RXDID is set to #22.

[dpdk-dev] [PATCH v2 1/3] net/ice: add AVX512 vector path

2020-09-17 Thread Leyi Rong
Add AVX512 support for ice PMD. This patch adds ice_rxtx_vec_avx512.c to support ice AVX512 vPMD. This patch aims to enable AVX512 on ice vPMD. Main changes are focus on Rx path compared with AVX2 vPMD. Signed-off-by: Leyi Rong Signed-off-by: Bruce Richardson --- drivers/net/ice/ice_rxtx.c

Re: [dpdk-dev] [dpdk-stable] [PATCH v2] net/i40e: fix incorrect byte counters

2020-09-17 Thread Jiang, JunyuX
Hi Ferruh, > -Original Message- > From: Ferruh Yigit > Sent: Wednesday, September 16, 2020 8:31 PM > To: Jiang, JunyuX ; dev@dpdk.org > Cc: Guo, Jia ; Xing, Beilei ; > sta...@dpdk.org > Subject: Re: [dpdk-stable] [PATCH v2] net/i40e: fix incorrect byte counters > > On 9/16/2020 2:51 AM,

Re: [dpdk-dev] [PATCH v4 4/5] net/ice: fix vector rx burst for ice

2020-09-17 Thread Zhang, Qi Z
> -Original Message- > From: Guo, Jia > Sent: Friday, September 18, 2020 11:20 AM > To: Zhang, Qi Z ; Yang, Qiming > ; Xing, Beilei ; Wu, Jingjing > ; Wang, Haiyue > Cc: Zhao1, Wei ; Richardson, Bruce > ; dev@dpdk.org; Zhang, Helin > ; m...@smartsharesystems.com; Yigit, Ferruh > ; step

Re: [dpdk-dev] [PATCH v3 5/6] eal: hide internal device event structure

2020-09-17 Thread Guo, Jia
Hi, David > -Original Message- > From: David Marchand > Sent: Thursday, September 17, 2020 7:28 PM > To: dev@dpdk.org > Cc: arybche...@solarflare.com; Ray Kinsella ; Neil > Horman ; Mcnamara, John > ; Kovacevic, Marko > ; Jianfeng Tan ; Guo, > Jia > Subject: [PATCH v3 5/6] eal: hide inte

Re: [dpdk-dev] [PATCH v4 4/5] net/ice: fix vector rx burst for ice

2020-09-17 Thread Guo, Jia
Hi, qi > -Original Message- > From: Zhang, Qi Z > Sent: Thursday, September 17, 2020 7:03 PM > To: Guo, Jia ; Yang, Qiming ; > Xing, Beilei ; Wu, Jingjing ; > Wang, Haiyue > Cc: Zhao1, Wei ; Richardson, Bruce > ; dev@dpdk.org; Zhang, Helin > ; m...@smartsharesystems.com; Yigit, Ferruh >

Re: [dpdk-dev] [PATCH v4 04/11] baseband/acc100: add queue configuration

2020-09-17 Thread Liu, Tianjiao
On Fri, 4 Sep 2020 10:53:58 -0700, Nicolas Chautru wrote: > Adding function to create and configure queues for the device. Still no > capability. > Signed-off-by: Nicolas Chautru > --- > drivers/baseband/acc100/rte_acc100_pmd.c | 420 > ++- drivers/baseband/acc100/

Re: [dpdk-dev] [PATCH] net/af_xdp: custom XDP program loading

2020-09-17 Thread Hu, Xuekun
> -Original Message- > From: dev On Behalf Of Ciara Loftus > Sent: Friday, August 28, 2020 7:18 PM > To: dev@dpdk.org > Cc: Loftus, Ciara > Subject: [dpdk-dev] [PATCH] net/af_xdp: custom XDP program loading > > The new 'xdp_prog=' vdev arg allows the user to specify the path to a > cus

Re: [dpdk-dev] [PATCH v4 03/11] baseband/acc100: add info get function

2020-09-17 Thread Liu, Tianjiao
On Fri, 4 Sep 2020 10:53:59 -0700, Nicolas Chautru wrote: > Add in the "info_get" function to the driver, to allow us to query the device. > No processing capability are available yet. > Linking bbdev-test to support the PMD with null capability. > Signed-off-by: Nicolas Chautru > --- > app/te

Re: [dpdk-dev] [PATCH v1] net/iavf: support flex desc metadata extraction

2020-09-17 Thread Guo, Jia
hi, haiyue > -Original Message- > From: Wang, Haiyue > Sent: Thursday, September 17, 2020 11:00 AM > To: Guo, Jia ; Wu, Jingjing ; > Zhang, Qi Z ; Xing, Beilei > Cc: dev@dpdk.org; Guo, Jia > Subject: RE: [dpdk-dev] [PATCH v1] net/iavf: support flex desc metadata > extraction > > Hi Jef

Re: [dpdk-dev] [PATCH v4 02/11] baseband/acc100: add register definition file

2020-09-17 Thread Liu, Tianjiao
On Fri, 4 Sep 2020 10:53:58 -0700, Nicolas Chautru wrote: > Add in the list of registers for the device and related > HW specs definitions. > Signed-off-by: Nicolas Chautru > --- > drivers/baseband/acc100/acc100_pf_enum.h | 1068 > ++ > drivers/baseband/acc100/acc1

Re: [dpdk-dev] [PATCH v2 01/17] eal: add max SIMD bitwidth

2020-09-17 Thread Honnappa Nagarahalli
> > > >>> > >> > diff --git a/lib/librte_eal/include/rte_eal.h > >> b/lib/librte_eal/include/rte_eal.h > index ddcf6a2e7a..8148f650f2 100644 > --- a/lib/librte_eal/include/rte_eal.h > +++ b/lib/librte_eal/include/rte_eal.h > @@ -43,6 +43,13 @@ enum rte_proc_type_t { >

Re: [dpdk-dev] [V5 1/3] ethdev: introduce FEC API

2020-09-17 Thread humin (Connor)
在 2020/9/17 20:49, Ananyev, Konstantin 写道: This patch adds Forward error correction(FEC) support for ethdev. Introduce APIs which support query and config FEC information in hardware. Signed-off-by: Min Hu (Connor) Reviewed-by: Wei Hu (Xavier) Reviewed-by: Chengwen Feng Reviewed-by: Che

[dpdk-dev] [PATCH v3] net/ice: refactor the Rx FlexiMD handling

2020-09-17 Thread Haiyue Wang
The hardware supports many kinds of FlexiMDs set into Rx descriptor, and the FlexiMDs can have different offsets in the descriptor according the DDP package setting. The FlexiMDs type and offset are identified by the RXDID, which will be used to setup the queue. For expanding to support different

Re: [dpdk-dev] [PATCH 07/22] event/dlb2: add xstats

2020-09-17 Thread Chen, Mike Ximing
> -Original Message- > From: McDaniel, Timothy > Sent: Thursday, September 17, 2020 5:26 PM > To: Chen, Mike Ximing > Cc: dev@dpdk.org; Carrillo, Erik G ; Eads, Gage > ; Van Haaren, Harry ; > jer...@marvell.com > Subject: RE: [dpdk-dev] [PATCH 07/22] event/dlb2: add xstats > > > > >

Re: [dpdk-dev] [PATCH v2 1/7] cmdline: make implementation opaque

2020-09-17 Thread Dmitry Kozlyuk
Hi Olivier, thanks for the review. > In my opinion, we could accept the patch for 20.11, knowing it reduce > the risk of future ABI breakage, and that cmdline is not a core > component of DPDK. However it has to be discussed and accepted by other > people. > > Else, the patch would be delayed for

Re: [dpdk-dev] [PATCH v8 2/3] app/testpmd: support ethdev rss level config

2020-09-17 Thread Ajit Khaparde
On Wed, Sep 16, 2020 at 7:08 PM wrote: > > From: Kiran Kumar K > > Adding support to set RSS level from ethdev config. > level-default will requests the default behavior. > level-outer will requests RSS to be performed on the outermost packet > encapsulation level. > level-inner will request RSS

Re: [dpdk-dev] [PATCH v8 1/3] ethdev: add level support for RSS offload types

2020-09-17 Thread Ajit Khaparde
On Thu, Sep 17, 2020 at 2:36 AM Andrew Rybchenko wrote: > > On 9/17/20 5:07 AM, kirankum...@marvell.com wrote: > > From: Kiran Kumar K > > > > This patch reserves 2 bits as input selection to select Inner and > > outer encapsulation level for RSS computation. It is combined with existing > > ETH_

Re: [dpdk-dev] [PATCH 07/22] event/dlb2: add xstats

2020-09-17 Thread McDaniel, Timothy
> -Original Message- > From: Chen, Mike Ximing > Sent: Thursday, September 17, 2020 3:58 PM > To: McDaniel, Timothy > Cc: dev@dpdk.org; Carrillo, Erik G ; Eads, Gage > ; Van Haaren, Harry ; > jer...@marvell.com > Subject: RE: [dpdk-dev] [PATCH 07/22] event/dlb2: add xstats > > > > +d

Re: [dpdk-dev] [PATCH 07/22] event/dlb2: add xstats

2020-09-17 Thread Chen, Mike Ximing
> +dlb2_eventdev_dump(struct rte_eventdev *dev, FILE *f) { > + struct dlb2_eventdev *dlb2; > + struct dlb2_hw_dev *handle; > + int i; > + > + if (!f) { > + printf("Invalid file pointer\n"); > + return; > + } > + > + if (!dev) { > + fprint

Re: [dpdk-dev] [RFC PATCH 0/5] rework feature enabling macros for compatibility

2020-09-17 Thread Andrew Rybchenko
On 9/16/20 7:44 PM, Bruce Richardson wrote: As flagged previously on-list, there are a number of macros used to specify what libs and drivers are enabled in the build which differ from the equivalents used with make. This patchset is one possible approach to fixing these, but as part of the inves

Re: [dpdk-dev] [PATCH 1/2] config: add Graviton2(arm64) meson configuration

2020-09-17 Thread Honnappa Nagarahalli
> > > > > > On 9/11/20 8:23 PM, Honnappa Nagarahalli wrote: > > > > > > > > +Jerin, Hemant, Dharmik > > > > > > > > > > > > Hi Vimal, > > > > Few comments inline. > > > > > > > >> > > > >> Add meson build configuration for Graviton2 platform with 64-bit > > > >> ARM Neoverse N1 cores. Th

Re: [dpdk-dev] [PATCH v2 1/7] cmdline: make implementation opaque

2020-09-17 Thread Stephen Hemminger
On Thu, 17 Sep 2020 15:34:43 +0200 Olivier Matz wrote: > Hi Dmitry, > > On Fri, Jul 31, 2020 at 12:06:45AM +0300, Dmitry Kozlyuk wrote: > > struct cmdline exposes platform-specific members it contains, most > > notably struct termios that is only available on Unix. Make the > > structure opaque.

Re: [dpdk-dev] [PATCH 00/20] Upgrade HAL and add ENI metrics support

2020-09-17 Thread Stephen Hemminger
On Thu, 17 Sep 2020 07:30:15 +0200 Michal Krawczyk wrote: > Hi, > > this patchset contains upgrade of the of the HAL, which, beside some fixes, > also > adds possibility for reading ENI metrics from the device. > > Those are further exposed to the DPDK applicaiton using xstats. > > As it's an

Re: [dpdk-dev] [RFC] ethdev: introduce Rx buffer split

2020-09-17 Thread Andrew Rybchenko
On 8/17/20 8:49 PM, Slava Ovsiienko wrote: From 7f7052d8b85ff3ff7011bd844b6d3169c6e51923 Mon Sep 17 00:00:00 2001 From: Viacheslav Ovsiienko Date: Mon, 17 Aug 2020 16:57:43 + Subject: [RFC] ethdev: introduce Rx buffer split The DPDK datapath in the transmit direction is very flexible. An a

Re: [dpdk-dev] [PATCH v2 01/17] eal: add max SIMD bitwidth

2020-09-17 Thread Bruce Richardson
On Thu, Sep 17, 2020 at 05:31:52PM +0100, Kinsella, Ray wrote: > > > On 09/09/2020 20:30, Honnappa Nagarahalli wrote: > > > > > >>> > >> > diff --git a/lib/librte_eal/include/rte_eal.h > >> b/lib/librte_eal/include/rte_eal.h > index ddcf6a2e7a..8148f650f2 100644 > --- a/lib/librte_e

Re: [dpdk-dev] [PATCH v2 01/17] eal: add max SIMD bitwidth

2020-09-17 Thread Kinsella, Ray
On 09/09/2020 20:30, Honnappa Nagarahalli wrote: > > >>> >> > diff --git a/lib/librte_eal/include/rte_eal.h >> b/lib/librte_eal/include/rte_eal.h index ddcf6a2e7a..8148f650f2 100644 --- a/lib/librte_eal/include/rte_eal.h +++ b/lib/librte_eal/include/rte_eal.h @@ -43,6 +43

Re: [dpdk-dev] [PATCH v5 7/7] test/ring: improve the application of macro

2020-09-17 Thread Ananyev, Konstantin
> Add more parameters into the macro TEST_RING_VERIFY and expand the scope > of application for it. Then replace all ring APIs check with > TEST_RING_VERIFY to facilitate debugging. > > Furthermore, correct a spelling mistakes of the macro > TEST_RING_FULL_EMTPY_ITER. > > Suggested-by: Honnapp

Re: [dpdk-dev] [PATCH v2 4/4] ethdev: use C11 atomic builtins for link status update

2020-09-17 Thread Andrew Rybchenko
On 9/16/20 11:23 AM, Phil Yang wrote: Since rte_atomicXX APIs are not allowed to be used, use C11 atomic builtins for link status update. Signed-off-by: Phil Yang Reviewed-by: Ruifeng Wang Reviewed-by: Honnappa Nagarahalli Acked-by: Andrew Rybchenko

Re: [dpdk-dev] [dpdk-stable] [PATCH] metrics: fix resource leak on memory allocation fail

2020-09-17 Thread Mcnamara, John
> If an error occurred when allocating memory for metrics or names, the > function returned without freeing allocated memory. This is now fixed to > avoid the resource leak in the case that either metrics or names had been > successfully allocated memory. > > Coverity issue: 362053 > Fixes: c5b719

Re: [dpdk-dev] [PATCH v2 1/6] ethdev: add flow shared action API

2020-09-17 Thread Ori Kam
> -Original Message- > From: Andrew Rybchenko > Sent: Thursday, September 17, 2020 6:34 PM > > Subject: Re: [dpdk-dev] [PATCH v2 1/6] ethdev: add flow shared action API > > On 9/16/20 10:20 PM, Ajit Khaparde wrote: > > On Wed, Sep 16, 2020 at 8:52 AM Andrey Vesnovaty > wrote: > >> > >

Re: [dpdk-dev] [PATCH] testpmd: add speed capability in device info

2020-09-17 Thread Ferruh Yigit
On 9/4/2020 7:23 AM, Sarosh Arif wrote: diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c index 30bee3324..8824ad174 100644 --- a/app/test-pmd/config.c +++ b/app/test-pmd/config.c @@ -518,6 +518,7 @@ device_infos_display(const char *identifier) struct rte_device *dev; str

Re: [dpdk-dev] [PATCH v4] net/virtio: fix wrong variable assignment in helper macro

2020-09-17 Thread Andrew Rybchenko
On 9/16/20 8:57 AM, Vipul Ashri wrote: Inside Macro ASSIGN_UNLESS_EQUAL(var, val), assignment to var is always failing as assignment done using var_ having local scope only. This leads to TX packets not going out and found broken due to cleanup malfunctioning. This patch fixes the wrong variable

Re: [dpdk-dev] [PATCH] crypto/scheduler: fix header install with meson

2020-09-17 Thread Bruce Richardson
On Thu, Sep 17, 2020 at 05:33:23PM +0200, David Marchand wrote: > On Thu, Sep 17, 2020 at 5:29 PM Bruce Richardson > wrote: > > > > On Thu, Sep 17, 2020 at 05:09:17PM +0200, David Marchand wrote: > > > The headers variable is only used in lib/meson.build context. > > > For drivers, an explicit ins

Re: [dpdk-dev] [dpdk-stable] [PATCH] net/dpaa2: fix build error about timesync functions

2020-09-17 Thread Hemant Agrawal
On 9/17/2020 5:29 PM, Ferruh Yigit wrote: On 9/17/2020 12:50 PM, Hemant Agrawal wrote: On 9/17/2020 5:08 PM, Ferruh Yigit wrote: On 9/17/2020 3:03 AM, Di, ChenxuX wrote: Hi, -Original Message- From: Ferruh Yigit Sent: Wednesday, September 16, 2020 11:29 PM To: Di, ChenxuX ; hemant.

Re: [dpdk-dev] [PATCH 2/2] bus/fslmc: fix check for vfio_group_fd

2020-09-17 Thread Hemant Agrawal
Acked-by: Hemant Agrawal

Re: [dpdk-dev] [PATCH v3 3/3] bus/fslmc: support bus close API

2020-09-17 Thread Kinsella, Ray
On 26/08/2020 06:52, rohit@nxp.com wrote: > From: Rohit Raj > > This patch add support for closing the bus objects which > were acquired In the bus probe. > > Some devices need to be cleaned while in both primary and > secondary process and while some need to be cleaned only in > case of

Re: [dpdk-dev] [PATCH v3 1/3] eal: add API for bus close

2020-09-17 Thread Kinsella, Ray
On 26/08/2020 06:52, rohit@nxp.com wrote: > From: Rohit Raj > > As per the current code we have API for bus probe, but the > bus close API is missing. This breaks the multi process > scenarios as objects are not cleaned while terminating the > secondary processes. > > This patch adds a ne

Re: [dpdk-dev] [PATCH v2 1/6] ethdev: add flow shared action API

2020-09-17 Thread Andrew Rybchenko
On 9/16/20 10:20 PM, Ajit Khaparde wrote: On Wed, Sep 16, 2020 at 8:52 AM Andrey Vesnovaty wrote: Hi Ajit For shared action configuration I have following suggestion: struct rte_flow_shared_action_conf { uint32_t no_ingress: 1; uint32_t no_egress: 1; }; /*...*/ rte_flow_sha

Re: [dpdk-dev] [PATCH] crypto/scheduler: fix header install with meson

2020-09-17 Thread David Marchand
On Thu, Sep 17, 2020 at 5:29 PM Bruce Richardson wrote: > > On Thu, Sep 17, 2020 at 05:09:17PM +0200, David Marchand wrote: > > The headers variable is only used in lib/meson.build context. > > For drivers, an explicit install_headers() is necessary. > > > > Reproduced while compiling the l2fwd-cr

Re: [dpdk-dev] [PATCH] crypto/scheduler: fix header install with meson

2020-09-17 Thread Bruce Richardson
On Thu, Sep 17, 2020 at 05:09:17PM +0200, David Marchand wrote: > The headers variable is only used in lib/meson.build context. > For drivers, an explicit install_headers() is necessary. > > Reproduced while compiling the l2fwd-crypto example out of meson > (which can be done by adding it in devto

Re: [dpdk-dev] [PATCH] crypto/scheduler: fix header install with meson

2020-09-17 Thread Bruce Richardson
On Thu, Sep 17, 2020 at 05:09:17PM +0200, David Marchand wrote: > The headers variable is only used in lib/meson.build context. > For drivers, an explicit install_headers() is necessary. > > Reproduced while compiling the l2fwd-crypto example out of meson > (which can be done by adding it in devto

Re: [dpdk-dev] [dpdk-stable] [PATCH] doc: improve NFP PMD multiport PF documentation

2020-09-17 Thread Ferruh Yigit
On 9/3/2020 12:23 PM, Heinrich Kuhn wrote: The Agilio CX family of smartNIC's generally have a 1:many mapping of PF to physical ports. Elaborate on this mapping in the PF multiport section of the NFP PMD documentation. Fixes: d625beafc8be ("doc: update NFP with PF support information") Cc: sta..

Re: [dpdk-dev] [PATCH v2 1/4] ethdev: allow negative values in flow rule types

2020-09-17 Thread Andrew Rybchenko
On 9/17/20 10:56 AM, Gregory Etelson wrote: On 9/16/20 8:21 PM, Gregory Etelson wrote: From: Gregory Etelson Sent: Tuesday, September 15, 2020 13:27 To: Andrew Rybchenko ; Ajit Khaparde Cc: dpdk-dev ; Matan Azrad ; Raslan Darawsheh ; Ori Kam ; Gregory Etelson ; Ori Kam ; NBU-Contact-Thomas Monj

Re: [dpdk-dev] [PATCH v2 1/4] ethdev: allow negative values in flow rule types

2020-09-17 Thread Andrew Rybchenko
Hi Ori, On 9/17/20 10:47 AM, Ori Kam wrote: Hi Andrew, -Original Message- From: Andrew Rybchenko Sent: Thursday, September 17, 2020 9:50 AM On 9/16/20 8:21 PM, Gregory Etelson wrote: From: Gregory Etelson Sent: Tuesday, September 15, 2020 13:27 To: Andrew Rybchenko ; Ajit Khaparde

[dpdk-dev] [PATCH] crypto/scheduler: fix header install with meson

2020-09-17 Thread David Marchand
The headers variable is only used in lib/meson.build context. For drivers, an explicit install_headers() is necessary. Reproduced while compiling the l2fwd-crypto example out of meson (which can be done by adding it in devtools/test-meson-builds.sh examples build test). Fixes: cd2b6458a1cb ("cryp

Re: [dpdk-dev] [dpdk-stable] [PATCH] net/cxgbe: fix segfault when accessing empty Tx mbuf list

2020-09-17 Thread Ferruh Yigit
On 9/1/2020 6:20 PM, Rahul Lakkireddy wrote: Ensure packets are available before accessing the mbuf list in Tx burst function. Otherwise, just reclaim completed Tx descriptors and exit. Fixes: b1df19e43e1d ("net/cxgbe: fix prefetch for non-coalesced Tx packets") Cc: sta...@dpdk.org Reported-by:

[dpdk-dev] [PATCH] metrics: fix resource leak on memory allocation fail

2020-09-17 Thread Ciara Power
If an error occurred when allocating memory for metrics or names, the function returned without freeing allocated memory. This is now fixed to avoid the resource leak in the case that either metrics or names had been successfully allocated memory. Coverity issue: 362053 Fixes: c5b7197f662e ("telem

Re: [dpdk-dev] [PATCH v2] gso: fix pyld_unit_size issue for udp gso

2020-09-17 Thread Ferruh Yigit
On 9/17/2020 3:16 AM, Hu, Jiayu wrote: -Original Message- From: yang_y...@163.com Sent: Thursday, September 17, 2020 10:13 AM To: dev@dpdk.org Cc: Hu, Jiayu ; tho...@monjalon.net; yangy...@inspur.com; yang_y...@163.com Subject: [PATCH v2] gso: fix pyld_unit_size issue for udp gso From:

Re: [dpdk-dev] Issue with net/netvsc pmd in 18.11.9

2020-09-17 Thread Dey, Souvik
I have taken all the available approved patches from DPDK patchwork, but still Rx is not working properly. A bit of summary: With 18.11.6 – everything works fine. With 18.11.9 – 1. Seg fault in tx path. Ported the https://patches.dpdk.org/patch/75001/ patch to fix that. 2. Large tx packet

Re: [dpdk-dev] [PATCH] eal/linux: fix memory allocations in containers+SELinux

2020-09-17 Thread David Marchand
On Thu, Sep 17, 2020 at 4:17 PM Burakov, Anatoly wrote: > Anonymous hugepages shouldn't matter, yes, but single-file segments mode > does fallocate() and remove - you have the remove part covered, but i'm > just curious if fallocate() would also cause any issues with SELinux. I found no hook in t

Re: [dpdk-dev] [PATCH] eal/linux: fix memory allocations in containers+SELinux

2020-09-17 Thread Aaron Conole
"Burakov, Anatoly" writes: > On 17-Sep-20 2:47 PM, David Marchand wrote: >> On Fri, Sep 11, 2020 at 2:46 PM Burakov, Anatoly >> wrote: Removing hugepage files is done in multiple places and the memory allocation code is complex. This fix tries to do the minimum and avoids touching

Re: [dpdk-dev] [PATCH 2/2] bus/fslmc: fix check for vfio_group_fd

2020-09-17 Thread Burakov, Anatoly
On 17-Sep-20 2:34 PM, wangyunjian wrote: -Original Message- From: Burakov, Anatoly [mailto:anatoly.bura...@intel.com] Sent: Thursday, September 17, 2020 8:56 PM To: wangyunjian ; dev@dpdk.org Cc: hemant.agra...@nxp.com; sachin.sax...@nxp.com; Lilijun (Jerry) ; xudingke ; sta...@dpdk.org S

Re: [dpdk-dev] [PATCH v3] doc: add stack mempool guide

2020-09-17 Thread Olivier Matz
Hi Gage, On Mon, Sep 14, 2020 at 04:11:53PM -0500, Gage Eads wrote: > This guide describes the two stack modes, their tradeoffs, and (via a > reference to the mempool guide) how to enable them. > > Signed-off-by: Gage Eads > --- > v3: Fixed "Title underline too short" warning > > v2: Added comm

Re: [dpdk-dev] [PATCH] eventdev: support telemetry with xstats info

2020-09-17 Thread Chen, Mike Ximing
Hi Ciara, Thanks for identifying the issue. For some reasons, the problem did not show up in my previous tests with telemetry and eventdev. I will fix the bug as we discussed and upload a v2 patch. Best Regards, Mike -Original Message- From: Power, Ciara Sent: Thursday, September 17

Re: [dpdk-dev] [PATCH] mem: fix allocation failure on non-NUMA kernel

2020-09-17 Thread Nick Connolly
Sure. On 17/09/2020 15:18, Burakov, Anatoly wrote: On 17-Sep-20 3:08 PM, Nick Connolly wrote: Excellent - thanks - I'll amend the patch. On 17/09/2020 15:07, Burakov, Anatoly wrote: On 17-Sep-20 2:05 PM, Nick Connolly wrote: Hi Anatoly, Thanks.  My recollection is that all of the NUMA confi

Re: [dpdk-dev] [PATCH] mem: fix allocation failure on non-NUMA kernel

2020-09-17 Thread Burakov, Anatoly
On 17-Sep-20 3:08 PM, Nick Connolly wrote: Excellent - thanks - I'll amend the patch. On 17/09/2020 15:07, Burakov, Anatoly wrote: On 17-Sep-20 2:05 PM, Nick Connolly wrote: Hi Anatoly, Thanks.  My recollection is that all of the NUMA configuration flags were set to 'n'. Regards, Nick On

Re: [dpdk-dev] [PATCH] eal/linux: fix memory allocations in containers+SELinux

2020-09-17 Thread Burakov, Anatoly
On 17-Sep-20 2:47 PM, David Marchand wrote: On Fri, Sep 11, 2020 at 2:46 PM Burakov, Anatoly wrote: Removing hugepage files is done in multiple places and the memory allocation code is complex. This fix tries to do the minimum and avoids touching other paths. If trying to remove the hugepage f

Re: [dpdk-dev] [PATCH v2] cmdline: avoid name clash with Windows system types

2020-09-17 Thread Olivier Matz
Hi, On Thu, Sep 03, 2020 at 10:40:31AM +0100, Bruce Richardson wrote: > On Thu, Sep 03, 2020 at 12:30:56PM +0300, Dmitry Kozlyuk wrote: > > On Thu, 3 Sep 2020 10:20:52 +0100, Bruce Richardson wrote: > > > On Wed, Sep 02, 2020 at 09:38:05PM +0300, Dmitry Kozlyuk wrote: > > > > cmdline_numtype membe

Re: [dpdk-dev] [PATCH] mem: fix allocation failure on non-NUMA kernel

2020-09-17 Thread Burakov, Anatoly
On 17-Sep-20 2:05 PM, Nick Connolly wrote: Hi Anatoly, Thanks.  My recollection is that all of the NUMA configuration flags were set to 'n'. Regards, Nick On 17/09/2020 13:57, Burakov, Anatoly wrote: On 17-Sep-20 1:29 PM, Nick Connolly wrote: Hi Anatoly, Thanks for the response.  You are

Re: [dpdk-dev] [PATCH] mem: fix allocation failure on non-NUMA kernel

2020-09-17 Thread Nick Connolly
Excellent - thanks - I'll amend the patch. On 17/09/2020 15:07, Burakov, Anatoly wrote: On 17-Sep-20 2:05 PM, Nick Connolly wrote: Hi Anatoly, Thanks.  My recollection is that all of the NUMA configuration flags were set to 'n'. Regards, Nick On 17/09/2020 13:57, Burakov, Anatoly wrote: O

Re: [dpdk-dev] question regarding rx checksum offload flags

2020-09-17 Thread Olivier Matz
Hi Lance, On Mon, Aug 24, 2020 at 04:11:45PM -0400, Lance Richardson wrote: > I was looking for some clarification regarding how rx checksum > flags should be set for tunnel packets having both inner and outer > IP/L4 headers. > > Based on comments in rte_mbuf_core.h, it seems to me. that the > i

Re: [dpdk-dev] [PATCH v1 1/6] app/test: fix deadlock in distributor test

2020-09-17 Thread Lukasz Wojciechowski
Hi David, W dniu 17.09.2020 o 13:21, David Hunt pisze: > Hi Lukasz, > > On 15/9/2020 8:34 PM, Lukasz Wojciechowski wrote: >> The sanity test with worker shutdown delegates all bufs >> to be processed by a single lcore worker, then it freezes >> one of the lcore workers and continues to send more b

Re: [dpdk-dev] [PATCH] eal/linux: fix memory allocations in containers+SELinux

2020-09-17 Thread David Marchand
On Fri, Sep 11, 2020 at 2:46 PM Burakov, Anatoly wrote: > > Removing hugepage files is done in multiple places and the memory > > allocation code is complex. > > This fix tries to do the minimum and avoids touching other paths. > > > > If trying to remove the hugepage file before allocating a page

Re: [dpdk-dev] [PATCH v3 22/37] doc: remove references to make in contributing guides

2020-09-17 Thread Power, Ciara
Hi Thomas, One comment inline. Thanks, Ciara >-Original Message- >From: Thomas Monjalon >Sent: Monday 7 September 2020 11:21 >To: Power, Ciara ; dev@dpdk.org >Cc: Kilheeney, Louise ; Mcnamara, John >; Kovacevic, Marko > >Subject: Re: [dpdk-dev] [PATCH v3 22/37] doc: remove references t

Re: [dpdk-dev] [PATCH v2 1/7] cmdline: make implementation opaque

2020-09-17 Thread Olivier Matz
Hi Dmitry, On Fri, Jul 31, 2020 at 12:06:45AM +0300, Dmitry Kozlyuk wrote: > struct cmdline exposes platform-specific members it contains, most > notably struct termios that is only available on Unix. Make the > structure opaque. > > Remove tests checking struct cmdline content as meaningless. >

Re: [dpdk-dev] [PATCH 2/2] bus/fslmc: fix check for vfio_group_fd

2020-09-17 Thread wangyunjian
> -Original Message- > From: Burakov, Anatoly [mailto:anatoly.bura...@intel.com] > Sent: Thursday, September 17, 2020 8:56 PM > To: wangyunjian ; dev@dpdk.org > Cc: hemant.agra...@nxp.com; sachin.sax...@nxp.com; Lilijun (Jerry) > ; xudingke ; > sta...@dpdk.org > Subject: Re: [dpdk-dev] [PAT

Re: [dpdk-dev] [PATCH v1 6/6] distributor: fix handshake deadlock

2020-09-17 Thread David Hunt
Hi Lukasz, On 15/9/2020 8:34 PM, Lukasz Wojciechowski wrote: Synchronization of data exchange between distributor and worker cores is based on 2 handshakes: retptr64 for returning mbufs from workers to distributor and bufptr64 for passing mbufs to workers. Without proper order of verifying thos

Re: [dpdk-dev] [v2 1/2] cryptodev: support enqueue callback functions

2020-09-17 Thread Ananyev, Konstantin
> > > > > > In an eventdev world, multiple workers (with ordered queue) will be > > > working on IPsec ESP processing. The ESP header's sequence number is > > > unique and has to be sequentially incremented in an orderly manner. > > > This rises a need for incrementing sequence number in crypto

Re: [dpdk-dev] [PATCH v1 5/6] distributor: fix missing handshake synchronization

2020-09-17 Thread David Hunt
Hi Lukasz, On 15/9/2020 8:34 PM, Lukasz Wojciechowski wrote: rte_distributor_return_pkt function which is run on worker cores must wait for distributor core to clear handshake on retptr64 before using those buffers. While the handshake is set distributor core controls buffers and any operations

Re: [dpdk-dev] [PATCH v2] examples/ioat: fix stats print

2020-09-17 Thread Bruce Richardson
On Thu, Sep 17, 2020 at 02:07:40PM +0100, Kevin Laatz wrote: > Currently some of the status string at the top of the stats output is being > cut off. To fix this, the status string array size has been increased. > In addition to this, the "\n" has been moved to the printf, rather than > having it i

[dpdk-dev] [PATCH v2] examples/ioat: fix stats print

2020-09-17 Thread Kevin Laatz
Currently some of the status string at the top of the stats output is being cut off. To fix this, the status string array size has been increased. In addition to this, the "\n" has been moved to the printf, rather than having it in the last string, in case of future formatting issues due to truncat

Re: [dpdk-dev] [PATCH] mem: fix allocation failure on non-NUMA kernel

2020-09-17 Thread Nick Connolly
Hi Anatoly, Thanks.  My recollection is that all of the NUMA configuration flags were set to 'n'. Regards, Nick On 17/09/2020 13:57, Burakov, Anatoly wrote: On 17-Sep-20 1:29 PM, Nick Connolly wrote: Hi Anatoly, Thanks for the response.  You are asking a good question - here's what I know

[dpdk-dev] [PATCH v2] net/ice: enhance the FlexiMD handling

2020-09-17 Thread Haiyue Wang
The ice hardware supports different FlexiMDs selection into mbuf, it can have different offset in the Rx descriptor for single FlexiMD, like flow id. So it needs to handle the FlexiMD extraction according to the RXDID. Signed-off-by: Haiyue Wang --- v2: assign the handle for ICE_RXDID_COMMS_OVS d

Re: [dpdk-dev] [PATCH] mem: fix allocation failure on non-NUMA kernel

2020-09-17 Thread Burakov, Anatoly
On 17-Sep-20 1:29 PM, Nick Connolly wrote: Hi Anatoly, Thanks for the response.  You are asking a good question - here's what I know: The issue arose on a single socket system, running WSL2 (full Linux kernel running as a lightweight VM under Windows). The default kernel in this environment

Re: [dpdk-dev] [PATCH 2/2] bus/fslmc: fix check for vfio_group_fd

2020-09-17 Thread Burakov, Anatoly
On 19-May-20 4:42 AM, wangyunjian wrote: From: Yunjian Wang The issue is that a file descriptor at 0 is a valid one. Currently the file not found, the return value will be set to 0. As a result, it is impossible to distinguish between a correct descriptor and a failed return value. Fix it to re

Re: [dpdk-dev] [V5 1/3] ethdev: introduce FEC API

2020-09-17 Thread Ananyev, Konstantin
> > This patch adds Forward error correction(FEC) support for ethdev. > Introduce APIs which support query and config FEC information in > hardware. > > Signed-off-by: Min Hu (Connor) > Reviewed-by: Wei Hu (Xavier) > Reviewed-by: Chengwen Feng > Reviewed-by: Chengchang Tang > --- > v4->v5:

Re: [dpdk-dev] [PATCH 2/2] net/cxgbe: release port resources during port close

2020-09-17 Thread Ferruh Yigit
On 9/1/2020 6:16 PM, Rahul Lakkireddy wrote: Enable RTE_ETH_DEV_CLOSE_REMOVE during PCI probe for all ports enumerated under the PF. Free up the underlying port Virtual Identifier (VI) and associated resources during port close. Once all the ports under the PF are closed, free up the PF-wide shar

Re: [dpdk-dev] [PATCH 2/2] bus/fslmc: fix check for vfio_group_fd

2020-09-17 Thread wangyunjian
Friendly ping > -Original Message- > From: wangyunjian > Sent: Tuesday, May 19, 2020 11:42 AM > To: dev@dpdk.org > Cc: anatoly.bura...@intel.com; hemant.agra...@nxp.com; > sachin.sax...@nxp.com; Lilijun (Jerry) ; xudingke > ; wangyunjian ; > sta...@dpdk.org > Subject: [dpdk-dev] [PATCH 2/2

Re: [dpdk-dev] [PATCH v1 4/6] app/test: collect return mbufs in distributor test

2020-09-17 Thread David Hunt
Hi Lukasz, On 15/9/2020 8:34 PM, Lukasz Wojciechowski wrote: During quit_workers function distributor's main core processes some packets to wake up pending worker cores so they can quit. As quit_workers acts also as a cleanup procedure for next test case it should also collect these packages ret

Re: [dpdk-dev] [PATCH] net/tap: release port upon close

2020-09-17 Thread wangyunjian
> -Original Message- > From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Sunday, September 13, 2020 5:17 PM > To: wangyunjian > Cc: dev@dpdk.org; ferruh.yi...@intel.com; Lilijun (Jerry) > ; xudingke ; > keith.wi...@intel.com > Subject: Re: [dpdk-dev] [PATCH] net/tap: release port

Re: [dpdk-dev] [PATCH v1 3/6] app/test: fix freeing mbufs in distributor tests

2020-09-17 Thread David Hunt
Hi Lukasz, On 15/9/2020 8:34 PM, Lukasz Wojciechowski wrote: Sanity tests with mbuf alloc and shutdown tests assume that mbufs passed to worker cores are freed in handlers. Such packets should not be returned to the distributor's main core. The only packets that should be returned are the packet

Re: [dpdk-dev] [PATCH] mem: fix allocation failure on non-NUMA kernel

2020-09-17 Thread Nick Connolly
Hi Anatoly, Thanks for the response.  You are asking a good question - here's what I know: The issue arose on a single socket system, running WSL2 (full Linux kernel running as a lightweight VM under Windows). The default kernel in this environment is built with CONFIG_NUMA=n which means get

Re: [dpdk-dev] [PATCH v4 1/3] app/testpmd: add GENEVE parsing

2020-09-17 Thread Olivier Matz
Hi Ophir, Please find some comments below. On Tue, Sep 15, 2020 at 01:17:15PM +, Ophir Munk wrote: > From: Ophir Munk > > GENEVE is a widely used tunneling protocol in modern Virtualized > Networks. testpmd already supports parsing of several tunneling > protocols including VXLAN, VXLAN-GPE

Re: [dpdk-dev] [PATCH v1 5/5] net/i40e: fix max mtu size packets with vlan tag cannot be received by default

2020-09-17 Thread Ananyev, Konstantin
> > Subject: RE: [dpdk-dev] [PATCH v1 5/5] net/i40e: fix max mtu size packets > > with vlan tag cannot be received by default > > > > > testpmd will initialize default max packet length to 1518 which does't > > > include vlan tag size in ether overheader. Once, send the max mtu > > > length packe

[dpdk-dev] [PATCH v1] net/ice: enhance the FlexiMD handling

2020-09-17 Thread Haiyue Wang
The ice hardware supports different FlexiMDs selection into mbuf, it can have different offset in the Rx descriptor for single FlexiMD, like flow id. So it needs to handle the FlexiMD extraction according to the RXDID. Signed-off-by: Haiyue Wang --- drivers/net/ice/ice_rxtx.c | 260 +

Re: [dpdk-dev] [dpdk-stable] [PATCH] net/dpaa2: fix build error about timesync functions

2020-09-17 Thread Ferruh Yigit
On 9/17/2020 12:50 PM, Hemant Agrawal wrote: On 9/17/2020 5:08 PM, Ferruh Yigit wrote: On 9/17/2020 3:03 AM, Di, ChenxuX wrote: Hi, -Original Message- From: Ferruh Yigit Sent: Wednesday, September 16, 2020 11:29 PM To: Di, ChenxuX ; hemant.agra...@nxp.com Cc: sachin.sax...@nxp.com;

Re: [dpdk-dev] [dpdk-stable] [PATCH] net/dpaa2: fix build error about timesync functions

2020-09-17 Thread Hemant Agrawal
On 9/17/2020 5:08 PM, Ferruh Yigit wrote: On 9/17/2020 3:03 AM, Di, ChenxuX wrote: Hi, -Original Message- From: Ferruh Yigit Sent: Wednesday, September 16, 2020 11:29 PM To: Di, ChenxuX ; hemant.agra...@nxp.com Cc: sachin.sax...@nxp.com; sta...@dpdk.org; dev@dpdk.org; Richardson, Br

  1   2   >