On Thu, 17 Sep 2020 15:34:43 +0200 Olivier Matz <olivier.m...@6wind.com> wrote:
> Hi Dmitry, > > On Fri, Jul 31, 2020 at 12:06:45AM +0300, Dmitry Kozlyuk wrote: > > struct cmdline exposes platform-specific members it contains, most > > notably struct termios that is only available on Unix. Make the > > structure opaque. > > > > Remove tests checking struct cmdline content as meaningless. > > > > Add cmdline_get_rdline() to access history buffer. > > The new function is currently used only in tests. > > > > Signed-off-by: Dmitry Kozlyuk <dmitry.kozl...@gmail.com> > > First, please forgive me for the very late feedback. It is all the more > problematic because I think this patch introduces an ABI breakage, that > should have been announced. Since 20.11 is a API/ABI breaking release, I think breaking ABI is okay without announcement. What matters more is if that API would need to be impacted. API changes need some announcement.
