[dpdk-dev] [PATCH] metrics: fix resource leak on memory allocation fail

[Ciara Power]

If an error occurred when allocating memory for metrics or names,
the function returned without freeing allocated memory. This is now
fixed to avoid the resource leak in the case that either metrics or
names had been successfully allocated memory.

Coverity issue: 362053
Fixes: c5b7197f662e ("telemetry: move some functions to metrics library")
Cc: sta...@dpdk.org

Signed-off-by: Ciara Power <ciara.po...@intel.com>
---
 lib/librte_metrics/rte_metrics_telemetry.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/lib/librte_metrics/rte_metrics_telemetry.c 
b/lib/librte_metrics/rte_metrics_telemetry.c
index 289ebae0bd..36a3821b4c 100644
--- a/lib/librte_metrics/rte_metrics_telemetry.c
+++ b/lib/librte_metrics/rte_metrics_telemetry.c
@@ -170,7 +170,8 @@ rte_metrics_tel_format_port(uint32_t pid, json_t *ports,
        names = malloc(sizeof(struct rte_metric_name) * num_metrics);
        if (metrics == NULL || names == NULL) {
                METRICS_LOG_ERR("Cannot allocate memory");
-               return -ENOMEM;
+               ret = -ENOMEM;
+               goto fail;
        }
 
        if (rte_metrics_get_names(names, num_metrics) != num_metrics ||
-- 
2.17.1