Hi Olivier, thanks for the review. > In my opinion, we could accept the patch for 20.11, knowing it reduce > the risk of future ABI breakage, and that cmdline is not a core > component of DPDK. However it has to be discussed and accepted by other > people. > > Else, the patch would be delayed for 21.11. From what I see from the > other patches, it looks possible to keep cmdline struct public without > breaking the existing ABI by adding #ifdef CONFIG_RTE_EXEC_ENV_WINDOWS, > is it correct?
Windows team is now working on getting testpmd, tests, and examples functional. librte_cmdline is essential for that, so delaying to 21.11 is the worst option. If unannounced ABI breakage is deemed intolerable, I'd certainly go with #ifdef.
