Re: [dpdk-dev] [PATCH v1 1/1] net/ice: fix link status down

2020-09-14 Thread Mei, JianweiX
Tested-by: Mei,JianweiX < jianweix@intel.com> -Original Message- From: dev On Behalf Of yanx...@intel.com Sent: Wednesday, September 9, 2020 6:47 AM To: Zhang, Qi Z ; Guo, Jia Cc: dev@dpdk.org; Fu, YanX ; sta...@dpdk.org Subject: [dpdk-dev] [PATCH v1 1/1] net/ice: fix link status do

[dpdk-dev] [PATCH v3] net/ixgbe: fix vf reset hw error handling

2020-09-14 Thread SteveX Yang
When start a VF with no initial MAC address assigned by the underlying Host PF driver, just reuse the MAC address assigned when VF is initializing. Fixes: f69166c9a3c9 ("net/ixgbe: fix reset error handling") Signed-off-by: SteveX Yang --- v3: * update commit and inline comment v2: * update com

[dpdk-dev] [PATCH v3 2/2] net/iavf: support RSS for IPv6 prefix 64bit

2020-09-14 Thread Junfeng Guo
RSS for IPv6 prefix 64bit fields are supported in this patch, so that we can use prefix instead of full IPv6 address for RSS. The prefix here only includes the first 64 bits of both SRC and DST IPv6 address. Signed-off-by: Junfeng Guo --- drivers/net/iavf/iavf_hash.c | 21 +

[dpdk-dev] [PATCH v3 1/2] net/iavf: replace function name with macro

2020-09-14 Thread Junfeng Guo
Replace some function name with macro to shrink coding charactors. VIRTCHNL_DEL_PROTO_HDR_FIELD, VIRTCHNL_ADD_PROTO_HDR_FIELD --> REFINE_PROTO_FLD. Signed-off-by: Junfeng Guo --- drivers/net/iavf/iavf_hash.c | 42 ++-- 1 file changed, 16 insertions

[dpdk-dev] [PATCH v3 0/2] add AVF RSS support for IPv6 prefix

2020-09-14 Thread Junfeng Guo
RSS for IPv6 prefix fields are supported in this patchset, so that we can use prefixes instead of full IPv6 address for AVF RSS. The prefix here includes the first 64 bits of both SRC and DST IPv6 address. v3: * code rebase v2: * add support RSS for GTPU IPv6 prefix 64bit. [PATCH v2 1/2] net/iav

[dpdk-dev] [PATCH v5 6/7] test/ring: add new function to validate dequeue data

2020-09-14 Thread Feifei Wang
Do code clean up by moving repeated code inside 'test_ring_mem_cmp' function to validate data and print information of enqueue/dequeue elements if validation fails. Signed-off-by: Feifei Wang Reviewed-by: Ruifeng Wang Reviewed-by: Phil Yang Reviewed-by: Dharmik Thakkar Reviewed-by: Honnappa Na

[dpdk-dev] [PATCH v5 7/7] test/ring: improve the application of macro

2020-09-14 Thread Feifei Wang
Add more parameters into the macro TEST_RING_VERIFY and expand the scope of application for it. Then replace all ring APIs check with TEST_RING_VERIFY to facilitate debugging. Furthermore, correct a spelling mistakes of the macro TEST_RING_FULL_EMTPY_ITER. Suggested-by: Honnappa Nagarahalli Sign

[dpdk-dev] [PATCH v5 4/7] test/ring: add check to validate dequeued objects

2020-09-14 Thread Feifei Wang
Add check in test_ring_basic_ex and test_ring_with_exact_size for single element enqueue and dequeue operations to validate the dequeued objects. Signed-off-by: Feifei Wang Reviewed-by: Ruifeng Wang Reviewed-by: Phil Yang Reviewed-by: Dharmik Thakkar Reviewed-by: Honnappa Nagarahalli --- app

[dpdk-dev] [PATCH v5 5/7] test/ring: validate the return value of enq/deq elements

2020-09-14 Thread Feifei Wang
Validate the return value of single element enqueue/dequeue operation in the test. Suggested-by: Honnappa Nagarahalli Signed-off-by: Feifei Wang Reviewed-by: Phil Yang Reviewed-by: Honnappa Nagarahalli --- app/test/test_ring.c | 26 ++ 1 file changed, 22 insertions(+),

[dpdk-dev] [PATCH v5 1/7] test/ring: fix wrong parameter passed to the enqueue APIs

2020-09-14 Thread Feifei Wang
When enqueue one element to ring in the performance test, a pointer should be passed to rte_ring_[sp|mp]enqueue APIs, not the pointer to a table of void *pointers. Fixes: a9fe152363e2 ("test/ring: add custom element size functional tests") Cc: honnappa.nagaraha...@arm.com Cc: sta...@dpdk.org Sign

[dpdk-dev] [PATCH v5 2/7] test/ring: fix wrong number of enq/deq elements

2020-09-14 Thread Feifei Wang
The ring capacity is (RING_SIZE - 1), thus only (RING_SIZE - 1) number of elements can be enqueued into the ring. Fixes: af75078fece3 ("first public release") Cc: sta...@dpdk.org Signed-off-by: Feifei Wang Reviewed-by: Ruifeng Wang Reviewed-by: Phil Yang Reviewed-by: Honnappa Nagarahalli ---

[dpdk-dev] [PATCH v5 3/7] test/ring: fix wrong size used in memcmp

2020-09-14 Thread Feifei Wang
When using memcmp function to check data, the third param should be the size of all elements, rather than the number of the elements. Fixes: a9fe152363e2 ("test/ring: add custom element size functional tests") Cc: honnappa.nagaraha...@arm.com Cc: sta...@dpdk.org Signed-off-by: Feifei Wang Review

[dpdk-dev] [PATCH v5 0/7] fix wrong passed pointer and add check

2020-09-14 Thread Feifei Wang
Several bugs in ring unit tests were identified and fixed. Added data validation on objects after enqueue/dequeue operations for data integration check. Unit tests were enhanced by checking return value of enqueue/dequeue operations and validating data integrity of objects. v2: 1. add check to v

Re: [dpdk-dev] [PATCH v3 0/2] refactor and clean FDIR

2020-09-14 Thread Zhang, Qi Z
> -Original Message- > From: Yan, Zhirun > Sent: Tuesday, September 15, 2020 1:27 PM > To: Zhang, Qi Z ; dev@dpdk.org > Cc: Cao, Yahui ; Wang, Xiao W > ; Su, Simei ; Guo, Junfeng > ; Yan, Zhirun > Subject: [PATCH v3 0/2] refactor and clean FDIR > > V3: > fix complie warning. > > > V

[dpdk-dev] [PATCH v3 0/2] refactor and clean FDIR

2020-09-14 Thread Zhirun Yan
V3: fix complie warning. V2: Simplified code. main changes: 1. Refactor FDIR configure function. 2. Merge flow seg info for tun/non-tun, distinguish inner/outer input_set. 3. Remove redundant segment info. Zhirun Yan (2): net/ice: refactor FDIR set conf function net/ice: merge inner/oute

[dpdk-dev] [PATCH v3 2/2] net/ice: merge inner/outer flow seg info for FDIR

2020-09-14 Thread Zhirun Yan
For tunnel and non-tunnel packets, it can share the same seg_tun info. seg_tun[1] can be used for supporting inner fields with tunnel flow rule or for non-tunnel packets, seg_tun[0] only used for tunnel outer part. Add outer_input_set to distinguish inner/outer input set. So we can identify differe

[dpdk-dev] [PATCH v3 1/2] net/ice: refactor FDIR set conf function

2020-09-14 Thread Zhirun Yan
The original set conf function in FDIR was very long. Refactor to increase readability to make it clearer and allow for more convenient further changes. No functional change here. Signed-off-by: Zhirun Yan --- drivers/net/ice/ice_fdir_filter.c | 53 +-- 1 file change

Re: [dpdk-dev] [PATCH v2 1/2] net/ice: refactor FDIR set conf function

2020-09-14 Thread Yan, Zhirun
> -Original Message- > From: Ferruh Yigit [mailto:ferruh.yi...@intel.com] > Sent: Monday, September 14, 2020 6:55 PM > To: Yan, Zhirun ; Zhang, Qi Z ; > dev@dpdk.org > Cc: Cao, Yahui ; Wang, Xiao W > ; Su, Simei ; Guo, Junfeng > > Subject: Re: [dpdk-dev] [PATCH v2 1/2] net/ice: refactor

Re: [dpdk-dev] [PATCH] net/dpaa2: fix build error about timesync functions

2020-09-14 Thread Hemant Agrawal
Acked-by: Hemant Agrawal

[dpdk-dev] [PATCH] net/dpaa2: fix build error about timesync functions

2020-09-14 Thread Chenxu Di
When the build option has '-DRTE_LIBRTE_IEEE1588=1', the announce of timesync functions will be build. However the dpdk_conf doesn't hav RTE_LIBRTE_IEEE1588 so that the file dpaa2_ptp.c will not be build. It cause the build error. This patch fixes it by adding set for dpdk_conf. Fixes: 184c39d1656

[dpdk-dev] [PATCH] net/mlx5: use bond index for netdev operations

2020-09-14 Thread Xueming Li
In case of bonding, device ifindex was detected as the PF ifindex, so any operation using ifindex applied to PF instead of the bond device. These operations includes MTU get/set, up/down and mac address manipulation, etc. This patch detects bond interface ifindex and name for PF that join a bond i

Re: [dpdk-dev] [PATCH v6] net/iavf: support outer IP hash for no inner GTPU

2020-09-14 Thread Zhang, Qi Z
> -Original Message- > From: Zhang, AlvinX > Sent: Tuesday, September 15, 2020 10:44 AM > To: Guo, Jia ; Zhang, Qi Z > Cc: dev@dpdk.org; Zhang, AlvinX > Subject: [PATCH v6] net/iavf: support outer IP hash for no inner GTPU > > From: Alvin Zhang > > Outer IP hash can be configured a

Re: [dpdk-dev] [PATCH v3 2/7] app/bbdev: add explicit check for counters

2020-09-14 Thread Liu, Tianjiao
On Tue, 18 Aug 2020 17:05:52 -0700, Nicolas Chautru wrote: > Adding explicit check in ut that the stats counters > have the expected values. Was missing for coverage. > > Signed-off-by: Nicolas Chautru > --- > app/test-bbdev/test_bbdev_perf.c | 17 + > 1 file changed, 17 insertion

[dpdk-dev] [PATCH v6] net/iavf: support outer IP hash for no inner GTPU

2020-09-14 Thread alvinx . zhang
From: Alvin Zhang Outer IP hash can be configured as input sets for no inner GTPU packets. Signed-off-by: Alvin Zhang V2: Modify codes according to comments. V3: Refact all codes. V4: Fix compatibility issues. V5, V6: Modify codes according to comments. --- drivers/net/iavf/iavf_hash.c | 26

Re: [dpdk-dev] [PATCH v4 02/11] baseband/acc100: add register definition file

2020-09-14 Thread Xu, Rosen
Hi, > -Original Message- > From: Chautru, Nicolas > Sent: Saturday, September 05, 2020 1:54 > To: dev@dpdk.org; akhil.go...@nxp.com > Cc: Richardson, Bruce ; Xu, Rosen > ; dave.bur...@accelercomm.com; > aidan.godd...@accelercomm.com; Yigit, Ferruh ; > Liu, Tianjiao ; Chautru, Nicolas > >

Re: [dpdk-dev] [PATCH v4 04/11] baseband/acc100: add queue configuration

2020-09-14 Thread Xu, Rosen
Hi, > -Original Message- > From: Chautru, Nicolas > Sent: Saturday, September 05, 2020 1:54 > To: dev@dpdk.org; akhil.go...@nxp.com > Cc: Richardson, Bruce ; Xu, Rosen > ; dave.bur...@accelercomm.com; > aidan.godd...@accelercomm.com; Yigit, Ferruh ; > Liu, Tianjiao ; Chautru, Nicolas > >

[dpdk-dev] [PATCH v3] app/test-pmd: fix meson build failed when enabled pmd_bonded

2020-09-14 Thread SteveX Yang
The depended pmd bond is missing for test-pmd. Add the pmd_bond to deps, and replace the relative MACRO name with new RTE_LIBRTE_BOND_PMD. Fixes: 2950a769315e ("bond: testpmd support") Signed-off-by: SteveX Yang --- v2->v3: * added fixline; v1->v2: * replaced the bond pmd MACRO with the new on

Re: [dpdk-dev] [PATCH v3 1/7] app/bbdev: add explicit ut for latency vs validation

2020-09-14 Thread Liu, Tianjiao
On Tue, 18 Aug 2020 17:05:51 -0700, Nicolas Chautru wrote: > Adding explicit different ut when testing for validation > or latency (early termination enabled or not). > > Signed-off-by: Nicolas Chautru > mailto:nicolas.chau...@intel.com>> > --- > app/test-bbdev/test_bbdev_perf.c | 92 > +

[dpdk-dev] [PATCH v2] app/test-pmd: fix meson build failed when used latency stats lib

2020-09-14 Thread SteveX Yang
meson build cannot find the header rte_latencystats.h when build DPDK first time or never installed DPDK lib after build via meson/ninja. Because the corresponding header directory isn't included after enabled RTE_LIBRTE_LATENCY_STATS flag. Add the lib 'latencystats' to deps of meson.build of tes

[dpdk-dev] [PATCH v3, 1/7] app/bbdev: add explicit ut for latency vs validation

2020-09-14 Thread Liu, Tianjiao
On Tue, 18 Aug 2020 17:05:51 -0700, Nicolas Chautru wrote: > Adding explicit different ut when testing for validation > or latency (early termination enabled or not). > > Signed-off-by: Nicolas Chautru > --- > app/test-bbdev/test_bbdev_perf.c | 92 > ++-- > 1

[dpdk-dev] [PATCH 3/3] MAINTAINERS - remove expermental tag of netvsd PMD

2020-09-14 Thread Stephen Hemminger
With Long's help the driver is now stable enough for real usage. Signed-off-by: Stephen Hemminger --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index e3e70c25560d..d9717c1997e6 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -773,7 +7

[dpdk-dev] [PATCH 0/3] MAINTAINERS changes related to netvsc

2020-09-14 Thread Stephen Hemminger
Breakout three small changes to netvsc maintainers Stephen Hemminger (3): MAINTAINERS remove experimental tag from vdev_netvsc MAINTAINERS - drop Kys and Haiyang MAINTAINERS - remove expermental tag of netvsd PMD MAINTAINERS | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) --

[dpdk-dev] [PATCH 2/3] MAINTAINERS - drop Kys and Haiyang

2020-09-14 Thread Stephen Hemminger
These two maintainers deal with the Linux side of netvsc and are not relevant for DPDK. Signed-off-by: Stephen Hemminger --- MAINTAINERS | 2 -- 1 file changed, 2 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index 32db0996181f..e3e70c25560d 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -

[dpdk-dev] [PATCH 1/3] MAINTAINERS remove experimental tag from vdev_netvsc

2020-09-14 Thread Stephen Hemminger
Vdev_netvsc has been around for several years. It no longer needs to be marked experimental. Signed-off-by: Stephen Hemminger --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index 3b16d7a4b8c8..32db0996181f 100644 --- a/MAINTAINERS ++

Re: [dpdk-dev] [PATCH v5] net/iavf: support outer IP hash for no inner GTPU

2020-09-14 Thread Zhang, AlvinX
Thanks Zhangqi. > -Original Message- > From: Zhang, Qi Z > Sent: Monday, September 14, 2020 6:33 PM > To: Zhang, AlvinX ; Guo, Jia > Cc: dev@dpdk.org > Subject: RE: [PATCH v5] net/iavf: support outer IP hash for no inner GTPU > > > > > -Original Message- > > From: Zhang, Alvin

Re: [dpdk-dev] [PATCH v3 05/11] baseband/acc100: add LDPC processing functions

2020-09-14 Thread Chautru, Nicolas
Hi Konstantin, Rosen, Replying to my own email. Can you confirm that the previous explanation below makes sense and can you ack this patch? Thanks and regards, Nic > From: Chautru, Nicolas > > > From: Ananyev, Konstantin > > > > > > > > > -Original Message- > > > From: dev On Behal

Re: [dpdk-dev] [PATCH v1 2/2] net/ice: optimize Tx path on AVX512 vPMD

2020-09-14 Thread Wang, Haiyue
> -Original Message- > From: dev On Behalf Of Leyi Rong > Sent: Thursday, September 10, 2020 14:55 > To: Richardson, Bruce ; Lu, Wenzhuo > ; Zhang, Qi Z > > Cc: dev@dpdk.org; Rong, Leyi > Subject: [dpdk-dev] [PATCH v1 2/2] net/ice: optimize Tx path on AVX512 vPMD > > Optimize Tx path b

Re: [dpdk-dev] [PATCH 3/3] net/iavf: enable AVX512 for TX

2020-09-14 Thread Wang, Haiyue
> -Original Message- > From: dev On Behalf Of Wenzhuo Lu > Sent: Thursday, September 10, 2020 13:59 > To: dev@dpdk.org > Cc: Lu, Wenzhuo ; Richardson, Bruce > ; Rong, Leyi > > Subject: [dpdk-dev] [PATCH 3/3] net/iavf: enable AVX512 for TX > > To enhance the per-core performance, this pa

Re: [dpdk-dev] [PATCH v2 1/2] drivers: replace RTE CIO barriers with RTE IO barriers

2020-09-14 Thread Honnappa Nagarahalli
> > Replace the deprecated rte_cio_[rw]mb barriers with rte_io_[rw]mb barriers. > > Signed-off-by: Phil Yang > Signed-off-by: Joyce Kong > Reviewed-by: Ruifeng Wang Looks good. Reviewed-by: Honnappa Nagarahalli > --- > drivers/common/mlx5/mlx5_common.h | 2 +- > drivers/cryp

Re: [dpdk-dev] [PATCH v2 2/2] eal: remove RTE CIO barriers

2020-09-14 Thread Honnappa Nagarahalli
> > Remove the deprecated rte_cio_[rw]mb APIs. > > Signed-off-by: Phil Yang > Reviewed-by: Ruifeng Wang Reviewed-by: Honnappa Nagarahalli > --- > doc/guides/rel_notes/release_20_11.rst | 3 +++ > lib/librte_eal/arm/include/rte_atomic_32.h | 4 --- > lib/librte_eal/arm/include/rte_a

Re: [dpdk-dev] [PATCH v4 03/22] event/dlb: add private data structures and constants

2020-09-14 Thread Eads, Gage
> -Original Message- > From: McDaniel, Timothy > Sent: Friday, September 11, 2020 2:18 PM > Cc: dev@dpdk.org; Carrillo, Erik G ; Eads, Gage > ; Van Haaren, Harry ; > jer...@marvell.com > Subject: [PATCH v4 03/22] event/dlb: add private data structures and > constants > > Add headers use

Re: [dpdk-dev] [PATCH 05/12] net/bnxt: improve support for small ring sizes

2020-09-14 Thread Ferruh Yigit
On 9/9/2020 4:52 PM, Lance Richardson wrote: > Improve support for small ring sizes: >- Ensure that transmit free threshold is no more than 1/4 ring size. >- Ensure that receive free threshold is no more than 1/4 ring size. >- Validate requested ring sizes against minimum supported size

Re: [dpdk-dev] [PATCH v2] net/axgbe: enable IEEE 1588 PTP support

2020-09-14 Thread Ferruh Yigit
On 9/14/2020 7:01 PM, Ferruh Yigit wrote: > On 9/14/2020 3:25 PM, Somalapuram, Amaranath wrote: >> [AMD Official Use Only - Internal Distribution Only] >> > > It would be nice if above text can be removed. > >> -Original Message- >> From: Sebastian, Selwin >> Sent: Tuesday, June 9, 2020

[dpdk-dev] [PATCH v3] doc: add stack mempool guide

2020-09-14 Thread Gage Eads
This guide describes the two stack modes, their tradeoffs, and (via a reference to the mempool guide) how to enable them. Signed-off-by: Gage Eads --- v3: Fixed "Title underline too short" warning v2: Added commit description doc/guides/mempool/index.rst | 1 + doc/guides/mempool/sta

Re: [dpdk-dev] [PATCH v3 1/6] eal: add power management intrinsics

2020-09-14 Thread Liang, Ma
On 04 Sep 11:42, Stephen Hemminger wrote: we are very open to discuss design with other vendor. > Before this is merged, please work with Arm maintainers to have a version that > works on Arm 64 as well. Don't think this should be merged unless the two > major > platforms supported by DPDK can w

Re: [dpdk-dev] [PATCH v3 2/6] ethdev: add simple power management API

2020-09-14 Thread Liang, Ma
agree, will be addressed On 04 Sep 09:37, Stephen Hemminger wrote: > On Fri, 4 Sep 2020 11:18:56 +0100 > Liang Ma wrote: > > > > > +#define ETH_EMPTYPOLL_MAX 512 /**< Empty poll number threshlold */ > > Spelling here. > > Also, shouldn't this be a per-device (or per-queue) configur

Re: [dpdk-dev] [PATCH v4 02/22] event/dlb: add dynamic logging

2020-09-14 Thread Eads, Gage
> -Original Message- > From: McDaniel, Timothy > Sent: Friday, September 11, 2020 2:18 PM > Cc: dev@dpdk.org; Carrillo, Erik G ; Eads, Gage > ; Van Haaren, Harry ; > jer...@marvell.com > Subject: [PATCH v4 02/22] event/dlb: add dynamic logging > > This commit adds base support for dyna

Re: [dpdk-dev] [PATCH v3 3/6] power: add simple power management API and callback

2020-09-14 Thread Liang, Ma
On 04 Sep 11:33, Ananyev, Konstantin wrote: > > +struct rte_eth_dev *dev = &rte_eth_devices[port_id]; > > + > > +if (unlikely(nb_rx == 0)) { > > +dev->empty_poll_stats[qidx].num++; > Hi Konstantin, Agree, v4 will relocate the meta data to seperate structure. and without touch the rte_ethde

Re: [dpdk-dev] [PATCH v4 01/22] event/dlb: add documentation and meson infrastructure

2020-09-14 Thread Eads, Gage
> diff --git a/doc/guides/eventdevs/dlb.rst b/doc/guides/eventdevs/dlb.rst > new file mode 100644 > index 000..e5759c0 > --- /dev/null > +++ b/doc/guides/eventdevs/dlb.rst Please add a dlb entry to doc/guides/eventdevs/index.rst > @@ -0,0 +1,340 @@ > +.. SPDX-License-Identifier: BSD-3-Clause

Re: [dpdk-dev] [PATCH v3 3/6] power: add simple power management API and callback

2020-09-14 Thread Liang, Ma
Hi Stephen, v4 will support 1 port with multiple core(still 1 queue per core)support this part description will be updated according to the design change. Regards Liang > The common way to express is this is: > > This API is not thread-safe and not preempt-safe. > There is also no mechan

Re: [dpdk-dev] [PATCH v3 1/6] eal: add power management intrinsics

2020-09-14 Thread Liang, Ma
Hi Stephen, v4 patch will include the l3fwd-power udpate. Regards Liang On 04 Sep 09:37, Stephen Hemminger wrote: > On Fri, 4 Sep 2020 11:18:55 +0100 > Liang Ma wrote: > > > Add two new power management intrinsics, and provide an implementation > > in eal/x86 based on UMONITOR/UMWAIT instru

Re: [dpdk-dev] [PATCH v3 1/6] eal: add power management intrinsics

2020-09-14 Thread Liang, Ma
Hi Stephen, Agree. v4 will address this. Regards Liang On 04 Sep 09:23, Stephen Hemminger wrote: > On Fri, 4 Sep 2020 11:18:55 +0100 > Liang Ma wrote: > > > + * > > + * @return > > + * Architecture-dependent return value. > > + */ > > +static inline int rte_power_monitor(const volatile voi

Re: [dpdk-dev] [PATCH] eventdev: add PCI probe named convenience function

2020-09-14 Thread Eads, Gage
> /** > * @internal > + * Wrapper for use by pci drivers as a .probe function to attach to a event > + * interface. > + */ > +static inline int > +rte_event_pmd_pci_probe(struct rte_pci_driver *pci_drv, > + struct rte_pci_device *pci_dev, > + siz

[dpdk-dev] [dpdk-announce] DPDK Userspace Summit - Join us next week!

2020-09-14 Thread Jill Lovato
DPDK Community, We are only one week away from DPDK Userspace Summit 2020! It kicks off Tuesday, September 22 at 12:30 CEST. Check out the full agenda and plan your schedule: https://events.linuxfoundation.org/dpdk-userspace-summit/program/schedule/ And if you have not already, please REGISTER

[dpdk-dev] [PATCH v2 17/17] examples: replace master lcore with main lcore

2020-09-14 Thread Stephen Hemminger
Replace use of the term master lcore with main lcore in the example programs. Signed-off-by: Stephen Hemminger --- examples/bbdev_app/main.c | 14 +-- examples/bond/main.c| 32 - examples/distributor/main.c | 10 --

[dpdk-dev] [PATCH v2 16/17] examples/ipsec-secgw: replace master lcore with main lcore

2020-09-14 Thread Stephen Hemminger
Simple replacement. Acked-by: Anatoly Burakov Signed-off-by: Stephen Hemminger --- examples/ipsec-secgw/event_helper.c | 6 +++--- examples/ipsec-secgw/ipsec-secgw.c | 4 ++-- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/examples/ipsec-secgw/event_helper.c b/examples/ipsec-s

[dpdk-dev] [PATCH v2 15/17] examples/qos: replace references to master

2020-09-14 Thread Stephen Hemminger
Use main instead of master in the QoS examples. Replace the "mst" command line argument with "mnc" Acked-by: Anatoly Burakov Signed-off-by: Stephen Hemminger --- examples/qos_meter/main.c| 4 ++-- examples/qos_sched/args.c| 26 +- examples/qos_sched/cmdline.c |

[dpdk-dev] [PATCH v2 11/17] app: replace references to master/slave

2020-09-14 Thread Stephen Hemminger
For the miscellaneous tests. Replace references to master lcore with main lcore and slave lcore with worker lcore. Acked-by: Anatoly Burakov Signed-off-by: Stephen Hemminger --- app/test-acl/main.c | 2 +- app/test-bbdev/test_bbdev_perf.c | 16 app/test-compress-

[dpdk-dev] [PATCH v2 12/17] examples: replace use of master with main

2020-09-14 Thread Stephen Hemminger
Change references to master/slave lcore to main/worker. For l2fwd, l3fwd and link_status examples. Acked-by: Anatoly Burakov Signed-off-by: Stephen Hemminger --- app/pdump/main.c | 2 +- examples/ip_pipeline/thread.c| 14 +++--- examp

[dpdk-dev] [PATCH v2 14/17] examples/performance-thread: replace reference to master lcore

2020-09-14 Thread Stephen Hemminger
Replace term master with main here. Acked-by: Anatoly Burakov Signed-off-by: Stephen Hemminger --- examples/performance-thread/l3fwd-thread/main.c | 16 examples/performance-thread/pthread_shim/main.c | 4 ++-- 2 files changed, 10 insertions(+), 10 deletions(-) diff --git a/e

[dpdk-dev] [PATCH v2 13/17] examples/multi_process: replace references to master/slave

2020-09-14 Thread Stephen Hemminger
Replace master with main and slave with worker. Fix the wording in comments. Acked-by: Anatoly Burakov Signed-off-by: Stephen Hemminger --- .../multi_process/client_server_mp/mp_server/main.c| 10 +- examples/multi_process/simple_mp/main.c| 4 ++-- examples/multi_pr

[dpdk-dev] [PATCH v2 10/17] app/test-eventdev: replace use of master lcore with main lcore

2020-09-14 Thread Stephen Hemminger
Replace master with main lcore. Acked-by: Anatoly Burakov Signed-off-by: Stephen Hemminger --- app/test-eventdev/evt_options.c | 2 +- app/test-eventdev/test_order_common.c| 12 ++-- app/test-eventdev/test_perf_common.c | 16 app/test-eventdev/test_pip

[dpdk-dev] [PATCH v2 07/17] doc: replace master lcore with main lcore

2020-09-14 Thread Stephen Hemminger
Make sure that master lcore is not used in documentation. Signed-off-by: Stephen Hemminger --- doc/guides/contributing/coding_style.rst | 2 +- doc/guides/faq/faq.rst | 6 +++--- doc/guides/howto/debug_troubleshoot.rst | 2 +- doc/guides/linux_gsg/ea

[dpdk-dev] [PATCH v2 09/17] app/test-pmd: replace master lcore with main lcore

2020-09-14 Thread Stephen Hemminger
Replace wording around main lcore. Acked-by: Anatoly Burakov Signed-off-by: Stephen Hemminger --- app/test-pmd/cmdline.c| 2 +- app/test-pmd/config.c | 4 ++-- app/test-pmd/parameters.c | 2 +- app/test-pmd/testpmd.c| 4 ++-- 4 files changed, 6 insertions(+), 6 deletions(-) diff --

[dpdk-dev] [PATCH v2 08/17] app/test: replace uses of master/slave

2020-09-14 Thread Stephen Hemminger
Replace master lcore with main lcore and slave lcore with worker lcore. Mostly automatic replacement. Acked-by: Anatoly Burakov Signed-off-by: Stephen Hemminger --- app/test/autotest_test_funcs.py | 2 +- app/test/meson.build| 2 +- app/test/test.c

[dpdk-dev] [PATCH v2 06/17] net/memif: replace master/slave arguments with server/client

2020-09-14 Thread Stephen Hemminger
Replace master/slave terms in this driver. The memory interface drivers uses a client/server architecture so change the variable names and device arguments to that. The previous devargs are maintained for compatiablity, but if used cause a notice in the log. Signed-off-by: Stephen Hemminger ---

[dpdk-dev] [PATCH v2 05/17] drivers: replace master lcore with main lcore

2020-09-14 Thread Stephen Hemminger
Replace use of deprecated rte_master_lcore with rte_main_lcore. Acked-by: Anatoly Burakov Signed-off-by: Stephen Hemminger --- drivers/bus/dpaa/dpaa_bus.c | 2 +- drivers/net/bnxt/bnxt_ring.c | 4 ++-- drivers/net/mvpp2/mrvl_ethdev.c | 6 +++--- dri

[dpdk-dev] [PATCH v2 03/17] eal: rename lcore word choices

2020-09-14 Thread Stephen Hemminger
Replace master lcore with main lcore and replace slave lcore with worker lcore. Keep the old functions and macros but mark them as deprecated for this release. The "--master-lcore" command line option is also deprecated and any usage will print a warning and use "--main-lcore" as replacement. Si

[dpdk-dev] [PATCH v2 04/17] rte_power: replace rte_master_lcore with rte_main_lcore

2020-09-14 Thread Stephen Hemminger
The old rte_master_lcore is now replaced by rte_mail_lcore. Signed-off-by: Stephen Hemminger --- lib/librte_power/rte_power_empty_poll.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/librte_power/rte_power_empty_poll.c b/lib/librte_power/rte_power_empty_poll.c index 70

[dpdk-dev] [PATCH v2 02/17] eal: add macro to mark macros as deprecated

2020-09-14 Thread Stephen Hemminger
Add a macro that causes GCC and CLANG to emit a warning when a deprecated macro is used. Signed-off-by: Stephen Hemminger --- lib/librte_eal/include/rte_common.h | 11 +++ 1 file changed, 11 insertions(+) diff --git a/lib/librte_eal/include/rte_common.h b/lib/librte_eal/include/rte_com

[dpdk-dev] [PATCH v2 01/17] doc/coding_style: add policy about master/slave

2020-09-14 Thread Stephen Hemminger
Update the coding style document to include a policy against introducing new master/slave usage. This is taken from the similar place in the Linux kernel coding style. Signed-off-by: Stephen Hemminger --- doc/guides/contributing/coding_style.rst | 23 +++ 1 file changed, 23 i

[dpdk-dev] [PATCH v2 00/17] Replace terms master/slave

2020-09-14 Thread Stephen Hemminger
As announced in 20.08 release notes, the terms for lcore role will change in 20.11 release. This is a project wide patchset to terminolgy used for DPDK lcore. The term "master" referring to lcore is replaced with "main" and "slave" lcore is replaced with "worker" lcore. This is most visible in AP

Re: [dpdk-dev] [PATCH 00/13] app/flow-perf: add support for new items/actions

2020-09-14 Thread Ferruh Yigit
On 8/30/2020 12:15 PM, Wisam Jaddo wrote: > * Some fixes. > * Add headers modify actions support. > * Add flag action support. > * Add raw-encap & raw-decap actions support. > * Add VXLAN encap & VXLAN decap actions support. > * Add set portmask option. > * Add icmp and icmp6 matching items support

Re: [dpdk-dev] [PATCH v2] net/axgbe: enable IEEE 1588 PTP support

2020-09-14 Thread Ferruh Yigit
On 9/14/2020 3:25 PM, Somalapuram, Amaranath wrote: > [AMD Official Use Only - Internal Distribution Only] > It would be nice if above text can be removed. > -Original Message- > From: Sebastian, Selwin > Sent: Tuesday, June 9, 2020 8:44 PM > To: dev@dpdk.org > Cc: Somalapuram, Amaranat

Re: [dpdk-dev] [dpdk-stable] [PATCH v2] net/cxgbe: fix duplicate MAC addresses in MPS TCAM

2020-09-14 Thread Ferruh Yigit
On 9/12/2020 12:47 AM, Rahul Lakkireddy wrote: > From: Karra Satwik > > During MAC address insertion to MPS TCAM, add a default mask when > the mask is not explicitly specified. Otherwise, driver misses the > mask comparison and ends up inserting duplicate entries in the > MPS TCAM. > > Fixes: 6

Re: [dpdk-dev] [PATCH v2] net/dpaa: fix public API port ID type

2020-09-14 Thread Ferruh Yigit
On 8/26/2020 6:15 AM, Hemant Agrawal wrote: >> -Original Message- >> From: Ferruh Yigit >> Sent: Tuesday, August 25, 2020 11:21 PM >> To: dev@dpdk.org; Ray Kinsella ; Neil Horman >> ; John McNamara ; >> Marko Kovacevic ; Hemant Agrawal >> ; Sachin Saxena >> Cc: Ferruh Yigit ; sta...@dpdk

Re: [dpdk-dev] [PATCH v2 2/3] app/testpmd: enable configuring GENEVE port

2020-09-14 Thread Ferruh Yigit
On 8/27/2020 8:02 AM, Ophir Munk wrote: > From: Ophir Munk > > IANA has assigned port 6081 as the fixed well-known destination port for > GENEVE. Nevertheless draft-ietf-nvo3-geneve-09 recommends that > implementations make this configurable. This commit enables specifying > any positive UDP des

Re: [dpdk-dev] [PATCH v2 1/3] app/testpmd: add GENEVE parsing

2020-09-14 Thread Ferruh Yigit
On 8/27/2020 8:02 AM, Ophir Munk wrote: > From: Ophir Munk > > GENEVE is a widely used tunneling protocol in modern Virtualized > Networks. testpmd already supports parsing of several tunneling > protocols including VXLAN, VXLAN-GPE, GRE. This commit adds GENEVE > parsing of inner protocols (IPv4

Re: [dpdk-dev] [dpdk-stable] [PATCH] bus/dpaa: fix fd check before close

2020-09-14 Thread Ferruh Yigit
On 8/26/2020 12:54 PM, wangyunjian wrote: > From: Yunjian Wang > > The fd is possibly a negative value while it is passed as an > argument to function "close". Fix the check to the fd. > > Fixes: b9c94167904f ("bus/dpaa: decouple FQ portal alloc and init") > Cc: sta...@dpdk.org > > Signed-off-b

Re: [dpdk-dev] [PATCH v4 15/31] app: remove references to make-based config

2020-09-14 Thread Laatz, Kevin
On 07/09/2020 23:06, Thomas Monjalon wrote: From: Ciara Power Make is no longer supported, RTE_SDK, RTE_TARGET and CONFIG options are no longer in use. Signed-off-by: Ciara Power --- app/test-bbdev/test-bbdev.py | 11 + app/test/test_cryptodev.c | 89 +---

Re: [dpdk-dev] [PATCH v2] net/dpaa2: fix misuse of if_index

2020-09-14 Thread Ferruh Yigit
On 9/14/2020 3:21 PM, Sachin Saxena (OSS) wrote: > From: Sachin Saxena > > Dpaa2 pmd has no need to bound host interface > for which we require if_index field. > Setting it to 0 as unused. > > Signed-off-by: Sachin Saxena Fixes: 3e5a335d3f88 ("net/dpaa2: add basic operations") Cc: sta...@dpdk.

Re: [dpdk-dev] [PATCH v2] net/pfe: fix misuse of if_index

2020-09-14 Thread Ferruh Yigit
On 9/14/2020 3:22 PM, Sachin Saxena (OSS) wrote: > From: Sachin Saxena > > Pfe pmd has no need to bound host interface > for which we require if_index field. > Setting it to 0 as unused. > > Signed-off-by: Sachin Saxena Fixes: fe38ad9ba73e ("net/pfe: add device start/stop") Cc: sta...@dpdk.org

Re: [dpdk-dev] [PATCH v4 18/31] doc: remove references to make from howto guides

2020-09-14 Thread Laatz, Kevin
On 07/09/2020 23:06, Thomas Monjalon wrote: From: Ciara Power Make is no longer supported for compiling DPDK, references are now removed in the documentation. Signed-off-by: Ciara Power --- doc/guides/howto/lm_bond_virtio_sriov.rst | 4 +-- doc/guides/howto/lm_virtio_vhost_user.rst

Re: [dpdk-dev] [PATCH v4 20/31] doc: remove references to make from platforms guides

2020-09-14 Thread Laatz, Kevin
On 07/09/2020 23:07, Thomas Monjalon wrote: From: Ciara Power Make is no longer supported for compiling DPDK, references are now removed in the documentation. Signed-off-by: Ciara Power --- doc/guides/platform/bluefield.rst | 22 - doc/guides/platform/octeontx.rst | 33

Re: [dpdk-dev] [PATCH v4 21/31] doc: remove references to make from mempool guide

2020-09-14 Thread Laatz, Kevin
On 07/09/2020 23:07, Thomas Monjalon wrote: From: Ciara Power Make is no longer supported for compiling DPDK, references are now removed in the documentation. Signed-off-by: Ciara Power --- doc/guides/mempool/octeontx.rst | 28 +++- doc/guides/mempool/octeontx2.rst

Re: [dpdk-dev] [PATCH V2] testpmd: add eeprom/module eeprom display

2020-09-14 Thread Ferruh Yigit
On 9/14/2020 4:11 PM, David Liu wrote: > Add module EEPROM/EEPROM dump command >    "show port (module_eeprom|eeprom)" > Commands will dump the content of the EEPROM/module > EEPROM for the selected port. > > Signed-off-by: David Liu mailto:d...@iol.unh.edu>> Hi David, The formatting is wrong i

Re: [dpdk-dev] [PATCH] eal: add umonitor umwait to x86 cpuflags

2020-09-14 Thread McDaniel, Timothy
> -Original Message- > From: Ananyev, Konstantin > Sent: Friday, September 11, 2020 11:37 AM > To: McDaniel, Timothy ; Richardson, Bruce > > Cc: dev@dpdk.org; Carrillo, Erik G ; Eads, Gage > ; Van Haaren, Harry ; > Ma, Liang J ; Burakov, Anatoly > > Subject: RE: [PATCH] eal: add umoni

Re: [dpdk-dev] [PATCH] eal/rte_malloc: add alloc_size() attribute to allocation functions

2020-09-14 Thread Stephen Hemminger
On Mon, 14 Sep 2020 16:35:58 +0100 "Burakov, Anatoly" wrote: > >* Replacement function for calloc(), using huge-page memory. Memory area > > is > > @@ -239,9 +243,9 @@ rte_zmalloc_socket(const char *type, size_t size, > > unsigned align, int socket); > >* align is not a power of two

Re: [dpdk-dev] [PATCH v2] eal/interrupts: add function to allow interruptible epoll

2020-09-14 Thread Stephen Hemminger
On Mon, 14 Sep 2020 10:56:33 +0200 David Marchand wrote: > On Fri, Sep 4, 2020 at 1:28 AM Stephen Hemminger > wrote: > > > > The existing definition of rte_epoll_wait retries if interrupted > > by a signal. This behavior makes it hard to use rte_epoll_wait > > for applications that want to use s

Re: [dpdk-dev] [PATCH v2 2/2] rte_log: make rte_logs private

2020-09-14 Thread Stephen Hemminger
On Mon, 14 Sep 2020 10:13:29 +0200 David Marchand wrote: > On Fri, Sep 4, 2020 at 1:05 AM Stephen Hemminger > wrote: > > > > As announced in earlier releases, rte_logs can now be made > > internal to eal_common_log. > > > > Acked-by: Andrew Rybchenko > > Signed-off-by: Stephen Hemminger > >

Re: [dpdk-dev] [PATCH v2 4/4] app/testpmd: fix displaying Rx Tx queues information

2020-09-14 Thread Ferruh Yigit
On 8/20/2020 2:42 AM, Wei Hu (Xavier) wrote: > From: Huisong Li > > Currently, the information of Rx/Tx queues from PMD driver is not displayed > exactly in the rxtx_config_display function. Because "ports[pid].rx_conf" > and "ports[pid].tx_conf" maintained in testpmd application may be not the >

Re: [dpdk-dev] [PATCH v2] app/test-pmd: fix meson build failed when enabled pmd_bonded

2020-09-14 Thread Bruce Richardson
On Mon, Sep 14, 2020 at 08:18:14AM +0100, Yang, SteveX wrote: > Hi Bruce, > > Do you mean I can provide a patch set which includes following two commit > fixes: > 1. For 20.11, add 'pmd_bond' to deps, and change the old macro to > RTE_LIBRTE_BOND_PMD; > 2. For backporting version, add 'pmd_bond'

Re: [dpdk-dev] [PATCH v2 3/4] app/testpmd: fix packet header in txonly mode

2020-09-14 Thread Ferruh Yigit
On 8/20/2020 2:42 AM, Wei Hu (Xavier) wrote: > From: Chengchang Tang > > In txonly forward mode, the packet header is fixed by the initial > setting, including the packet length and checksum. So when the packets > varies, this may cause a packet header error. Currently, there are two > methods in

[dpdk-dev] [PATCH 2/4] mempool: remove physical address aliases

2020-09-14 Thread Thomas Monjalon
Remove the deprecated unioned fields physaddr and phys_addr from the structures rte_mempool_objhdr and rte_mempool_memhdr. They are replaced with the fields iova which are at the same offsets. Remove the deprecated macro MEMPOOL_F_NO_PHYS_CONTIG which is an alias of the more recent MEMPOOL_F_NO_IO

[dpdk-dev] [PATCH 4/4] mbuf: remove physical address alias

2020-09-14 Thread Thomas Monjalon
Remove the deprecated buf_physaddr union field from rte_mbuf. It is replaced with buf_iova which is at the same offset. The single field buf_physaddr in rte_kni_mbuf is also renamed. This concludes a 3-year process of semantic change. Signed-off-by: Thomas Monjalon --- doc/guides/rel_notes/dep

[dpdk-dev] [PATCH 1/4] mem: remove physical address aliases

2020-09-14 Thread Thomas Monjalon
Remove the deprecated unioned fields phys_addr from the structures rte_memseg and rte_memzone. They are replaced with the fields iova which are at the same offsets. Signed-off-by: Thomas Monjalon --- drivers/bus/fslmc/portal/dpaa2_hw_pvt.h | 2 +- drivers/common/dpaax/dpaax_iova_table

[dpdk-dev] [PATCH 3/4] mbuf: remove deprecated function and macro aliases

2020-09-14 Thread Thomas Monjalon
Remove the deprecated functions - rte_mbuf_data_dma_addr - rte_mbuf_data_dma_addr_default which aliased the more recent functions - rte_mbuf_data_iova - rte_mbuf_data_iova_default Remove the deprecated macros - rte_pktmbuf_mtophys - rte_pktmbuf_mtoph

[dpdk-dev] [PATCH 0/4] remove aliases replaced with IOVA

2020-09-14 Thread Thomas Monjalon
When introducing IOVA semantic, 3 years ago, some fields, functions and macros mentioning "physical address" were marked as deprecated and replaced with IOVA aliases. Some parts of the original "physical address" semantic have been removed over the years, other parts are still there. This pathset

Re: [dpdk-dev] [PATCH v2 2/4] app/testpmd: fix VLAN offload configuration when config fail

2020-09-14 Thread Ferruh Yigit
On 8/20/2020 2:42 AM, Wei Hu (Xavier) wrote: > From: Chengchang Tang > > When failing to configure VLAN offloads after the port was started, there > is no need to update the port configuration. Currently, when user > configure an unsupported VLAN offloads and fails, and then restart the > port, i

Re: [dpdk-dev] [PATCH v2 1/4] app/testpmd: fix missing verification of port id

2020-09-14 Thread Ferruh Yigit
On 8/20/2020 2:42 AM, Wei Hu (Xavier) wrote: > From: Chengchang Tang > > To set Tx vlan offloads, it is required to stop port firstly. But before > checking whether the port is stopped, the port id entered by the user > is not checked for validity. When the port id is illegal, it would lead > to

  1   2   3   >