Re: [dpdk-dev] [dpdk-stable] [PATCH v4] lib/table: fix cache alignment issue

2020-07-29 Thread Xu, Ting
Hi, all, > -Original Message- > From: Dumitrescu, Cristian > Sent: Wednesday, July 29, 2020 10:53 PM > To: David Marchand > Cc: Xu, Ting ; dev ; dpdk stable > ; Kevin Traynor ; Luca Boccassi > > Subject: RE: [dpdk-stable] [dpdk-dev] [PATCH v4] lib/table: fix cache > alignment > issue >

Re: [dpdk-dev] [RFC] lib: introduce traffic mirroring API

2020-07-29 Thread Thomas Monjalon
30/07/2020 05:23, Patrick Fu: > Network Test Access Point (TAP) is the network monitoring service > commonly adotpted in SDN-based network infrastructures. When VMs are > inter-connected over virtual switches, TAP requires vSwitch to mirror > out network traffics from specific workload VM ports to

Re: [dpdk-dev] [PATCH v4 3/3] net/vhost: fix interrupt mode

2020-07-29 Thread Xiao, QimaiX
Tested-by: Xiao Qimai Regards, Xiao Qimai > -Original Message- > From: dev On Behalf Of Xia, Chenbo > Sent: Wednesday, July 29, 2020 10:19 PM > To: Maxime Coquelin ; dev@dpdk.org; > ma...@mellanox.com; Liu, Yong ; Wang, Yinan > > Cc: tho...@monjalon.net; Yigit, Ferruh ; > david.march..

[dpdk-dev] [Bug 486] i40e driver has very bad performance when VXLAN TSO is enabled

2020-07-29 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=486 Xiaoyun Li (xiaoyun...@intel.com) changed: What|Removed |Added CC||xiaoyun...@intel.com

[dpdk-dev] [RFC] lib: introduce traffic mirroring API

2020-07-29 Thread Patrick Fu
Network Test Access Point (TAP) is the network monitoring service commonly adotpted in SDN-based network infrastructures. When VMs are inter-connected over virtual switches, TAP requires vSwitch to mirror out network traffics from specific workload VM ports to the TAP device/VM ports. Classical mir

Re: [dpdk-dev] [PATCH v4 1/3] eal: fix memory leak when removing event_cb

2020-07-29 Thread Jeff Guo
hi, yunjian The patch seems no problem, but when you update your patch, please add other guys who had comment on your patch and maintainer to see if they have other opinion, and --in-reply-to is also helpful for patch review, thanks. On 7/29/2020 7:47 PM, wangyunjian wrote: Ping for review.

Re: [dpdk-dev] DPDK PDUMP Issue

2020-07-29 Thread Varghese, Vipin
Hi Dikshant, Summarizing the contents from earlier mails below 1. Issue-1 shared with PDUMP not working with testpmd - solution shared and suggested what needs to be added to fix the same. 2. Issue-2 shared for custom Makefile for application not working - pointed out possible cause and missin

Re: [dpdk-dev] [PATCH v3 1/1] net: fix bad checksum in offloaded TSOv6 packets

2020-07-29 Thread Zhang, Yuying
> -Original Message- > From: Zhang, Yuying > Sent: 2020年7月30日 10:01 > To: dev@dpdk.org; olivier.m...@6wind.com; Zhang, Qi Z > ; Yang, Qiming > Cc: Zhang, Yuying ; David Marchand > > Subject: [PATCH v3 1/1] net: fix bad checksum in offloaded TSOv6 packets > > The rte_net_intel_cksum_flag

[dpdk-dev] [PATCH v3 1/1] net: fix bad checksum in offloaded TSOv6 packets

2020-07-29 Thread Yuying Zhang
The rte_net_intel_cksum_flags_prepare() function prepares the pseudoheader checksum in packet data when doing checksum or TSO offload. It does nothing when no checksum offload flag is set in mbuf. But in case of a IPv6/TCP TSO packet, it is not mandatory to have a checksum flag. We also need to ch

Re: [dpdk-dev] [PATCH 0/4] bnxt patches

2020-07-29 Thread Ajit Khaparde
On Wed, Jul 29, 2020 at 7:09 AM Somnath Kotur wrote: > fixes and cleanups in bnxt TRUFlow > > Kishore Padmanabha (2): > net/bnxt: configure loopback parif for full offload egress flows > net/bnxt: enable lookup default action record parif entry > > Somnath Kotur (1): > net/bnxt: cleanups an

Re: [dpdk-dev] [PATCH] net/bnxt: remove EEM system memory support

2020-07-29 Thread Ajit Khaparde
On Wed, Jul 29, 2020 at 9:25 AM Ferruh Yigit wrote: > On 7/29/2020 1:42 AM, Ajit Khaparde wrote: > > From: Randy Schacher > > > > Remove the memory management scheme for Extended Exact Match > > using system memory. Using host memory scheme instead which > > was the default anyway. > > > > Fixes

[dpdk-dev] [PATCH v2 20.08 6/6] check_maintainers: change variable names

2020-07-29 Thread Stephen Hemminger
Change variable names in python script: replace whitelist with include_files and blacklist with exclude_files. Signed-off-by: Stephen Hemminger Acked-by: Luca Boccassi --- devtools/check-maintainers.sh | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/devtools/check-ma

[dpdk-dev] [PATCH v2 20.08 2/6] kni: fix reference to master/slave process

2020-07-29 Thread Stephen Hemminger
In DPDK, the correct terms for process are primary/secondary. This is bugfix, not a change in terms for new release. Fixes: f2e7592c474c ("kni: fix multi-process support") Signed-off-by: Stephen Hemminger --- lib/librte_kni/rte_kni.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --

[dpdk-dev] [PATCH v2 20.08 1/6] doc: announce deprecation of master lcore

2020-07-29 Thread Stephen Hemminger
Announce upcoming changes related to master/slave in reference to lcore. Signed-off-by: Stephen Hemminger --- doc/guides/rel_notes/deprecation.rst | 17 + 1 file changed, 17 insertions(+) diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst i

[dpdk-dev] [PATCH v2 20.08 5/6] rte_ethdev: change comment to rte_dev_eth_mac_addr_add

2020-07-29 Thread Stephen Hemminger
The comment used the term whitelist and was awkardly written. Replace it with simpler direct description of adding a new address. No code or API changes for this. Signed-off-by: Stephen Hemminger Acked-by: Luca Boccassi --- lib/librte_ethdev/rte_ethdev.h | 3 +-- 1 file changed, 1 insertion(+),

[dpdk-dev] [PATCH v2 20.08 0/6] inclusive language fixes and deprecation notices

2020-07-29 Thread Stephen Hemminger
This set annonuces the upcoming changes for 20.11 around master/slave and blacklist/whitelist. It also fixes several places in the current code where the wrong and confusing terminolgy was used. v2 - fix wording and checkpatch about whitespace Stephen Hemminger (6): doc: announce deprecation of

[dpdk-dev] [PATCH v2 20.08 4/6] doc: announce deprecation blacklist/whitelist

2020-07-29 Thread Stephen Hemminger
Announce upcoming changes for 20.11. Signed-off-by: Stephen Hemminger --- doc/guides/rel_notes/deprecation.rst | 21 + 1 file changed, 21 insertions(+) diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst index 7c60779f3e68..abfec0aeaa4b

[dpdk-dev] [PATCH v2 20.08 3/6] doc: fix incorrect reference to master process

2020-07-29 Thread Stephen Hemminger
Correct terminolgy here is primary process. This is a bug in original doc. Fixes: fc1f2750a3ec ("doc: programmers guide") Signed-off-by: Stephen Hemminger Acked-by: Anatoly Burakov --- doc/guides/prog_guide/thread_safety_dpdk_functions.rst | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(

Re: [dpdk-dev] [PATCH v2] net/kni: set packet input port in Rx

2020-07-29 Thread Ferruh Yigit
On 7/29/2020 6:06 PM, Ferruh Yigit wrote: > On 7/29/2020 6:02 PM, David Marchand wrote: >> On Fri, Jul 24, 2020 at 5:10 PM Ferruh Yigit wrote: >>> >>> From: jiancheng pei >>> >>> Store port_id in pmd_internals when eth kni device is created. >>> Then set packet port of rte_mbuf in function eth_kn

Re: [dpdk-dev] [PATCH] net/bnxt: remove EEM system memory support

2020-07-29 Thread Ferruh Yigit
On 7/29/2020 10:24 PM, Ajit Khaparde wrote: > > > On Wed, Jul 29, 2020 at 9:25 AM Ferruh Yigit > wrote: > > On 7/29/2020 1:42 AM, Ajit Khaparde wrote: > > From: Randy Schacher > > > > > Remove the memory ma

Re: [dpdk-dev] [PATCH v1 2/2] test/ring: fix wrong param passed to the enqueue APIs

2020-07-29 Thread Honnappa Nagarahalli
> > > > On Wed, Jul 29, 2020 at 4:16 PM Feifei Wang > > wrote: > > > > Are we missing a check in the UT so that dequeued object is what > > > > had been enqueued? Yes, missing for single element enqueue/dequeue > > > > > > > > > > > Dequeue is not necessary to change because the param defined i

Re: [dpdk-dev] [PATCH v1 1/2] ring: fix the misdescription of the param

2020-07-29 Thread Honnappa Nagarahalli
> Subject: RE: [dpdk-dev] [PATCH v1 1/2] ring: fix the misdescription of the > param > > > > > > > When enqueue one element to the ring, the param "obj" should be the > > > object to be added into the ring. The object is of type void*. > > > > I understand void * as a pointer to an object you do

Re: [dpdk-dev] Queue Management Support in DPDK

2020-07-29 Thread Stephen Hemminger
On Thu, 30 Jul 2020 00:07:29 +0530 Archit Pandey wrote: > Hello everyone, > > We have been using DPDK's QoS framework over the last year and found > that rte_sched and the provided qos_sched app work great for QoS. > > However, when we ventured into trying to add CoDel (to replace RED) as > a d

Re: [dpdk-dev] long initialization time for EAL init

2020-07-29 Thread Balaji K N
Hello, I tried by disabling mlockall and not do see long time for EAL init and is done quickly. Thanks for help. ovs-vswitchd unix:/var/run/openvswitch/db.sock -vconsole:emer -vsyslog:err -vfile:info --no-chdir --log-file=/var/log/openvswitch/ovs-vswitchd.log --pidfile=/var/run/openvswitch/ovs

Re: [dpdk-dev] [PATCH 14/27] event/dlb: add PMD self-tests

2020-07-29 Thread McDaniel, Timothy
>-Original Message- >From: Eads, Gage >Sent: Friday, July 10, 2020 3:43 PM >To: McDaniel, Timothy ; jer...@marvell.com >Cc: mattias.ronnb...@ericsson.com; dev@dpdk.org; Van Haaren, Harry > >Subject: RE: [PATCH 14/27] event/dlb: add PMD self-tests > >Hi Tim, > >> +#include >> +#include >>

[dpdk-dev] Queue Management Support in DPDK

2020-07-29 Thread Archit Pandey
Hello everyone, We have been using DPDK's QoS framework over the last year and found that rte_sched and the provided qos_sched app work great for QoS. However, when we ventured into trying to add CoDel (to replace RED) as a dropper to the framework, we faced several challenges due to how tightly

[dpdk-dev] [PATCH 4/4] net/bnxt: fix vfrep port add when it's endpoint interface is down

2020-07-29 Thread Somnath Kotur
From: Venkat Duvvuru While adding vfrep port to OVS bridge, vnic & svif information of vfrep's endpoint(VF) would be needed to program default flow rules. However, if the endpoint interface is down when vfrep port is added, firmware will return invalid vnic & svif information. This patch fixes t

[dpdk-dev] [PATCH v4] app/test-regex: add RegEx test application

2020-07-29 Thread Ori Kam
From: Yuval Avnery Following the new RegEx class. There is a need to create a dedicated test application in order to validate this class and PMD. Unlike net device this application loads data from a file. This commit introduces the new RegEx test app. The basic app flow: 1. Configure the RegEx

[dpdk-dev] [PATCH 0/4] bnxt patches

2020-07-29 Thread Somnath Kotur
fixes and cleanups in bnxt TRUFlow Kishore Padmanabha (2): net/bnxt: configure loopback parif for full offload egress flows net/bnxt: enable lookup default action record parif entry Somnath Kotur (1): net/bnxt: cleanups and checks for ulp context allocation Venkat Duvvuru (1): net/bnxt:

[dpdk-dev] [PATCH 2/4] net/bnxt: enable lookup default action record parif entry

2020-07-29 Thread Somnath Kotur
From: Kishore Padmanabha The lookup default action record parif table is updated to catch the miss path for the entries in the exact match table. Fixes: fe82f3e02701 ("net/bnxt: support exact match templates") Signed-off-by: Kishore Padmanabha Reviewed-by: Shahaji Bhosle Reviewed-by: Michael

[dpdk-dev] [PATCH 3/4] net/bnxt: cleanups and checks for ulp context allocation

2020-07-29 Thread Somnath Kotur
Set ulp_ctx explicitly to NULL in ulp_ctx_deinit() so that representor init is aborted if parent ulp context is not initialized. Also check for the same before creation of port default rules. Additional checks in VF rep dev ops for proper parent dev initialization Fixes: 322bd6e70272 ("net/bnxt: a

[dpdk-dev] [PATCH 1/4] net/bnxt: configure loopback parif for full offload egress flows

2020-07-29 Thread Somnath Kotur
From: Kishore Padmanabha The full offload egress flows for the VF rep interface should use loopback parif to offload missed flows. Fixes: fe82f3e02701 ("net/bnxt: support exact match templates") Signed-off-by: Kishore Padmanabha Reviewed-by: Shahaji Bhosle --- drivers/net/bnxt/tf_ulp/ulp_rte

[dpdk-dev] [PATCH 1/4] net/bnxt: configure loopback parif for full offload egress flows

2020-07-29 Thread Somnath Kotur
From: Kishore Padmanabha The full offload egress flows for the VF rep interface should use loopback parif to offload missed flows. Fixes: fe82f3e02701 ("net/bnxt: support exact match templates") Signed-off-by: Kishore Padmanabha Reviewed-by: Shahaji Bhosle --- drivers/net/bnxt/tf_ulp/ulp_rte

[dpdk-dev] [PATCH 0/4] bnxt patches

2020-07-29 Thread Somnath Kotur
fixes and cleanups in bnxt TRUFlow Kishore Padmanabha (2): net/bnxt: configure loopback parif for full offload egress flows net/bnxt: enable lookup default action record parif entry Somnath Kotur (1): net/bnxt: cleanups and checks for ulp context allocation Venkat Duvvuru (1): net/bnxt:

Re: [dpdk-dev] [PATCH] net/bnxt: remove EEM system memory support

2020-07-29 Thread Ajit Khaparde
On Tue, Jul 28, 2020 at 5:43 PM Ajit Khaparde wrote: > From: Randy Schacher > > Remove the memory management scheme for Extended Exact Match > using system memory. Using host memory scheme instead which > was the default anyway. > > Fixes: b2da02480cb7 ("net/bnxt: support EEM system memory") > >

Re: [dpdk-dev] [PATCH v2] net/kni: set packet input port in Rx

2020-07-29 Thread Ferruh Yigit
On 7/29/2020 6:02 PM, David Marchand wrote: > On Fri, Jul 24, 2020 at 5:10 PM Ferruh Yigit wrote: >> >> From: jiancheng pei >> >> Store port_id in pmd_internals when eth kni device is created. >> Then set packet port of rte_mbuf in function eth_kni_rx. > > LGTM. > > Is this fix worth a backport

Re: [dpdk-dev] [PATCH v2] net/kni: set packet input port in Rx

2020-07-29 Thread David Marchand
On Fri, Jul 24, 2020 at 5:10 PM Ferruh Yigit wrote: > > From: jiancheng pei > > Store port_id in pmd_internals when eth kni device is created. > Then set packet port of rte_mbuf in function eth_kni_rx. LGTM. Is this fix worth a backport? A net driver is expected to set the port in all mbufs (m-

Re: [dpdk-dev] [PATCH] net/bnxt: remove EEM system memory support

2020-07-29 Thread Ferruh Yigit
On 7/29/2020 1:42 AM, Ajit Khaparde wrote: > From: Randy Schacher > > Remove the memory management scheme for Extended Exact Match > using system memory. Using host memory scheme instead which > was the default anyway. > > Fixes: b2da02480cb7 ("net/bnxt: support EEM system memory") > > Signed-o

Re: [dpdk-dev] [PATCH v1 1/2] ring: fix the misdescription of the param

2020-07-29 Thread Ananyev, Konstantin
> > > > When enqueue one element to the ring, the param "obj" should be the > > object to be added into the ring. The object is of type void*. > > I understand void * as a pointer to an object you don't know the type of. > I would keep the current description. > > Honnappa, Konstantin, Olivier ?

Re: [dpdk-dev] [PATCH] [RFC] cryptodev: move AES-GMAC to aead algorithms

2020-07-29 Thread Trahe, Fiona
Hi Arek, Small typo below. > -Original Message- > From: Kusztal, ArkadiuszX > Sent: Wednesday, July 29, 2020 3:22 PM > To: dev@dpdk.org > Cc: akhil.go...@nxp.com; Trahe, Fiona ; > ano...@marvell.com; > shal...@marvell.com; Doherty, Declan ; Zhang, Roy > Fan > ; Ananyev, Konstantin > ;

Re: [dpdk-dev] [PATCH v2] app/crypto-perf: support security protocol in PMDCC mode

2020-07-29 Thread Akhil Goyal
> > > > This patch adds support for DOCSIS and PDCP security protocols to the > > pmd-cyclecount mode of the crypto performance tool. Adding this support > > involves freeing the correct session type (i.e. security or cryptodev > > session) when the test ends, depending on the op_type specified. >

Re: [dpdk-dev] [PATCH v1] app/crypto-perf: set mbuf lengths correctly for DOCSIS tests

2020-07-29 Thread Akhil Goyal
> Hi Pablo/David, > > > > Hi David, > > > > > Hi Pablo, > > > > > > > -Original Message- > > > > From: De Lara Guarch, Pablo > > > > Sent: Friday, July 17, 2020 8:04 PM > > > > > @@ -48,6 +48,10 @@ cperf_set_ops_security(struct rte_crypto_op > **ops, > > > > > } else

Re: [dpdk-dev] [PATCH v2 1/1] net: fix TSO packets checksum incorrect

2020-07-29 Thread Andrew Rybchenko
On 7/29/20 10:49 AM, Olivier Matz wrote: > On Tue, Jul 28, 2020 at 05:09:50PM +, Yuying Zhang wrote: >> The ol_flags check lacks of flag for IPv6 which causes checksum >> flag configuration error while IPv6/TCP TSO packet is sent. >> This patch fixes the issue by adding PKT_TX_TCP_SEG flag. >

Re: [dpdk-dev] [PATCH v1 1/2] ring: fix the misdescription of the param

2020-07-29 Thread David Marchand
On Wed, Jul 29, 2020 at 8:31 AM Feifei Wang wrote: > > When enqueue one element to the ring, the param "obj" should be the > object to be added into the ring. The object is of type void*. I understand void * as a pointer to an object you don't know the type of. I would keep the current descriptio

Re: [dpdk-dev] [PATCH v1] net: fix TSO packet checksum incorrect

2020-07-29 Thread Andrew Rybchenko
On 7/28/20 12:29 PM, Olivier Matz wrote: > Hi, > > On Tue, Jul 28, 2020 at 08:55:31AM +, Yuying Zhang wrote: >> The ol_flags check lacks of PKT_TX_IPV6 which causes checksum >> flag configuration error while IPv6/TCP TSO packet is sent. >> This patch fixes the issue using PKT_TX_OFFLOAD_MASK.

Re: [dpdk-dev] Userspace testing

2020-07-29 Thread Burakov, Anatoly
On 29-Jul-20 3:34 PM, Owen Hilyard wrote: Hello all, I was wondering what everyone's thoughts on doing both userspace testing and unprivileged testing of dpdk applications is. DTS currently runs all commands on the tester and the dut as the root user. Please correct me if I'm wrong, but I was un

Re: [dpdk-dev] [PATCH] [RFC] doc: announce removal of crypto list end enumerators

2020-07-29 Thread Trahe, Fiona
Hi David, > -Original Message- > From: David Marchand > Sent: Wednesday, July 29, 2020 4:24 PM > To: Kusztal, ArkadiuszX > Cc: dev ; Akhil Goyal ; Trahe, Fiona > ; > Anoob Joseph ; shal...@marvell.com; Doherty, Declan > ; Zhang, Roy Fan ; > Ananyev, Konstantin > > Subject: Re: [dpdk-d

Re: [dpdk-dev] [PATCH v2] app/testpmd: fix txonly mode timestamp intitialization

2020-07-29 Thread Ferruh Yigit
On 7/29/2020 3:07 PM, Phil Yang wrote: >> -Original Message- >> From: Viacheslav Ovsiienko >> Sent: Wednesday, July 29, 2020 8:30 PM >> To: dev@dpdk.org >> Cc: ma...@mellanox.com; rasl...@mellanox.com; tho...@monjalon.net; >> ferruh.yi...@intel.com; Phil Yang >> Subject: [PATCH v2] app/te

Re: [dpdk-dev] [PATCH] [RFC] doc: announce removal of crypto list end enumerators

2020-07-29 Thread David Marchand
On Wed, Jul 29, 2020 at 4:47 PM Arek Kusztal wrote: > > Enumerators RTE_CRYPTO_CIPHER_LIST_END, RTE_CRYPTO_AUTH_LIST_END, > RTE_CRYPTO_AEAD_LIST_END will be removed to prevent some problems > that may arise when adding new algorithms. How does it cohabitate with Ferruh notice? Is it a complement?

Re: [dpdk-dev] [PATCH] [RFC] doc: announce removal of crypto list end enumerators

2020-07-29 Thread Trahe, Fiona
> -Original Message- > From: Kusztal, ArkadiuszX > Sent: Wednesday, July 29, 2020 3:47 PM > To: dev@dpdk.org > Cc: akhil.go...@nxp.com; Trahe, Fiona ; > ano...@marvell.com; > shal...@marvell.com; Doherty, Declan ; Zhang, Roy > Fan > ; Ananyev, Konstantin > ; Kusztal, ArkadiuszX > >

Re: [dpdk-dev] [PATCH] [RFC] doc: announce removal of crypto list end enumerators

2020-07-29 Thread Bruce Richardson
On Wed, Jul 29, 2020 at 04:46:51PM +0200, Arek Kusztal wrote: > Enumerators RTE_CRYPTO_CIPHER_LIST_END, RTE_CRYPTO_AUTH_LIST_END, > RTE_CRYPTO_AEAD_LIST_END will be removed to prevent some problems > that may arise when adding new algorithms. > > Signed-off-by: Arek Kusztal Since these seem to c

Re: [dpdk-dev] [PATCH] common/mlx5: fix MAC addresses flush

2020-07-29 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Shiri Kuzin > Sent: Wednesday, July 29, 2020 5:29 PM > To: dev@dpdk.org > Cc: Matan Azrad ; Raslan Darawsheh > ; Ori Kam ; Slava Ovsiienko > ; sta...@dpdk.org > Subject: [PATCH] common/mlx5: fix MAC addresses flush > > mlx5_nl_mac_addr_flush should flush

[dpdk-dev] 回复: [PATCH v1 2/2] test/ring: fix wrong param passed to the enqueue APIs

2020-07-29 Thread Feifei Wang
> -邮件原件- > 发件人: David Marchand > 发送时间: 2020年7月29日 22:21 > 收件人: Feifei Wang > 抄送: Honnappa Nagarahalli ; Konstantin > Ananyev ; Gavin Hu ; > Olivier Matz ; dev ; nd > ; dpdk stable > 主题: Re: [dpdk-dev] [PATCH v1 2/2] test/ring: fix wrong param passed to the > enqueue APIs > > On Wed, J

Re: [dpdk-dev] [PATCH] common/mlx5: fix user mode register access command

2020-07-29 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Viacheslav Ovsiienko > Sent: Wednesday, July 29, 2020 3:29 PM > To: dev@dpdk.org > Cc: Matan Azrad ; Raslan Darawsheh > ; Dekel Peled > Subject: [PATCH] common/mlx5: fix user mode register access command > > To detect the timestamp mode configured on the

Re: [dpdk-dev] [PATCH v1] common/mlx5: fix set regex register layout

2020-07-29 Thread Raslan Darawsheh
Hi, > -Original Message- > From: dev On Behalf Of Yuval Avnery > Sent: Tuesday, July 28, 2020 8:51 PM > To: Matan Azrad ; Shahaf Shuler > ; Slava Ovsiienko > Cc: Thomas Monjalon ; dev@dpdk.org; Yuval > Avnery ; Ori Kam > Subject: [dpdk-dev] [PATCH v1] common/mlx5: fix set regex register

Re: [dpdk-dev] [PATCH v2] regex/mlx5: fix sq free check on enqueue

2020-07-29 Thread Thomas Monjalon
29/07/2020 04:14, Yuval Avnery: > Free sq check had a bug, causing jobs to overwrite. Reworded with Ori's help: regex/mlx5: fix overrun on enqueueing When enqueueing a buffer the PMD check if there is room in its send queue (SQ). The current implementation did not take into a

Re: [dpdk-dev] DPDK PDUMP Issue

2020-07-29 Thread Dikshant Chitkara
Hi Vipin, Here is full log with include option and build with make -n option from master makefile as well: make[2]: Entering directory `/mnt/data/dchitkara/PHY5G/Prototype/NR_5G_SIM/Tests/COMMON/PACKET_GENERATOR' echo ./packet_generator.cc -msse4.1 -I../../../COMMON/Sys_API/Math_API/ -I../.

Re: [dpdk-dev] [PATCH v5] vhost: fix async copy fail on multi-page buffers

2020-07-29 Thread Maxime Coquelin
On 7/29/20 4:04 AM, Patrick Fu wrote: > Async copy fails when single ring buffer vector is splited on multiple > physical pages. This happens because current hpa address translation > function doesn't handle multi-page buffers. A new gpa to hpa address > conversion function, which returns the hp

Re: [dpdk-dev] DPDK PDUMP Issue

2020-07-29 Thread Dikshant Chitkara
Hi Vipin, I tried using `-Wl,--whole-archive` and `-Wl,--no-whole-archive ` option with my necessary libraries but it does not seem to help as well. Below is the makefile log for my app: g++ -shared -Wl,--export-dynamic packet_generator.o -L/mnt/data/dchitkara/DPDK_2020_01_30_x86/x86_64-nati

Re: [dpdk-dev] [PATCH v1] net/virtio-user: fix return value check

2020-07-29 Thread Maxime Coquelin
On 7/29/20 3:12 PM, Chenbo Xia wrote: > Setting the flags of tapfd may fail and the return value > should be checked. > > Coverity issue: 140739 > Fixes: e3b434818bbb ("net/virtio-user: support kernel vhost") > Cc: sta...@dpdk.org > > Signed-off-by: Chenbo Xia > --- > drivers/net/virtio/virt

Re: [dpdk-dev] [PATCH v4 0/3] Fix Vhost regressions

2020-07-29 Thread Maxime Coquelin
On 7/29/20 3:36 PM, Maxime Coquelin wrote: > This series aims at fixing the regressions reported by Intel QE. > I managed to reproduce the issues, and this series fixes them. > > The two first patches fix the performance regression. They have > been tested by intel QE which confirms the fix. >

Re: [dpdk-dev] [PATCH] [RFC] doc: announce removal of crypto list end enumerators

2020-07-29 Thread Kusztal, ArkadiuszX
Hi All, This is proposal to remove list_end enumerators from algorithms enums. I do not expect many changes in current list of algorithms but it may happen (ChachaPoly in 20.02, GMAC move to AEAD proposal) so relying on list_end enumerator may be incorrect approach as this value may change acros

Re: [dpdk-dev] [dpdk-stable] [PATCH v4] lib/table: fix cache alignment issue

2020-07-29 Thread Dumitrescu, Cristian
> -Original Message- > From: David Marchand > Sent: Wednesday, July 29, 2020 3:00 PM > To: Dumitrescu, Cristian > Cc: Xu, Ting ; dev ; dpdk stable > ; Kevin Traynor ; Luca Boccassi > > Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH v4] lib/table: fix cache > alignment issue > > On Wed,

[dpdk-dev] [PATCH] [RFC] doc: announce removal of crypto list end enumerators

2020-07-29 Thread Arek Kusztal
Enumerators RTE_CRYPTO_CIPHER_LIST_END, RTE_CRYPTO_AUTH_LIST_END, RTE_CRYPTO_AEAD_LIST_END will be removed to prevent some problems that may arise when adding new algorithms. Signed-off-by: Arek Kusztal --- doc/guides/rel_notes/deprecation.rst | 6 ++ 1 file changed, 6 insertions(+) diff --

Re: [dpdk-dev] [PATCH] [RFC] cryptodev: move AES-GMAC to aead algorithms

2020-07-29 Thread Kusztal, ArkadiuszX
Hi All, I would give bit more introduction to this change: Right now AES-GMAC is auth only algorithm (previously it was cipher+auth -> GCM + GMAC), but since it is variant of AES-GCM implementation it should probably be AEAD right now (people often wondering why at all it is auth instead of AEAD

[dpdk-dev] Userspace testing

2020-07-29 Thread Owen Hilyard
Hello all, I was wondering what everyone's thoughts on doing both userspace testing and unprivileged testing of dpdk applications is. DTS currently runs all commands on the tester and the dut as the root user. Please correct me if I'm wrong, but I was under the assumption that most applications wr

Re: [dpdk-dev] [PATCH v3 1/8] net/dpaa: add support for fmlib in dpdk

2020-07-29 Thread Kevin Traynor
Hi Hemant, On 29/07/2020 07:39, Hemant Agrawal wrote: > Hi David > >> -Original Message- >> From: David Marchand >> Sent: Tuesday, July 28, 2020 7:12 PM >> To: Hemant Agrawal >> Cc: Thomas Monjalon ; Sachin Saxena >> ; dev@dpdk.org; Ferruh Yigit >> ; techbo...@dpdk.org >> Subject: Re: [

[dpdk-dev] [PATCH] common/mlx5: fix MAC addresses flush

2020-07-29 Thread Shiri Kuzin
mlx5_nl_mac_addr_flush should flush all allocated MAC addresses. The MAC addresses array size should be of size MLX5_MAX_MAC_ADDRESSES, but currently we return without flushing the addresses if size is MLX5_MAX_MAC_ADDRESSES. This was fixed by not allowing an array larger than MLX5_MAX_MAC_ADDRES

[dpdk-dev] [Bug 518] Disabling a VF with XL710 still sees the traffic and the link is still high

2020-07-29 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=518 Bug ID: 518 Summary: Disabling a VF with XL710 still sees the traffic and the link is still high Product: DPDK Version: 18.05 Hardware: x86 OS: Linux Sta

Re: [dpdk-dev] [PATCH v5] vhost: fix async copy fail on multi-page buffers

2020-07-29 Thread Maxime Coquelin
On 7/29/20 4:04 AM, Patrick Fu wrote: > Async copy fails when single ring buffer vector is splited on multiple > physical pages. This happens because current hpa address translation > function doesn't handle multi-page buffers. A new gpa to hpa address > conversion function, which returns the hp

Re: [dpdk-dev] [PATCH v1] net/virtio-user: fix return value check

2020-07-29 Thread Maxime Coquelin
On 7/29/20 3:12 PM, Chenbo Xia wrote: > Setting the flags of tapfd may fail and the return value > should be checked. > > Coverity issue: 140739 > Fixes: e3b434818bbb ("net/virtio-user: support kernel vhost") > Cc: sta...@dpdk.org > > Signed-off-by: Chenbo Xia > --- > drivers/net/virtio/virt

[dpdk-dev] [PATCH] [RFC] cryptodev: move AES-GMAC to aead algorithms

2020-07-29 Thread Arek Kusztal
This is proposal to move AES-GMAC algorithm to AEAD set of algorithms. It is however not 100% conformant GMAC as instead of aad pointer data to be authenticated is passed normally and aead.data.length field is used to specify length of data to be authenticated. Reason behind this move is that GMAC

Re: [dpdk-dev] [PATCH v1 2/2] test/ring: fix wrong param passed to the enqueue APIs

2020-07-29 Thread David Marchand
On Wed, Jul 29, 2020 at 4:16 PM Feifei Wang wrote: > > Are we missing a check in the UT so that dequeued object is what had been > > enqueued? > > > > > Dequeue is not necessary to change because the param defined in > rte_ring_dequeue > is different from that in rte_ring_enqueue: > rte_ring_enqu

Re: [dpdk-dev] [PATCH v4 3/3] net/vhost: fix interrupt mode

2020-07-29 Thread Xia, Chenbo
> -Original Message- > From: Maxime Coquelin > Sent: Wednesday, July 29, 2020 9:36 PM > To: dev@dpdk.org; ma...@mellanox.com; Xia, Chenbo > ; Liu, Yong ; Wang, Yinan > > Cc: tho...@monjalon.net; Yigit, Ferruh ; > david.march...@redhat.com; Maxime Coquelin > > Subject: [PATCH v4 3/3] ne

[dpdk-dev] 回复: [PATCH v1 2/2] test/ring: fix wrong param passed to the enqueue APIs

2020-07-29 Thread Feifei Wang
Hi, David > -邮件原件- > 发件人: David Marchand > 发送时间: 2020年7月29日 21:48 > 收件人: Feifei Wang > 抄送: Honnappa Nagarahalli ; Konstantin > Ananyev ; Gavin Hu ; > Olivier Matz ; dev ; nd > ; dpdk stable > 主题: Re: [dpdk-dev] [PATCH v1 2/2] test/ring: fix wrong param passed to the > enqueue APIs > >

Re: [dpdk-dev] [PATCH] regex/mlx5: fix registration name

2020-07-29 Thread David Marchand
On Wed, Jul 29, 2020 at 4:10 PM Thomas Monjalon wrote: > > 29/07/2020 16:01, Ori Kam: > > The current registration name has the net prefix, which is incorrect. > > This commit removes the net and changes the name to be regex_mlx5. > > It was offlist, but Reported-by: David Marchand > > Signed-

Re: [dpdk-dev] [PATCH] bus/vmbus: use SMP memory barrier for signaling read

2020-07-29 Thread Thomas Monjalon
17/07/2020 22:18, Long Li: > From: Long Li > > rte_smp_mb() uses the same locked ADD as the in-kernel vmbus driver, > and it has slightly performance improvement over rte_mb(). > > Signed-off-by: Long Li Applied, thanks

Re: [dpdk-dev] [PATCH] regex/mlx5: fix registration name

2020-07-29 Thread Thomas Monjalon
29/07/2020 16:01, Ori Kam: > The current registration name has the net prefix, which is incorrect. > This commit removes the net and changes the name to be regex_mlx5. > > Signed-off-by: Ori Kam > --- > drivers/regex/mlx5/mlx5_regex.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-)

Re: [dpdk-dev] [PATCH v2] app/testpmd: fix txonly mode timestamp intitialization

2020-07-29 Thread Phil Yang
> -Original Message- > From: Viacheslav Ovsiienko > Sent: Wednesday, July 29, 2020 8:30 PM > To: dev@dpdk.org > Cc: ma...@mellanox.com; rasl...@mellanox.com; tho...@monjalon.net; > ferruh.yi...@intel.com; Phil Yang > Subject: [PATCH v2] app/testpmd: fix txonly mode timestamp intitializati

[dpdk-dev] [PATCH] power: fix current frequency index

2020-07-29 Thread Reshma Pattan
1) During power initialization the pstate cpufreq api is not setting the initial curr_idx of pstate_power_info to corresponding current frequency index. Without this the idx is always 0, which is causing the below check to pass and returns without setting the initial min/max frequency to system ma

[dpdk-dev] [PATCH] regex/mlx5: fix registration name

2020-07-29 Thread Ori Kam
The current registration name has the net prefix, which is incorrect. This commit removes the net and changes the name to be regex_mlx5. Signed-off-by: Ori Kam --- drivers/regex/mlx5/mlx5_regex.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/regex/mlx5/mlx5_re

Re: [dpdk-dev] [dpdk-stable] [PATCH v4] lib/table: fix cache alignment issue

2020-07-29 Thread David Marchand
On Wed, Jul 29, 2020 at 3:54 PM Dumitrescu, Cristian wrote: > > -Original Message- > > From: David Marchand > > Sent: Wednesday, July 29, 2020 2:28 PM > > To: Dumitrescu, Cristian > > Cc: Xu, Ting ; dev ; dpdk stable > > ; Kevin Traynor ; Luca Boccassi > > > > Subject: Re: [dpdk-stable]

[dpdk-dev] [PATCH] net/netvsc: fix seg fault during transmit

2020-07-29 Thread Chas Williams
Commit cc0251813277 ("net/netvsc: split send buffers from Tx descriptors") changed the way that transmit descriptors are allocated. They come from a single pool instead of being individually attached to each mbuf. To find the IOVA, you need to calculate the offset from the base of the pool. Fixes:

Re: [dpdk-dev] [PATCH v3] app/test-regex: add RegEx test application

2020-07-29 Thread Thomas Monjalon
29/07/2020 13:26, Ori Kam: > --- /dev/null > +++ b/app/test-regex/Makefile > @@ -0,0 +1,21 @@ > +# SPDX-License-Identifier: BSD-3-Clause > +# Copyright 2020 Mellanox Technologies, Ltd > + > +include $(RTE_SDK)/mk/rte.vars.mk > + > +# > +# library name It's not a library. You can completely drop th

Re: [dpdk-dev] [dpdk-stable] [PATCH v4] lib/table: fix cache alignment issue

2020-07-29 Thread Dumitrescu, Cristian
> -Original Message- > From: David Marchand > Sent: Wednesday, July 29, 2020 2:28 PM > To: Dumitrescu, Cristian > Cc: Xu, Ting ; dev ; dpdk stable > ; Kevin Traynor ; Luca Boccassi > > Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH v4] lib/table: fix cache > alignment issue > > On Wed,

Re: [dpdk-dev] [PATCH v1 2/2] test/ring: fix wrong param passed to the enqueue APIs

2020-07-29 Thread David Marchand
Hello Feifei, On Wed, Jul 29, 2020 at 8:32 AM Feifei Wang wrote: > > When enqueue one element (object of type void*) to ring in the > performance test, a pointer (the object to be enqueued) should be > passed to rte_ring_[sp|mp]enqueue APIs, not the pointer to a table > of void *pointers (objects

[dpdk-dev] [PATCH v4 3/3] net/vhost: fix interrupt mode

2020-07-29 Thread Maxime Coquelin
At .new_device() time, only the first vring pair is now ready, other vrings are configured later. Problem is that when application will setup and enable interrupts, only the first queue pair Rx interrupt will be enabled. This patches fixes the issue by setting the number of max interrupts to the

[dpdk-dev] [PATCH v4 2/3] net/vhost: fix queue update

2020-07-29 Thread Maxime Coquelin
Now that the vhost library saves the guest notifications enablement value in its virtqueues metadata, it is not necessary to do it in the vring_state_changed callback. One effect of the patch is also to prevent possible deadlock happening in vhost library. Fixes: 604052ae5395 ("net/vhost: support

[dpdk-dev] [PATCH v4 0/3] Fix Vhost regressions

2020-07-29 Thread Maxime Coquelin
This series aims at fixing the regressions reported by Intel QE. I managed to reproduce the issues, and this series fixes them. The two first patches fix the performance regression. They have been tested by intel QE which confirms the fix. Patch 3 aims at fixing interrupt mode. In this v4, only

[dpdk-dev] [PATCH v4 1/3] vhost: fix guest notification setting

2020-07-29 Thread Maxime Coquelin
If rte_vhost_enable_guest_notification is called before the virtqueue is ready, the configuration is lost. This patch fixes this by saving the guest notification enablement value requested by the application, and apply it before the virtqueue is made ready to the application. Fixes: 604052ae5395

Re: [dpdk-dev] [pull-request] next-crypto 20.08 rc3

2020-07-29 Thread Thomas Monjalon
28/07/2020 22:14, Akhil Goyal: > http://dpdk.org/git/next/dpdk-next-crypto Pulled, thanks Please be more careful on quality of QuickAssist patches.

Re: [dpdk-dev] [dpdk-stable] [PATCH v4] lib/table: fix cache alignment issue

2020-07-29 Thread David Marchand
On Wed, Jul 29, 2020 at 3:14 PM Dumitrescu, Cristian wrote: > > Please correct me if I am wrong, but it simply means this part of the > > table library never worked for 32-bit. > > It seems more adding 32-bit support rather than a fix and then I > > wonder if it has its place in rc3. > > > > Funct

Re: [dpdk-dev] [PATCH v3 3/3] net/vhost: fix interrupt mode

2020-07-29 Thread Maxime Coquelin
On 7/29/20 3:24 PM, Xia, Chenbo wrote: > Hi Maxime, > >> -Original Message- >> From: Maxime Coquelin >> Sent: Wednesday, July 29, 2020 8:54 PM >> To: dev@dpdk.org; ma...@mellanox.com; Xia, Chenbo >> ; Liu, Yong ; Wang, Yinan >> >> Cc: tho...@monjalon.net; Yigit, Ferruh ; >> david.marc

Re: [dpdk-dev] [PATCH v3 3/3] net/vhost: fix interrupt mode

2020-07-29 Thread Xia, Chenbo
Hi Maxime, > -Original Message- > From: Maxime Coquelin > Sent: Wednesday, July 29, 2020 8:54 PM > To: dev@dpdk.org; ma...@mellanox.com; Xia, Chenbo > ; Liu, Yong ; Wang, Yinan > > Cc: tho...@monjalon.net; Yigit, Ferruh ; > david.march...@redhat.com > Subject: Re: [PATCH v3 3/3] net/vhos

Re: [dpdk-dev] [PATCH] common/qat: fix uninitialized variable bug

2020-07-29 Thread Thomas Monjalon
26/07/2020 21:19, Akhil Goyal: > > > > > > [Adam] The ret variable value (signed) is not returned directly, please > > > check the > > rest of this function in src > > > code. This is just checked to calculate how many ops were enqueued. And > > > if all > > checks skip (meaning the > > > op was

Re: [dpdk-dev] [PATCH v3 3/3] net/vhost: fix interrupt mode

2020-07-29 Thread Maxime Coquelin
On 7/29/20 1:27 PM, David Marchand wrote: > On Wed, Jul 29, 2020 at 11:20 AM Maxime Coquelin > wrote: >> >> At .new_device() time, only the first vring pair is >> now ready, other vrings are consfigured later. > > configured* > >> >> Problem is that when application will setup and enable >> i

Re: [dpdk-dev] [PATCH v4] lib/table: fix cache alignment issue

2020-07-29 Thread Dumitrescu, Cristian
> -Original Message- > From: David Marchand > Sent: Wednesday, July 29, 2020 1:01 PM > To: Xu, Ting ; Dumitrescu, Cristian > > Cc: dev ; dpdk stable > Subject: Re: [dpdk-dev] [PATCH v4] lib/table: fix cache alignment issue > > On Wed, Jul 22, 2020 at 4:13 AM Ting Xu wrote: > > > > Wh

Re: [dpdk-dev] [dpdk-dev v1] net/ice: fix gtpu teid hash

2020-07-29 Thread Zhang, Qi Z
> -Original Message- > From: Guo, Jia > Sent: Tuesday, July 28, 2020 5:21 PM > To: Zhang, Qi Z ; Yang, Qiming > Cc: dev@dpdk.org; Su, Simei ; Guo, Jia > > Subject: [dpdk-dev v1] net/ice: fix gtpu teid hash > > Refine gtpu teid hash rule mapping for > GTPU_IP/GTPU_EH/GTPU_DWN/GTPU_UP.

Re: [dpdk-dev] [PATCH v3 3/3] net/vhost: fix interrupt mode

2020-07-29 Thread Maxime Coquelin
On 7/29/20 11:20 AM, Maxime Coquelin wrote: > At .new_device() time, only the first vring pair is > now ready, other vrings are consfigured later. > > Problem is that when application will setup and enable > interrupts, only the first queue pair Rx interrupt will > be enabled. > > This patches

[dpdk-dev] long initialization time for EAL init

2020-07-29 Thread Balaji K N
Hello, We are using OVS 2.12.0 with DPDK 18.11.2 release on Ubuntu 16.04 LTS. We do observe long initialization time for EAL init ( ~10 seconds for EAL memory initialization). Below is our hardware and memory configuration Hardware : Dell Server Sockets(NUMA) : 2

  1   2   >