hi, yunjian
The patch seems no problem, but when you update your patch, please add
other guys who had comment on your patch and maintainer to see if they have
other opinion, and --in-reply-to is also helpful for patch review, thanks.
On 7/29/2020 7:47 PM, wangyunjian wrote:
Ping for review.
Thanks,
Yunjian
-----Original Message-----
From: wangyunjian
Sent: Friday, July 3, 2020 5:46 PM
To: dev@dpdk.org
Cc: jia....@intel.com; Lilijun (Jerry) <jerry.lili...@huawei.com>; xudingke
<xudin...@huawei.com>; wangyunjian <wangyunj...@huawei.com>;
sta...@dpdk.org
Subject: [dpdk-dev] [PATCH v4 1/3] eal: fix memory leak when removing
event_cb
From: Yunjian Wang <wangyunj...@huawei.com>
The event_cb->dev_name is not freed when freeing event_cb, and this causes a
memory leak.
Fixes: a753e53d517b ("eal: add device event monitor framework")
Cc: sta...@dpdk.org
Signed-off-by: Yunjian Wang <wangyunj...@huawei.com>
---
lib/librte_eal/common/eal_common_dev.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/lib/librte_eal/common/eal_common_dev.c
b/lib/librte_eal/common/eal_common_dev.c
index 9e4f09d..363a2ca 100644
--- a/lib/librte_eal/common/eal_common_dev.c
+++ b/lib/librte_eal/common/eal_common_dev.c
@@ -526,6 +526,7 @@ static int cmp_dev_name(const struct rte_device *dev,
const void *_name)
*/
if (event_cb->active == 0) {
TAILQ_REMOVE(&dev_event_cbs, event_cb, next);
+ free(event_cb->dev_name);
free(event_cb);
ret++;
} else {
--
1.8.3.1
Acked-by: Jeff Guo <jia....@intel.com>
