On Wed, Jul 29, 2020 at 4:16 PM Feifei Wang <feifei.wa...@arm.com> wrote: > > Are we missing a check in the UT so that dequeued object is what had been > > enqueued? > > > > > Dequeue is not necessary to change because the param defined in > rte_ring_dequeue > is different from that in rte_ring_enqueue: > rte_ring_enqueue(struct rte_ring *r, void *obj): obj is a pointer (object) to > be added in the ring > rte_ring_dequeue(struct rte_ring *r, void **obj_p): obj_p is a pointer to a > void * pointer > (object) that will be filled.
That I get it. What I meant is that the test enqueues an object in a ring until it is full [1], then dequeues all the ring [2]. 1: https://git.dpdk.org/dpdk/tree/app/test/test_ring.c#n814 2: https://git.dpdk.org/dpdk/tree/app/test/test_ring.c#n825 If the test had checked that dequeued objects are the right one, we would have caught it. But on the other hand, maybe another part of the functionnal ring tests already check this and we only need to fix this issue here. -- David Marchand
