Hello Feifei,
On Wed, Jul 29, 2020 at 8:32 AM Feifei Wang <feifei.wa...@arm.com> wrote:
>
> When enqueue one element (object of type void*) to ring in the
> performance test, a pointer (the object to be enqueued) should be
> passed to rte_ring_[sp|mp]enqueue APIs, not the pointer to a table
> of void *pointers (objects).
Good catch.
Are we missing a check in the UT so that dequeued object is what had
been enqueued?
>
> Fixes: a9fe152363e2 ("test/ring: add custom element size functional tests")
> Cc: honnappa.nagaraha...@arm.com
> Cc: sta...@dpdk.org
>
> Signed-off-by: Feifei Wang <feifei.wa...@arm.com>
> Reviewed-by: Ruifeng Wang <ruifeng.w...@arm.com>
> ---
> app/test/test_ring.h | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/app/test/test_ring.h b/app/test/test_ring.h
> index aa6ae67ca..d4b15af7c 100644
> --- a/app/test/test_ring.h
> +++ b/app/test/test_ring.h
> @@ -50,11 +50,11 @@ test_ring_enqueue(struct rte_ring *r, void **obj, int
> esize, unsigned int n,
> if ((esize) == -1)
> switch (api_type) {
> case (TEST_RING_THREAD_DEF | TEST_RING_ELEM_SINGLE):
> - return rte_ring_enqueue(r, obj);
> + return rte_ring_enqueue(r, *obj);
> case (TEST_RING_THREAD_SPSC | TEST_RING_ELEM_SINGLE):
> - return rte_ring_sp_enqueue(r, obj);
> + return rte_ring_sp_enqueue(r, *obj);
> case (TEST_RING_THREAD_MPMC | TEST_RING_ELEM_SINGLE):
> - return rte_ring_mp_enqueue(r, obj);
> + return rte_ring_mp_enqueue(r, *obj);
> case (TEST_RING_THREAD_DEF | TEST_RING_ELEM_BULK):
> return rte_ring_enqueue_bulk(r, obj, n, NULL);
> case (TEST_RING_THREAD_SPSC | TEST_RING_ELEM_BULK):
> --
> 2.17.1
>
--
David Marchand
