Re: [dpdk-dev] [EXT] [PATCH 1/5] examples/l2fwd-event: free resources in case of error

2020-06-15 Thread Sunil Kumar Kori
>-Original Message- >From: Muhammad Bilal >Sent: Monday, June 15, 2020 5:30 PM >To: Sunil Kumar Kori >Cc: declan.dohe...@intel.com; tomasz.kante...@intel.com; Pavan Nikhilesh >Bhagavatula ; dev@dpdk.org; >jgraj...@cisco.com; vipin.vargh...@intel.com >Subject: Re: [EXT] [PATCH 1/5] example

Re: [dpdk-dev] [PATCH 3/3] net/bnxt: add ARM64 vector support

2020-06-15 Thread Ruifeng Wang
> -Original Message- > From: dev On Behalf Of Lance Richardson > Sent: Friday, June 12, 2020 7:58 AM > To: dev@dpdk.org; Ajit Khaparde (ajit.khapa...@broadcom.com) > > Subject: [dpdk-dev] [PATCH 3/3] net/bnxt: add ARM64 vector support > > Add bnxt vector PMD support using NEON SIMD inst

[dpdk-dev] [PATCH v3 12/12] doc: enable DCF datapath configuration

2020-06-15 Thread Ting Xu
Add doc for DCF datapath configuration in DPDK 20.08 release note. Signed-off-by: Ting Xu --- doc/guides/rel_notes/release_20_08.rst | 6 ++ 1 file changed, 6 insertions(+) diff --git a/doc/guides/rel_notes/release_20_08.rst b/doc/guides/rel_notes/release_20_08.rst index dee4ccbb5..1a3a4cd

[dpdk-dev] [PATCH v3 11/12] net/ice: set MAC filter during dev start for DCF

2020-06-15 Thread Ting Xu
From: Qi Zhang Add support to add and delete MAC address filter in DCF. Signed-off-by: Qi Zhang Signed-off-by: Ting Xu --- drivers/net/ice/ice_dcf.c| 42 drivers/net/ice/ice_dcf.h| 1 + drivers/net/ice/ice_dcf_ethdev.c | 7 ++ 3 files ch

[dpdk-dev] [PATCH v3 05/12] net/ice: add stop flag for device start / stop

2020-06-15 Thread Ting Xu
From: Qi Zhang Add stop flag for DCF device start and stop. Signed-off-by: Qi Zhang Signed-off-by: Ting Xu --- drivers/net/ice/ice_dcf_ethdev.c | 12 drivers/net/ice/ice_dcf_parent.c | 1 + 2 files changed, 13 insertions(+) diff --git a/drivers/net/ice/ice_dcf_ethdev.c b/driver

[dpdk-dev] [PATCH v3 06/12] net/ice: add Rx queue init in DCF

2020-06-15 Thread Ting Xu
From: Qi Zhang Enable Rx queues initialization during device start in DCF. Signed-off-by: Qi Zhang Signed-off-by: Ting Xu --- drivers/net/ice/ice_dcf.h| 1 + drivers/net/ice/ice_dcf_ethdev.c | 83 2 files changed, 84 insertions(+) diff --git a/driver

[dpdk-dev] [PATCH v3 08/12] net/ice: add queue config in DCF

2020-06-15 Thread Ting Xu
From: Qi Zhang Add queues and Rx queue irqs configuration during device start in DCF. The setup is sent to PF via virtchnl. Signed-off-by: Qi Zhang Signed-off-by: Ting Xu --- drivers/net/ice/ice_dcf.c| 111 +++ drivers/net/ice/ice_dcf.h| 6 ++ drivers

[dpdk-dev] [PATCH v3 09/12] net/ice: add queue start and stop for DCF

2020-06-15 Thread Ting Xu
From: Qi Zhang Add queue start and stop in DCF. Support queue enable and disable through virtual channel. Add support for Rx queue mbufs allocation and queue reset. Signed-off-by: Qi Zhang Signed-off-by: Ting Xu --- drivers/net/ice/ice_dcf.c| 57 ++ drivers/net/ice/ice_dcf.h

[dpdk-dev] [PATCH v3 10/12] net/ice: enable stats for DCF

2020-06-15 Thread Ting Xu
From: Qi Zhang Add support to get and reset Rx/Tx stats in DCF. Query stats from PF. Signed-off-by: Qi Zhang Signed-off-by: Ting Xu --- drivers/net/ice/ice_dcf.c| 27 drivers/net/ice/ice_dcf.h| 4 ++ drivers/net/ice/ice_dcf_ethdev.c | 102 ++

[dpdk-dev] [PATCH v3 07/12] net/ice: init RSS during DCF start

2020-06-15 Thread Ting Xu
From: Qi Zhang Enable RSS initialization during DCF start. Add RSS LUT and RSS key configuration functions. Signed-off-by: Qi Zhang Signed-off-by: Ting Xu --- drivers/net/ice/ice_dcf.c| 117 +++ drivers/net/ice/ice_dcf.h| 1 + drivers/net/ice/ice_

[dpdk-dev] [PATCH v3 03/12] net/ice: complete dev configure in DCF

2020-06-15 Thread Ting Xu
From: Qi Zhang Enable device configuration function in DCF. Signed-off-by: Qi Zhang Signed-off-by: Ting Xu --- drivers/net/ice/ice_dcf_ethdev.c | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/drivers/net/ice/ice_dcf_ethdev.c b/drivers/net/ice/ice_dcf_ethdev.c i

[dpdk-dev] [PATCH v3 00/12] enable DCF datapath configuration

2020-06-15 Thread Ting Xu
This patchset adds support to configure DCF datapath, including Rx/Tx queues setup, start and stop, device configuration, RSS and flexible descriptor RXDID initialization and MAC filter setup. Qi Zhang (11): net/ice: init RSS and supported RXDID in DCF net/ice: complete device info get in DCF

[dpdk-dev] [PATCH v3 01/12] net/ice: init RSS and supported RXDID in DCF

2020-06-15 Thread Ting Xu
From: Qi Zhang Enable RSS parameters initialization and get the supported flexible descriptor RXDIDs bitmap from PF during DCF init. Signed-off-by: Qi Zhang Signed-off-by: Ting Xu --- drivers/net/ice/ice_dcf.c | 54 ++- drivers/net/ice/ice_dcf.h | 3 +++ 2

[dpdk-dev] [PATCH v3 04/12] net/ice: complete queue setup in DCF

2020-06-15 Thread Ting Xu
From: Qi Zhang Delete original DCF queue setup functions and use ice queue setup and release functions instead. Signed-off-by: Qi Zhang Signed-off-by: Ting Xu --- drivers/net/ice/ice_dcf_ethdev.c | 42 +++- drivers/net/ice/ice_dcf_ethdev.h | 3 --- drivers/net/ice

[dpdk-dev] [PATCH v3 02/12] net/ice: complete device info get in DCF

2020-06-15 Thread Ting Xu
From: Qi Zhang Add support to get complete device information for DCF, including Rx/Tx offload capabilities and default configuration. Signed-off-by: Qi Zhang Signed-off-by: Ting Xu --- drivers/net/ice/ice_dcf_ethdev.c | 72 ++-- 1 file changed, 69 insertions(+), 3

Re: [dpdk-dev] [PATCH 6/9] vhost: add support for virtio status

2020-06-15 Thread Xia, Chenbo
Hi Maxime, > -Original Message- > From: dev On Behalf Of Maxime Coquelin > Sent: Thursday, May 14, 2020 4:02 PM > To: Ye, Xiaolong ; shah...@mellanox.com; > ma...@mellanox.com; amore...@redhat.com; Wang, Xiao W > ; viachesl...@mellanox.com; dev@dpdk.org > Cc: jasow...@redhat.com; l...@red

Re: [dpdk-dev] [PATCH v9 00/12] Windows basic memory management

2020-06-15 Thread Ranjit Menon
On 6/14/2020 5:43 PM, Dmitry Kozlyuk wrote: Note for v9: rte_eal_memory.h renamed, dependent patchsets have to be updated. This patchset implements basic MM with the following features: * Hugepages are dynamically allocated in user-mode. * Only 2MB hugepages are supported. * IOVA is always PA

[dpdk-dev] Aligning DPDK Link bonding with current standards terminology

2020-06-15 Thread Stephen Hemminger
I am disturbed by the wide spread use of master/slave in Ethernet bonding. Asked the current IEEE chairs and it looks like it is already fixed "upstream". The proper terminology is for Ethernet link aggregation in the the current standard 802.1AX 2020 revision (pay walled) for the parts formerly k

[dpdk-dev] [PATCH v2 4/4] devtools: add Windows cross-build test with MinGW

2020-06-15 Thread Thomas Monjalon
The Meson cross file is renamed from meson_mingw.txt to cross-mingw, and is added to test-meson-builds.sh. The only example supported on Windows so far is "helloworld", that's why the default list of examples is overridden. Signed-off-by: Thomas Monjalon --- config/x86/{meson_mingw.txt => cross

[dpdk-dev] [PATCH v2 2/4] devtools: allow non-standard toolchain in meson test

2020-06-15 Thread Thomas Monjalon
If a compiler is not found in $PATH, the compilation test is skipped. In some cases, the compiler could be found after extending $PATH in an environment configuration script (called by load-devel-config). The decision to skip is deferred to a later stage, after loading the configuration script. I

[dpdk-dev] [PATCH v2 0/4] add PPC and Windows cross-compilation to meson test

2020-06-15 Thread Thomas Monjalon
In order to better support PPC and Windows, their compilation is tested on Linux with Meson with the script test-meson-builds.sh, supposed to be called in every CI labs. Thomas Monjalon (4): devtools: shrink cross-compilation test definition devtools: allow non-standard toolchain in meson tes

[dpdk-dev] [PATCH v2 3/4] devtools: add ppc64 in meson build test

2020-06-15 Thread Thomas Monjalon
Add cross-compilation support of a PPC target in the build test matrix. The CPU is defined as Power8, running as little endian. Signed-off-by: Thomas Monjalon --- config/ppc/ppc64le-power8-linux-gcc | 11 +++ devtools/test-meson-builds.sh | 5 + 2 files changed, 16 insertions(

[dpdk-dev] [PATCH v2 1/4] devtools: shrink cross-compilation test definition

2020-06-15 Thread Thomas Monjalon
Each cross-compilation case needs to define the target compiler and the meson cross file. Given the compiler is already defined in the cross file, the latter is enough. The function "build" is changed to accept a cross file alternatively to the compiler name. In the case of a file (detected if rea

Re: [dpdk-dev] [PATCH 3/4] devtools: add ppc64 in meson build test

2020-06-15 Thread Thomas Monjalon
15/06/2020 23:43, David Christensen: > On 6/14/20 3:57 PM, Thomas Monjalon wrote: > > diff --git a/devtools/test-meson-builds.sh b/devtools/test-meson-builds.sh > > index 1d80a029aa..1cde17a2e5 100755 > > --- a/devtools/test-meson-builds.sh > > +++ b/devtools/test-meson-builds.sh > > @@ -212,6 +212

Re: [dpdk-dev] [RFC PATCH 6/6] bus/mlx5_pci: enable net and vDPA to use mlx5 PCI bus driver

2020-06-15 Thread Gaëtan Rivet
On 10/06/20 17:17 +, Parav Pandit wrote: > Enable class driver to match with the mlx5 pci devices. > Migrate mlx5 net PMD and vdpa PMD to start using mlx5 common class > driver. > > Signed-off-by: Parav Pandit > --- > drivers/bus/Makefile| 3 ++ > drivers/bus/mlx5_pci/mlx5_p

Re: [dpdk-dev] [RFC PATCH 5/6] bus/mlx5_pci: register a PCI driver

2020-06-15 Thread Gaëtan Rivet
On 10/06/20 17:17 +, Parav Pandit wrote: > Create a mlx5 bus driver framework for invoking drivers of > multiple classes who have registered with the mlx5_pci bus > driver. > > Validate user class arguments for supported class combinations. > > Signed-off-by: Parav Pandit > --- > drivers/bu

Re: [dpdk-dev] [PATCH 3/4] devtools: add ppc64 in meson build test

2020-06-15 Thread David Christensen
On 6/14/20 3:57 PM, Thomas Monjalon wrote: diff --git a/devtools/test-meson-builds.sh b/devtools/test-meson-builds.sh index 1d80a029aa..1cde17a2e5 100755 --- a/devtools/test-meson-builds.sh +++ b/devtools/test-meson-builds.sh @@ -212,6 +212,11 @@ for f in $srcdir/config/arm/arm64_[bdo]*gcc ; do

Re: [dpdk-dev] [RFC PATCH 4/6] bus/mlx5_pci: add mlx5 PCI bus

2020-06-15 Thread Gaëtan Rivet
On 10/06/20 17:17 +, Parav Pandit wrote: > Add mlx5 PCI bus which enables multiple mlx5 drivers to bind to single > pci device. > This is a little quick to explain the architecture here. First it should be clear that this is not, in fact, a bus. You only define a PCI driver, that will demux

Re: [dpdk-dev] [RFC PATCH 3/6] common/mlx5: change mlx5 class enum values as bits

2020-06-15 Thread Gaëtan Rivet
On 10/06/20 17:17 +, Parav Pandit wrote: > mlx5 PCI Device supports multiple classes of devices such as net, vdpa, > and/or regex. > To support these multiple classes, change mlx5_class to a > bitmap values so that if users asks to enable multiple of them, all > supported classes can be returne

Re: [dpdk-dev] [RFC PATCH 2/6] common/mlx5: use class enable check helper function

2020-06-15 Thread Gaëtan Rivet
On 10/06/20 17:17 +, Parav Pandit wrote: > Currently mlx5_class_get() returns enabled single valid class. > To support multiple class and to improve readability of code, change it > to mlx5_class_enabled(). > With this function, each class enablement can be checked, to load class > specific dri

Re: [dpdk-dev] [RFC PATCH 1/6] eal: introduce macros for getting value for bit

2020-06-15 Thread Gaëtan Rivet
Hello Parav, On 10/06/20 17:17 +, Parav Pandit wrote: > There are several drivers which duplicate bit generation macro. > Introduce a generic bit macros so that such drivers avoid redefining > same in multiple drivers. > > Signed-off-by: Parav Pandit > --- > lib/librte_eal/include/rte_bits.

Re: [dpdk-dev] [PATCH v9 00/12] Windows basic memory management

2020-06-15 Thread Thomas Monjalon
15/06/2020 02:43, Dmitry Kozlyuk: > Note for v9: > rte_eal_memory.h renamed, dependent patchsets have to be updated. > > This patchset implements basic MM with the following features: > > * Hugepages are dynamically allocated in user-mode. > * Only 2MB hugepages are supported. > * IOVA is always

[dpdk-dev] [PATCH] rte_sched: fix 64-bit support in rate functions

2020-06-15 Thread Hrvoje Habjanic
Functions rte_sched_subport_config_pipe_profile_table and pipe_profile_check should also have increased rate arguments. Fixes: 68c1f26d4236 (\"sched: support 64-bit values\") Cc: jasvinder.si...@intel.com Signed-off-by: Hrvoje Habjanic --- lib/librte_sched/rte_sched.c | 4 ++-- 1 file changed,

Re: [dpdk-dev] [EXT] Re: [PATCH 3/3] l3fwd-power: add interrupt-only mode

2020-06-15 Thread Jerin Jacob
On Mon, Jun 15, 2020 at 9:15 PM Burakov, Anatoly wrote: > > On 15-Jun-20 4:21 PM, Jerin Jacob wrote: > > On Mon, Jun 15, 2020 at 8:35 PM Burakov, Anatoly > > wrote: > >> > >> On 15-Jun-20 12:43 PM, Jerin Jacob wrote: > >>> On Mon, Jun 15, 2020 at 5:02 PM Burakov, Anatoly > >>> wrote: > > >>

Re: [dpdk-dev] [EXT] Re: [PATCH 3/3] l3fwd-power: add interrupt-only mode

2020-06-15 Thread Burakov, Anatoly
On 15-Jun-20 4:21 PM, Jerin Jacob wrote: On Mon, Jun 15, 2020 at 8:35 PM Burakov, Anatoly wrote: On 15-Jun-20 12:43 PM, Jerin Jacob wrote: On Mon, Jun 15, 2020 at 5:02 PM Burakov, Anatoly wrote: On 02-Jun-20 1:16 PM, Harman Kalra wrote: On Tue, Jun 02, 2020 at 03:53:07PM +0530, Harman Kal

Re: [dpdk-dev] [PATCH v9 09/12] eal/windows: improve CPU and NUMA node detection

2020-06-15 Thread Dmitry Kozlyuk
[snip] > > + rte_errno = EINVAL; > > + return -1; > > + } > > rte_errno is unknown > > It seems to be fixed in patch 12: > > --- a/lib/librte_eal/windows/eal_windows.h > +++ b/lib/librte_eal/windows/eal_windows.h > @@ -9,8 +9,24 @@ > * @file Facilities private to Window

Re: [dpdk-dev] [EXT] Re: [PATCH 3/3] l3fwd-power: add interrupt-only mode

2020-06-15 Thread Jerin Jacob
On Mon, Jun 15, 2020 at 8:35 PM Burakov, Anatoly wrote: > > On 15-Jun-20 12:43 PM, Jerin Jacob wrote: > > On Mon, Jun 15, 2020 at 5:02 PM Burakov, Anatoly > > wrote: > >> > >> On 02-Jun-20 1:16 PM, Harman Kalra wrote: > >>> On Tue, Jun 02, 2020 at 03:53:07PM +0530, Harman Kalra wrote: > On M

Re: [dpdk-dev] [PATCH v9 09/12] eal/windows: improve CPU and NUMA node detection

2020-06-15 Thread Thomas Monjalon
15/06/2020 02:43, Dmitry Kozlyuk: > + infos_size = 0; > + if (!GetLogicalProcessorInformationEx( > + RelationNumaNode, NULL, &infos_size)) { > + DWORD error = GetLastError(); > + if (error != ERROR_INSUFFICIENT_BUFFER) { > + lo

Re: [dpdk-dev] [EXT] Re: [PATCH 3/3] l3fwd-power: add interrupt-only mode

2020-06-15 Thread Burakov, Anatoly
On 15-Jun-20 12:43 PM, Jerin Jacob wrote: On Mon, Jun 15, 2020 at 5:02 PM Burakov, Anatoly wrote: On 02-Jun-20 1:16 PM, Harman Kalra wrote: On Tue, Jun 02, 2020 at 03:53:07PM +0530, Harman Kalra wrote: On Mon, Jun 01, 2020 at 01:50:26PM +0100, Burakov, Anatoly wrote: On 30-May-20 11:02 AM,

Re: [dpdk-dev] i40eVF pmd vlan id handling

2020-06-15 Thread Yan Fridland
Actually that didnt work for me. I added both the flag and called rte_eth_dev_vlan_filter() for the rellevant port and vlan, however no packets are sent. BTW, how flag resposible for rx is relevant for my tx problem? Thanks Yan Sent from my Huawei Mobile Original Message Sub

Re: [dpdk-dev] [PATCH v9 04/12] eal/mem: extract common code for memseg list initialization

2020-06-15 Thread Thomas Monjalon
15/06/2020 02:43, Dmitry Kozlyuk: > --- a/lib/librte_eal/common/eal_common_memory.c > +++ b/lib/librte_eal/common/eal_common_memory.c > + RTE_LOG(DEBUG, EAL, > + "Memseg list allocated at socket %i, page size 0x%"PRIx64"kB\n", > + socket_id, (size_t)page_sz >> 10); The

Re: [dpdk-dev] i40eVF pmd vlan id handling

2020-06-15 Thread Yan Fridland
Thanks a lot, I will check and update. -Yan From: Dey, Souvik Sent: Monday, June 15, 2020 3:44 PM To: Yan Fridland Cc: dev@dpdk.org Subject: RE: i40eVF pmd vlan id handling We need to enable DEV_RX_OFFLOAD_VLAN_FILTER from the DPDK app, and then configure the specific vlan id using rte_eth_dev

Re: [dpdk-dev] i40eVF pmd vlan id handling

2020-06-15 Thread Dey, Souvik
We need to enable DEV_RX_OFFLOAD_VLAN_FILTER from the DPDK app, and then configure the specific vlan id using rte_eth_dev_vlan_filter() to have vlan id come up to the guest. By default in VmWare I guess VLAN+MAC filtering gets enabled as, we set 0/4095 vlan_id on the VF to allow all Vlans. Can y

Re: [dpdk-dev] [EXT] [PATCH 1/5] examples/l2fwd-event: free resources in case of error

2020-06-15 Thread Muhammad Bilal
On Wed, Jun 10, 2020 at 3:01 PM Sunil Kumar Kori wrote: > > >-Original Message- > >From: Muhammad Bilal > >Sent: Tuesday, June 2, 2020 5:57 PM > >To: Sunil Kumar Kori > >Cc: declan.dohe...@intel.com; tomasz.kante...@intel.com; Pavan Nikhilesh > >Bhagavatula ; dev@dpdk.org; > >jgraj...@ci

Re: [dpdk-dev] [EXT] Re: [PATCH 3/3] l3fwd-power: add interrupt-only mode

2020-06-15 Thread Jerin Jacob
On Mon, Jun 15, 2020 at 5:02 PM Burakov, Anatoly wrote: > > On 02-Jun-20 1:16 PM, Harman Kalra wrote: > > On Tue, Jun 02, 2020 at 03:53:07PM +0530, Harman Kalra wrote: > >> On Mon, Jun 01, 2020 at 01:50:26PM +0100, Burakov, Anatoly wrote: > >>> On 30-May-20 11:02 AM, Harman Kalra wrote: > On

Re: [dpdk-dev] [EXT] Re: [PATCH 3/3] l3fwd-power: add interrupt-only mode

2020-06-15 Thread Burakov, Anatoly
On 02-Jun-20 1:16 PM, Harman Kalra wrote: On Tue, Jun 02, 2020 at 03:53:07PM +0530, Harman Kalra wrote: On Mon, Jun 01, 2020 at 01:50:26PM +0100, Burakov, Anatoly wrote: On 30-May-20 11:02 AM, Harman Kalra wrote: On Fri, May 29, 2020 at 03:19:45PM +0100, Burakov, Anatoly wrote: External Email

Re: [dpdk-dev] [PATCH v1 1/2] eal/x86: add WC store function

2020-06-15 Thread Ananyev, Konstantin
Hi Radu, > > Add rte_write32_wc function that implements a WC store > using movdiri instruction. Probably worth to add 1-2 lines of text explaining what are the advantages (perf improvement or whatever). > > Signed-off-by: Radu Nicolau > --- > lib/librte_eal/x86/include/rte_io.h | 20 ++

Re: [dpdk-dev] [PATCH v9 03/12] eal: introduce memory management wrappers

2020-06-15 Thread Dmitry Kozlyuk
On Mon, 15 Jun 2020 06:53:45 -0400 Neil Horman wrote: > On Mon, Jun 15, 2020 at 10:41:20AM +0300, Dmitry Kozlyuk wrote: > > On Mon, 15 Jun 2020 07:03:23 +0100 > > "Kinsella, Ray" wrote: > > > > [snip] > > > > + > > > > +INTERNAL { > > > > + global: > > > > + > > > > + rte_mem_lock

Re: [dpdk-dev] [PATCH v9 03/12] eal: introduce memory management wrappers

2020-06-15 Thread Neil Horman
On Mon, Jun 15, 2020 at 10:41:20AM +0300, Dmitry Kozlyuk wrote: > On Mon, 15 Jun 2020 07:03:23 +0100 > "Kinsella, Ray" wrote: > > [snip] > > > + > > > +INTERNAL { > > > + global: > > > + > > > + rte_mem_lock; > > > + rte_mem_map; > > > + rte_mem_page_size; > > > + rte_mem_unmap; > > > +}; > >

Re: [dpdk-dev] [PATCH] net/mlx5: fix Rx/Tx descriptors number adjustment

2020-06-15 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Alexander Kozyrev > Sent: Thursday, June 11, 2020 8:43 PM > To: dev@dpdk.org > Cc: sta...@dpdk.org; Raslan Darawsheh ; Matan > Azrad > Subject: [PATCH] net/mlx5: fix Rx/Tx descriptors number adjustment > > The number of descriptors to configure in a Rx/T

Re: [dpdk-dev] [PATCH] eal: fix Windows export

2020-06-15 Thread Thomas Monjalon
10/06/2020 16:30, David Marchand: > rte_eal_get_configuration() has been made private in 19.11, remove > leftover in Windows export list. > > Fixes: f58cef079b05 ("eal: make the global configuration private") > > Signed-off-by: David Marchand I assume no backport is required for Windows so far.

Re: [dpdk-dev] [PATCH v3] eal/windows: fix invalid thread handle

2020-06-15 Thread Thomas Monjalon
02/06/2020 04:00, Tasnim Bashar: > #define pthread_setaffinity_np(thread, size, cpuset) \ > - eal_set_thread_affinity_mask(thread, (unsigned long *) cpuset) > + eal_set_thread_affinity_mask(thread, cpuset) > #define pthread_getaffinity_np(thread, size, cpuset) \ > - eal_get_thread_aff

Re: [dpdk-dev] [PATCH v4] eal: fix warnings on Windows

2020-06-15 Thread Thomas Monjalon
11/06/2020 22:18, Narcisa Ana Maria Vasile: > On Thu, Jun 11, 2020 at 12:50:55PM -0700, Pallavi Kadam wrote: > > Fixed bunch of warnings when compiling using clang on Windows > > such as the use of an unsafe string function (strerror), > > [-Wunused-variable], [-Wunused-function] in eal_common_opti

Re: [dpdk-dev] [PATCH v3 5/7] net/ixgbe: return unknown speed in status

2020-06-15 Thread Zhao1, Wei
Hi, dyukov > -Original Message- > From: Ivan Dyukov > Sent: Monday, June 15, 2020 5:02 PM > To: dev@dpdk.org; i.dyu...@samsung.com; v.kurams...@samsung.com; > tho...@monjalon.net; david.march...@redhat.com; Yigit, Ferruh > ; arybche...@solarflare.com; Zhao1, Wei > ; Guo, Jia ; Xing, Beile

Re: [dpdk-dev] MinGW guide

2020-06-15 Thread Tal Shnaiderman
> Subject: Re: MinGW guide > > On Sat, 13 Jun 2020 10:55:14 +0200 > Thomas Monjalon wrote: [snip] > > Then when installing mingw-w64-install.exe, a choice must be done > > between threads POSIX or Win32. > > If I understand well, POSIX must be chosen? > > Yes. DPDK config/meson.build now links

Re: [dpdk-dev] [PATCH 04/14] vhost: make vDPA framework bus agnostic

2020-06-15 Thread Maxime Coquelin
On 6/12/20 2:46 PM, Gaëtan Rivet wrote: > On 11/06/20 23:37 +0200, Maxime Coquelin wrote: >> This patch makes the vDPA framework to no more >> support only PCI devices, but any devices by relying >> on the generic device name as identifier. >> >> Signed-off-by: Maxime Coquelin >> --- >> driver

Re: [dpdk-dev] [PATCH 03/14] vhost: introduce vDPA devices class

2020-06-15 Thread Maxime Coquelin
On 6/12/20 2:37 PM, Gaëtan Rivet wrote: > On 11/06/20 23:37 +0200, Maxime Coquelin wrote: >> This patch introduces vDPA device class. It will enable >> application to iterate over the vDPA devices. >> >> Signed-off-by: Maxime Coquelin >> --- >> lib/librte_vhost/vdpa.c | 116 +++

Re: [dpdk-dev] 19.11.3 patches review and test

2020-06-15 Thread Luca Boccassi
On Sun, 2020-06-14 at 22:05 -0400, Pei Zhang wrote: > Hi Luca, > > Testing with dpdk v19.11.3-rc1 from Red Hat looks good. > > We cover below 14 scenarios and and all get PASS on RHEL8 testing: > > (1)Guest with device assignment(PF) throughput testing(1G hugepage size): PASS > (2)Guest with dev

[dpdk-dev] [PATCH v3 6/7] net/i40e: return unknown speed in status

2020-06-15 Thread Ivan Dyukov
rte_ethdev has declared new NUM_UNKNOWN speed which could be used in case when no speed information is available and link is up. NUM_NONE should be returned, if link is down. Signed-off-by: Ivan Dyukov --- drivers/net/i40e/i40e_ethdev.c| 5 - drivers/net/i40e/i40e_ethdev_vf.c | 10 +

[dpdk-dev] [PATCH v3 4/7] doc: update sample app with unknown speed

2020-06-15 Thread Ivan Dyukov
Add usage of rte_eth_link_format function to example applications Signed-off-by: Ivan Dyukov --- doc/guides/sample_app_ug/link_status_intr.rst | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/doc/guides/sample_app_ug/link_status_intr.rst b/doc/guides/sample_app_ug/

[dpdk-dev] [PATCH v3 5/7] net/ixgbe: return unknown speed in status

2020-06-15 Thread Ivan Dyukov
rte_ethdev has declared new NUM_UNKNOWN speed which could be used in case when no speed information is available Signed-off-by: Ivan Dyukov --- drivers/net/ixgbe/ixgbe_ethdev.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net

[dpdk-dev] [PATCH v3 7/7] net/ice: return unknown speed in status

2020-06-15 Thread Ivan Dyukov
rte_ethdev has declared new NUM_UNKNOWN speed which could be used in case when no speed information is available and link is up. NUM_NONE should be returned, if link is down. Signed-off-by: Ivan Dyukov --- drivers/net/ice/ice_ethdev.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) di

[dpdk-dev] [PATCH v3 2/7] ethdev: add a link status text representation

2020-06-15 Thread Ivan Dyukov
This commit add function which treat link status structure and format it to text representation. Signed-off-by: Ivan Dyukov --- MAINTAINERS| 1 + app/test/Makefile | 3 + app/test/meson.build | 2 + app/test/test_ethdev_link.c| 253 +++

[dpdk-dev] [PATCH v3 1/7] ethdev: allow unknown link speed

2020-06-15 Thread Ivan Dyukov
From: Thomas Monjalon When querying the link information, the link status is a mandatory major information. Other boolean values are supposed to be accurate: - duplex mode (half/full) - negotiation (auto/fixed) This API update is making explicit that the link speed information is

[dpdk-dev] [PATCH v3 3/7] app: UNKNOWN link speed print format

2020-06-15 Thread Ivan Dyukov
Add usage of rte_eth_link_format function to example applications Signed-off-by: Ivan Dyukov --- app/proc-info/main.c | 9 +++-- app/test-pipeline/init.c | 10 -- app/test-pmd/config.c| 19 +++ app/test-pmd/testpmd.c | 9 + app/test/test_pmd_perf.c

[dpdk-dev] [PATCH v3 0/7] ethdev: allow unknown link speed

2020-06-15 Thread Ivan Dyukov
MAINTAINERS | 1 + app/proc-info/main.c | 9 +- app/test-pipeline/init.c | 10 +- app/test-pmd/config.c | 19 +-- app/test-pmd/testpmd.c| 9 +- app/test/Makefile

Re: [dpdk-dev] [PATCH] net/mlx5: do not select legacy MPW implicitly

2020-06-15 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Alexander Kozyrev > Sent: Thursday, June 11, 2020 8:42 PM > To: dev@dpdk.org > Cc: sta...@dpdk.org; Raslan Darawsheh ; Slava > Ovsiienko > Subject: [PATCH] net/mlx5: do not select legacy MPW implicitly > > The Legacy MPW (multi-packet write) should not b

[dpdk-dev] [PATCH 1/3] examples/packet_ordering: free resources on exit

2020-06-15 Thread Sarosh Arif
Resources should be cleared while exiting the application. Bugzilla ID: 437 Signed-off-by: Sarosh Arif --- examples/packet_ordering/main.c | 51 ++--- 1 file changed, 41 insertions(+), 10 deletions(-) diff --git a/examples/packet_ordering/main.c b/examples/packet_ord

[dpdk-dev] [PATCH 2/3] examples/rxtx_callbacks: free resources on exit

2020-06-15 Thread Sarosh Arif
Resources should be cleared while exiting the application. Bugzilla ID: 437 Signed-off-by: Sarosh Arif --- examples/rxtx_callbacks/main.c | 45 -- 1 file changed, 38 insertions(+), 7 deletions(-) diff --git a/examples/rxtx_callbacks/main.c b/examples/rxtx_callbac

[dpdk-dev] [PATCH 3/3] examples/skeleton: free resources on exit

2020-06-15 Thread Sarosh Arif
Resources should be cleared while exiting the application. Bugzilla ID: 437 Signed-off-by: Sarosh Arif --- examples/skeleton/basicfwd.c | 39 +--- 1 file changed, 36 insertions(+), 3 deletions(-) diff --git a/examples/skeleton/basicfwd.c b/examples/skeleton/basic

Re: [dpdk-dev] [PATCH v3] eal/windows: fix invalid thread handle

2020-06-15 Thread Thomas Monjalon
02/06/2020 04:00, Tasnim Bashar: > Casting thread ID to handle is not accurate way to get thread handle. > Need to use OpenThread function to get thread handle from thread ID. > > pthread_setaffinity_np and pthread_getaffinity_np functions > for Windows are affected because of it. > > Signed-off-

Re: [dpdk-dev] [PATCH 4/4] devtools: add Windows cross-build test with MinGW

2020-06-15 Thread Thomas Monjalon
15/06/2020 03:05, Dmitry Kozlyuk: > > It looks to be a false positive, but we need to find a way to remove > > the warning with a code change. > > > > This workaround in lib/librte_eal/common/eal_common_options.c > > makes 200% sure the default_set is initialized: > > > > - if (pthread_geta

Re: [dpdk-dev] [PATCH v9 03/12] eal: introduce memory management wrappers

2020-06-15 Thread Kinsella, Ray
perfect. On 15/06/2020 08:41, Dmitry Kozlyuk wrote: > On Mon, 15 Jun 2020 07:03:23 +0100 > "Kinsella, Ray" wrote: > > [snip] >>> + >>> +INTERNAL { >>> + global: >>> + >>> + rte_mem_lock; >>> + rte_mem_map; >>> + rte_mem_page_size; >>> + rte_mem_unmap; >>> +}; >> Don't >> >> * eal_mem_

Re: [dpdk-dev] [PATCH v9 03/12] eal: introduce memory management wrappers

2020-06-15 Thread Dmitry Kozlyuk
On Mon, 15 Jun 2020 07:03:23 +0100 "Kinsella, Ray" wrote: [snip] > > + > > +INTERNAL { > > + global: > > + > > + rte_mem_lock; > > + rte_mem_map; > > + rte_mem_page_size; > > + rte_mem_unmap; > > +}; > > Don't > > * eal_mem_reserve() > * eal_mem_free() > * eal_mem_set_dump() > > Be

Re: [dpdk-dev] [PATCH 7/7] eal: add lcore hotplug notifications

2020-06-15 Thread David Marchand
On Mon, Jun 15, 2020 at 8:34 AM Kinsella, Ray wrote: > > From ABI PoV, you are 100%. > > Is the agreed term 'callback'?, not 'notifier' for example > rte_dev_event_callback_register, rte_mem_event_callback_register > > I did wonder however, if all these cb's would be better handled through a >

Re: [dpdk-dev] [PATCH 0/7] Register external threads as lcore

2020-06-15 Thread David Marchand
On Wed, Jun 10, 2020 at 5:33 PM Jerin Jacob wrote: > > On Wed, Jun 10, 2020 at 8:48 PM David Marchand > wrote: > > > > On Wed, Jun 10, 2020 at 5:09 PM Jerin Jacob wrote: > > > > > > On Wed, Jun 10, 2020 at 8:15 PM David Marchand > > > wrote: > > > > > > > > OVS and some other applications have