11/06/2020 22:18, Narcisa Ana Maria Vasile: > On Thu, Jun 11, 2020 at 12:50:55PM -0700, Pallavi Kadam wrote: > > Fixed bunch of warnings when compiling using clang on Windows > > such as the use of an unsafe string function (strerror), > > [-Wunused-variable], [-Wunused-function] in eal_common_options.c > > [-Wunused-const-variable] in getopt.c and [-Wunused-parameter] > > in eal_common_thread.c. > > Also fixed warnings generated using Mingw: > > [-Werror=old-style-definition], [-Werror=cast-function-type] and > > [-Werror=attributes] > > > > v4 changes: > > Removed -Werror that was added on Windows in v3 > > Removed self 'Tested-by' line > > > > v3 changes: > > Fixed pthread warning > > Added -Werror on Windows > > Fixed MinGW warnings > > > > v2 changes: > > Excluded dirent.h file on Windows temporarily. > > (This file will stay on Windows for later use) > > > > Signed-off-by: Ranjit Menon <ranjit.me...@intel.com> > > Signed-off-by: Pallavi Kadam <pallavi.ka...@intel.com> > > --- > Tested with clang, no warnings generated. > Tested-by: Narcisa Vasile <navas...@linux.microsoft.com> > Acked-by: Narcisa Vasile <navas...@linux.microsoft.com>
Applied, thanks
