Re: [dpdk-dev] [PATCH v3] net/ixgbe: add support for VF MAC address add and remove

Hi, Guinan There is a bug for this patch: The second input parameter of function hw->mac.ops.set_rar() should be index of MAC address register IXGBE_RAL/H. This index should be management by pf host for all the vf, not only index for one vf, or vf1 maybe overwrite this MAC address of vf0

[dpdk-dev] [PATCH] doc: fix wrong multicast filter flag

Multicast MAC filter flag means device ops set_mc_addr_list support or not. This patch fixes the wrong flag value in intel driver's document. Fixes: 9db3f52126fb ("doc: generate NIC overview table from ini files") Fixes: cb25d4323fbf ("net/avf: enable MAC VLAN and promisc ops") Fixes: 26e887343321

Re: [dpdk-dev] [PATCH 0/2] fix defects of macro in VF

> -Original Message- > From: Sun, GuinanX > Sent: Friday, May 8, 2020 1:07 PM > To: Zhao1, Wei ; dev@dpdk.org > Cc: Guo, Jia > Subject: RE: [dpdk-dev] [PATCH 0/2] fix defects of macro in VF > > Hi ZhaoWei > > > -Original Message- > > From: Zhao1, Wei > > Sent: Friday, May 8,

Re: [dpdk-dev] [PATCH] test/ring: code rework to reduce compilation time

> > > > > > > > > > > > > > > > > > > Hi Konstantin, > > > > > > > > I like the way the tests are organized and it looks > > > > > > > > good. > > > > > > > > > > > > > > > > I am just wondering about the way it is being tested here. > > > > > > > > The intent to write the test cases the

[dpdk-dev] [PATCH] example/vhost_blk: fix buffer not null terminated

Fix the potential bug. Signed-off-by: Jin Yu --- examples/vhost_blk/vhost_blk.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/examples/vhost_blk/vhost_blk.c b/examples/vhost_blk/vhost_blk.c index f08473f58..b5ce3332a 100644 --- a/examples/vhost_blk/vhost_blk.c +++ b/ex

Re: [dpdk-dev] rte_ring work

> > > > > > Hi Honnappa, > > > > > > > > > > > Hi Konstantin, > > > > Just to make sure we are coordinating the work on rte_ring, I > > > > plan to get the following things done for 20.08. Please let me > > > > know if you have any > > > comments. > > > > > > Thanks for sharing your plans.

Re: [dpdk-dev] [PATCH v2] net/igc: fix memory illegal accesses

On 5/7/2020 5:31 PM, alvinx.zh...@intel.com wrote: From: Alvin Zhang Fix some out-of-bounds memory issues, they may lead to wrong results or affect application stability. Fixes: bd3fcf0d0fa1 (net/igc: support RSS) Cc: sta...@dpdk.org Signed-off-by: Alvin Zhang --- V2: update git log dr

Re: [dpdk-dev] [PATCH 0/2] fix defects of macro in VF

Hi ZhaoWei > -Original Message- > From: Zhao1, Wei > Sent: Friday, May 8, 2020 10:19 AM > To: Sun, GuinanX ; dev@dpdk.org > Cc: Sun, GuinanX ; Guo, Jia > Subject: RE: [dpdk-dev] [PATCH 0/2] fix defects of macro in VF > > Hi, > Please alaign " \" in each line. It will be modified in V2 p

Re: [dpdk-dev] [PATCH v2 0/2] fix defects of macro in VF

Reviewed-by: Wei Zhao > -Original Message- > From: dev On Behalf Of Guinan Sun > Sent: Friday, May 8, 2020 12:46 PM > To: dev@dpdk.org > Cc: Sun, GuinanX > Subject: [dpdk-dev] [PATCH v2 0/2] fix defects of macro in VF > > The defects of UPDATE_VF_STAT and UPDATE_VF_STAT_36BIT exist. >

[dpdk-dev] [PATCH v2 0/2] fix defects of macro in VF

The defects of UPDATE_VF_STAT and UPDATE_VF_STAT_36BIT exist. If latest is less than last, we will get wrong result. The issues exist only in ixgbe and e1000 NICs. --- v2 changes: * Aligned line-continuation character "\". Guinan Sun (2): net/ixgbe: fix defects of macro in VF net/e1000: fix de

[dpdk-dev] [PATCH v2 1/2] net/ixgbe: fix defects of macro in VF

The defects in the macros UPDATE_VF_STAT and UPDATE_VF_STAT_36BIT exist. If latest is less than last, we will get wrong result. The patch fixes the defect. Fixes: abf7275bbaa2 ("ixgbe: move to drivers/net/") Cc: sta...@dpdk.org Signed-off-by: Guinan Sun --- v2 changes: * Aligned line-continuatio

[dpdk-dev] [PATCH v2 2/2] net/e1000: fix defects of macro in VF

The defects in the macros UPDATE_VF_STAT and UPDATE_VF_STAT_36BIT exist. If latest is less than last, we will get wrong result. The patch fixes the defect. Fixes: d15fcf76c8b7 ("e1000: move to drivers/net/") Cc: sta...@dpdk.org Signed-off-by: Guinan Sun --- v2 changes: * Aligned line-continuatio

[dpdk-dev] [PATCH v3] app/testpmd: fix null pointer dereferencing issue

From: Kalesh AP In cmd_ddp_get_list_parsed(), elements of "p_list" are accessed even after the memory allocation for "p_list" fails. With this patch, this null pointer dereference is avoided as we return when there is malloc failure. Fixes: e088907bb851 ("app/testpmd: add command for getting lo

[dpdk-dev] [RFC 2/3] net/vdev_netvsc: automatically enable hotplug support

In Hyper-V/Azure with accelerated networking the VF device maybe added or removed at anytime. Automatically enable hotplug support (in case application has forgot to). Signed-off-by: Stephen Hemminger --- drivers/net/vdev_netvsc/vdev_netvsc.c | 4 1 file changed, 4 insertions(+) diff --git

[dpdk-dev] [RFC 1/3] eal/hotplug: allow monitor to be setup by multiple places

In some cases, a device or infrastructure may want to enable hotplug but application may also try and start hotplug as well. Therefore change the monitor_started from a boolean into a reference count. Signed-off-by: Stephen Hemminger --- lib/librte_eal/linux/eal_dev.c | 15 +++ 1 fil

[dpdk-dev] [RFC 0/3] Auto enable hotplug with netvsc devices

In Azure, hotplug is a requirement for a working application. Yet most applications don't enable it because DPDK hotplug support is opt-in. There are three options: 1. Blame the application (this seems to be the DPDK default) 2. Fix the design mistake (too risky at this time) 3. Automatical

[dpdk-dev] [RFC 3/3] net/netvsc: automatically enable hotplug support

In Hyper-V/Azure with accelerated networking the VF device maybe added or removed at anytime. Automatically enable hotplug support (in case application has forgot to). Signed-off-by: Stephen Hemminger --- drivers/net/netvsc/hn_ethdev.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) d

Re: [dpdk-dev] [PATCH] doc: announce adoption of C11 atomic operations semantics

> Subject: Re: [PATCH] doc: announce adoption of C11 atomic operations > semantics > > On Thu, 7 May 2020 15:06:33 +0800 > Phil Yang wrote: > > > From: Honnappa Nagarahalli > > > > As agreed in the DPDK tech board [1], after 20.05 release, patches > > must use C11 atomic operations semantics

Re: [dpdk-dev] [PATCH] net/i40e: fix hash enable issue in RSS flow

Tested-by: Xu, Hailin Regards, Xu, Hailin -Original Message- From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Wang, ShougangX Sent: Friday, May 8, 2020 9:52 AM To: Xing, Beilei ; dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH] net/i40e: fix hash enable issue in RSS flow Hi, Beilei > -

Re: [dpdk-dev] [PATCH] net/e1000: fix port hotplug for multi-process

Tested-by: Mei Jianwei -Original Message- From: Jiang, YuX Sent: Thursday, May 7, 2020 4:45 PM To: Mei, JianweiX Subject: FW: [dpdk-dev] [PATCH] net/e1000: fix port hotplug for multi-process -Original Message- From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of alvinx.zh...@

Re: [dpdk-dev] [PATCH v2] net/i40e: fix out of bounds read issue

Hi, Xiaolong I reviewed that function, it need rework, not only this coverity issue, the logical was wrong. Qiming > -Original Message- > From: Ye, Xiaolong > Sent: Friday, May 8, 2020 10:36 > To: Yang, Qiming > Cc: Di, ChenxuX ; dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v2] net/i4

Re: [dpdk-dev] [PATCH] net/ixgbe: fix link state timing issue on fiber ports

> Subject: [dpdk-dev] [PATCH] net/ixgbe: fix link state timing issue on fiber > ports > > With some models of fiber ports (e.g. X520-2 device ID 0x10fb), it > is possible when a port is started to experience a timing issue > which prevents the link from ever being fully set up. > > In ixgbe_dev_l

Re: [dpdk-dev] [PATCH v2] net/i40e: fix out of bounds read issue

Hi, Qiming On 05/08, Yang, Qiming wrote: >Nacked by: Qiming Yang Could you post the reason why you nack this patch? Thanks, Xiaolong > >> -Original Message- >> From: dev On Behalf Of Chenxu Di >> Sent: Thursday, May 7, 2020 17:50 >> To: dev@dpdk.org >> Cc: Di, ChenxuX >> Subject: [dp

Re: [dpdk-dev] [PATCH] net/ice/base: fix FDIR rule completion report value

On 05/08, Zhang, Qi Z wrote: > > >> -Original Message- >> From: Su, Simei >> Sent: Friday, May 8, 2020 9:37 AM >> To: Zhang, Qi Z ; Ye, Xiaolong >> Cc: dev@dpdk.org; Cao, Yahui ; Su, Simei >> >> Subject: [PATCH] net/ice/base: fix FDIR rule completion report value >> >> IAVF FDIR needs t

Re: [dpdk-dev] [PATCH v2] net/i40e: fix out of bounds read issue

Nacked by: Qiming Yang > -Original Message- > From: dev On Behalf Of Chenxu Di > Sent: Thursday, May 7, 2020 17:50 > To: dev@dpdk.org > Cc: Di, ChenxuX > Subject: [dpdk-dev] [PATCH v2] net/i40e: fix out of bounds read issue > > This patch fixes (out-of-bounds read) coverity issue. > >

Re: [dpdk-dev] [PATCH 0/2] fix defects of macro in VF

Hi, Please alaign " \" in each line. > -Original Message- > From: dev On Behalf Of Guinan Sun > Sent: Friday, May 8, 2020 9:59 AM > To: dev@dpdk.org > Cc: Sun, GuinanX > Subject: [dpdk-dev] [PATCH 0/2] fix defects of macro in VF > > The defects of UPDATE_VF_STAT and UPDATE_VF_S

[dpdk-dev] [PATCH 0/2] fix defects of macro in VF

The defects of UPDATE_VF_STAT and UPDATE_VF_STAT_36BIT exist. If latest is less than last, we will get wrong result. The issues exist only in ixgbe and e1000 NICs. Guinan Sun (2): net/ixgbe: fix defects of macro in VF net/e1000: fix defects of macro in VF drivers/net/e1000/igb_ethdev.c | 1

[dpdk-dev] [PATCH 1/2] net/ixgbe: fix defects of macro in VF

The defects in the macros UPDATE_VF_STAT and UPDATE_VF_STAT_36BIT exist. If latest is less than last, we will get wrong result. The patch fixes the defect. Fixes: abf7275bbaa2 ("ixgbe: move to drivers/net/") Cc: sta...@dpdk.org Signed-off-by: Guinan Sun --- drivers/net/ixgbe/ixgbe_ethdev.c | 20

[dpdk-dev] [PATCH 2/2] net/e1000: fix defects of macro in VF

The defects in the macros UPDATE_VF_STAT and UPDATE_VF_STAT_36BIT exist. If latest is less than last, we will get wrong result. The patch fixes the defect. Fixes: d15fcf76c8b7 ("e1000: move to drivers/net/") Cc: sta...@dpdk.org Signed-off-by: Guinan Sun --- drivers/net/e1000/igb_ethdev.c | 14 +

Re: [dpdk-dev] [PATCH v2] net/virtio: fix crash when device reconnecting

Tested-by: Wang, Yinan > -Original Message- > From: dev On Behalf Of Maxime Coquelin > Sent: 2020年5月7日 22:18 > To: Liu, Yong ; Ye, Xiaolong ; > Wang, Zhihong > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v2] net/virtio: fix crash when device > reconnecting > > > > On 5/6/20 5:

Re: [dpdk-dev] [PATCH] net/i40e: fix hash enable issue in RSS flow

Hi, Beilei > -Original Message- > From: Xing, Beilei > Sent: Friday, May 8, 2020 9:04 AM > To: Wang, ShougangX ; dev@dpdk.org > Subject: RE: [PATCH] net/i40e: fix hash enable issue in RSS flow > > > > > -Original Message- > > From: Wang, ShougangX > > Sent: Thursday, May 7, 20

Re: [dpdk-dev] [PATCH v3] l3fwd-power: add Rx interrupt timeout

Tested-by:ma,lihong Regards, Ma,lihong -Original Message- From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Anatoly Burakov Sent: Thursday, May 7, 2020 6:46 PM To: dev@dpdk.org Cc: Hunt, David ; sta...@dpdk.org Subject: [dpdk-dev] [PATCH v3] l3fwd-power: add Rx interrupt timeout Curre

Re: [dpdk-dev] [PATCH] net/ice/base: fix FDIR rule completion report value

> -Original Message- > From: Su, Simei > Sent: Friday, May 8, 2020 9:37 AM > To: Zhang, Qi Z ; Ye, Xiaolong > Cc: dev@dpdk.org; Cao, Yahui ; Su, Simei > > Subject: [PATCH] net/ice/base: fix FDIR rule completion report value > > IAVF FDIR needs to check program status from FD completi

[dpdk-dev] [PATCH] net/ice/base: fix FDIR rule completion report value

IAVF FDIR needs to check program status from FD completion descriptors for both successful and failed case, rather than only ask for completion on error. This patch corrects completion report value so that the called can determine whether to report completion on error or other cases. Fixes: 55daca

[dpdk-dev] [PATCH] net/ice/base: fix FDIR rule passthrough mode

This patch adds support for FDIR passthrough mode. When FDIR rule hits, FDIR just forward this packet to the next stage filter. Fixes: 55daca4e45fc ("net/ice/base: change function to static") Signed-off-by: Simei Su --- drivers/net/ice/base/ice_fdir.c | 9 - 1 file changed, 8 insertions

Re: [dpdk-dev] [PATCH] net/i40e: fix hash enable issue in RSS flow

> -Original Message- > From: Wang, ShougangX > Sent: Thursday, May 7, 2020 5:44 PM > To: dev@dpdk.org > Cc: Xing, Beilei ; Wang, ShougangX > > Subject: [PATCH] net/i40e: fix hash enable issue in RSS flow > > This patch fixes the issue that failed to create an RSS rule with type L2- >

Re: [dpdk-dev] [PATCH v3 3/7] pci: build on Windows

On 2020-05-07 15:16 GMT+0300 tal...@mellanox.com wrote: > From: Tal Shnaiderman > > Added off_t in Windows header file as a supported > type since it is needed by PCI. > > Signed-off-by: Tal Shnaiderman > --- > lib/librte_eal/windows/include/rte_os.h | 1 + > lib/meson.build

Re: [dpdk-dev] [PATCH v3 1/7] eal: move OS common functions to single file

On 2020-05-07 15:16 GMT+0300 tal...@mellanox.com wrote: > From: Tal Shnaiderman > > Move common functions between Unix and Windows to eal_common_config.c. > > Those simple functions are getter functions for IOVA, > configuration, Multi-process. > > Move rte_config and runtime_dir to be defined

Re: [dpdk-dev] [PATCH v3 7/7] bus/pci: support Windows with bifurcated drivers

On 2020-05-08 01:50 GMT+0300 Dmitry Kozlyuk wrote: [snip] > Cumulative fixes diff, feel free to distribute it among your patches: > > diff --git a/drivers/bus/pci/windows/pci.c b/drivers/bus/pci/windows/pci.c > index e8eff4f6f..9568a090a 100644 > --- a/drivers/bus/pci/windows/pci.c > +++ b/drivers

Re: [dpdk-dev] [PATCH 2/2] net/bnxt: fix uninitialized variable error

On Wed, May 6, 2020 at 2:14 AM Ferruh Yigit wrote: > On 5/5/2020 8:17 PM, Ajit Khaparde wrote: > > Fix uninitialized variable error reported by coverity. > > > > Fixes: d33b68154fa4 ("net/bnxt: add tf_core table scope support") > > The commit id and the patch title doesn't exist in next-net (also

Re: [dpdk-dev] [PATCH v3 7/7] bus/pci: support Windows with bifurcated drivers

On 2020-05-07 15:16 GMT+0300 tal...@mellanox.com wrote: > From: Tal Shnaiderman > > Uses SetupAPI.h functions to scan PCI tree. > Uses DEVPKEY_Device_Numa_Node to get the PCI NUMA node. > Uses SPDRP_BUSNUMBER and SPDRP_BUSNUMBER to get the BDF. > scanning currently supports types RTE_KDRV_NONE. >

Re: [dpdk-dev] [PATCH 3/5] doc: add cycles per packet in testpmd user guide

Hi Jerin, > On May 7, 2020, at 12:24 AM, Jerin Jacob wrote: > > On Thu, May 7, 2020 at 3:30 AM Dharmik Thakkar > wrote: >> >> Update documentation for 'show fwd' testpmd runtime function to show >> CPU cycles/packet example. >> >> Signed-off-by: Dharmik Thakkar >> Reviewed-by: Honnappa Naga

Re: [dpdk-dev] [PATCH 2/5] app/testpmd: print fractional part in CPU cycles

Hi Konstantin, > On May 7, 2020, at 4:50 AM, Ananyev, Konstantin > wrote: > > > >> -Original Message- >> From: dev On Behalf Of Dharmik Thakkar >> Sent: Wednesday, May 6, 2020 10:59 PM >> To: Lu, Wenzhuo ; Wu, Jingjing >> ; Iremonger, Bernard >> Cc: dev@dpdk.org; n...@arm.com; Dhar

Re: [dpdk-dev] [PATCH] net/bnxt: fix FW version get

On 5/7/2020 4:19 AM, Ajit Khaparde wrote: > bnxt_fw_version_get is not indicating the complete FW version. > Fix it to indicate complete version string. > > Fixes: e2652b0a20a0 ("net/bnxt: support get FW version") > Cc: sta...@dpdk.org > > Signed-off-by: Ajit Khaparde Applied to dpdk-next-net/m

Re: [dpdk-dev] [PATCH 2/2] net/bnxt: fix uninitialized variable error

On 5/7/2020 7:55 PM, Ajit Khaparde wrote: > > > On Wed, May 6, 2020 at 2:14 AM Ferruh Yigit > wrote: > > On 5/5/2020 8:17 PM, Ajit Khaparde wrote: > > Fix uninitialized variable error reported by coverity. > > > > Fixes: d33b68154fa4 ("net/bnxt: ad

Re: [dpdk-dev] [PATCH] doc: announce adoption of C11 atomic operations semantics

On Thu, 7 May 2020 15:06:33 +0800 Phil Yang wrote: > From: Honnappa Nagarahalli > > As agreed in the DPDK tech board [1], after 20.05 release, patches must > use C11 atomic operations semantics with the help of wrappers. > > [1] http://mails.dpdk.org/archives/dev/2020-April/165143.html > > S

Re: [dpdk-dev] [PATCH v5 3/3] timer: support EAL functions on Windows

On 2020-05-07 16:05 GMT+0300 Fady Bader wrote: > Implemented the needed Windows eal timer functions. [snip] > +void > +rte_delay_us_sleep(unsigned int us) > +{ > + LARGE_INTEGER start, end; > + LARGE_INTEGER freq; > + > + QueryPerformanceCounter(&start); > + QueryPerformanceFrequenc

Re: [dpdk-dev] [PATCH v3 1/2] common/mlx5: add rte internal tag and avoid comparison

07/05/2020 13:41, Ophir Munk: > From: Thomas Monjalon > > 07/05/2020 10:56, Ophir Munk: > > > Move mlx5 symbols in the map file to the INTERNAL section and add > > > __internal tags to their definitions. > > > Those symbols were exported in 20.02 and now (20.05) they are removed. > > [...] > > > -

Re: [dpdk-dev] [dpdk-stable] [PATCH] drivers/net: fix mlx* glue libraries ABI version

07/05/2020 14:35, David Marchand: > On Thu, Dec 12, 2019 at 11:18 PM Thomas Monjalon wrote: > > > > 04/12/2019 11:05, David Marchand: > > > Those libraries have been missed when switching to global ABI version. > > > > The versioning of the glue libraries are for compatibility checks > > between t

[dpdk-dev] [PATCH v1 2/3] examples: remove extra 'new line' in output

This patch removes extra 'new line' in few app examples Fixes: d3641ae863 (examples: update link status checks) Cc: sta...@dpdk.org Signed-off-by: Ivan Dyukov --- examples/ip_fragmentation/main.c | 2 +- examples/ipv4_multicast/main.c | 2 +- ex

[dpdk-dev] [PATCH v1 3/3] examples: remove extra 'new line' in output

This patch removes extra 'new line' in few app examples Fixes: d299106e8e (examples/ipsec-secgw: add IPsec sample application) Fixes: d48415e1fe (examples/performance-thread: add l3fwd-thread app) Fixes: 3fc5ca2f63 (kni: initial import) Fixes: 387259bd6c (examples/l2fwd-crypto: add sample applicat

[dpdk-dev] [PATCH v1 1/3] ethdev: remove extra 'new line' in output

This is testpmd part of new line cleanup Fixes: 002ade70e9 (app/test: measure cycles per packet in Rx/Tx) Fixes: ce8d561418 (app/testpmd: add port configuration settings) Cc: sta...@dpdk.org Acked-by: Andrew Rybchenko Signed-off-by: Ivan Dyukov --- app/test-pmd/testpmd.c | 2 +- app/test/tes

Re: [dpdk-dev] [PATCH v5 2/2] cryptodev: version cryptodev info get function

> -Original Message- > From: Kusztal, ArkadiuszX > Sent: Thursday, May 7, 2020 11:57 AM > To: dev@dpdk.org > Cc: Trahe, Fiona ; Kinsella, Ray > ; > akhil.go...@nxp.com; Richardson, Bruce ; Kusztal, > ArkadiuszX > > Subject: [PATCH v5 2/2] cryptodev: version cryptodev info get functio

Re: [dpdk-dev] rte_ring work

> > > > Hi Honnappa, > > > > > > > > Hi Konstantin, > > > Just to make sure we are coordinating the work on rte_ring, I plan to > > > get the following things done for 20.08. Please let me know if you have > > > any > > comments. > > > > Thanks for sharing your plans. > > In general, looks reaso

Re: [dpdk-dev] rte_ring work

> > Hi Honnappa, > > > > > Hi Konstantin, > > Just to make sure we are coordinating the work on rte_ring, I plan to > > get the following things done for 20.08. Please let me know if you have any > comments. > > Thanks for sharing your plans. > In general, looks reasonable to me. > Few com

Re: [dpdk-dev] [PATCH v3] examples/ipsec-secgw: add per core packet stats

> @@ -1099,6 +1151,10 @@ ipsec_poll_mode_worker(void) > const uint64_t drain_tsc = (rte_get_tsc_hz() + US_PER_S - 1) > / US_PER_S * BURST_TX_DRAIN_US; > struct lcore_rx_queue *rxql; > +#if (STATS_INTERVAL > 0) > + const uint64_t timer_period = STATS_INTERVAL *

Re: [dpdk-dev] [PATCH v2] bus/pci: set boot-up log prints to absolute minimum

07/05/2020 15:54, Jerin Jacob: > On Mon, May 4, 2020 at 6:56 PM wrote: > > > > From: Jerin Jacob > > > > Some machines may have a lot of PCI devices and all of them are > > not bound to DPDK. In such case the logs from EAL creates a lot of > > clutter on boot-up, typically one needs to scroll the

Re: [dpdk-dev] [PATCH v2 3/4] net/netvsc: change tx/rx error handling

On 5/6/2020 8:52 PM, Stephen Hemminger wrote: > The PMD_TX_LOG and PMD_RX_LOG can hide errors since the > debug log is typically disabled. Change the code to use > PMD_DRV_LOG for errors. This will cost additional cycles in fast path, but I assume you know and accept it. > > Under load, the rin

Re: [dpdk-dev] [PATCH v2 2/4] net/netvsc: implement rx/tx descriptor status functions

On 5/6/2020 8:52 PM, Stephen Hemminger wrote: > These functions are useful for applications and debugging. > The netvsc PMD also transparently handles the rx/tx descriptor > functions for underlying VF device. > > Signed-off-by: Stephen Hemminger <...> > +int hn_dev_rx_queue_status(void *arg, u

[dpdk-dev] [PATCH] app/test: handle -ENOTSUP from session init

The session init routine rte_cryptodev_sym_session_init(), could return -ENOTSUP when the requested algo combination is not supported by the PMD. This should be treated as unsupported features. For other return values like -EINVAL or -ENOMEM the test can be treated as failure. Signed-off-by: Ankur

Re: [dpdk-dev] [PATCH v1 3/6] ethdev: remove extra 'new line' in output

07.05.2020 13:28, Thomas Monjalon пишет: > 01/05/2020 15:15, Andrew Rybchenko: >> On 4/27/20 12:57 PM, Ivan Dyukov wrote: >>> Signed-off-by: Ivan Dyukov >>> --- >>>app/test-pmd/testpmd.c | 2 +- >>>app/test/test_pmd_perf.c | 2 +- >>>2 files changed, 2 insertions(+), 2 deletions(-) >>>

Re: [dpdk-dev] [PATCH] cryptodev: add support for user callback functions

Hi Konstantin, Please find the comments inline. > -Original Message- > From: Ananyev, Konstantin > Sent: Friday, April 24, 2020 8:40 PM > To: Gujjar, Abhinandan S ; Doherty, Declan > ; jer...@marvell.com; akhil.go...@nxp.com; > dev@dpdk.org > Cc: Vangati, Narender ; Gujjar, Abhinandan S

Re: [dpdk-dev] [PATCH 4/5] doc: include config options in testpmd user guide

Hi Dharmik, > -Original Message- > From: Dharmik Thakkar > Sent: Wednesday, May 6, 2020 10:59 PM > To: Lu, Wenzhuo ; Wu, Jingjing > ; Iremonger, Bernard > ; Mcnamara, John > ; Kovacevic, Marko > > Cc: dev@dpdk.org; n...@arm.com; Dharmik Thakkar > > Subject: [PATCH 4/5] doc: include conf

Re: [dpdk-dev] [PATCH v4 2/9] net/dpaa2: fix 10g port negotiation issue

On 5/7/2020 11:46 AM, Hemant Agrawal wrote: > From: Rohit Raj > s/10g/10G in the title > Fixed 10g port negotiation issue with another 10G/non 10G port. Can be good to explain how it is fixed. > Initialize the port link speed. > > Fixes: c5acbb5ea20e ("net/dpaa2: support link status event")

Re: [dpdk-dev] [PATCH v4 8/9] net/dpaa2: fix cong group id for multiple tcs

On 5/7/2020 11:46 AM, Hemant Agrawal wrote: > From: Jun Yang > > Flow id will not work when used with multiple traffic > classes. The CGID shall be provided in the INDEX field. Can you please add more detail, same also asked in prev version [1]. Btw what does "flow id won't work" mean, and what

Re: [dpdk-dev] [PATCH] app/testpmd: fix NULL pointer dereferencing issue

Hi Bernard, On Thu, May 7, 2020 at 3:18 PM Iremonger, Bernard < bernard.iremon...@intel.com> wrote: > Hi Kalesh, > > > -Original Message- > > From: Kalesh A P > > Sent: Thursday, May 7, 2020 10:08 AM > > To: dev@dpdk.org > > Cc: Yigit, Ferruh ; Xing, Beilei > > ; Wu, Jingjing ; > Iremong

Re: [dpdk-dev] [PATCH 3/5] doc: add cycles per packet in testpmd user guide

Hi Dharmik, > -Original Message- > From: Dharmik Thakkar > Sent: Wednesday, May 6, 2020 10:59 PM > To: Lu, Wenzhuo ; Wu, Jingjing > ; Iremonger, Bernard > ; Mcnamara, John > ; Kovacevic, Marko > > Cc: dev@dpdk.org; n...@arm.com; Dharmik Thakkar > > Subject: [PATCH 3/5] doc: add cycles

Re: [dpdk-dev] [PATCH v4 5/9] drivers: dpaa2 enhance portal alloc failure log

On 5/7/2020 11:46 AM, Hemant Agrawal wrote: > From: Nipun Gupta > > The change adds printing the thread id when portal allocation > failure occurs Not just adds the tid, also changes the log itself. > > Signed-off-by: Nipun Gupta > --- > drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c | 8 +

Re: [dpdk-dev] [PATCH v4 4/9] net/dpaa2: add default values for Rx params in info

On 5/7/2020 11:46 AM, Hemant Agrawal wrote: > This patch adds default/preferred rx/tx params in dev info, > specially the advertised burst size. > > Signed-off-by: Hemant Agrawal > --- > doc/guides/nics/features/dpaa2.ini | 2 +- > drivers/net/dpaa/dpaa_ethdev.c | 4 > drivers/net/dpa

Re: [dpdk-dev] [PATCH] net/virtio: fix 32-bit build with clang 6.0.0

On 5/6/20 8:47 AM, Marvin Liu wrote: > Clang 6.0.0 will undefine function _mm512_maskz_set1_epi64 on i686 > target. Fix it by replacing the function with _mm512_set4_epi64 when > doing 32-bit build. > > Warning messasge during build: > ../drivers/net/virtio/virtio_rxtx_packed_avx.c:385:19: warn

Re: [dpdk-dev] [PATCH v2] doc: refine ethernet and VLAN flow rule items

On 5/3/2020 3:57 PM, Ori Kam wrote: > > >> -Original Message- >> From: Andrew Rybchenko >> >> On 5/3/20 10:17 AM, Dekel Peled wrote: >>> Specified pattern may be translated in different manner. >>> For example the pattern "eth / ipv4" can be translated to match >>> untagged packets only,

Re: [dpdk-dev] [PATCH v2] net/virtio: fix crash when device reconnecting

On 5/6/20 5:07 PM, Marvin Liu wrote: > When doing virtio device initialization, virtqueues will be reset in > server mode if ring type is packed. It will cause issue because queues > have been freed in the beginning of device initialization. > > Fix this issue by checking whether device has bee

Re: [dpdk-dev] [PATCH v1 0/6] ethdev: allow unknown link speed

On 5/7/2020 2:55 PM, Ivan Dyukov wrote: > 07.05.2020 13:31, Thomas Monjalon пишет: >> 07/05/2020 10:53, Ivan Dyukov: >>> 06.05.2020 20:42, Ferruh Yigit пишет: On 4/27/2020 10:57 AM, Ivan Dyukov wrote: > This is initial patchset which introduces UNKNOWN speed to dpdk > applications. Als

Re: [dpdk-dev] [PATCH 2/3] mempool/octeontx2: fix build for gcc O1 optimization

Hi Ferruh, Jerin > Can be reproduced with "make EXTRA_CFLAGS='-O1'" command using > gcc (GCC) 9.3.1 20200408 (Red Hat 9.3.1-2) > > Build error: > In file included from .../drivers/mempool/octeontx2/otx2_mempool.h:13, > from .../drivers/mempool/octeontx2/otx2_mempool_ops.c:8: > ...

Re: [dpdk-dev] [PATCH v1 0/6] ethdev: allow unknown link speed

07.05.2020 13:31, Thomas Monjalon пишет: > 07/05/2020 10:53, Ivan Dyukov: >> 06.05.2020 20:42, Ferruh Yigit пишет: >>> On 4/27/2020 10:57 AM, Ivan Dyukov wrote: This is initial patchset which introduces UNKNOWN speed to dpdk applications. Also it contains changes related to printf formati

Re: [dpdk-dev] [PATCH v2] bus/pci: set boot-up log prints to absolute minimum

On Mon, May 4, 2020 at 6:56 PM wrote: > > From: Jerin Jacob > > Some machines may have a lot of PCI devices and all of them are > not bound to DPDK. In such case the logs from EAL creates a lot of > clutter on boot-up, typically one needs to scroll the screen to > find other issues in boot-up. >

Re: [dpdk-dev] [PATCH 1/3] ring: fix build for gcc O1 optimization

> > Can be reproduced with "make EXTRA_CFLAGS='-O1'" command using > gcc (GCC) 9.3.1 20200408 (Red Hat 9.3.1-2) > > Two build errors: > 1) > In file included from .../build/include/rte_ring_elem.h:1093, > from .../lib/librte_rcu/rte_rcu_qsbr.c:21: > ../lib/librte_rcu/rte_rcu_qs

Re: [dpdk-dev] [PATCH 1/5] app/testpmd: print clock with CPU cycles per pkt

Hi Dharmik, > -Original Message- > From: Dharmik Thakkar > Sent: Wednesday, May 6, 2020 10:59 PM > To: Lu, Wenzhuo ; Wu, Jingjing > ; Iremonger, Bernard > > Cc: dev@dpdk.org; n...@arm.com; Dharmik Thakkar > > Subject: [PATCH 1/5] app/testpmd: print clock with CPU cycles per pkt > > On

Re: [dpdk-dev] [PATCH v2] app/testpmd: fix null pointer dereferencing issue

Hi Kalesh, > -Original Message- > From: Kalesh A P > Sent: Thursday, May 7, 2020 12:06 PM > To: dev@dpdk.org > Cc: Yigit, Ferruh ; Xing, Beilei > ; Wu, Jingjing ; Iremonger, > Bernard > Subject: [dpdk-dev] [PATCH v2] app/testpmd: fix null pointer dereferencing > issue > > From: Kalesh A

Re: [dpdk-dev] [PATCH] autotest: fix pexpect in python3

On Thu, 2020-05-07 at 14:38 +0200, Christian Ehrhardt wrote: > In python3 pexpect wants by default a BytesIO stream as log buffer. > Otherwise it will (silently masked since we just return false) > File "/usr/share/dpdk/test/autotest_runner.py", line 22, in wait_prompt > child.sendline() >

[dpdk-dev] [PATCH v5 1/3] timer: move from common to Unix directory

Eal common timer doesn't compile under Windows. Compilation log: error LNK2019: unresolved external symbol nanosleep referenced in function rte_delay_us_sleep error LNK2019: unresolved external symbol get_tsc_freq referenced in function set_tsc_freq error LNK2019: unresolved external symbol sleep

[dpdk-dev] [PATCH v5 3/3] timer: support EAL functions on Windows

Implemented the needed Windows eal timer functions. Signed-off-by: Fady Bader --- lib/librte_eal/common/meson.build | 1 + lib/librte_eal/windows/eal.c| 6 +++ lib/librte_eal/windows/eal_timer.c | 77 + lib/librte_eal/windows/include/rte_o

[dpdk-dev] [PATCH v5 0/3] eal timer split and implementation for Windows

This patchset splits OS dependent EAL timer functions and implements them for windows. v2: * fixing styles and correctness errors. v3: * fixing correctness, get_tsc_freq was reimplemented. v4: * rebasing to the new version of "Windows basic memory management" series. * fixing styl

[dpdk-dev] [PATCH v5 2/3] eal: proc type function for Windows

Implementation of rte_proc_type_t for Windows as it is needed for Windows eal timer. Signed-off-by: Fady Bader --- lib/librte_eal/windows/eal.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/lib/librte_eal/windows/eal.c b/lib/librte_eal/windows/eal.c index 2cf7a04ef..831179799 100644

Re: [dpdk-dev] [PATCH v5] eal/cpuflags: add x86 based cpu flags

> Acked-By: Ray Kinsella Applied, thanks

Re: [dpdk-dev] [PATCH] net/tap: fix compilation issue with old kernels

On 5/7/2020 10:45 AM, Raslan Darawsheh wrote: > With old kernels that don't have support for extended ack > the variable one is not used which will cause a compilation > failure: > drivers/net/tap/tap_netlink.c:48:6: > error: unused variable 'one' [-Werror=unused-variable] > int one = 1; >

[dpdk-dev] DPDK Release Status Meeting 7/05/2020

Minutes 7 May 2020 -- Agenda: * Release Dates * -rc1 status * Subtrees Participants: * Arm * Debian/Microsoft * Intel * Marvell * Mellanox * NXP * Red Hat Release Dates - * v20.05 dates: * -rc2 pushed to *Monday 11 May 2020* * -rc3

Re: [dpdk-dev] [PATCH 2/2] bus/pci: cleanup private symbols

On Wed, May 6, 2020 at 10:25 PM Stephen Hemminger wrote: > > If that is correct, we should use pci_* prefix for static symbols, > > rte_* for everything else, even "internal" symbols -- in the sense > > that they are meant to be opaque to the user, but will still be linked > > in static build. > >

Re: [dpdk-dev] [PATCH 2/2] bus/pci: cleanup private symbols

On Wed, May 6, 2020 at 7:21 PM Gaëtan Rivet wrote: > > On 06/05/20 14:43 +0200, David Marchand wrote: > > Internal symbols do not need the rte_ prefix. > > Some symbols do not need to be exposed in the private header and have > > been made static. > > > > Fixes: c752998b5e2e ("pci: introduce libra

Re: [dpdk-dev] [PATCH v5 2/5] app/flow-perf: add insertion rate calculation

>-Original Message- >From: Andrew Rybchenko >Sent: Wednesday, May 6, 2020 6:24 PM >To: Wisam Monther ; dev@dpdk.org; Jack Min >; Thomas Monjalon ; >jerinjac...@gmail.com; gerlitz...@gmail.com; l@epfl.ch; >ajit.khapa...@broadcom.com >Cc: Stephen Hemminger ; >david.march...@redhat.com >S

[dpdk-dev] [PATCH] autotest: fix pexpect in python3

In python3 pexpect wants by default a BytesIO stream as log buffer. Otherwise it will (silently masked since we just return false) File "/usr/share/dpdk/test/autotest_runner.py", line 22, in wait_prompt child.sendline() File "/usr/lib/python3/dist-packages/pexpect/pty_spawn.py", line 555, i

Re: [dpdk-dev] [dpdk-stable] [PATCH] drivers/net: fix mlx* glue libraries ABI version

On Thu, Dec 12, 2019 at 11:18 PM Thomas Monjalon wrote: > > 04/12/2019 11:05, David Marchand: > > Those libraries have been missed when switching to global ABI version. > > The versioning of the glue libraries are for compatibility checks > between the PMD and its dependency (rdma-core) packaged a

Re: [dpdk-dev] [dpdk-stable] [PATCH v2] mem: fix the alloc size roundup overflow

On Thu, May 7, 2020 at 2:16 PM Bing Zhao wrote: > > Hi David, > I've changed the space into tabs in v3 and suppressed this one. Ok, I would have noticed anyway :-) Thanks. -- David Marchand

[dpdk-dev] [PATCH v3 2/7] pci: use OS generic memory mapping functions

From: Tal Shnaiderman Changing all of PCIs Unix memory mapping to the new memory allocation API wrapper. Change all of PCI mapping function usage in bus/pci to support the new API. Signed-off-by: Tal Shnaiderman --- drivers/bus/pci/bsd/pci.c| 2 +- drivers/bus/pci/linux/pci_uio.c |

[dpdk-dev] [PATCH v3 0/7] Windows bus/pci support

From: Tal Shnaiderman This patchset implements the EAL and PCI functions needed for probing PMDs using RTE_KDRV_NONE on Windows. Depends-on: series-9713 ("Windows basic memory management") v3: * Changes in BDF and hardware ids retrieval(DmitryK). * Apply new generic MM to all p

[dpdk-dev] [PATCH v3 6/7] bus/pci: introduce Windows support with stubs

From: Tal Shnaiderman Addition of stub eal and bus/pci functions to compile bus/pci for Windows. Signed-off-by: Tal Shnaiderman --- drivers/baseband/meson.build | 4 + drivers/bus/ifpga/meson.build | 6 ++ drivers/bus/pci/meson.build| 14 ++- drivers/bus/pci/pci_common.

[dpdk-dev] [PATCH v3 4/7] drivers: ignore pmdinfogen generation for Windows

From: Tal Shnaiderman pmdinfogen generation is currently unsupported for Windows. The relevant part in meson.build is skipped. Signed-off-by: Tal Shnaiderman --- drivers/meson.build | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/meson.build b/drivers/meson.build

[dpdk-dev] [PATCH v3 5/7] drivers: fix incorrect meson import folder for Windows

From: Tal Shnaiderman import library (/IMPLIB) in meson.build should use the 'drivers' and not 'libs' folder. The error is: fatal error LNK1149: output filename matches input filename. The fix uses the correct folder. Fixes: 5ed3766981 ("drivers: process shared link dependencies as for libs")

[dpdk-dev] [PATCH v3 1/7] eal: move OS common functions to single file

From: Tal Shnaiderman Move common functions between Unix and Windows to eal_common_config.c. Those simple functions are getter functions for IOVA, configuration, Multi-process. Move rte_config and runtime_dir to be defined in a common file. Signed-off-by: Tal Shnaiderman --- lib/librte_eal/c

[dpdk-dev] [PATCH v3 3/7] pci: build on Windows

From: Tal Shnaiderman Added off_t in Windows header file as a supported type since it is needed by PCI. Signed-off-by: Tal Shnaiderman --- lib/librte_eal/windows/include/rte_os.h | 1 + lib/meson.build | 5 - 2 files changed, 5 insertions(+), 1 deletion(-) diff --g

  1   2   >