Hi Dharmik,
> -----Original Message-----
> From: Dharmik Thakkar <dharmik.thak...@arm.com>
> Sent: Wednesday, May 6, 2020 10:59 PM
> To: Lu, Wenzhuo <wenzhuo...@intel.com>; Wu, Jingjing
> <jingjing...@intel.com>; Iremonger, Bernard
> <bernard.iremon...@intel.com>
> Cc: dev@dpdk.org; n...@arm.com; Dharmik Thakkar
> <dharmik.thak...@arm.com>
> Subject: [PATCH 1/5] app/testpmd: print clock with CPU cycles per pkt
>
> On aarch64 platforms, the cycles are counted using either a low-resolution
> generic counter or a high-resolution PMU cycle counter.
> Print the clock frequency along with CPU cycles/packet to identify which
> cycle counter is being used.
>
> Signed-off-by: Dharmik Thakkar <dharmik.thak...@arm.com>
> Reviewed-by: Honnappa Nagarahalli <honnappa.nagaraha...@arm.com>
> Reviewed-by: Phil Yang <phil.y...@arm.com>
> ---
> app/test-pmd/testpmd.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c index
> 99bacddbfdca..9a8cbbd6fc7c 100644
> --- a/app/test-pmd/testpmd.c
> +++ b/app/test-pmd/testpmd.c
> @@ -1953,11 +1953,12 @@ fwd_stats_display(void)
> "%s\n",
> acc_stats_border, acc_stats_border); #ifdef
> RTE_TEST_PMD_RECORD_CORE_CYCLES
> +#define CYC_PER_MHZ 1E6
> if (total_recv > 0)
> printf("\n CPU cycles/packet=%u (total cycles="
> - "%"PRIu64" / total RX packets=%"PRIu64")\n",
> + "%"PRIu64" / total RX packets=%"PRIu64") at %lu MHz
> Clock\n",
Better to use =%"PRIu64" instead of %lu in previous line
> (unsigned int)(fwd_cycles / total_recv),
> - fwd_cycles, total_recv);
> + fwd_cycles, total_recv, (uint64_t)(rte_get_tsc_hz() /
> +CYC_PER_MHZ));
> #endif
> }
>
> --
> 2.20.1
Better to fix checkpatch the following checkpatch warning:
WARNING:LONG_LINE: line over 80 characters
#77: FILE: app/test-pmd/testpmd.c:1961:
+ fwd_cycles, total_recv, (uint64_t)(rte_get_tsc_hz() /
CYC_PER_MHZ));
Regards,
Bernard.
